* [PATCH] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
@ 2022-01-17 5:03 ` Julian Braha
0 siblings, 0 replies; 12+ messages in thread
From: Julian Braha @ 2022-01-17 5:03 UTC (permalink / raw)
To: broonie, lgirdwood, perex, tiwai, matthias.bgg, trevor.wu,
tzungbi, geert+renesas
Cc: alsa-devel, linux-kernel, linux-arm-kernel, linux-mediatek,
fazilyildiran
When SND_SOC_MT8195_MT6359_RT1011_RT5682 is selected,
and GPIOLIB is not selected,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for SND_SOC_DMIC
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
Selected by [y]:
- SND_SOC_MT8195_MT6359_RT1011_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y] && MTK_PMIC_WRAP [=y]
This is because SND_SOC_MT8195_MT6359_RT1011_RT5682
selects SND_SOC_DMIC without selecting or depending on
GPIOLIB, depsite SND_SOC_DMIC depending on GPIOLIB.
This unmet dependency bug was detected by Kismet,
a static analysis tool for Kconfig. Please advise
if this is not the appropriate solution.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
sound/soc/mediatek/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
index 9306b7ca2644..0d154350f180 100644
--- a/sound/soc/mediatek/Kconfig
+++ b/sound/soc/mediatek/Kconfig
@@ -216,7 +216,7 @@ config SND_SOC_MT8195_MT6359_RT1019_RT5682
config SND_SOC_MT8195_MT6359_RT1011_RT5682
tristate "ASoC Audio driver for MT8195 with MT6359 RT1011 RT5682 codec"
- depends on I2C
+ depends on I2C && GPIOLIB
depends on SND_SOC_MT8195 && MTK_PMIC_WRAP
select SND_SOC_MT6359
select SND_SOC_RT1011
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
@ 2022-01-17 5:03 ` Julian Braha
0 siblings, 0 replies; 12+ messages in thread
From: Julian Braha @ 2022-01-17 5:03 UTC (permalink / raw)
To: broonie, lgirdwood, perex, tiwai, matthias.bgg, trevor.wu,
tzungbi, geert+renesas
Cc: alsa-devel, linux-kernel, linux-arm-kernel, linux-mediatek,
fazilyildiran
When SND_SOC_MT8195_MT6359_RT1011_RT5682 is selected,
and GPIOLIB is not selected,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for SND_SOC_DMIC
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
Selected by [y]:
- SND_SOC_MT8195_MT6359_RT1011_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y] && MTK_PMIC_WRAP [=y]
This is because SND_SOC_MT8195_MT6359_RT1011_RT5682
selects SND_SOC_DMIC without selecting or depending on
GPIOLIB, depsite SND_SOC_DMIC depending on GPIOLIB.
This unmet dependency bug was detected by Kismet,
a static analysis tool for Kconfig. Please advise
if this is not the appropriate solution.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
sound/soc/mediatek/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
index 9306b7ca2644..0d154350f180 100644
--- a/sound/soc/mediatek/Kconfig
+++ b/sound/soc/mediatek/Kconfig
@@ -216,7 +216,7 @@ config SND_SOC_MT8195_MT6359_RT1019_RT5682
config SND_SOC_MT8195_MT6359_RT1011_RT5682
tristate "ASoC Audio driver for MT8195 with MT6359 RT1011 RT5682 codec"
- depends on I2C
+ depends on I2C && GPIOLIB
depends on SND_SOC_MT8195 && MTK_PMIC_WRAP
select SND_SOC_MT6359
select SND_SOC_RT1011
--
2.32.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
@ 2022-01-17 5:03 ` Julian Braha
0 siblings, 0 replies; 12+ messages in thread
From: Julian Braha @ 2022-01-17 5:03 UTC (permalink / raw)
To: broonie, lgirdwood, perex, tiwai, matthias.bgg, trevor.wu,
tzungbi, geert+renesas
Cc: fazilyildiran, alsa-devel, linux-mediatek, linux-kernel,
linux-arm-kernel
When SND_SOC_MT8195_MT6359_RT1011_RT5682 is selected,
and GPIOLIB is not selected,
Kbuild gives the following warning:
WARNING: unmet direct dependencies detected for SND_SOC_DMIC
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
Selected by [y]:
- SND_SOC_MT8195_MT6359_RT1011_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y] && MTK_PMIC_WRAP [=y]
This is because SND_SOC_MT8195_MT6359_RT1011_RT5682
selects SND_SOC_DMIC without selecting or depending on
GPIOLIB, depsite SND_SOC_DMIC depending on GPIOLIB.
This unmet dependency bug was detected by Kismet,
a static analysis tool for Kconfig. Please advise
if this is not the appropriate solution.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
sound/soc/mediatek/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
index 9306b7ca2644..0d154350f180 100644
--- a/sound/soc/mediatek/Kconfig
+++ b/sound/soc/mediatek/Kconfig
@@ -216,7 +216,7 @@ config SND_SOC_MT8195_MT6359_RT1019_RT5682
config SND_SOC_MT8195_MT6359_RT1011_RT5682
tristate "ASoC Audio driver for MT8195 with MT6359 RT1011 RT5682 codec"
- depends on I2C
+ depends on I2C && GPIOLIB
depends on SND_SOC_MT8195 && MTK_PMIC_WRAP
select SND_SOC_MT6359
select SND_SOC_RT1011
--
2.32.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
2022-01-17 5:03 ` Julian Braha
(?)
(?)
@ 2022-01-17 5:59 ` Tzung-Bi Shih
-1 siblings, 0 replies; 12+ messages in thread
From: Tzung-Bi Shih @ 2022-01-17 5:59 UTC (permalink / raw)
To: Julian Braha
Cc: broonie, lgirdwood, perex, tiwai, matthias.bgg, trevor.wu,
geert+renesas, alsa-devel, linux-kernel, linux-arm-kernel,
linux-mediatek, fazilyildiran
On Mon, Jan 17, 2022 at 12:03:24AM -0500, Julian Braha wrote:
> This is because SND_SOC_MT8195_MT6359_RT1011_RT5682
> selects SND_SOC_DMIC without selecting or depending on
> GPIOLIB, depsite SND_SOC_DMIC depending on GPIOLIB.
>
> This unmet dependency bug was detected by Kismet,
> a static analysis tool for Kconfig. Please advise
> if this is not the appropriate solution.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
@ 2022-01-17 5:59 ` Tzung-Bi Shih
0 siblings, 0 replies; 12+ messages in thread
From: Tzung-Bi Shih @ 2022-01-17 5:59 UTC (permalink / raw)
To: Julian Braha
Cc: broonie, lgirdwood, perex, tiwai, matthias.bgg, trevor.wu,
geert+renesas, alsa-devel, linux-kernel, linux-arm-kernel,
linux-mediatek, fazilyildiran
On Mon, Jan 17, 2022 at 12:03:24AM -0500, Julian Braha wrote:
> This is because SND_SOC_MT8195_MT6359_RT1011_RT5682
> selects SND_SOC_DMIC without selecting or depending on
> GPIOLIB, depsite SND_SOC_DMIC depending on GPIOLIB.
>
> This unmet dependency bug was detected by Kismet,
> a static analysis tool for Kconfig. Please advise
> if this is not the appropriate solution.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
@ 2022-01-17 5:59 ` Tzung-Bi Shih
0 siblings, 0 replies; 12+ messages in thread
From: Tzung-Bi Shih @ 2022-01-17 5:59 UTC (permalink / raw)
To: Julian Braha
Cc: alsa-devel, geert+renesas, linux-kernel, fazilyildiran, tiwai,
lgirdwood, broonie, linux-mediatek, trevor.wu, matthias.bgg,
linux-arm-kernel
On Mon, Jan 17, 2022 at 12:03:24AM -0500, Julian Braha wrote:
> This is because SND_SOC_MT8195_MT6359_RT1011_RT5682
> selects SND_SOC_DMIC without selecting or depending on
> GPIOLIB, depsite SND_SOC_DMIC depending on GPIOLIB.
>
> This unmet dependency bug was detected by Kismet,
> a static analysis tool for Kconfig. Please advise
> if this is not the appropriate solution.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
@ 2022-01-17 5:59 ` Tzung-Bi Shih
0 siblings, 0 replies; 12+ messages in thread
From: Tzung-Bi Shih @ 2022-01-17 5:59 UTC (permalink / raw)
To: Julian Braha
Cc: broonie, lgirdwood, perex, tiwai, matthias.bgg, trevor.wu,
geert+renesas, alsa-devel, linux-kernel, linux-arm-kernel,
linux-mediatek, fazilyildiran
On Mon, Jan 17, 2022 at 12:03:24AM -0500, Julian Braha wrote:
> This is because SND_SOC_MT8195_MT6359_RT1011_RT5682
> selects SND_SOC_DMIC without selecting or depending on
> GPIOLIB, depsite SND_SOC_DMIC depending on GPIOLIB.
>
> This unmet dependency bug was detected by Kismet,
> a static analysis tool for Kconfig. Please advise
> if this is not the appropriate solution.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
2022-01-17 5:03 ` Julian Braha
(?)
(?)
@ 2022-01-19 18:02 ` Mark Brown
-1 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-01-19 18:02 UTC (permalink / raw)
To: tiwai, lgirdwood, Julian Braha, matthias.bgg, tzungbi,
geert+renesas, perex, trevor.wu
Cc: linux-mediatek, alsa-devel, linux-kernel, fazilyildiran,
linux-arm-kernel
On Mon, 17 Jan 2022 00:03:24 -0500, Julian Braha wrote:
> When SND_SOC_MT8195_MT6359_RT1011_RT5682 is selected,
> and GPIOLIB is not selected,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for SND_SOC_DMIC
> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
> Selected by [y]:
> - SND_SOC_MT8195_MT6359_RT1011_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y] && MTK_PMIC_WRAP [=y]
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus
Thanks!
[1/1] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
commit: 579b2c8f72d974f27d85bbd53846f34675ee3b01
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
@ 2022-01-19 18:02 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-01-19 18:02 UTC (permalink / raw)
To: tiwai, lgirdwood, Julian Braha, matthias.bgg, tzungbi,
geert+renesas, perex, trevor.wu
Cc: fazilyildiran, alsa-devel, linux-mediatek, linux-kernel,
linux-arm-kernel
On Mon, 17 Jan 2022 00:03:24 -0500, Julian Braha wrote:
> When SND_SOC_MT8195_MT6359_RT1011_RT5682 is selected,
> and GPIOLIB is not selected,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for SND_SOC_DMIC
> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
> Selected by [y]:
> - SND_SOC_MT8195_MT6359_RT1011_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y] && MTK_PMIC_WRAP [=y]
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus
Thanks!
[1/1] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
commit: 579b2c8f72d974f27d85bbd53846f34675ee3b01
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
@ 2022-01-19 18:02 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-01-19 18:02 UTC (permalink / raw)
To: tiwai, lgirdwood, Julian Braha, matthias.bgg, tzungbi,
geert+renesas, perex, trevor.wu
Cc: linux-mediatek, alsa-devel, linux-kernel, fazilyildiran,
linux-arm-kernel
On Mon, 17 Jan 2022 00:03:24 -0500, Julian Braha wrote:
> When SND_SOC_MT8195_MT6359_RT1011_RT5682 is selected,
> and GPIOLIB is not selected,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for SND_SOC_DMIC
> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
> Selected by [y]:
> - SND_SOC_MT8195_MT6359_RT1011_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y] && MTK_PMIC_WRAP [=y]
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus
Thanks!
[1/1] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
commit: 579b2c8f72d974f27d85bbd53846f34675ee3b01
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
@ 2022-01-19 18:02 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2022-01-19 18:02 UTC (permalink / raw)
To: tiwai, lgirdwood, Julian Braha, matthias.bgg, tzungbi,
geert+renesas, perex, trevor.wu
Cc: linux-mediatek, alsa-devel, linux-kernel, fazilyildiran,
linux-arm-kernel
On Mon, 17 Jan 2022 00:03:24 -0500, Julian Braha wrote:
> When SND_SOC_MT8195_MT6359_RT1011_RT5682 is selected,
> and GPIOLIB is not selected,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for SND_SOC_DMIC
> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
> Selected by [y]:
> - SND_SOC_MT8195_MT6359_RT1011_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y] && MTK_PMIC_WRAP [=y]
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus
Thanks!
[1/1] ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
commit: 579b2c8f72d974f27d85bbd53846f34675ee3b01
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 12+ messages in thread