All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/3] sprd drm cover letter
@ 2022-01-17  8:38 ` Kevin Tang
  0 siblings, 0 replies; 4+ messages in thread
From: Kevin Tang @ 2022-01-17  8:38 UTC (permalink / raw)
  To: maarten.lankhorst, mripard, airlied, daniel, mark.rutland,
	javierm, tzimmermann, lukas.bulwahn
  Cc: zou_wei, kevin3.tang, pony1.wu, orsonzhai, dan.carpenter,
	zhang.lyra, linux-kernel, dri-devel, devicetree

v1:
  remove the selected DRM_KMS_CMA_HELPER in kconfig
  drm-sprd-fix-potential-NULL-dereference

v2:
  fix commit comments long lines issue and drop "On linux-next" comments
  Split checking platform_get_resource() return value to a separate patch
  Use dev_warn() instead of removing the warning log

Kevin Tang (3):
  drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig
  drm/sprd: fix potential NULL dereference
  drm/sprd: check the platform_get_resource() return value

 drivers/gpu/drm/sprd/Kconfig    | 1 -
 drivers/gpu/drm/sprd/sprd_dpu.c | 5 +++++
 drivers/gpu/drm/sprd/sprd_drm.c | 2 +-
 drivers/gpu/drm/sprd/sprd_dsi.c | 5 +++++
 4 files changed, 11 insertions(+), 2 deletions(-)

-- 
2.29.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 0/3] sprd drm cover letter
@ 2022-01-17  8:38 ` Kevin Tang
  0 siblings, 0 replies; 4+ messages in thread
From: Kevin Tang @ 2022-01-17  8:38 UTC (permalink / raw)
  To: maarten.lankhorst, mripard, airlied, daniel, mark.rutland,
	javierm, tzimmermann, lukas.bulwahn
  Cc: devicetree, kevin3.tang, zhang.lyra, linux-kernel, dri-devel,
	orsonzhai, zou_wei, pony1.wu, dan.carpenter

v1:
  remove the selected DRM_KMS_CMA_HELPER in kconfig
  drm-sprd-fix-potential-NULL-dereference

v2:
  fix commit comments long lines issue and drop "On linux-next" comments
  Split checking platform_get_resource() return value to a separate patch
  Use dev_warn() instead of removing the warning log

Kevin Tang (3):
  drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig
  drm/sprd: fix potential NULL dereference
  drm/sprd: check the platform_get_resource() return value

 drivers/gpu/drm/sprd/Kconfig    | 1 -
 drivers/gpu/drm/sprd/sprd_dpu.c | 5 +++++
 drivers/gpu/drm/sprd/sprd_drm.c | 2 +-
 drivers/gpu/drm/sprd/sprd_dsi.c | 5 +++++
 4 files changed, 11 insertions(+), 2 deletions(-)

-- 
2.29.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/3] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig
  2022-01-17  8:38 ` Kevin Tang
@ 2022-01-17  8:38   ` Kevin Tang
  -1 siblings, 0 replies; 4+ messages in thread
From: Kevin Tang @ 2022-01-17  8:38 UTC (permalink / raw)
  To: maarten.lankhorst, mripard, airlied, daniel, mark.rutland,
	javierm, tzimmermann, lukas.bulwahn
  Cc: zou_wei, kevin3.tang, pony1.wu, orsonzhai, dan.carpenter,
	zhang.lyra, linux-kernel, dri-devel, devicetree

On commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master"),
adds the config DRM_SPRD, which selects DRM_KMS_CMA_HELPER.

However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER
option") just removed the DRM_KMS_CMA_HELPER.
So the select DRM_KMS_CMA_HELPER refers to a non-existing kconfig symbol.

Reported-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

v1 -> v2:
- fix commit comments long lines issue and drop "On linux-next" comments
---
 drivers/gpu/drm/sprd/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sprd/Kconfig b/drivers/gpu/drm/sprd/Kconfig
index 3edeaeca0..9a9c7ebfc 100644
--- a/drivers/gpu/drm/sprd/Kconfig
+++ b/drivers/gpu/drm/sprd/Kconfig
@@ -3,7 +3,6 @@ config DRM_SPRD
 	depends on ARCH_SPRD || COMPILE_TEST
 	depends on DRM && OF
 	select DRM_GEM_CMA_HELPER
-	select DRM_KMS_CMA_HELPER
 	select DRM_KMS_HELPER
 	select DRM_MIPI_DSI
 	select VIDEOMODE_HELPERS
-- 
2.29.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 1/3] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig
@ 2022-01-17  8:38   ` Kevin Tang
  0 siblings, 0 replies; 4+ messages in thread
From: Kevin Tang @ 2022-01-17  8:38 UTC (permalink / raw)
  To: maarten.lankhorst, mripard, airlied, daniel, mark.rutland,
	javierm, tzimmermann, lukas.bulwahn
  Cc: devicetree, kevin3.tang, zhang.lyra, linux-kernel, dri-devel,
	orsonzhai, zou_wei, pony1.wu, dan.carpenter

On commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master"),
adds the config DRM_SPRD, which selects DRM_KMS_CMA_HELPER.

However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER
option") just removed the DRM_KMS_CMA_HELPER.
So the select DRM_KMS_CMA_HELPER refers to a non-existing kconfig symbol.

Reported-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

v1 -> v2:
- fix commit comments long lines issue and drop "On linux-next" comments
---
 drivers/gpu/drm/sprd/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sprd/Kconfig b/drivers/gpu/drm/sprd/Kconfig
index 3edeaeca0..9a9c7ebfc 100644
--- a/drivers/gpu/drm/sprd/Kconfig
+++ b/drivers/gpu/drm/sprd/Kconfig
@@ -3,7 +3,6 @@ config DRM_SPRD
 	depends on ARCH_SPRD || COMPILE_TEST
 	depends on DRM && OF
 	select DRM_GEM_CMA_HELPER
-	select DRM_KMS_CMA_HELPER
 	select DRM_KMS_HELPER
 	select DRM_MIPI_DSI
 	select VIDEOMODE_HELPERS
-- 
2.29.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-17  8:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17  8:38 [PATCH v2 0/3] sprd drm cover letter Kevin Tang
2022-01-17  8:38 ` Kevin Tang
2022-01-17  8:38 ` [PATCH v2 1/3] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig Kevin Tang
2022-01-17  8:38   ` Kevin Tang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.