[PATCH] coccinelle: misc: fix swap.cocci warnings

* [PATCH] coccinelle: misc: fix swap.cocci warnings
  2022-01-18 11:13 lib/bch.c:842:7-8: WARNING opportunity for swap() kernel test robot
@ 2022-01-18  8:17 ` kernel test robot
  0 siblings, 0 replies; 14+ messages in thread
From: kernel test robot @ 2022-01-18  8:17 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1850 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Denis Efremov <efremov@linux.com>
CC: Julia Lawall <Julia.Lawall@inria.fr>
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

lib/bch.c:842:7-8: WARNING opportunity for swap()
lib/bch.c:849:7-8: WARNING opportunity for swap()
lib/bch.c:518:22-23: WARNING opportunity for swap()


 Check for opencoded swap() implementation.

Generated by: scripts/coccinelle/misc/swap.cocci

CC: Denis Efremov <efremov@linux.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e3a8b6a1e70c37702054ae3c7c07ed828435d8ee
commit: 7845daa8bd72efa8bbc1de122edfce6e058bbe41 coccinelle: misc: add swap script
:::::: branch date: 4 hours ago
:::::: commit date: 9 months ago

Please take the patch only if it's a positive warning. Thanks!

 bch.c |   20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

--- a/lib/bch.c
+++ b/lib/bch.c
@@ -513,11 +513,9 @@ static int solve_linear_system(struct bc
 		/* find suitable row for elimination */
 		for (r = p; r < m; r++) {
 			if (rows[r] & mask) {
-				if (r != p) {
-					tmp = rows[r];
-					rows[r] = rows[p];
-					rows[p] = tmp;
-				}
+				if (r != p)
+					
+					swap(rows[r], rows[p]);
 				rem = r+1;
 				break;
 			}
@@ -837,17 +835,13 @@ static struct gf_poly *gf_poly_gcd(struc
 
 	dbg("gcd(%s,%s)=", gf_poly_str@, gf_poly_str(b));
 
-	if (a->deg < b->deg) {
-		tmp = b;
-		b = a;
-		a = tmp;
-	}
+	if (a->deg < b->deg)
+		
+		swap(b, a);
 
 	while (b->deg > 0) {
 		gf_poly_mod(bch, a, b, NULL);
-		tmp = b;
-		b = a;
-		a = tmp;
+		swap(b, a);
 	}
 
 	dbg("%s\n", gf_poly_str(a));

^ permalink raw reply	[flat|nested] 14+ messages in thread