All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example
@ 2022-01-19  1:56 ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-01-19  1:56 UTC (permalink / raw)
  To: Charles Keepax, Richard Fitzgerald, Lee Jones, -
  Cc: alsa-devel, devicetree, linux-kernel

The 'interrupts' properties takes an irq number, not a phandle, and
'interrupt-parent' isn't needed in examples.
---
 Documentation/devicetree/bindings/mfd/cirrus,madera.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml b/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml
index 5dce62a7eff2..68c75a517c92 100644
--- a/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml
+++ b/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml
@@ -245,8 +245,7 @@ examples:
 
             interrupt-controller;
             #interrupt-cells = <2>;
-            interrupts = <&host_irq1>;
-            interrupt-parent = <&gic>;
+            interrupts = <4 1 0>;
 
             gpio-controller;
             #gpio-cells = <2>;
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example
@ 2022-01-19  1:56 ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-01-19  1:56 UTC (permalink / raw)
  To: Charles Keepax, Richard Fitzgerald, Lee Jones, -
  Cc: devicetree, alsa-devel, linux-kernel

The 'interrupts' properties takes an irq number, not a phandle, and
'interrupt-parent' isn't needed in examples.
---
 Documentation/devicetree/bindings/mfd/cirrus,madera.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml b/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml
index 5dce62a7eff2..68c75a517c92 100644
--- a/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml
+++ b/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml
@@ -245,8 +245,7 @@ examples:
 
             interrupt-controller;
             #interrupt-cells = <2>;
-            interrupts = <&host_irq1>;
-            interrupt-parent = <&gic>;
+            interrupts = <4 1 0>;
 
             gpio-controller;
             #gpio-cells = <2>;
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example
  2022-01-19  1:56 ` Rob Herring
@ 2022-01-19 10:57   ` Charles Keepax
  -1 siblings, 0 replies; 8+ messages in thread
From: Charles Keepax @ 2022-01-19 10:57 UTC (permalink / raw)
  To: Rob Herring
  Cc: Richard Fitzgerald, Lee Jones, -, alsa-devel, devicetree, linux-kernel

On Tue, Jan 18, 2022 at 07:56:11PM -0600, Rob Herring wrote:
> The 'interrupts' properties takes an irq number, not a phandle, and
> 'interrupt-parent' isn't needed in examples.
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example
@ 2022-01-19 10:57   ` Charles Keepax
  0 siblings, 0 replies; 8+ messages in thread
From: Charles Keepax @ 2022-01-19 10:57 UTC (permalink / raw)
  To: Rob Herring
  Cc: devicetree, alsa-devel, -, linux-kernel, Richard Fitzgerald, Lee Jones

On Tue, Jan 18, 2022 at 07:56:11PM -0600, Rob Herring wrote:
> The 'interrupts' properties takes an irq number, not a phandle, and
> 'interrupt-parent' isn't needed in examples.
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example
  2022-01-19  1:56 ` Rob Herring
@ 2022-01-20 19:36   ` Rob Herring
  -1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-01-20 19:36 UTC (permalink / raw)
  To: Rob Herring
  Cc: linux-kernel, Lee Jones, alsa-devel, Charles Keepax, -,
	Richard Fitzgerald, devicetree

On Tue, 18 Jan 2022 19:56:11 -0600, Rob Herring wrote:
> The 'interrupts' properties takes an irq number, not a phandle, and
> 'interrupt-parent' isn't needed in examples.
> ---
>  Documentation/devicetree/bindings/mfd/cirrus,madera.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Applied (with my Sob added), thanks!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example
@ 2022-01-20 19:36   ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-01-20 19:36 UTC (permalink / raw)
  To: Rob Herring
  Cc: devicetree, alsa-devel, Charles Keepax, -,
	linux-kernel, Richard Fitzgerald, Lee Jones

On Tue, 18 Jan 2022 19:56:11 -0600, Rob Herring wrote:
> The 'interrupts' properties takes an irq number, not a phandle, and
> 'interrupt-parent' isn't needed in examples.
> ---
>  Documentation/devicetree/bindings/mfd/cirrus,madera.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Applied (with my Sob added), thanks!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example
  2022-01-20 19:36   ` Rob Herring
@ 2022-01-21  8:39     ` Lee Jones
  -1 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2022-01-21  8:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: linux-kernel, alsa-devel, Charles Keepax, -,
	Richard Fitzgerald, devicetree

On Thu, 20 Jan 2022, Rob Herring wrote:

> On Tue, 18 Jan 2022 19:56:11 -0600, Rob Herring wrote:
> > The 'interrupts' properties takes an irq number, not a phandle, and
> > 'interrupt-parent' isn't needed in examples.
> > ---
> >  Documentation/devicetree/bindings/mfd/cirrus,madera.yaml | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> 
> Applied (with my Sob added), thanks!

Was going to say ... :)

Please add my Ack too:

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example
@ 2022-01-21  8:39     ` Lee Jones
  0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2022-01-21  8:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: devicetree, alsa-devel, Charles Keepax, -,
	linux-kernel, Richard Fitzgerald

On Thu, 20 Jan 2022, Rob Herring wrote:

> On Tue, 18 Jan 2022 19:56:11 -0600, Rob Herring wrote:
> > The 'interrupts' properties takes an irq number, not a phandle, and
> > 'interrupt-parent' isn't needed in examples.
> > ---
> >  Documentation/devicetree/bindings/mfd/cirrus,madera.yaml | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> 
> Applied (with my Sob added), thanks!

Was going to say ... :)

Please add my Ack too:

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-01-21  8:40 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-19  1:56 [PATCH] dt-bindings: mfd: cirrus,madera: Fix 'interrupts' in example Rob Herring
2022-01-19  1:56 ` Rob Herring
2022-01-19 10:57 ` Charles Keepax
2022-01-19 10:57   ` Charles Keepax
2022-01-20 19:36 ` Rob Herring
2022-01-20 19:36   ` Rob Herring
2022-01-21  8:39   ` Lee Jones
2022-01-21  8:39     ` Lee Jones

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.