* [PATCH] devtmpfs: drop redundant fs parameters from internal fs
@ 2022-01-19 22:02 Anthony Iliopoulos
2022-01-20 7:29 ` Christoph Hellwig
2022-01-20 8:46 ` Christian Brauner
0 siblings, 2 replies; 3+ messages in thread
From: Anthony Iliopoulos @ 2022-01-19 22:02 UTC (permalink / raw)
To: Al Viro, Andrew Morton, David Howells, Greg Kroah-Hartman
Cc: linux-fsdevel, linux-kernel
The internal_fs_type is mounted via vfs_kernel_mount() and is never
registered as a filesystem, thus specifying the parameters is redundant
as those params will not be validated by fs_validate_description().
Both {shmem,ramfs}_fs_parameters are anyway validated when those
respective filesystems are first registered, so there is no reason to
pass them to devtmpfs too, drop them.
Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
---
drivers/base/devtmpfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
index f41063ac1aee..ad5f304e2b30 100644
--- a/drivers/base/devtmpfs.c
+++ b/drivers/base/devtmpfs.c
@@ -81,10 +81,8 @@ static struct file_system_type internal_fs_type = {
.name = "devtmpfs",
#ifdef CONFIG_TMPFS
.init_fs_context = shmem_init_fs_context,
- .parameters = shmem_fs_parameters,
#else
.init_fs_context = ramfs_init_fs_context,
- .parameters = ramfs_fs_parameters,
#endif
.kill_sb = kill_litter_super,
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] devtmpfs: drop redundant fs parameters from internal fs
2022-01-19 22:02 [PATCH] devtmpfs: drop redundant fs parameters from internal fs Anthony Iliopoulos
@ 2022-01-20 7:29 ` Christoph Hellwig
2022-01-20 8:46 ` Christian Brauner
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2022-01-20 7:29 UTC (permalink / raw)
To: Anthony Iliopoulos
Cc: Al Viro, Andrew Morton, David Howells, Greg Kroah-Hartman,
linux-fsdevel, linux-kernel
On Wed, Jan 19, 2022 at 11:02:48PM +0100, Anthony Iliopoulos wrote:
> The internal_fs_type is mounted via vfs_kernel_mount() and is never
> registered as a filesystem, thus specifying the parameters is redundant
> as those params will not be validated by fs_validate_description().
>
> Both {shmem,ramfs}_fs_parameters are anyway validated when those
> respective filesystems are first registered, so there is no reason to
> pass them to devtmpfs too, drop them.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] devtmpfs: drop redundant fs parameters from internal fs
2022-01-19 22:02 [PATCH] devtmpfs: drop redundant fs parameters from internal fs Anthony Iliopoulos
2022-01-20 7:29 ` Christoph Hellwig
@ 2022-01-20 8:46 ` Christian Brauner
1 sibling, 0 replies; 3+ messages in thread
From: Christian Brauner @ 2022-01-20 8:46 UTC (permalink / raw)
To: Anthony Iliopoulos
Cc: Al Viro, Andrew Morton, David Howells, Greg Kroah-Hartman,
linux-fsdevel, linux-kernel
On Wed, Jan 19, 2022 at 11:02:48PM +0100, Anthony Iliopoulos wrote:
> The internal_fs_type is mounted via vfs_kernel_mount() and is never
> registered as a filesystem, thus specifying the parameters is redundant
> as those params will not be validated by fs_validate_description().
>
> Both {shmem,ramfs}_fs_parameters are anyway validated when those
> respective filesystems are first registered, so there is no reason to
> pass them to devtmpfs too, drop them.
>
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
> ---
Ah yes, I "complained" about this on the patch re-enabling
reconfigure_mnt() for devtmpfs.
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-20 8:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-19 22:02 [PATCH] devtmpfs: drop redundant fs parameters from internal fs Anthony Iliopoulos
2022-01-20 7:29 ` Christoph Hellwig
2022-01-20 8:46 ` Christian Brauner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.