[PATCH] pipe: remove redundant assignment to pointer buf

[PATCH] pipe: remove redundant assignment to pointer buf

[Colin Ian King]

The pointer buf is being assigned a value that is never read, it is
being re-assigned later on closer to where is it required to be set.
The assignment is redundant and can be removed. Cleans up clang
scan build warning:

fs/pipe.c:490:24: warning: Value stored to 'buf' during its
initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 fs/pipe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/pipe.c b/fs/pipe.c
index cc28623a67b6..d19229df66ee 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -487,7 +487,7 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from)
 		head = pipe->head;
 		if (!pipe_full(head, pipe->tail, pipe->max_usage)) {
 			unsigned int mask = pipe->ring_size - 1;
-			struct pipe_buffer *buf = &pipe->bufs[head & mask];
+			struct pipe_buffer *buf;
 			struct page *page = pipe->tmp_page;
 			int copied;
 
-- 
2.33.1

Re: [PATCH] pipe: remove redundant assignment to pointer buf

[Christian Brauner]

On Wed, Jan 19, 2022 at 10:56:33PM +0000, Colin Ian King wrote:
> The pointer buf is being assigned a value that is never read, it is
> being re-assigned later on closer to where is it required to be set.
> The assignment is redundant and can be removed. Cleans up clang
> scan build warning:
> 
> fs/pipe.c:490:24: warning: Value stored to 'buf' during its
> initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---

Acked-by: Christian Brauner <brauner@kernel.org>