Re: [PATCH net-next v4 11/11] net: dsa: realtek: rtl8365mb: multiple cpu ports, non cpu extint

From: Vladimir Oltean <olteanv@gmail.com>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	"Frank Wunderlich" <frank-w@public-files.de>,
	"Alvin Šipraga" <ALSI@bang-olufsen.dk>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"arinc.unal@arinc9.com" <arinc.unal@arinc9.com>
Subject: Re: [PATCH net-next v4 11/11] net: dsa: realtek: rtl8365mb: multiple cpu ports, non cpu extint
Date: Fri, 21 Jan 2022 04:06:27 +0200	[thread overview]
Message-ID: <20220121020627.spli3diixw7uxurr@skbuf> (raw)
In-Reply-To: <CAJq09z6UE72zSVZfUi6rk_nBKGOBC0zjeyowHgsHDHh7WyH0jA@mail.gmail.com>

On Thu, Jan 20, 2022 at 08:35:54PM -0300, Luiz Angelo Daros de Luca wrote:
> > And what is the problem if the hardware cannot calculate the checksum
> > with an unknown EtherType? Is it the DSA master that drops the packets
> > in hardware? What is the reported error counter?
> 
> No, the issue is with outgoing packets and nothing is dropped inside
> the DSA device.

Ah, sorry, I missed that.

> If the OS is configured to offload (I'm using OpenWrt.), it will send
> a packet with the wrong checksum expecting that the HW will fix that.
> After DSA is brought up, the OS is still expecting the HW to calculate
> the checksums. However, with the EtherType DSA tag from a , it cannot
> understand it anymore, leaving the checksum as is. The DSA switch
> (Realtek) passes the packet to the network and the other end receives
> a broken packet. Maybe if the DSA knew that the CPU Ethernet HW cannot
> handle that DSA tag, it could disable checksums by default. But it is
> difficult to foresee how each offload HW will digest each type of CPU
> tag.
> 
> Is the kernel enabling checksum by default when the driver reports it
> is supported? If so, it would be nice to somehow disable offloading
> with some kind of device-tree dsa cpu port property.

:) device tree properties are not the fix for everything!

I think I know what the problem is. But I'd need to know what the driver
for the DSA master is, to confirm. To be precise, what I'd like to check
is the value of master->vlan_features.