* [PATCH net] selftests: net: ioam: Fixes b63c5478e9
@ 2022-01-21 17:34 ` Justin Iurman
0 siblings, 0 replies; 4+ messages in thread
From: Justin Iurman @ 2022-01-21 17:34 UTC (permalink / raw)
To: netdev
Cc: davem, kuba, shuah, linux-kselftest, linux-kernel, oliver.sang,
idosch, lkp, lkp, justin.iurman
The IOAM queue-depth data field was added a few weeks ago, but the test unit
was not updated accordingly. Here is the fix, thanks for the report.
Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Justin Iurman <justin.iurman@uliege.be>
---
tools/testing/selftests/net/ioam6_parser.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/testing/selftests/net/ioam6_parser.c b/tools/testing/selftests/net/ioam6_parser.c
index 8f6997d35816..d9d1d4190126 100644
--- a/tools/testing/selftests/net/ioam6_parser.c
+++ b/tools/testing/selftests/net/ioam6_parser.c
@@ -240,11 +240,8 @@ static int check_ioam6_data(__u8 **p, struct ioam6_trace_hdr *ioam6h,
*p += sizeof(__u32);
}
- if (ioam6h->type.bit6) {
- if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
- return 1;
+ if (ioam6h->type.bit6)
*p += sizeof(__u32);
- }
if (ioam6h->type.bit7) {
if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH net] selftests: net: ioam: Fixes b63c5478e9
@ 2022-01-21 17:34 ` Justin Iurman
0 siblings, 0 replies; 4+ messages in thread
From: Justin Iurman @ 2022-01-21 17:34 UTC (permalink / raw)
To: lkp
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
The IOAM queue-depth data field was added a few weeks ago, but the test unit
was not updated accordingly. Here is the fix, thanks for the report.
Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Justin Iurman <justin.iurman@uliege.be>
---
tools/testing/selftests/net/ioam6_parser.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/testing/selftests/net/ioam6_parser.c b/tools/testing/selftests/net/ioam6_parser.c
index 8f6997d35816..d9d1d4190126 100644
--- a/tools/testing/selftests/net/ioam6_parser.c
+++ b/tools/testing/selftests/net/ioam6_parser.c
@@ -240,11 +240,8 @@ static int check_ioam6_data(__u8 **p, struct ioam6_trace_hdr *ioam6h,
*p += sizeof(__u32);
}
- if (ioam6h->type.bit6) {
- if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
- return 1;
+ if (ioam6h->type.bit6)
*p += sizeof(__u32);
- }
if (ioam6h->type.bit7) {
if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] selftests: net: ioam: Fixes b63c5478e9
2022-01-21 17:34 ` Justin Iurman
@ 2022-01-22 3:27 ` Jakub Kicinski
-1 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-01-22 3:27 UTC (permalink / raw)
To: Justin Iurman
Cc: netdev, davem, shuah, linux-kselftest, linux-kernel, oliver.sang,
idosch, lkp, lkp
On Fri, 21 Jan 2022 18:34:49 +0100 Justin Iurman wrote:
> Subject: [PATCH net] selftests: net: ioam: Fixes b63c5478e9
selftests: net: ioam: expect support for Queue depth data
> Date: Fri, 21 Jan 2022 18:34:49 +0100
> X-Mailer: git-send-email 2.25.1
>
> The IOAM queue-depth data field was added a few weeks ago, but the test unit
> was not updated accordingly. Here is the fix, thanks for the report.
s/Here.*//
> Reported-by: kernel test robot <oliver.sang@intel.com>
Fixes: b63c5478e9cb ("ipv6: ioam: Support for Queue depth data field")
> Signed-off-by: Justin Iurman <justin.iurman@uliege.be>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] selftests: net: ioam: Fixes b63c5478e9
@ 2022-01-22 3:27 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-01-22 3:27 UTC (permalink / raw)
To: lkp
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
On Fri, 21 Jan 2022 18:34:49 +0100 Justin Iurman wrote:
> Subject: [PATCH net] selftests: net: ioam: Fixes b63c5478e9
selftests: net: ioam: expect support for Queue depth data
> Date: Fri, 21 Jan 2022 18:34:49 +0100
> X-Mailer: git-send-email 2.25.1
>
> The IOAM queue-depth data field was added a few weeks ago, but the test unit
> was not updated accordingly. Here is the fix, thanks for the report.
s/Here.*//
> Reported-by: kernel test robot <oliver.sang@intel.com>
Fixes: b63c5478e9cb ("ipv6: ioam: Support for Queue depth data field")
> Signed-off-by: Justin Iurman <justin.iurman@uliege.be>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-22 3:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-21 17:34 [PATCH net] selftests: net: ioam: Fixes b63c5478e9 Justin Iurman
2022-01-21 17:34 ` Justin Iurman
2022-01-22 3:27 ` Jakub Kicinski
2022-01-22 3:27 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.