* Re: [PATCH] ipv4: fix lock leaks
@ 2022-01-21 22:57 kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-01-21 22:57 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 10174 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20220121031108.4813-1-ycaibb@gmail.com>
References: <20220121031108.4813-1-ycaibb@gmail.com>
TO: ycaibb <ycaibb@gmail.com>
TO: edumazet(a)google.com
TO: davem(a)davemloft.net
TO: yoshfuji(a)linux-ipv6.org
TO: dsahern(a)kernel.org
TO: kuba(a)kernel.org
TO: ast(a)kernel.org
TO: daniel(a)iogearbox.net
TO: andrii(a)kernel.org
TO: kafai(a)fb.com
TO: songliubraving(a)fb.com
Hi ycaibb,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master horms-ipvs/master linus/master v5.16 next-20220121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/ycaibb/ipv4-fix-lock-leaks/20220121-111241
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8aaaf2f3af2ae212428f4db1af34214225f5cec3
:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago
config: x86_64-randconfig-m001-20220117 (https://download.01.org/0day-ci/archive/20220122/202201220630.r90cJXB8-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
net/ipv4/tcp_ipv4.c:2344 listening_get_first() warn: curly braces intended?
net/ipv4/tcp_ipv4.c:2340 listening_get_first() warn: ignoring unreachable code.
net/ipv4/tcp_ipv4.c:2423 established_get_first() warn: curly braces intended?
Old smatch warnings:
net/ipv4/tcp_ipv4.c:2965 bpf_iter_tcp_seq_show() error: uninitialized symbol 'slow'.
vim +2344 net/ipv4/tcp_ipv4.c
ad2d61376a0517 Martin KaFai Lau 2021-07-01 2321
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2322 /* Find a non empty bucket (starting from st->bucket)
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2323 * and return the first sk from it.
a8b690f98baf9f Tom Herbert 2010-06-07 2324 */
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2325 static void *listening_get_first(struct seq_file *seq)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2326 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2327 struct tcp_iter_state *st = seq->private;
b08d4d3b6c0460 Yonghong Song 2020-06-23 2328
a8b690f98baf9f Tom Herbert 2010-06-07 2329 st->offset = 0;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2330 for (; st->bucket <= tcp_hashinfo.lhash2_mask; st->bucket++) {
05c0b35709c58b Martin KaFai Lau 2021-07-01 2331 struct inet_listen_hashbucket *ilb2;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2332 struct inet_connection_sock *icsk;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2333 struct sock *sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2334
05c0b35709c58b Martin KaFai Lau 2021-07-01 2335 ilb2 = &tcp_hashinfo.lhash2[st->bucket];
05c0b35709c58b Martin KaFai Lau 2021-07-01 2336 if (hlist_empty(&ilb2->head))
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2337 continue;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2338
05c0b35709c58b Martin KaFai Lau 2021-07-01 2339 spin_lock(&ilb2->lock);
05c0b35709c58b Martin KaFai Lau 2021-07-01 @2340 inet_lhash2_for_each_icsk(icsk, &ilb2->head) {
05c0b35709c58b Martin KaFai Lau 2021-07-01 2341 sk = (struct sock *)icsk;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2342 if (seq_sk_match(seq, sk))
604258c8f5a979 Ryan Cai 2022-01-21 2343 spin_unlock(&ilb2->lock);
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 @2344 return sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2345 }
05c0b35709c58b Martin KaFai Lau 2021-07-01 2346 spin_unlock(&ilb2->lock);
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2347 }
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2348
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2349 return NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2350 }
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2351
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2352 /* Find the next sk of "cur" within the same bucket (i.e. st->bucket).
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2353 * If "cur" is the last one in the st->bucket,
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2354 * call listening_get_first() to return the first sk of the next
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2355 * non empty bucket.
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2356 */
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2357 static void *listening_get_next(struct seq_file *seq, void *cur)
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2358 {
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2359 struct tcp_iter_state *st = seq->private;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2360 struct inet_listen_hashbucket *ilb2;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2361 struct inet_connection_sock *icsk;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2362 struct sock *sk = cur;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2363
^1da177e4c3f41 Linus Torvalds 2005-04-16 2364 ++st->num;
a8b690f98baf9f Tom Herbert 2010-06-07 2365 ++st->offset;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2366
05c0b35709c58b Martin KaFai Lau 2021-07-01 2367 icsk = inet_csk(sk);
05c0b35709c58b Martin KaFai Lau 2021-07-01 2368 inet_lhash2_for_each_icsk_continue(icsk) {
05c0b35709c58b Martin KaFai Lau 2021-07-01 2369 sk = (struct sock *)icsk;
ad2d61376a0517 Martin KaFai Lau 2021-07-01 2370 if (seq_sk_match(seq, sk))
3b24d854cb3538 Eric Dumazet 2016-04-01 2371 return sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2372 }
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2373
05c0b35709c58b Martin KaFai Lau 2021-07-01 2374 ilb2 = &tcp_hashinfo.lhash2[st->bucket];
05c0b35709c58b Martin KaFai Lau 2021-07-01 2375 spin_unlock(&ilb2->lock);
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2376 ++st->bucket;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2377 return listening_get_first(seq);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2378 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2379
^1da177e4c3f41 Linus Torvalds 2005-04-16 2380 static void *listening_get_idx(struct seq_file *seq, loff_t *pos)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2381 {
a8b690f98baf9f Tom Herbert 2010-06-07 2382 struct tcp_iter_state *st = seq->private;
a8b690f98baf9f Tom Herbert 2010-06-07 2383 void *rc;
a8b690f98baf9f Tom Herbert 2010-06-07 2384
a8b690f98baf9f Tom Herbert 2010-06-07 2385 st->bucket = 0;
a8b690f98baf9f Tom Herbert 2010-06-07 2386 st->offset = 0;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2387 rc = listening_get_first(seq);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2388
^1da177e4c3f41 Linus Torvalds 2005-04-16 2389 while (rc && *pos) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2390 rc = listening_get_next(seq, rc);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2391 --*pos;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2392 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2393 return rc;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2394 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2395
05dbc7b59481ca Eric Dumazet 2013-10-03 2396 static inline bool empty_bucket(const struct tcp_iter_state *st)
6eac56040787c3 Andi Kleen 2008-08-28 2397 {
05dbc7b59481ca Eric Dumazet 2013-10-03 2398 return hlist_nulls_empty(&tcp_hashinfo.ehash[st->bucket].chain);
6eac56040787c3 Andi Kleen 2008-08-28 2399 }
6eac56040787c3 Andi Kleen 2008-08-28 2400
a8b690f98baf9f Tom Herbert 2010-06-07 2401 /*
a8b690f98baf9f Tom Herbert 2010-06-07 2402 * Get first established socket starting from bucket given in st->bucket.
a8b690f98baf9f Tom Herbert 2010-06-07 2403 * If st->bucket is zero, the very first socket in the hash is returned.
a8b690f98baf9f Tom Herbert 2010-06-07 2404 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 2405 static void *established_get_first(struct seq_file *seq)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2406 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2407 struct tcp_iter_state *st = seq->private;
b08d4d3b6c0460 Yonghong Song 2020-06-23 2408
a8b690f98baf9f Tom Herbert 2010-06-07 2409 st->offset = 0;
a8b690f98baf9f Tom Herbert 2010-06-07 2410 for (; st->bucket <= tcp_hashinfo.ehash_mask; ++st->bucket) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2411 struct sock *sk;
3ab5aee7fe840b Eric Dumazet 2008-11-16 2412 struct hlist_nulls_node *node;
9db66bdcc83749 Eric Dumazet 2008-11-20 2413 spinlock_t *lock = inet_ehash_lockp(&tcp_hashinfo, st->bucket);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2414
6eac56040787c3 Andi Kleen 2008-08-28 2415 /* Lockless fast path for the common case of empty buckets */
6eac56040787c3 Andi Kleen 2008-08-28 2416 if (empty_bucket(st))
6eac56040787c3 Andi Kleen 2008-08-28 2417 continue;
6eac56040787c3 Andi Kleen 2008-08-28 2418
9db66bdcc83749 Eric Dumazet 2008-11-20 2419 spin_lock_bh(lock);
3ab5aee7fe840b Eric Dumazet 2008-11-16 2420 sk_nulls_for_each(sk, node, &tcp_hashinfo.ehash[st->bucket].chain) {
ad2d61376a0517 Martin KaFai Lau 2021-07-01 2421 if (seq_sk_match(seq, sk))
604258c8f5a979 Ryan Cai 2022-01-21 2422 spin_unlock_bh(lock);
ad2d61376a0517 Martin KaFai Lau 2021-07-01 @2423 return sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2424 }
9db66bdcc83749 Eric Dumazet 2008-11-20 2425 spin_unlock_bh(lock);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2426 }
ad2d61376a0517 Martin KaFai Lau 2021-07-01 2427
ad2d61376a0517 Martin KaFai Lau 2021-07-01 2428 return NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2429 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2430
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] ipv4: fix lock leaks
@ 2022-01-21 3:11 ycaibb
2022-01-21 3:46 ` Jakub Kicinski
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: ycaibb @ 2022-01-21 3:11 UTC (permalink / raw)
To: edumazet, davem, yoshfuji, dsahern, kuba, ast, daniel, andrii,
kafai, songliubraving, yhs, john.fastabend, kpsingh
Cc: netdev, linux-kernel, bpf, ycaibb
From: Ryan Cai <ycaibb@gmail.com>
In methods listening_get_first and listening_get_first in tcp_ipv4.c, there are lock leaks when seq_sk_match returns true.
Signed-off-by: Ryan Cai <ycaibb@gmail.com>
---
net/ipv4/tcp_ipv4.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 13d868c43284..714107766035 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -2329,6 +2329,7 @@ static void *listening_get_first(struct seq_file *seq)
inet_lhash2_for_each_icsk(icsk, &ilb2->head) {
sk = (struct sock *)icsk;
if (seq_sk_match(seq, sk))
+ spin_unlock(&ilb2->lock);
return sk;
}
spin_unlock(&ilb2->lock);
@@ -2407,6 +2408,7 @@ static void *established_get_first(struct seq_file *seq)
spin_lock_bh(lock);
sk_nulls_for_each(sk, node, &tcp_hashinfo.ehash[st->bucket].chain) {
if (seq_sk_match(seq, sk))
+ spin_unlock_bh(lock);
return sk;
}
spin_unlock_bh(lock);
--
2.33.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] ipv4: fix lock leaks
2022-01-21 3:11 ycaibb
@ 2022-01-21 3:46 ` Jakub Kicinski
2022-01-21 3:47 ` Jakub Kicinski
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Jakub Kicinski @ 2022-01-21 3:46 UTC (permalink / raw)
To: ycaibb
Cc: edumazet, davem, yoshfuji, dsahern, ast, daniel, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh, netdev,
linux-kernel, bpf
On Fri, 21 Jan 2022 11:11:08 +0800 ycaibb wrote:
> From: Ryan Cai <ycaibb@gmail.com>
>
> In methods listening_get_first and listening_get_first in tcp_ipv4.c,
> there are lock leaks when seq_sk_match returns true.
This is on purpose, please read the code carefully and try to test
your patches.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ipv4: fix lock leaks
2022-01-21 3:11 ycaibb
2022-01-21 3:46 ` Jakub Kicinski
@ 2022-01-21 3:47 ` Jakub Kicinski
2022-01-21 4:06 ` Ryan Cai
2022-01-21 7:58 ` kernel test robot
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Jakub Kicinski @ 2022-01-21 3:47 UTC (permalink / raw)
To: ycaibb
Cc: edumazet, davem, yoshfuji, dsahern, ast, daniel, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh, netdev,
linux-kernel, bpf
On Fri, 21 Jan 2022 11:11:08 +0800 ycaibb wrote:
> if (seq_sk_match(seq, sk))
> + spin_unlock_bh(lock);
> return sk;
Heh, also you're missing brackets so this is patently buggy.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ipv4: fix lock leaks
2022-01-21 3:47 ` Jakub Kicinski
@ 2022-01-21 4:06 ` Ryan Cai
2022-01-21 4:11 ` Alexei Starovoitov
0 siblings, 1 reply; 10+ messages in thread
From: Ryan Cai @ 2022-01-21 4:06 UTC (permalink / raw)
To: Jakub Kicinski
Cc: edumazet, davem, yoshfuji, dsahern, ast, daniel, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh, netdev,
linux-kernel, bpf
Sorry for reporting this false positive. Would be more careful next time. Thank you for your checking.
Best,
Ryan
On 21/1/2022, 11:47 AM, "Jakub Kicinski" <kuba@kernel.org> wrote:
On Fri, 21 Jan 2022 11:11:08 +0800 ycaibb wrote:
> if (seq_sk_match(seq, sk))
> + spin_unlock_bh(lock);
> return sk;
Heh, also you're missing brackets so this is patently buggy.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ipv4: fix lock leaks
2022-01-21 4:06 ` Ryan Cai
@ 2022-01-21 4:11 ` Alexei Starovoitov
0 siblings, 0 replies; 10+ messages in thread
From: Alexei Starovoitov @ 2022-01-21 4:11 UTC (permalink / raw)
To: Ryan Cai
Cc: Jakub Kicinski, Eric Dumazet, David S. Miller, Hideaki YOSHIFUJI,
David Ahern, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, Martin KaFai Lau, Song Liu, Yonghong Song,
John Fastabend, KP Singh, Network Development, LKML, bpf
On Thu, Jan 20, 2022 at 8:06 PM Ryan Cai <ycaibb@gmail.com> wrote:
>
> Sorry for reporting this false positive. Would be more careful next time. Thank you for your checking.
In the past 3 weeks you've sent 4 subtly broken patches.
Not a single valid one.
Are you trying to test the maintainer's review skills?
Is this another "lets hack the kernel" research project?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ipv4: fix lock leaks
2022-01-21 3:11 ycaibb
@ 2022-01-21 7:58 ` kernel test robot
2022-01-21 3:47 ` Jakub Kicinski
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-01-21 7:58 UTC (permalink / raw)
To: ycaibb, edumazet, davem, yoshfuji, dsahern, kuba, ast, daniel,
andrii, kafai, songliubraving
Cc: llvm, kbuild-all
Hi ycaibb,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master horms-ipvs/master linus/master v5.16 next-20220121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/ycaibb/ipv4-fix-lock-leaks/20220121-111241
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8aaaf2f3af2ae212428f4db1af34214225f5cec3
config: mips-cu1000-neo_defconfig (https://download.01.org/0day-ci/archive/20220121/202201211532.LRhcv7cH-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d4baf3b1322b84816aa623d8e8cb45a49cb68b84)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/604258c8f5a9792828f54e55769ca1673c4a34ee
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review ycaibb/ipv4-fix-lock-leaks/20220121-111241
git checkout 604258c8f5a9792828f54e55769ca1673c4a34ee
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash net/ipv4/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/ipv4/tcp_ipv4.c:2344:5: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
return sk;
^
net/ipv4/tcp_ipv4.c:2342:4: note: previous statement is here
if (seq_sk_match(seq, sk))
^
net/ipv4/tcp_ipv4.c:2423:5: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
return sk;
^
net/ipv4/tcp_ipv4.c:2421:4: note: previous statement is here
if (seq_sk_match(seq, sk))
^
2 warnings generated.
vim +/if +2344 net/ipv4/tcp_ipv4.c
ad2d61376a0517 Martin KaFai Lau 2021-07-01 2321
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2322 /* Find a non empty bucket (starting from st->bucket)
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2323 * and return the first sk from it.
a8b690f98baf9f Tom Herbert 2010-06-07 2324 */
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2325 static void *listening_get_first(struct seq_file *seq)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2326 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2327 struct tcp_iter_state *st = seq->private;
b08d4d3b6c0460 Yonghong Song 2020-06-23 2328
a8b690f98baf9f Tom Herbert 2010-06-07 2329 st->offset = 0;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2330 for (; st->bucket <= tcp_hashinfo.lhash2_mask; st->bucket++) {
05c0b35709c58b Martin KaFai Lau 2021-07-01 2331 struct inet_listen_hashbucket *ilb2;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2332 struct inet_connection_sock *icsk;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2333 struct sock *sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2334
05c0b35709c58b Martin KaFai Lau 2021-07-01 2335 ilb2 = &tcp_hashinfo.lhash2[st->bucket];
05c0b35709c58b Martin KaFai Lau 2021-07-01 2336 if (hlist_empty(&ilb2->head))
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2337 continue;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2338
05c0b35709c58b Martin KaFai Lau 2021-07-01 2339 spin_lock(&ilb2->lock);
05c0b35709c58b Martin KaFai Lau 2021-07-01 2340 inet_lhash2_for_each_icsk(icsk, &ilb2->head) {
05c0b35709c58b Martin KaFai Lau 2021-07-01 2341 sk = (struct sock *)icsk;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2342 if (seq_sk_match(seq, sk))
604258c8f5a979 Ryan Cai 2022-01-21 2343 spin_unlock(&ilb2->lock);
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 @2344 return sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2345 }
05c0b35709c58b Martin KaFai Lau 2021-07-01 2346 spin_unlock(&ilb2->lock);
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2347 }
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2348
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2349 return NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2350 }
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2351
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ipv4: fix lock leaks
@ 2022-01-21 7:58 ` kernel test robot
0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-01-21 7:58 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5008 bytes --]
Hi ycaibb,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master horms-ipvs/master linus/master v5.16 next-20220121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/ycaibb/ipv4-fix-lock-leaks/20220121-111241
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8aaaf2f3af2ae212428f4db1af34214225f5cec3
config: mips-cu1000-neo_defconfig (https://download.01.org/0day-ci/archive/20220121/202201211532.LRhcv7cH-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d4baf3b1322b84816aa623d8e8cb45a49cb68b84)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/604258c8f5a9792828f54e55769ca1673c4a34ee
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review ycaibb/ipv4-fix-lock-leaks/20220121-111241
git checkout 604258c8f5a9792828f54e55769ca1673c4a34ee
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash net/ipv4/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/ipv4/tcp_ipv4.c:2344:5: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
return sk;
^
net/ipv4/tcp_ipv4.c:2342:4: note: previous statement is here
if (seq_sk_match(seq, sk))
^
net/ipv4/tcp_ipv4.c:2423:5: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
return sk;
^
net/ipv4/tcp_ipv4.c:2421:4: note: previous statement is here
if (seq_sk_match(seq, sk))
^
2 warnings generated.
vim +/if +2344 net/ipv4/tcp_ipv4.c
ad2d61376a0517 Martin KaFai Lau 2021-07-01 2321
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2322 /* Find a non empty bucket (starting from st->bucket)
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2323 * and return the first sk from it.
a8b690f98baf9f Tom Herbert 2010-06-07 2324 */
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2325 static void *listening_get_first(struct seq_file *seq)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2326 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2327 struct tcp_iter_state *st = seq->private;
b08d4d3b6c0460 Yonghong Song 2020-06-23 2328
a8b690f98baf9f Tom Herbert 2010-06-07 2329 st->offset = 0;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2330 for (; st->bucket <= tcp_hashinfo.lhash2_mask; st->bucket++) {
05c0b35709c58b Martin KaFai Lau 2021-07-01 2331 struct inet_listen_hashbucket *ilb2;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2332 struct inet_connection_sock *icsk;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2333 struct sock *sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2334
05c0b35709c58b Martin KaFai Lau 2021-07-01 2335 ilb2 = &tcp_hashinfo.lhash2[st->bucket];
05c0b35709c58b Martin KaFai Lau 2021-07-01 2336 if (hlist_empty(&ilb2->head))
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2337 continue;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2338
05c0b35709c58b Martin KaFai Lau 2021-07-01 2339 spin_lock(&ilb2->lock);
05c0b35709c58b Martin KaFai Lau 2021-07-01 2340 inet_lhash2_for_each_icsk(icsk, &ilb2->head) {
05c0b35709c58b Martin KaFai Lau 2021-07-01 2341 sk = (struct sock *)icsk;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2342 if (seq_sk_match(seq, sk))
604258c8f5a979 Ryan Cai 2022-01-21 2343 spin_unlock(&ilb2->lock);
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 @2344 return sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2345 }
05c0b35709c58b Martin KaFai Lau 2021-07-01 2346 spin_unlock(&ilb2->lock);
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2347 }
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2348
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2349 return NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2350 }
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2351
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ipv4: fix lock leaks
2022-01-21 3:11 ycaibb
` (2 preceding siblings ...)
2022-01-21 7:58 ` kernel test robot
@ 2022-01-21 9:30 ` kernel test robot
2022-01-21 9:30 ` kernel test robot
4 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-01-21 9:30 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 5053 bytes --]
Hi ycaibb,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master v5.16 next-20220121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/ycaibb/ipv4-fix-lock-leaks/20220121-111241
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8aaaf2f3af2ae212428f4db1af34214225f5cec3
config: powerpc-warp_defconfig (https://download.01.org/0day-ci/archive/20220121/202201211710.SKAxSkq3-lkp(a)intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/604258c8f5a9792828f54e55769ca1673c4a34ee
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review ycaibb/ipv4-fix-lock-leaks/20220121-111241
git checkout 604258c8f5a9792828f54e55769ca1673c4a34ee
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash net/ipv4/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
net/ipv4/tcp_ipv4.c: In function 'listening_get_first':
>> net/ipv4/tcp_ipv4.c:2342:25: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
2342 | if (seq_sk_match(seq, sk))
| ^~
net/ipv4/tcp_ipv4.c:2344:33: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
2344 | return sk;
| ^~~~~~
net/ipv4/tcp_ipv4.c: In function 'established_get_first':
net/ipv4/tcp_ipv4.c:2421:25: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
2421 | if (seq_sk_match(seq, sk))
| ^~
net/ipv4/tcp_ipv4.c:2423:33: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
2423 | return sk;
| ^~~~~~
vim +/if +2342 net/ipv4/tcp_ipv4.c
ad2d61376a0517 Martin KaFai Lau 2021-07-01 2321
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2322 /* Find a non empty bucket (starting from st->bucket)
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2323 * and return the first sk from it.
a8b690f98baf9f Tom Herbert 2010-06-07 2324 */
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2325 static void *listening_get_first(struct seq_file *seq)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2326 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2327 struct tcp_iter_state *st = seq->private;
b08d4d3b6c0460 Yonghong Song 2020-06-23 2328
a8b690f98baf9f Tom Herbert 2010-06-07 2329 st->offset = 0;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2330 for (; st->bucket <= tcp_hashinfo.lhash2_mask; st->bucket++) {
05c0b35709c58b Martin KaFai Lau 2021-07-01 2331 struct inet_listen_hashbucket *ilb2;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2332 struct inet_connection_sock *icsk;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2333 struct sock *sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2334
05c0b35709c58b Martin KaFai Lau 2021-07-01 2335 ilb2 = &tcp_hashinfo.lhash2[st->bucket];
05c0b35709c58b Martin KaFai Lau 2021-07-01 2336 if (hlist_empty(&ilb2->head))
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2337 continue;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2338
05c0b35709c58b Martin KaFai Lau 2021-07-01 2339 spin_lock(&ilb2->lock);
05c0b35709c58b Martin KaFai Lau 2021-07-01 2340 inet_lhash2_for_each_icsk(icsk, &ilb2->head) {
05c0b35709c58b Martin KaFai Lau 2021-07-01 2341 sk = (struct sock *)icsk;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 @2342 if (seq_sk_match(seq, sk))
604258c8f5a979 Ryan Cai 2022-01-21 2343 spin_unlock(&ilb2->lock);
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2344 return sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2345 }
05c0b35709c58b Martin KaFai Lau 2021-07-01 2346 spin_unlock(&ilb2->lock);
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2347 }
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2348
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2349 return NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2350 }
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2351
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ipv4: fix lock leaks
2022-01-21 3:11 ycaibb
` (3 preceding siblings ...)
2022-01-21 9:30 ` kernel test robot
@ 2022-01-21 9:30 ` kernel test robot
4 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-01-21 9:30 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4676 bytes --]
Hi ycaibb,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master horms-ipvs/master linus/master v5.16 next-20220121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/ycaibb/ipv4-fix-lock-leaks/20220121-111241
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8aaaf2f3af2ae212428f4db1af34214225f5cec3
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220121/202201211725.MInieseL-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/604258c8f5a9792828f54e55769ca1673c4a34ee
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review ycaibb/ipv4-fix-lock-leaks/20220121-111241
git checkout 604258c8f5a9792828f54e55769ca1673c4a34ee
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash net/ipv4/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
net/ipv4/tcp_ipv4.c: In function 'listening_get_first':
>> net/ipv4/tcp_ipv4.c:2342:4: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
2342 | if (seq_sk_match(seq, sk))
| ^~
net/ipv4/tcp_ipv4.c:2344:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
2344 | return sk;
| ^~~~~~
net/ipv4/tcp_ipv4.c: In function 'established_get_first':
net/ipv4/tcp_ipv4.c:2421:4: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
2421 | if (seq_sk_match(seq, sk))
| ^~
net/ipv4/tcp_ipv4.c:2423:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
2423 | return sk;
| ^~~~~~
vim +/if +2342 net/ipv4/tcp_ipv4.c
ad2d61376a0517 Martin KaFai Lau 2021-07-01 2321
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2322 /* Find a non empty bucket (starting from st->bucket)
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2323 * and return the first sk from it.
a8b690f98baf9f Tom Herbert 2010-06-07 2324 */
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2325 static void *listening_get_first(struct seq_file *seq)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2326 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 2327 struct tcp_iter_state *st = seq->private;
b08d4d3b6c0460 Yonghong Song 2020-06-23 2328
a8b690f98baf9f Tom Herbert 2010-06-07 2329 st->offset = 0;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2330 for (; st->bucket <= tcp_hashinfo.lhash2_mask; st->bucket++) {
05c0b35709c58b Martin KaFai Lau 2021-07-01 2331 struct inet_listen_hashbucket *ilb2;
05c0b35709c58b Martin KaFai Lau 2021-07-01 2332 struct inet_connection_sock *icsk;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2333 struct sock *sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2334
05c0b35709c58b Martin KaFai Lau 2021-07-01 2335 ilb2 = &tcp_hashinfo.lhash2[st->bucket];
05c0b35709c58b Martin KaFai Lau 2021-07-01 2336 if (hlist_empty(&ilb2->head))
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2337 continue;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2338
05c0b35709c58b Martin KaFai Lau 2021-07-01 2339 spin_lock(&ilb2->lock);
05c0b35709c58b Martin KaFai Lau 2021-07-01 2340 inet_lhash2_for_each_icsk(icsk, &ilb2->head) {
05c0b35709c58b Martin KaFai Lau 2021-07-01 2341 sk = (struct sock *)icsk;
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 @2342 if (seq_sk_match(seq, sk))
604258c8f5a979 Ryan Cai 2022-01-21 2343 spin_unlock(&ilb2->lock);
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2344 return sk;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2345 }
05c0b35709c58b Martin KaFai Lau 2021-07-01 2346 spin_unlock(&ilb2->lock);
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2347 }
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2348
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2349 return NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2350 }
b72acf4501d7c3 Martin KaFai Lau 2021-07-01 2351
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-01-21 22:57 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-21 22:57 [PATCH] ipv4: fix lock leaks kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-01-21 3:11 ycaibb
2022-01-21 3:46 ` Jakub Kicinski
2022-01-21 3:47 ` Jakub Kicinski
2022-01-21 4:06 ` Ryan Cai
2022-01-21 4:11 ` Alexei Starovoitov
2022-01-21 7:58 ` kernel test robot
2022-01-21 7:58 ` kernel test robot
2022-01-21 9:30 ` kernel test robot
2022-01-21 9:30 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.