All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit branch/2021.02.x] package/linux-pam: separate locale and wchar dependencies
@ 2022-01-22 17:54 Peter Korsgaard
  0 siblings, 0 replies; only message in thread
From: Peter Korsgaard @ 2022-01-22 17:54 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=986fd8838f5c8348db889b9e6418ded3a2306243
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/2021.02.x

They are currently expressed as such:

     depends on (BR2_ENABLE_LOCALE && BR2_USE_WCHAR)

which is not the common practice in Buildroot. We prefer to use:

     depends on BR2_ENABLE_LOCALE
     depends on BR2_USE_WCHAR

This commit ensures linux-pam is consistent with this best practice.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
(cherry picked from commit ac9261edec111836952970e26cf373cc15b9e8ac)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/linux-pam/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/linux-pam/Config.in b/package/linux-pam/Config.in
index 931cfdeccf..27ba55bd61 100644
--- a/package/linux-pam/Config.in
+++ b/package/linux-pam/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LINUX_PAM
 	bool "linux-pam"
-	depends on (BR2_ENABLE_LOCALE && BR2_USE_WCHAR)
+	depends on BR2_ENABLE_LOCALE
+	depends on BR2_USE_WCHAR
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_USE_MMU # fork()
 	select BR2_PACKAGE_FLEX
@@ -12,5 +13,5 @@ config BR2_PACKAGE_LINUX_PAM
 
 comment "linux-pam needs a toolchain w/ wchar, locale, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !(BR2_ENABLE_LOCALE && BR2_USE_WCHAR) \
+	depends on !BR2_ENABLE_LOCALE || !BR2_USE_WCHAR \
 		|| BR2_STATIC_LIBS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-01-22 18:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-22 17:54 [Buildroot] [git commit branch/2021.02.x] package/linux-pam: separate locale and wchar dependencies Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.