[PATCH 1/4] dt-bindings: clock: gcc-msm8998: Add definitions of SSC-related clocks

[PATCH 1/4] dt-bindings: clock: gcc-msm8998: Add definitions of SSC-related clocks

[michael.srba]

From: Michael Srba <Michael.Srba@seznam.cz>

 This patch adds definitions of four clocks which need to be manipulated
 in order to initialize the AHB bus which exposes the SCC block in the
 global address space.

Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
---
 include/dt-bindings/clock/qcom,gcc-msm8998.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/dt-bindings/clock/qcom,gcc-msm8998.h b/include/dt-bindings/clock/qcom,gcc-msm8998.h
index 72c99e486d86..1badb4f9c58f 100644
--- a/include/dt-bindings/clock/qcom,gcc-msm8998.h
+++ b/include/dt-bindings/clock/qcom,gcc-msm8998.h
@@ -186,6 +186,10 @@
 #define UFS_UNIPRO_CORE_CLK_SRC					177
 #define GCC_MMSS_GPLL0_CLK					178
 #define HMSS_GPLL0_CLK_SRC					179
+#define GCC_IM_SLEEP						180
+#define AGGRE2_SNOC_NORTH_AXI					181
+#define SSC_XO							182
+#define SSC_CNOC_AHBS_CLK					183
 
 #define PCIE_0_GDSC						0
 #define UFS_GDSC						1
-- 
2.34.1

[PATCH 2/4] clk: qcom: gcc-msm8998: add SSC-related clocks

[michael.srba]

From: Michael Srba <Michael.Srba@seznam.cz>

 This patch adds four clocks which need to be manipulated in order to
 initialize the AHB bus which exposes the SCC block in the global address
 space.

 Care should be taken not to write to these registers unless the device is
 known to be configured such that writing to these registers from Linux
 is permitted.

Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
---
 drivers/clk/qcom/gcc-msm8998.c | 56 ++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c
index 407e2c5caea4..2d14c3d672fc 100644
--- a/drivers/clk/qcom/gcc-msm8998.c
+++ b/drivers/clk/qcom/gcc-msm8998.c
@@ -2833,6 +2833,58 @@ static struct clk_branch gcc_rx1_usb2_clkref_clk = {
 	},
 };
 
+static struct clk_branch gcc_im_sleep_clk = {
+	.halt_reg = 0x4300C,
+	.halt_check = BRANCH_HALT,
+	.clkr = {
+		.enable_reg = 0x4300C,
+		.enable_mask = BIT(0),
+		.hw.init = &(struct clk_init_data){
+			.name = "gcc_im_sleep_clk",
+			.ops = &clk_branch2_ops,
+		},
+	},
+};
+
+static struct clk_branch aggre2_snoc_north_axi_clk = {
+	.halt_reg = 0x83010,
+	.halt_check = BRANCH_HALT,
+	.clkr = {
+		.enable_reg = 0x83010,
+		.enable_mask = BIT(0),
+		.hw.init = &(struct clk_init_data){
+			.name = "aggre2_snoc_north_axi_clk",
+			.ops = &clk_branch2_ops,
+		},
+	},
+};
+
+static struct clk_branch ssc_xo_clk = {
+	.halt_reg = 0x63018,
+	.halt_check = BRANCH_HALT,
+	.clkr = {
+		.enable_reg = 0x63018,
+		.enable_mask = BIT(0),
+		.hw.init = &(struct clk_init_data){
+			.name = "ssc_xo_clk",
+			.ops = &clk_branch2_ops,
+		},
+	},
+};
+
+static struct clk_branch ssc_cnoc_ahbs_clk = {
+	.halt_reg = 0x6300C,
+	.halt_check = BRANCH_HALT,
+	.clkr = {
+		.enable_reg = 0x6300C,
+		.enable_mask = BIT(0),
+		.hw.init = &(struct clk_init_data){
+			.name = "ssc_cnoc_ahbs_clk",
+			.ops = &clk_branch2_ops,
+		},
+	},
+};
+
 static struct gdsc pcie_0_gdsc = {
 	.gdscr = 0x6b004,
 	.gds_hw_ctrl = 0x0,
@@ -3036,6 +3088,10 @@ static struct clk_regmap *gcc_msm8998_clocks[] = {
 	[GCC_MSS_MNOC_BIMC_AXI_CLK] = &gcc_mss_mnoc_bimc_axi_clk.clkr,
 	[GCC_MMSS_GPLL0_CLK] = &gcc_mmss_gpll0_clk.clkr,
 	[HMSS_GPLL0_CLK_SRC] = &hmss_gpll0_clk_src.clkr,
+	[GCC_IM_SLEEP] = &gcc_im_sleep_clk.clkr,
+	[AGGRE2_SNOC_NORTH_AXI] = &aggre2_snoc_north_axi_clk.clkr,
+	[SSC_XO] = &ssc_xo_clk.clkr,
+	[SSC_CNOC_AHBS_CLK] = &ssc_cnoc_ahbs_clk.clkr,
 };
 
 static struct gdsc *gcc_msm8998_gdscs[] = {
-- 
2.34.1

[PATCH 3/4] dt-bindings: bus: add device tree bindings for qcom,ssc-block-bus

[michael.srba]

From: Michael Srba <Michael.Srba@seznam.cz>

 This patch adds bindings for the AHB bus which exposes the SCC block in
 the global address space. This bus (and the SSC block itself) is present
 on certain qcom SoCs.

 In typical configuration, this bus (as some of the clocks and registers
 that we need to manipulate) is not accessible to the OS, and the
 resources on this bus are indirectly accessed by communicating with a
 hexagon CPU core residing in the SSC block. In this configuration, the
 hypervisor is the one performing the bus initialization for the purposes
 of bringing the haxagon CPU core out of reset.

 However, it is possible to change the configuration, in which case this
 binding serves to allow the OS to initialize the bus.

Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
---
 .../bindings/bus/qcom,ssc-block-bus.yaml      | 156 ++++++++++++++++++
 1 file changed, 156 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml

diff --git a/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml b/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml
new file mode 100644
index 000000000000..ff02b13618a6
--- /dev/null
+++ b/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml
@@ -0,0 +1,156 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/qcom,ssc-block-bus.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: The AHB Bus Providing a Global View of the SSC Block on (some) qcom SoCs
+
+maintainers:
+  - Michael Srba <Michael.Srba@seznam.cz>
+
+description: |
+  This binding describes the dependencies (clocks, resets, power domains) which
+  need to be turned on in a sequence before communication over the AHB bus
+  becomes possible.
+
+  Additionally, the reg property is used to pass to the driver the location of
+  two sadly undocumented registers which need to be poked as part of the sequence.
+
+  Currently, this binding is known to apply to msm8998. If the binding applies
+  in it's current form, the compatible should contain "qcom,ssc-block-bus-v1".
+  If the binding needs tweaking in order to apply to another SoC, this binding
+  shall be extended.
+
+
+properties:
+  compatible:
+    contains:
+      items:
+      - enum: [ qcom,ssc-block-bus-v1 ]
+      - const: qcom,ssc-block-bus
+    description:
+      Shall contain "qcom,ssc-block-bus"
+
+  reg:
+    description: |
+      Shall contain the addresses of the SSCAON_CONFIG0 and SSCAON_CONFIG1
+      registers
+    minItems: 2
+    maxItems: 2
+
+  reg-names:
+    minItems: 2
+    maxItems: 2
+    items:
+      - const: mpm_sscaon_config0
+      - const: mpm_sscaon_config1
+
+  '#address-cells':
+    enum: [ 1, 2 ]
+
+  '#size-cells':
+    enum: [ 1, 2 ]
+
+  ranges: true
+
+  clocks:
+    description: |
+      Clock phandles for the xo, aggre2, gcc_im_sleep, aggre2_north,
+      ssc_xo and ssc_ahbs clocks
+    minItems: 6
+    maxItems: 6
+
+  clock-names:
+    items:
+      - const: xo
+      - const: aggre2
+      - const: gcc_im_sleep
+      - const: aggre2_north
+      - const: ssc_xo
+      - const: ssc_ahbs
+
+  power-domains:
+    description: Power domain phandles for the ssc_cx and ssc_mx power domains
+    minItems: 2
+    maxItems: 2
+
+  power-domain-names:
+    items:
+      - const: ssc_cx
+      - const: ssc_mx
+
+  resets:
+    description: |
+      Reset phandles for the ssc_reset and ssc_bcr resets (note: ssc_bcr is the
+      branch control register associated with the ssc_xo and ssc_ahbs clocks)
+    minItems: 2
+    maxItems: 2
+
+  reset-names:
+    items:
+      - const: ssc_reset
+      - const: ssc_bcr
+
+  qcom,halt-regs:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    description:
+      Phandle reference to a syscon representing TCSR followed by the
+      offset within syscon for the ssc AXI halt register.
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - '#address-cells'
+  - '#size-cells'
+  - ranges
+  - clocks
+  - clock-names
+  - power-domains
+  - power-domain-names
+  - resets
+  - reset-names
+  - qcom,halt-regs
+
+additionalProperties: true
+
+examples:
+  - |
+    #include <dt-bindings/clock/qcom,gcc-msm8996.h>
+
+    &soc {
+        ssc_ahb_slave@0x10AC008 { // devices under this node are physically located in the SSC block, connected to an ssc-internal bus;
+            #address-cells = <1>;
+            #size-cells = <1>;
+            ranges;
+
+            compatible = "qcom,ssc-block-bus";
+            reg = <0x10AC008 0x4>, <0x10AC010 0x4>;
+            reg-names = "mpm_sscaon_config0", "mpm_sscaon_config1";
+
+            clocks = <&xo>,
+                     <&rpmcc RPM_SMD_AGGR2_NOC_CLK>,
+                     <&gcc GCC_IM_SLEEP>,
+                     <&gcc AGGRE2_SNOC_NORTH_AXI>,
+                     <&gcc SSC_XO>,
+                     <&gcc SSC_CNOC_AHBS_CLK>;
+            clock-names = "xo", "aggre2", "gcc_im_sleep", "aggre2_north", "ssc_xo", "ssc_ahbs";
+
+            resets = <&gcc GCC_SSC_RESET>, <&gcc GCC_SSC_BCR>;
+            reset-names = "ssc_reset", "ssc_bcr";
+
+            power-domains = <&rpmpd MSM8998_SSCCX>, <&rpmpd MSM8998_SSCMX>;
+            power-domain-names = "ssc_cx", "ssc_mx";
+
+            qcom,halt-regs = <&tcsr_mutex_regs 0x26000>;
+
+            ssc_tlmm: pinctrl@5e10000 {
+                compatible = "qcom,msm8998-ssc-tlmm-pinctrl";
+                reg = <0x5E10000 0x10000>;
+                gpio-controller;
+                #gpio-cells = <2>;
+                gpio-ranges = <&ssc_tlmm 0 0 20>;
+            };
+        };
+    };
-- 
2.34.1

[PATCH 4/4] drivers: bus: add driver for initializing the SSC bus on (some) qcom SoCs

[michael.srba]

From: Michael Srba <Michael.Srba@seznam.cz>

 This patch adds bindings for the AHB bus which exposes the SCC block in
 the global address space. This bus (and the SSC block itself) is present
 on certain qcom SoCs.

 In typical configuration, this bus (as some of the clocks and registers
 that we need to manipulate) is not accessible to Linux, and the resources
 on this bus are indirectly accessed by communicating with a hexagon CPU
 core residing in the SSC block. In this configuration, the hypervisor is
 the one performing the bus initialization for the purposes of bringing
 the haxagon CPU core out of reset.

 However, it is possible to change the configuration, in which case this
 driver will initialize the bus.

 In combination with drivers for resources on the SSC bus, this driver can
 aid in debugging, and for example with a TLMM driver can be used to
 directly access SSC-dedicated GPIO pins, removing the need to commit
 to a particular usecase during hw design.

 Finally, until open firmware for the hexagon core is available, this
 approach allows for using sensors hooked up to SSC-dedicated GPIO pins
 on mainline Linux simply by utilizing the existing in-tree drivers for
 these sensors.

Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
---
 drivers/bus/Kconfig              |   6 +
 drivers/bus/Makefile             |   1 +
 drivers/bus/qcom-ssc-block-bus.c | 365 +++++++++++++++++++++++++++++++
 3 files changed, 372 insertions(+)
 create mode 100644 drivers/bus/qcom-ssc-block-bus.c

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 3c68e174a113..f2b2e3098491 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -173,6 +173,12 @@ config SUNXI_RSB
 	  with various RSB based devices, such as AXP223, AXP8XX PMICs,
 	  and AC100/AC200 ICs.
 
+config QCOM_SSC_BLOCK_BUS
+	bool "Qualcomm SSC Block Bus Init Driver"
+	  help
+	  Say y here to enable support for initializing the bus that connects the SSC block's internal
+	  bus to the cNoC on (some) qcom SoCs
+
 config TEGRA_ACONNECT
 	tristate "Tegra ACONNECT Bus Driver"
 	depends on ARCH_TEGRA_210_SOC
diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile
index 52c2f35a26a9..e6756e83a9c4 100644
--- a/drivers/bus/Makefile
+++ b/drivers/bus/Makefile
@@ -25,6 +25,7 @@ obj-$(CONFIG_OMAP_INTERCONNECT)	+= omap_l3_smx.o omap_l3_noc.o
 
 obj-$(CONFIG_OMAP_OCP2SCP)	+= omap-ocp2scp.o
 obj-$(CONFIG_QCOM_EBI2)		+= qcom-ebi2.o
+obj-$(CONFIG_QCOM_SSC_BLOCK_BUS)	+= qcom-ssc-block-bus.o
 obj-$(CONFIG_SUN50I_DE2_BUS)	+= sun50i-de2.o
 obj-$(CONFIG_SUNXI_RSB)		+= sunxi-rsb.o
 obj-$(CONFIG_OF)		+= simple-pm-bus.o
diff --git a/drivers/bus/qcom-ssc-block-bus.c b/drivers/bus/qcom-ssc-block-bus.c
new file mode 100644
index 000000000000..a93c7350a231
--- /dev/null
+++ b/drivers/bus/qcom-ssc-block-bus.c
@@ -0,0 +1,365 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright (c) 2021, Michael Srba
+
+#include <linux/clk.h>
+#include <linux/delay.h>
+#include <linux/io.h>
+#include <linux/mfd/syscon.h>
+#include <linux/module.h>
+#include <linux/of_platform.h>
+#include <linux/platform_device.h>
+#include <linux/pm_clock.h>
+#include <linux/pm_domain.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <linux/reset.h>
+
+/* AXI Halt Register Offsets */
+#define AXI_HALTREQ_REG			0x0
+#define AXI_HALTACK_REG			0x4
+#define AXI_IDLE_REG			0x8
+
+static const char * const qcom_ssc_block_pd_names[] = {
+	"ssc_cx",
+	"ssc_mx"
+};
+
+struct qcom_ssc_block_bus_data {
+	int num_pds;
+	const char **pd_names;
+	struct device *pds[ARRAY_SIZE(qcom_ssc_block_pd_names)];
+	char __iomem *reg_mpm_sscaon_config0; // MPM - msm power manager; AON - always-on
+	char __iomem *reg_mpm_sscaon_config1; // that's as much as we know about these
+	struct regmap *halt_map;
+	u32 ssc_axi_halt;
+	struct clk *xo_clk;
+	struct clk *aggre2_clk;
+	struct clk *gcc_im_sleep_clk;
+	struct clk *aggre2_north_clk;
+	struct clk *ssc_xo_clk;
+	struct clk *ssc_ahbs_clk;
+	struct reset_control *ssc_bcr;
+	struct reset_control *ssc_reset;
+};
+
+static void reg32_set_bits(char __iomem *reg, u32 value)
+{
+	u32 tmp = ioread32(reg);
+
+	iowrite32(tmp | value, reg);
+}
+
+static void reg32_clear_bits(char __iomem *reg, u32 value)
+{
+	u32 tmp = ioread32(reg);
+
+	iowrite32(tmp & (~value), reg);
+}
+
+
+static int qcom_ssc_block_bus_init(struct device *dev)
+{
+	int ret;
+
+	struct qcom_ssc_block_bus_data *data = dev_get_drvdata(dev);
+
+	clk_prepare_enable(data->xo_clk);
+	clk_prepare_enable(data->aggre2_clk);
+
+	clk_prepare_enable(data->gcc_im_sleep_clk);
+
+	reg32_clear_bits(data->reg_mpm_sscaon_config0, BIT(4) | BIT(5));
+	reg32_clear_bits(data->reg_mpm_sscaon_config1, BIT(31));
+
+	clk_disable(data->aggre2_north_clk);
+
+	ret = reset_control_deassert(data->ssc_reset);
+	if (ret) {
+		dev_err(dev, "error deasserting ssc_reset: %d\n", ret);
+		return ret;
+	}
+
+	clk_prepare_enable(data->aggre2_north_clk);
+
+	ret = reset_control_deassert(data->ssc_bcr);
+	if (ret) {
+		dev_err(dev, "error deasserting ssc_bcr: %d\n", ret);
+		return ret;
+	}
+
+	regmap_write(data->halt_map, data->ssc_axi_halt + AXI_HALTREQ_REG, 0);
+
+	clk_prepare_enable(data->ssc_xo_clk);
+
+	clk_prepare_enable(data->ssc_ahbs_clk);
+
+	return 0;
+}
+
+static int qcom_ssc_block_bus_deinit(struct device *dev)
+{
+	int ret;
+
+	struct qcom_ssc_block_bus_data *data = dev_get_drvdata(dev);
+
+	clk_disable(data->ssc_xo_clk);
+	clk_disable(data->ssc_ahbs_clk);
+
+	ret = reset_control_assert(data->ssc_bcr);
+	if (ret) {
+		dev_err(dev, "error asserting ssc_bcr: %d\n", ret);
+		return ret;
+	}
+
+	regmap_write(data->halt_map, data->ssc_axi_halt + AXI_HALTREQ_REG, 1);
+
+	reg32_set_bits(data->reg_mpm_sscaon_config1, BIT(31));
+	reg32_set_bits(data->reg_mpm_sscaon_config0, BIT(4) | BIT(5));
+
+	ret = reset_control_assert(data->ssc_reset);
+	if (ret) {
+		dev_err(dev, "error asserting ssc_reset: %d\n", ret);
+		return ret;
+	}
+
+	clk_disable(data->gcc_im_sleep_clk);
+
+	clk_disable(data->aggre2_north_clk);
+
+	clk_disable(data->aggre2_clk);
+	clk_disable(data->xo_clk);
+
+	return 0;
+}
+
+
+static int qcom_ssc_block_bus_pds_attach(struct device *dev, struct device **pds,
+					 const char **pd_names, size_t num_pds)
+{
+	int ret;
+	int i;
+
+	for (i = 0; i < num_pds; i++) {
+		pds[i] = dev_pm_domain_attach_by_name(dev, pd_names[i]);
+		if (IS_ERR_OR_NULL(pds[i])) {
+			ret = PTR_ERR(pds[i]) ? : -ENODATA;
+			goto unroll_attach;
+		}
+	}
+
+	return num_pds;
+
+unroll_attach:
+	for (i--; i >= 0; i--)
+		dev_pm_domain_detach(pds[i], false);
+
+	return ret;
+};
+
+static void qcom_ssc_block_bus_pds_detach(struct device *dev, struct device **pds, size_t num_pds)
+{
+	int i;
+
+	for (i = 0; i < num_pds; i++)
+		dev_pm_domain_detach(pds[i], false);
+}
+
+static int qcom_ssc_block_bus_pds_enable(struct device **pds, size_t num_pds)
+{
+	int ret;
+	int i;
+
+	for (i = 0; i < num_pds; i++) {
+		dev_pm_genpd_set_performance_state(pds[i], INT_MAX);
+		ret = pm_runtime_get_sync(pds[i]);
+		if (ret < 0)
+			goto unroll_pd_votes;
+	}
+
+	return 0;
+
+unroll_pd_votes:
+	for (i--; i >= 0; i--) {
+		dev_pm_genpd_set_performance_state(pds[i], 0);
+		pm_runtime_put(pds[i]);
+	}
+
+	return ret;
+};
+
+static void qcom_ssc_block_bus_pds_disable(struct device **pds, size_t num_pds)
+{
+	int i;
+
+	for (i = 0; i < num_pds; i++) {
+		dev_pm_genpd_set_performance_state(pds[i], 0);
+		pm_runtime_put(pds[i]);
+	}
+}
+
+static int qcom_ssc_block_bus_probe(struct platform_device *pdev)
+{
+	struct qcom_ssc_block_bus_data *data;
+	struct device_node *np = pdev->dev.of_node;
+	struct of_phandle_args halt_args;
+	struct resource *res;
+	int ret;
+
+	if (np)
+		of_platform_populate(np, NULL, NULL, &pdev->dev);
+
+	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
+	if (!data)
+		return -ENOMEM;
+
+	platform_set_drvdata(pdev, data);
+
+	data->pd_names = qcom_ssc_block_pd_names;
+	data->num_pds = ARRAY_SIZE(qcom_ssc_block_pd_names);
+
+	ret = qcom_ssc_block_bus_pds_attach(&pdev->dev, data->pds, data->pd_names, data->num_pds);
+	if (ret < 0) {
+		dev_err(&pdev->dev, "error when attaching power domains: %d\n", ret);
+		return ret;
+	}
+
+	ret = qcom_ssc_block_bus_pds_enable(data->pds, data->num_pds);
+	if (ret < 0) {
+		dev_err(&pdev->dev, "error when enabling power domains: %d\n", ret);
+		return ret;
+	}
+
+	// the meaning of the bits in these two registers is sadly not documented,
+	// the set/clear operations are just copying what qcom does
+	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpm_sscaon_config0");
+	data->reg_mpm_sscaon_config0 = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(data->reg_mpm_sscaon_config0)) {
+		ret = PTR_ERR(data->reg_mpm_sscaon_config0);
+		dev_err(&pdev->dev, "failed to ioremap mpm_sscaon_config0 (err: %d)\n", ret);
+		return ret;
+	}
+	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpm_sscaon_config0");
+	data->reg_mpm_sscaon_config1 = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(data->reg_mpm_sscaon_config1)) {
+		ret = PTR_ERR(data->reg_mpm_sscaon_config1);
+		dev_err(&pdev->dev, "failed to ioremap mpm_sscaon_config1 (err: %d)\n", ret);
+		return ret;
+	}
+
+	data->ssc_bcr = devm_reset_control_get_exclusive(&pdev->dev, "ssc_bcr");
+	if (IS_ERR(data->ssc_bcr)) {
+		ret = PTR_ERR(data->ssc_bcr);
+		dev_err(&pdev->dev, "failed to acquire reset: scc_bcr (err: %d)\n", ret);
+		return ret;
+	}
+	data->ssc_reset = devm_reset_control_get_exclusive(&pdev->dev, "ssc_reset");
+	if (IS_ERR(data->ssc_reset)) {
+		ret = PTR_ERR(data->ssc_reset);
+		dev_err(&pdev->dev, "failed to acquire reset: ssc_reset: (err: %d)\n", ret);
+		return ret;
+	}
+
+	data->xo_clk = devm_clk_get(&pdev->dev, "xo");
+	if (IS_ERR(data->xo_clk)) {
+		ret = PTR_ERR(data->xo_clk);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "Failed to get clock: xo (err: %d)\n", ret);
+		return ret;
+	}
+
+	data->aggre2_clk = devm_clk_get(&pdev->dev, "aggre2");
+	if (IS_ERR(data->aggre2_clk)) {
+		ret = PTR_ERR(data->aggre2_clk);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "Failed to get clock: aggre2 (err: %d)\n", ret);
+		return ret;
+	}
+
+	data->gcc_im_sleep_clk = devm_clk_get(&pdev->dev, "gcc_im_sleep");
+	if (IS_ERR(data->gcc_im_sleep_clk)) {
+		ret = PTR_ERR(data->gcc_im_sleep_clk);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "Failed to get clock: gcc_im_sleep (err: %d)\n", ret);
+		return ret;
+	}
+
+	data->aggre2_north_clk = devm_clk_get(&pdev->dev, "aggre2_north");
+	if (IS_ERR(data->aggre2_north_clk)) {
+		ret = PTR_ERR(data->aggre2_north_clk);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "Failed to get clock: aggre2_north (err: %d)\n", ret);
+		return ret;
+	}
+
+	data->ssc_xo_clk = devm_clk_get(&pdev->dev, "ssc_xo");
+	if (IS_ERR(data->ssc_xo_clk)) {
+		ret = PTR_ERR(data->ssc_xo_clk);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "Failed to get clock: ssc_xo (err: %d)\n", ret);
+		return ret;
+	}
+
+	data->ssc_ahbs_clk = devm_clk_get(&pdev->dev, "ssc_ahbs");
+	if (IS_ERR(data->ssc_ahbs_clk)) {
+		ret = PTR_ERR(data->ssc_ahbs_clk);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "Failed to get clock: ssc_ahbs (err: %d)\n", ret);
+		return ret;
+	}
+
+	ret = of_parse_phandle_with_fixed_args(pdev->dev.of_node, "qcom,halt-regs", 1, 0,
+					       &halt_args);
+	if (ret < 0) {
+		dev_err(&pdev->dev, "failed to parse qcom,halt-regs\n");
+		return -EINVAL;
+	}
+
+	data->halt_map = syscon_node_to_regmap(halt_args.np);
+	of_node_put(halt_args.np);
+	if (IS_ERR(data->halt_map))
+		return PTR_ERR(data->halt_map);
+
+	data->ssc_axi_halt = halt_args.args[0];
+
+	qcom_ssc_block_bus_init(&pdev->dev);
+
+	return 0;
+}
+
+static int qcom_ssc_block_bus_remove(struct platform_device *pdev)
+{
+	struct qcom_ssc_block_bus_data *data = platform_get_drvdata(pdev);
+
+	qcom_ssc_block_bus_deinit(&pdev->dev);
+
+	iounmap(data->reg_mpm_sscaon_config0);
+	iounmap(data->reg_mpm_sscaon_config1);
+
+	qcom_ssc_block_bus_pds_disable(data->pds, data->num_pds);
+	qcom_ssc_block_bus_pds_detach(&pdev->dev, data->pds, data->num_pds);
+	pm_runtime_disable(&pdev->dev);
+	pm_clk_destroy(&pdev->dev);
+
+	return 0;
+}
+
+static const struct of_device_id qcom_ssc_block_bus_of_match[] = {
+	{ .compatible = "qcom,ssc-block-bus", },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, qcom_ssc_block_bus_of_match);
+
+static struct platform_driver qcom_ssc_block_bus_driver = {
+	.probe = qcom_ssc_block_bus_probe,
+	.remove = qcom_ssc_block_bus_remove,
+	.driver = {
+		.name = "qcom-ssc-block-bus",
+		.of_match_table = qcom_ssc_block_bus_of_match,
+	},
+};
+
+module_platform_driver(qcom_ssc_block_bus_driver);
+
+MODULE_DESCRIPTION("A driver for handling the init sequence needed for accessing the SSC block on (some) qcom SoCs over AHB");
+MODULE_AUTHOR("Michael Srba <Michael.Srba@seznam.cz>");
+MODULE_LICENSE("GPL v2");
-- 
2.34.1

Re: [PATCH 3/4] dt-bindings: bus: add device tree bindings for qcom,ssc-block-bus

[Rob Herring]

On Sat, 22 Jan 2022 19:04:12 +0100, michael.srba@seznam.cz wrote:
> From: Michael Srba <Michael.Srba@seznam.cz>
> 
>  This patch adds bindings for the AHB bus which exposes the SCC block in
>  the global address space. This bus (and the SSC block itself) is present
>  on certain qcom SoCs.
> 
>  In typical configuration, this bus (as some of the clocks and registers
>  that we need to manipulate) is not accessible to the OS, and the
>  resources on this bus are indirectly accessed by communicating with a
>  hexagon CPU core residing in the SSC block. In this configuration, the
>  hypervisor is the one performing the bus initialization for the purposes
>  of bringing the haxagon CPU core out of reset.
> 
>  However, it is possible to change the configuration, in which case this
>  binding serves to allow the OS to initialize the bus.
> 
> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
> ---
>  .../bindings/bus/qcom,ssc-block-bus.yaml      | 156 ++++++++++++++++++
>  1 file changed, 156 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml:30:7: [warning] wrong indentation: expected 8 but found 6 (indentation)
./Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml:30:22: [warning] too few spaces after comma (commas)
./Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml:123:111: [warning] line too long (135 > 110 characters) (line-length)

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml: properties:reg-names: {'minItems': 2, 'maxItems': 2, 'items': [{'const': 'mpm_sscaon_config0'}, {'const': 'mpm_sscaon_config1'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml: properties:reg-names: 'oneOf' conditional failed, one must be fixed:
	[{'const': 'mpm_sscaon_config0'}, {'const': 'mpm_sscaon_config1'}] is too long
	[{'const': 'mpm_sscaon_config0'}, {'const': 'mpm_sscaon_config1'}] is too short
	False schema does not allow 2
	1 was expected
	hint: "minItems" is only needed if less than the "items" list length
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.yaml: ignoring, error in schema: properties: reg-names
Error: Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.example.dts:21.9-13 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/bus/qcom,ssc-block-bus.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1413: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1583024

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

Re: [PATCH 4/4] drivers: bus: add driver for initializing the SSC bus on (some) qcom SoCs

[kernel test robot]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v5.17-rc1 next-20220121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/michael-srba-seznam-cz/dt-bindings-clock-gcc-msm8998-Add-definitions-of-SSC-related-clocks/20220123-021013
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: i386-randconfig-a011-20220124 (https://download.01.org/0day-ci/archive/20220124/202201240259.yrjnY1AO-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 7b3d30728816403d1fd73cc5082e9fb761262bce)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2895c20e9788239e701eb0a1774049aae7963864
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review michael-srba-seznam-cz/dt-bindings-clock-gcc-msm8998-Add-definitions-of-SSC-related-clocks/20220123-021013
        git checkout 2895c20e9788239e701eb0a1774049aae7963864
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/bus/qcom-ssc-block-bus.c:217:17: error: assigning to 'const char **' from 'const char *const[2]' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           data->pd_names = qcom_ssc_block_pd_names;
                          ^ ~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +217 drivers/bus/qcom-ssc-block-bus.c

   199	
   200	static int qcom_ssc_block_bus_probe(struct platform_device *pdev)
   201	{
   202		struct qcom_ssc_block_bus_data *data;
   203		struct device_node *np = pdev->dev.of_node;
   204		struct of_phandle_args halt_args;
   205		struct resource *res;
   206		int ret;
   207	
   208		if (np)
   209			of_platform_populate(np, NULL, NULL, &pdev->dev);
   210	
   211		data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
   212		if (!data)
   213			return -ENOMEM;
   214	
   215		platform_set_drvdata(pdev, data);
   216	
 > 217		data->pd_names = qcom_ssc_block_pd_names;
   218		data->num_pds = ARRAY_SIZE(qcom_ssc_block_pd_names);
   219	
   220		ret = qcom_ssc_block_bus_pds_attach(&pdev->dev, data->pds, data->pd_names, data->num_pds);
   221		if (ret < 0) {
   222			dev_err(&pdev->dev, "error when attaching power domains: %d\n", ret);
   223			return ret;
   224		}
   225	
   226		ret = qcom_ssc_block_bus_pds_enable(data->pds, data->num_pds);
   227		if (ret < 0) {
   228			dev_err(&pdev->dev, "error when enabling power domains: %d\n", ret);
   229			return ret;
   230		}
   231	
   232		// the meaning of the bits in these two registers is sadly not documented,
   233		// the set/clear operations are just copying what qcom does
   234		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpm_sscaon_config0");
   235		data->reg_mpm_sscaon_config0 = devm_ioremap_resource(&pdev->dev, res);
   236		if (IS_ERR(data->reg_mpm_sscaon_config0)) {
   237			ret = PTR_ERR(data->reg_mpm_sscaon_config0);
   238			dev_err(&pdev->dev, "failed to ioremap mpm_sscaon_config0 (err: %d)\n", ret);
   239			return ret;
   240		}
   241		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpm_sscaon_config0");
   242		data->reg_mpm_sscaon_config1 = devm_ioremap_resource(&pdev->dev, res);
   243		if (IS_ERR(data->reg_mpm_sscaon_config1)) {
   244			ret = PTR_ERR(data->reg_mpm_sscaon_config1);
   245			dev_err(&pdev->dev, "failed to ioremap mpm_sscaon_config1 (err: %d)\n", ret);
   246			return ret;
   247		}
   248	
   249		data->ssc_bcr = devm_reset_control_get_exclusive(&pdev->dev, "ssc_bcr");
   250		if (IS_ERR(data->ssc_bcr)) {
   251			ret = PTR_ERR(data->ssc_bcr);
   252			dev_err(&pdev->dev, "failed to acquire reset: scc_bcr (err: %d)\n", ret);
   253			return ret;
   254		}
   255		data->ssc_reset = devm_reset_control_get_exclusive(&pdev->dev, "ssc_reset");
   256		if (IS_ERR(data->ssc_reset)) {
   257			ret = PTR_ERR(data->ssc_reset);
   258			dev_err(&pdev->dev, "failed to acquire reset: ssc_reset: (err: %d)\n", ret);
   259			return ret;
   260		}
   261	
   262		data->xo_clk = devm_clk_get(&pdev->dev, "xo");
   263		if (IS_ERR(data->xo_clk)) {
   264			ret = PTR_ERR(data->xo_clk);
   265			if (ret != -EPROBE_DEFER)
   266				dev_err(&pdev->dev, "Failed to get clock: xo (err: %d)\n", ret);
   267			return ret;
   268		}
   269	
   270		data->aggre2_clk = devm_clk_get(&pdev->dev, "aggre2");
   271		if (IS_ERR(data->aggre2_clk)) {
   272			ret = PTR_ERR(data->aggre2_clk);
   273			if (ret != -EPROBE_DEFER)
   274				dev_err(&pdev->dev, "Failed to get clock: aggre2 (err: %d)\n", ret);
   275			return ret;
   276		}
   277	
   278		data->gcc_im_sleep_clk = devm_clk_get(&pdev->dev, "gcc_im_sleep");
   279		if (IS_ERR(data->gcc_im_sleep_clk)) {
   280			ret = PTR_ERR(data->gcc_im_sleep_clk);
   281			if (ret != -EPROBE_DEFER)
   282				dev_err(&pdev->dev, "Failed to get clock: gcc_im_sleep (err: %d)\n", ret);
   283			return ret;
   284		}
   285	
   286		data->aggre2_north_clk = devm_clk_get(&pdev->dev, "aggre2_north");
   287		if (IS_ERR(data->aggre2_north_clk)) {
   288			ret = PTR_ERR(data->aggre2_north_clk);
   289			if (ret != -EPROBE_DEFER)
   290				dev_err(&pdev->dev, "Failed to get clock: aggre2_north (err: %d)\n", ret);
   291			return ret;
   292		}
   293	
   294		data->ssc_xo_clk = devm_clk_get(&pdev->dev, "ssc_xo");
   295		if (IS_ERR(data->ssc_xo_clk)) {
   296			ret = PTR_ERR(data->ssc_xo_clk);
   297			if (ret != -EPROBE_DEFER)
   298				dev_err(&pdev->dev, "Failed to get clock: ssc_xo (err: %d)\n", ret);
   299			return ret;
   300		}
   301	
   302		data->ssc_ahbs_clk = devm_clk_get(&pdev->dev, "ssc_ahbs");
   303		if (IS_ERR(data->ssc_ahbs_clk)) {
   304			ret = PTR_ERR(data->ssc_ahbs_clk);
   305			if (ret != -EPROBE_DEFER)
   306				dev_err(&pdev->dev, "Failed to get clock: ssc_ahbs (err: %d)\n", ret);
   307			return ret;
   308		}
   309	
   310		ret = of_parse_phandle_with_fixed_args(pdev->dev.of_node, "qcom,halt-regs", 1, 0,
   311						       &halt_args);
   312		if (ret < 0) {
   313			dev_err(&pdev->dev, "failed to parse qcom,halt-regs\n");
   314			return -EINVAL;
   315		}
   316	
   317		data->halt_map = syscon_node_to_regmap(halt_args.np);
   318		of_node_put(halt_args.np);
   319		if (IS_ERR(data->halt_map))
   320			return PTR_ERR(data->halt_map);
   321	
   322		data->ssc_axi_halt = halt_args.args[0];
   323	
   324		qcom_ssc_block_bus_init(&pdev->dev);
   325	
   326		return 0;
   327	}
   328	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Re: [PATCH 4/4] drivers: bus: add driver for initializing the SSC bus on (some) qcom SoCs

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 7389 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v5.17-rc1 next-20220121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/michael-srba-seznam-cz/dt-bindings-clock-gcc-msm8998-Add-definitions-of-SSC-related-clocks/20220123-021013
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: i386-randconfig-a011-20220124 (https://download.01.org/0day-ci/archive/20220124/202201240259.yrjnY1AO-lkp(a)intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 7b3d30728816403d1fd73cc5082e9fb761262bce)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2895c20e9788239e701eb0a1774049aae7963864
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review michael-srba-seznam-cz/dt-bindings-clock-gcc-msm8998-Add-definitions-of-SSC-related-clocks/20220123-021013
        git checkout 2895c20e9788239e701eb0a1774049aae7963864
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/bus/qcom-ssc-block-bus.c:217:17: error: assigning to 'const char **' from 'const char *const[2]' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           data->pd_names = qcom_ssc_block_pd_names;
                          ^ ~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +217 drivers/bus/qcom-ssc-block-bus.c

   199	
   200	static int qcom_ssc_block_bus_probe(struct platform_device *pdev)
   201	{
   202		struct qcom_ssc_block_bus_data *data;
   203		struct device_node *np = pdev->dev.of_node;
   204		struct of_phandle_args halt_args;
   205		struct resource *res;
   206		int ret;
   207	
   208		if (np)
   209			of_platform_populate(np, NULL, NULL, &pdev->dev);
   210	
   211		data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
   212		if (!data)
   213			return -ENOMEM;
   214	
   215		platform_set_drvdata(pdev, data);
   216	
 > 217		data->pd_names = qcom_ssc_block_pd_names;
   218		data->num_pds = ARRAY_SIZE(qcom_ssc_block_pd_names);
   219	
   220		ret = qcom_ssc_block_bus_pds_attach(&pdev->dev, data->pds, data->pd_names, data->num_pds);
   221		if (ret < 0) {
   222			dev_err(&pdev->dev, "error when attaching power domains: %d\n", ret);
   223			return ret;
   224		}
   225	
   226		ret = qcom_ssc_block_bus_pds_enable(data->pds, data->num_pds);
   227		if (ret < 0) {
   228			dev_err(&pdev->dev, "error when enabling power domains: %d\n", ret);
   229			return ret;
   230		}
   231	
   232		// the meaning of the bits in these two registers is sadly not documented,
   233		// the set/clear operations are just copying what qcom does
   234		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpm_sscaon_config0");
   235		data->reg_mpm_sscaon_config0 = devm_ioremap_resource(&pdev->dev, res);
   236		if (IS_ERR(data->reg_mpm_sscaon_config0)) {
   237			ret = PTR_ERR(data->reg_mpm_sscaon_config0);
   238			dev_err(&pdev->dev, "failed to ioremap mpm_sscaon_config0 (err: %d)\n", ret);
   239			return ret;
   240		}
   241		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpm_sscaon_config0");
   242		data->reg_mpm_sscaon_config1 = devm_ioremap_resource(&pdev->dev, res);
   243		if (IS_ERR(data->reg_mpm_sscaon_config1)) {
   244			ret = PTR_ERR(data->reg_mpm_sscaon_config1);
   245			dev_err(&pdev->dev, "failed to ioremap mpm_sscaon_config1 (err: %d)\n", ret);
   246			return ret;
   247		}
   248	
   249		data->ssc_bcr = devm_reset_control_get_exclusive(&pdev->dev, "ssc_bcr");
   250		if (IS_ERR(data->ssc_bcr)) {
   251			ret = PTR_ERR(data->ssc_bcr);
   252			dev_err(&pdev->dev, "failed to acquire reset: scc_bcr (err: %d)\n", ret);
   253			return ret;
   254		}
   255		data->ssc_reset = devm_reset_control_get_exclusive(&pdev->dev, "ssc_reset");
   256		if (IS_ERR(data->ssc_reset)) {
   257			ret = PTR_ERR(data->ssc_reset);
   258			dev_err(&pdev->dev, "failed to acquire reset: ssc_reset: (err: %d)\n", ret);
   259			return ret;
   260		}
   261	
   262		data->xo_clk = devm_clk_get(&pdev->dev, "xo");
   263		if (IS_ERR(data->xo_clk)) {
   264			ret = PTR_ERR(data->xo_clk);
   265			if (ret != -EPROBE_DEFER)
   266				dev_err(&pdev->dev, "Failed to get clock: xo (err: %d)\n", ret);
   267			return ret;
   268		}
   269	
   270		data->aggre2_clk = devm_clk_get(&pdev->dev, "aggre2");
   271		if (IS_ERR(data->aggre2_clk)) {
   272			ret = PTR_ERR(data->aggre2_clk);
   273			if (ret != -EPROBE_DEFER)
   274				dev_err(&pdev->dev, "Failed to get clock: aggre2 (err: %d)\n", ret);
   275			return ret;
   276		}
   277	
   278		data->gcc_im_sleep_clk = devm_clk_get(&pdev->dev, "gcc_im_sleep");
   279		if (IS_ERR(data->gcc_im_sleep_clk)) {
   280			ret = PTR_ERR(data->gcc_im_sleep_clk);
   281			if (ret != -EPROBE_DEFER)
   282				dev_err(&pdev->dev, "Failed to get clock: gcc_im_sleep (err: %d)\n", ret);
   283			return ret;
   284		}
   285	
   286		data->aggre2_north_clk = devm_clk_get(&pdev->dev, "aggre2_north");
   287		if (IS_ERR(data->aggre2_north_clk)) {
   288			ret = PTR_ERR(data->aggre2_north_clk);
   289			if (ret != -EPROBE_DEFER)
   290				dev_err(&pdev->dev, "Failed to get clock: aggre2_north (err: %d)\n", ret);
   291			return ret;
   292		}
   293	
   294		data->ssc_xo_clk = devm_clk_get(&pdev->dev, "ssc_xo");
   295		if (IS_ERR(data->ssc_xo_clk)) {
   296			ret = PTR_ERR(data->ssc_xo_clk);
   297			if (ret != -EPROBE_DEFER)
   298				dev_err(&pdev->dev, "Failed to get clock: ssc_xo (err: %d)\n", ret);
   299			return ret;
   300		}
   301	
   302		data->ssc_ahbs_clk = devm_clk_get(&pdev->dev, "ssc_ahbs");
   303		if (IS_ERR(data->ssc_ahbs_clk)) {
   304			ret = PTR_ERR(data->ssc_ahbs_clk);
   305			if (ret != -EPROBE_DEFER)
   306				dev_err(&pdev->dev, "Failed to get clock: ssc_ahbs (err: %d)\n", ret);
   307			return ret;
   308		}
   309	
   310		ret = of_parse_phandle_with_fixed_args(pdev->dev.of_node, "qcom,halt-regs", 1, 0,
   311						       &halt_args);
   312		if (ret < 0) {
   313			dev_err(&pdev->dev, "failed to parse qcom,halt-regs\n");
   314			return -EINVAL;
   315		}
   316	
   317		data->halt_map = syscon_node_to_regmap(halt_args.np);
   318		of_node_put(halt_args.np);
   319		if (IS_ERR(data->halt_map))
   320			return PTR_ERR(data->halt_map);
   321	
   322		data->ssc_axi_halt = halt_args.args[0];
   323	
   324		qcom_ssc_block_bus_init(&pdev->dev);
   325	
   326		return 0;
   327	}
   328	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

Re: [PATCH 4/4] drivers: bus: add driver for initializing the SSC bus on (some) qcom SoCs

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 7463 bytes --]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v5.17-rc1 next-20220124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/michael-srba-seznam-cz/dt-bindings-clock-gcc-msm8998-Add-definitions-of-SSC-related-clocks/20220123-021013
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: powerpc-randconfig-s032-20220124 (https://download.01.org/0day-ci/archive/20220124/202201241736.avyQBE1i-lkp(a)intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/2895c20e9788239e701eb0a1774049aae7963864
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review michael-srba-seznam-cz/dt-bindings-clock-gcc-msm8998-Add-definitions-of-SSC-related-clocks/20220123-021013
        git checkout 2895c20e9788239e701eb0a1774049aae7963864
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/bus/qcom-ssc-block-bus.c:217:24: sparse: sparse: incorrect type in assignment (different modifiers) @@     expected char const **pd_names @@     got char const *const * @@
   drivers/bus/qcom-ssc-block-bus.c:217:24: sparse:     expected char const **pd_names
   drivers/bus/qcom-ssc-block-bus.c:217:24: sparse:     got char const *const *

vim +217 drivers/bus/qcom-ssc-block-bus.c

   199	
   200	static int qcom_ssc_block_bus_probe(struct platform_device *pdev)
   201	{
   202		struct qcom_ssc_block_bus_data *data;
   203		struct device_node *np = pdev->dev.of_node;
   204		struct of_phandle_args halt_args;
   205		struct resource *res;
   206		int ret;
   207	
   208		if (np)
   209			of_platform_populate(np, NULL, NULL, &pdev->dev);
   210	
   211		data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
   212		if (!data)
   213			return -ENOMEM;
   214	
   215		platform_set_drvdata(pdev, data);
   216	
 > 217		data->pd_names = qcom_ssc_block_pd_names;
   218		data->num_pds = ARRAY_SIZE(qcom_ssc_block_pd_names);
   219	
   220		ret = qcom_ssc_block_bus_pds_attach(&pdev->dev, data->pds, data->pd_names, data->num_pds);
   221		if (ret < 0) {
   222			dev_err(&pdev->dev, "error when attaching power domains: %d\n", ret);
   223			return ret;
   224		}
   225	
   226		ret = qcom_ssc_block_bus_pds_enable(data->pds, data->num_pds);
   227		if (ret < 0) {
   228			dev_err(&pdev->dev, "error when enabling power domains: %d\n", ret);
   229			return ret;
   230		}
   231	
   232		// the meaning of the bits in these two registers is sadly not documented,
   233		// the set/clear operations are just copying what qcom does
   234		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpm_sscaon_config0");
   235		data->reg_mpm_sscaon_config0 = devm_ioremap_resource(&pdev->dev, res);
   236		if (IS_ERR(data->reg_mpm_sscaon_config0)) {
   237			ret = PTR_ERR(data->reg_mpm_sscaon_config0);
   238			dev_err(&pdev->dev, "failed to ioremap mpm_sscaon_config0 (err: %d)\n", ret);
   239			return ret;
   240		}
   241		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpm_sscaon_config0");
   242		data->reg_mpm_sscaon_config1 = devm_ioremap_resource(&pdev->dev, res);
   243		if (IS_ERR(data->reg_mpm_sscaon_config1)) {
   244			ret = PTR_ERR(data->reg_mpm_sscaon_config1);
   245			dev_err(&pdev->dev, "failed to ioremap mpm_sscaon_config1 (err: %d)\n", ret);
   246			return ret;
   247		}
   248	
   249		data->ssc_bcr = devm_reset_control_get_exclusive(&pdev->dev, "ssc_bcr");
   250		if (IS_ERR(data->ssc_bcr)) {
   251			ret = PTR_ERR(data->ssc_bcr);
   252			dev_err(&pdev->dev, "failed to acquire reset: scc_bcr (err: %d)\n", ret);
   253			return ret;
   254		}
   255		data->ssc_reset = devm_reset_control_get_exclusive(&pdev->dev, "ssc_reset");
   256		if (IS_ERR(data->ssc_reset)) {
   257			ret = PTR_ERR(data->ssc_reset);
   258			dev_err(&pdev->dev, "failed to acquire reset: ssc_reset: (err: %d)\n", ret);
   259			return ret;
   260		}
   261	
   262		data->xo_clk = devm_clk_get(&pdev->dev, "xo");
   263		if (IS_ERR(data->xo_clk)) {
   264			ret = PTR_ERR(data->xo_clk);
   265			if (ret != -EPROBE_DEFER)
   266				dev_err(&pdev->dev, "Failed to get clock: xo (err: %d)\n", ret);
   267			return ret;
   268		}
   269	
   270		data->aggre2_clk = devm_clk_get(&pdev->dev, "aggre2");
   271		if (IS_ERR(data->aggre2_clk)) {
   272			ret = PTR_ERR(data->aggre2_clk);
   273			if (ret != -EPROBE_DEFER)
   274				dev_err(&pdev->dev, "Failed to get clock: aggre2 (err: %d)\n", ret);
   275			return ret;
   276		}
   277	
   278		data->gcc_im_sleep_clk = devm_clk_get(&pdev->dev, "gcc_im_sleep");
   279		if (IS_ERR(data->gcc_im_sleep_clk)) {
   280			ret = PTR_ERR(data->gcc_im_sleep_clk);
   281			if (ret != -EPROBE_DEFER)
   282				dev_err(&pdev->dev, "Failed to get clock: gcc_im_sleep (err: %d)\n", ret);
   283			return ret;
   284		}
   285	
   286		data->aggre2_north_clk = devm_clk_get(&pdev->dev, "aggre2_north");
   287		if (IS_ERR(data->aggre2_north_clk)) {
   288			ret = PTR_ERR(data->aggre2_north_clk);
   289			if (ret != -EPROBE_DEFER)
   290				dev_err(&pdev->dev, "Failed to get clock: aggre2_north (err: %d)\n", ret);
   291			return ret;
   292		}
   293	
   294		data->ssc_xo_clk = devm_clk_get(&pdev->dev, "ssc_xo");
   295		if (IS_ERR(data->ssc_xo_clk)) {
   296			ret = PTR_ERR(data->ssc_xo_clk);
   297			if (ret != -EPROBE_DEFER)
   298				dev_err(&pdev->dev, "Failed to get clock: ssc_xo (err: %d)\n", ret);
   299			return ret;
   300		}
   301	
   302		data->ssc_ahbs_clk = devm_clk_get(&pdev->dev, "ssc_ahbs");
   303		if (IS_ERR(data->ssc_ahbs_clk)) {
   304			ret = PTR_ERR(data->ssc_ahbs_clk);
   305			if (ret != -EPROBE_DEFER)
   306				dev_err(&pdev->dev, "Failed to get clock: ssc_ahbs (err: %d)\n", ret);
   307			return ret;
   308		}
   309	
   310		ret = of_parse_phandle_with_fixed_args(pdev->dev.of_node, "qcom,halt-regs", 1, 0,
   311						       &halt_args);
   312		if (ret < 0) {
   313			dev_err(&pdev->dev, "failed to parse qcom,halt-regs\n");
   314			return -EINVAL;
   315		}
   316	
   317		data->halt_map = syscon_node_to_regmap(halt_args.np);
   318		of_node_put(halt_args.np);
   319		if (IS_ERR(data->halt_map))
   320			return PTR_ERR(data->halt_map);
   321	
   322		data->ssc_axi_halt = halt_args.args[0];
   323	
   324		qcom_ssc_block_bus_init(&pdev->dev);
   325	
   326		return 0;
   327	}
   328	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org