From: Daniel Wagner <wagi@monom.org>
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<Emmanuel.VAUTRIN@cpexterne.org>
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: Re: [PATCH] iwd: Always disconnect connection completely
Date: Sun, 23 Jan 2022 14:18:08 +0100 [thread overview]
Message-ID: <20220123131808.x7vvxmkhbu3jieiz@beryllium.lan> (raw)
In-Reply-To: <MRZP264MB154465E0619D397C2859ABA6935B9@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM>
You forgot a static. BTW, please check your formatting:
$ git am ~/0001-iwd-Always-disconnect-connection-completely.patch
Applying: iwd: Always disconnect connection completely
*** .git/hooks/pre-applypatch: Testing for mode changes...
*** .git/hooks/pre-applypatch: Testing that this is buildable...
GEN src/builtin.h
make --no-print-directory all-am
CC plugins/src_connmand-iwd.o
CC src/connmand-plugin.o
plugins/iwd.c:254:6: error: no previous declaration for ‘abort_pending_network’ [-Werror=missing-declarations]
254 | void abort_pending_network(struct iwd_device *iwdd,
| ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:3405: plugins/src_connmand-iwd.o] Error 1
make: *** [Makefile:1871: all] Error 2
*** .git/hooks/pre-applypatch: Didn't pass buildable test
--- a/plugins/iwd.c
+++ b/plugins/iwd.c
@@ -251,8 +251,9 @@ static void cm_network_connect_cb(DBusMessage *message, void *user_data)
update_network_connected(iwdn);
}
-void abort_pending_network(struct iwd_device *iwdd,
- enum connman_network_error error) {
+static void abort_pending_network(struct iwd_device *iwdd,
+ enum connman_network_error error)
+{
struct iwd_network *iwdn;
if (!iwdd->pending_network)
╭─wagi@beryllium ~/cm/connman-upstream ‹master*›
╰─$ make
GEN src/builtin.h
make --no-print-directory all-am
CC plugins/src_connmand-iwd.o
CC src/connmand-plugin.o
CCLD src/connmand
next prev parent reply other threads:[~2022-01-23 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220119133927.1245607-1-Emmanuel.VAUTRIN@cpexterne.org>
2022-01-19 13:43 ` [PATCH] iwd: Always disconnect connection completely VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-21 7:47 ` Daniel Wagner
2022-01-21 10:50 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-23 13:18 ` Daniel Wagner [this message]
2022-01-23 17:40 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-24 8:21 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220123131808.x7vvxmkhbu3jieiz@beryllium.lan \
--to=wagi@monom.org \
--cc=Emmanuel.VAUTRIN@cpexterne.org \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.