All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
	<Emmanuel.VAUTRIN@cpexterne.org>
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: Re: [PATCH] iwd: Always disconnect connection completely
Date: Mon, 24 Jan 2022 09:21:42 +0100	[thread overview]
Message-ID: <20220124082142.slbsbfuhnisll4bn@carbon.lan> (raw)
In-Reply-To: <MRZP264MB1544816EE2A3ECBCC2347C80935D9@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM>

On Sun, Jan 23, 2022 at 05:40:45PM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> For your information, it seems that some other code does
> not compile with this option (xt_match_parse, xt_target_parse in 
> unit/test-iptables.c & reset_xtables with no void argument in src/iptables.c).

I don't have any fallouts in there. This could be just because I use a
different compiler with different settings. Please report those
failures. It's not good to paper over them in the long run.

> > BTW, please check your formatting
> What do you mean by that? Do you have some link with associated
> guidelines to follow?

There was the curly bracket on the same line as the function name. It
should be covered in doc/conding-style.txt

Daniel

      reply	other threads:[~2022-01-24  8:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220119133927.1245607-1-Emmanuel.VAUTRIN@cpexterne.org>
2022-01-19 13:43 ` [PATCH] iwd: Always disconnect connection completely VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-21  7:47   ` Daniel Wagner
2022-01-21 10:50     ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-23 13:18       ` Daniel Wagner
2022-01-23 17:40         ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2022-01-24  8:21           ` Daniel Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220124082142.slbsbfuhnisll4bn@carbon.lan \
    --to=wagi@monom.org \
    --cc=Emmanuel.VAUTRIN@cpexterne.org \
    --cc=connman@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.