* [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
@ 2022-01-24 16:24 ` carsten.haitzler
0 siblings, 0 replies; 17+ messages in thread
From: carsten.haitzler @ 2022-01-24 16:24 UTC (permalink / raw)
To: dri-devel
Cc: liviu.dudau, brian.starkey, airlied, daniel, steven.price, linux-kernel
From: Carsten Haitzler <carsten.haitzler@arm.com>
Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
---
drivers/gpu/drm/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 58a242871b28..6e3f1d600541 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -6,6 +6,7 @@ config DRM_HDLCD
depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
depends on COMMON_CLK
select DRM_KMS_HELPER
+ select DRM_GEM_CMA_HELPER
help
Choose this option if you have an ARM High Definition Colour LCD
controller.
--
2.30.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
@ 2022-01-24 16:24 ` carsten.haitzler
0 siblings, 0 replies; 17+ messages in thread
From: carsten.haitzler @ 2022-01-24 16:24 UTC (permalink / raw)
To: dri-devel; +Cc: airlied, liviu.dudau, linux-kernel, steven.price
From: Carsten Haitzler <carsten.haitzler@arm.com>
Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
---
drivers/gpu/drm/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 58a242871b28..6e3f1d600541 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -6,6 +6,7 @@ config DRM_HDLCD
depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
depends on COMMON_CLK
select DRM_KMS_HELPER
+ select DRM_GEM_CMA_HELPER
help
Choose this option if you have an ARM High Definition Colour LCD
controller.
--
2.30.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
2022-01-24 16:24 ` carsten.haitzler
@ 2022-01-25 12:37 ` Liviu Dudau
-1 siblings, 0 replies; 17+ messages in thread
From: Liviu Dudau @ 2022-01-25 12:37 UTC (permalink / raw)
To: carsten.haitzler; +Cc: airlied, linux-kernel, dri-devel, steven.price
On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
> From: Carsten Haitzler <carsten.haitzler@arm.com>
>
> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
>
> Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
>
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
I will add Steven's reviewed-by as well when pushing it.
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> index 58a242871b28..6e3f1d600541 100644
> --- a/drivers/gpu/drm/arm/Kconfig
> +++ b/drivers/gpu/drm/arm/Kconfig
> @@ -6,6 +6,7 @@ config DRM_HDLCD
> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> depends on COMMON_CLK
> select DRM_KMS_HELPER
> + select DRM_GEM_CMA_HELPER
> help
> Choose this option if you have an ARM High Definition Colour LCD
> controller.
> --
> 2.30.1
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
@ 2022-01-25 12:37 ` Liviu Dudau
0 siblings, 0 replies; 17+ messages in thread
From: Liviu Dudau @ 2022-01-25 12:37 UTC (permalink / raw)
To: carsten.haitzler
Cc: dri-devel, brian.starkey, airlied, daniel, steven.price, linux-kernel
On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
> From: Carsten Haitzler <carsten.haitzler@arm.com>
>
> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
>
> Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
>
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
I will add Steven's reviewed-by as well when pushing it.
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> index 58a242871b28..6e3f1d600541 100644
> --- a/drivers/gpu/drm/arm/Kconfig
> +++ b/drivers/gpu/drm/arm/Kconfig
> @@ -6,6 +6,7 @@ config DRM_HDLCD
> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> depends on COMMON_CLK
> select DRM_KMS_HELPER
> + select DRM_GEM_CMA_HELPER
> help
> Choose this option if you have an ARM High Definition Colour LCD
> controller.
> --
> 2.30.1
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
2022-01-25 12:37 ` Liviu Dudau
(?)
@ 2022-02-23 10:18 ` Andre Przywara
-1 siblings, 0 replies; 17+ messages in thread
From: Andre Przywara @ 2022-02-23 10:18 UTC (permalink / raw)
To: Liviu Dudau, carsten.haitzler
Cc: dri-devel, brian.starkey, airlied, daniel, steven.price,
linux-kernel, Arnd Bergmann, linux-arm-kernel
On Tue, 25 Jan 2022 12:37:38 +0000
Liviu Dudau <liviu.dudau@arm.com> wrote:
Hi,
> On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
> > From: Carsten Haitzler <carsten.haitzler@arm.com>
> >
> > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
> >
> > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> >
> > Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
>
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
>
> I will add Steven's reviewed-by as well when pushing it.
Did this go anywhere? I see my .config just selecting HDLCD still failing
with -rc5. Any chance this can be taken now, as this is a regression
introduced with -rc1?
Cheers,
Andre
> > ---
> > drivers/gpu/drm/arm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> > index 58a242871b28..6e3f1d600541 100644
> > --- a/drivers/gpu/drm/arm/Kconfig
> > +++ b/drivers/gpu/drm/arm/Kconfig
> > @@ -6,6 +6,7 @@ config DRM_HDLCD
> > depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> > depends on COMMON_CLK
> > select DRM_KMS_HELPER
> > + select DRM_GEM_CMA_HELPER
> > help
> > Choose this option if you have an ARM High Definition Colour LCD
> > controller.
> > --
> > 2.30.1
> >
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
@ 2022-02-23 10:18 ` Andre Przywara
0 siblings, 0 replies; 17+ messages in thread
From: Andre Przywara @ 2022-02-23 10:18 UTC (permalink / raw)
To: Liviu Dudau, carsten.haitzler
Cc: Arnd Bergmann, airlied, linux-kernel, dri-devel, steven.price,
linux-arm-kernel
On Tue, 25 Jan 2022 12:37:38 +0000
Liviu Dudau <liviu.dudau@arm.com> wrote:
Hi,
> On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
> > From: Carsten Haitzler <carsten.haitzler@arm.com>
> >
> > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
> >
> > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> >
> > Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
>
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
>
> I will add Steven's reviewed-by as well when pushing it.
Did this go anywhere? I see my .config just selecting HDLCD still failing
with -rc5. Any chance this can be taken now, as this is a regression
introduced with -rc1?
Cheers,
Andre
> > ---
> > drivers/gpu/drm/arm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> > index 58a242871b28..6e3f1d600541 100644
> > --- a/drivers/gpu/drm/arm/Kconfig
> > +++ b/drivers/gpu/drm/arm/Kconfig
> > @@ -6,6 +6,7 @@ config DRM_HDLCD
> > depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> > depends on COMMON_CLK
> > select DRM_KMS_HELPER
> > + select DRM_GEM_CMA_HELPER
> > help
> > Choose this option if you have an ARM High Definition Colour LCD
> > controller.
> > --
> > 2.30.1
> >
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
@ 2022-02-23 10:18 ` Andre Przywara
0 siblings, 0 replies; 17+ messages in thread
From: Andre Przywara @ 2022-02-23 10:18 UTC (permalink / raw)
To: Liviu Dudau, carsten.haitzler
Cc: dri-devel, brian.starkey, airlied, daniel, steven.price,
linux-kernel, Arnd Bergmann, linux-arm-kernel
On Tue, 25 Jan 2022 12:37:38 +0000
Liviu Dudau <liviu.dudau@arm.com> wrote:
Hi,
> On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
> > From: Carsten Haitzler <carsten.haitzler@arm.com>
> >
> > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
> >
> > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> >
> > Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
>
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
>
> I will add Steven's reviewed-by as well when pushing it.
Did this go anywhere? I see my .config just selecting HDLCD still failing
with -rc5. Any chance this can be taken now, as this is a regression
introduced with -rc1?
Cheers,
Andre
> > ---
> > drivers/gpu/drm/arm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> > index 58a242871b28..6e3f1d600541 100644
> > --- a/drivers/gpu/drm/arm/Kconfig
> > +++ b/drivers/gpu/drm/arm/Kconfig
> > @@ -6,6 +6,7 @@ config DRM_HDLCD
> > depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> > depends on COMMON_CLK
> > select DRM_KMS_HELPER
> > + select DRM_GEM_CMA_HELPER
> > help
> > Choose this option if you have an ARM High Definition Colour LCD
> > controller.
> > --
> > 2.30.1
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
2022-02-23 10:18 ` Andre Przywara
(?)
@ 2022-02-28 19:36 ` Rob Herring
-1 siblings, 0 replies; 17+ messages in thread
From: Rob Herring @ 2022-02-28 19:36 UTC (permalink / raw)
To: Andre Przywara
Cc: Arnd Bergmann, David Airlie, Liviu Dudau, linux-kernel,
dri-devel, Steven Price, carsten.haitzler, linux-arm-kernel
On Wed, Feb 23, 2022 at 4:19 AM Andre Przywara <andre.przywara@arm.com> wrote:
>
> On Tue, 25 Jan 2022 12:37:38 +0000
> Liviu Dudau <liviu.dudau@arm.com> wrote:
>
> Hi,
>
> > On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
> > > From: Carsten Haitzler <carsten.haitzler@arm.com>
> > >
> > > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
> > >
> > > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> > >
> > > Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
> >
> > Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> >
> > I will add Steven's reviewed-by as well when pushing it.
>
> Did this go anywhere? I see my .config just selecting HDLCD still failing
> with -rc5. Any chance this can be taken now, as this is a regression
> introduced with -rc1?
I thought Liviu was going to, but in any case I've now pushed it to
drm-misc-fixes.
Rob
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
@ 2022-02-28 19:36 ` Rob Herring
0 siblings, 0 replies; 17+ messages in thread
From: Rob Herring @ 2022-02-28 19:36 UTC (permalink / raw)
To: Andre Przywara
Cc: Liviu Dudau, carsten.haitzler, Arnd Bergmann, David Airlie,
linux-kernel, dri-devel, Steven Price, linux-arm-kernel
On Wed, Feb 23, 2022 at 4:19 AM Andre Przywara <andre.przywara@arm.com> wrote:
>
> On Tue, 25 Jan 2022 12:37:38 +0000
> Liviu Dudau <liviu.dudau@arm.com> wrote:
>
> Hi,
>
> > On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
> > > From: Carsten Haitzler <carsten.haitzler@arm.com>
> > >
> > > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
> > >
> > > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> > >
> > > Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
> >
> > Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> >
> > I will add Steven's reviewed-by as well when pushing it.
>
> Did this go anywhere? I see my .config just selecting HDLCD still failing
> with -rc5. Any chance this can be taken now, as this is a regression
> introduced with -rc1?
I thought Liviu was going to, but in any case I've now pushed it to
drm-misc-fixes.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
@ 2022-02-28 19:36 ` Rob Herring
0 siblings, 0 replies; 17+ messages in thread
From: Rob Herring @ 2022-02-28 19:36 UTC (permalink / raw)
To: Andre Przywara
Cc: Liviu Dudau, carsten.haitzler, Arnd Bergmann, David Airlie,
linux-kernel, dri-devel, Steven Price, linux-arm-kernel
On Wed, Feb 23, 2022 at 4:19 AM Andre Przywara <andre.przywara@arm.com> wrote:
>
> On Tue, 25 Jan 2022 12:37:38 +0000
> Liviu Dudau <liviu.dudau@arm.com> wrote:
>
> Hi,
>
> > On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
> > > From: Carsten Haitzler <carsten.haitzler@arm.com>
> > >
> > > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
> > >
> > > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> > >
> > > Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
> >
> > Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> >
> > I will add Steven's reviewed-by as well when pushing it.
>
> Did this go anywhere? I see my .config just selecting HDLCD still failing
> with -rc5. Any chance this can be taken now, as this is a regression
> introduced with -rc1?
I thought Liviu was going to, but in any case I've now pushed it to
drm-misc-fixes.
Rob
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
2022-01-24 16:13 ` Steven Price
@ 2022-01-24 16:25 ` Carsten Haitzler
-1 siblings, 0 replies; 17+ messages in thread
From: Carsten Haitzler @ 2022-01-24 16:25 UTC (permalink / raw)
To: Steven Price, dri-devel
Cc: liviu.dudau, brian.starkey, airlied, daniel, linux-kernel
I sent an updated patch with the Fixes:
On 1/24/22 16:13, Steven Price wrote:
> On 24/01/2022 15:13, carsten.haitzler@foss.arm.com wrote:
>> From: Carsten Haitzler <carsten.haitzler@arm.com>
>>
>> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
>>
>> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
>
> To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that
> was removed in commit 09717af7d13d ("drm: Remove
> CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select
> DRM_GEM_CMA_HELPER but that transitive dependency was lost and
> apparently the fixup was missed in that commit.
>
> So we need a:
>
> Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
>
> and with that...
>
> Reviewed-by: Steven Price <steven.price@arm.com>
>
> Steve
>
>> ---
>> drivers/gpu/drm/arm/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
>> index 58a242871b28..6e3f1d600541 100644
>> --- a/drivers/gpu/drm/arm/Kconfig
>> +++ b/drivers/gpu/drm/arm/Kconfig
>> @@ -6,6 +6,7 @@ config DRM_HDLCD
>> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
>> depends on COMMON_CLK
>> select DRM_KMS_HELPER
>> + select DRM_GEM_CMA_HELPER
>> help
>> Choose this option if you have an ARM High Definition Colour LCD
>> controller.
>>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
@ 2022-01-24 16:25 ` Carsten Haitzler
0 siblings, 0 replies; 17+ messages in thread
From: Carsten Haitzler @ 2022-01-24 16:25 UTC (permalink / raw)
To: Steven Price, dri-devel; +Cc: airlied, liviu.dudau, linux-kernel
I sent an updated patch with the Fixes:
On 1/24/22 16:13, Steven Price wrote:
> On 24/01/2022 15:13, carsten.haitzler@foss.arm.com wrote:
>> From: Carsten Haitzler <carsten.haitzler@arm.com>
>>
>> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
>>
>> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
>
> To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that
> was removed in commit 09717af7d13d ("drm: Remove
> CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select
> DRM_GEM_CMA_HELPER but that transitive dependency was lost and
> apparently the fixup was missed in that commit.
>
> So we need a:
>
> Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
>
> and with that...
>
> Reviewed-by: Steven Price <steven.price@arm.com>
>
> Steve
>
>> ---
>> drivers/gpu/drm/arm/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
>> index 58a242871b28..6e3f1d600541 100644
>> --- a/drivers/gpu/drm/arm/Kconfig
>> +++ b/drivers/gpu/drm/arm/Kconfig
>> @@ -6,6 +6,7 @@ config DRM_HDLCD
>> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
>> depends on COMMON_CLK
>> select DRM_KMS_HELPER
>> + select DRM_GEM_CMA_HELPER
>> help
>> Choose this option if you have an ARM High Definition Colour LCD
>> controller.
>>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
2022-01-24 15:13 ` carsten.haitzler
@ 2022-01-24 16:13 ` Steven Price
-1 siblings, 0 replies; 17+ messages in thread
From: Steven Price @ 2022-01-24 16:13 UTC (permalink / raw)
To: carsten.haitzler, dri-devel
Cc: liviu.dudau, brian.starkey, airlied, daniel, linux-kernel
On 24/01/2022 15:13, carsten.haitzler@foss.arm.com wrote:
> From: Carsten Haitzler <carsten.haitzler@arm.com>
>
> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
>
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that
was removed in commit 09717af7d13d ("drm: Remove
CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select
DRM_GEM_CMA_HELPER but that transitive dependency was lost and
apparently the fixup was missed in that commit.
So we need a:
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
and with that...
Reviewed-by: Steven Price <steven.price@arm.com>
Steve
> ---
> drivers/gpu/drm/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> index 58a242871b28..6e3f1d600541 100644
> --- a/drivers/gpu/drm/arm/Kconfig
> +++ b/drivers/gpu/drm/arm/Kconfig
> @@ -6,6 +6,7 @@ config DRM_HDLCD
> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> depends on COMMON_CLK
> select DRM_KMS_HELPER
> + select DRM_GEM_CMA_HELPER
> help
> Choose this option if you have an ARM High Definition Colour LCD
> controller.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
@ 2022-01-24 16:13 ` Steven Price
0 siblings, 0 replies; 17+ messages in thread
From: Steven Price @ 2022-01-24 16:13 UTC (permalink / raw)
To: carsten.haitzler, dri-devel; +Cc: airlied, liviu.dudau, linux-kernel
On 24/01/2022 15:13, carsten.haitzler@foss.arm.com wrote:
> From: Carsten Haitzler <carsten.haitzler@arm.com>
>
> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
>
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that
was removed in commit 09717af7d13d ("drm: Remove
CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select
DRM_GEM_CMA_HELPER but that transitive dependency was lost and
apparently the fixup was missed in that commit.
So we need a:
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
and with that...
Reviewed-by: Steven Price <steven.price@arm.com>
Steve
> ---
> drivers/gpu/drm/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> index 58a242871b28..6e3f1d600541 100644
> --- a/drivers/gpu/drm/arm/Kconfig
> +++ b/drivers/gpu/drm/arm/Kconfig
> @@ -6,6 +6,7 @@ config DRM_HDLCD
> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> depends on COMMON_CLK
> select DRM_KMS_HELPER
> + select DRM_GEM_CMA_HELPER
> help
> Choose this option if you have an ARM High Definition Colour LCD
> controller.
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
2022-01-24 15:13 ` carsten.haitzler
(?)
@ 2022-01-24 15:17 ` Carsten Haitzler
-1 siblings, 0 replies; 17+ messages in thread
From: Carsten Haitzler @ 2022-01-24 15:17 UTC (permalink / raw)
To: dri-devel
Sorry - noise. Ignore this one. Following one is fixed.
On 1/24/22 15:13, carsten.haitzler@foss.arm.com wrote:
> From: Carsten Haitzler <carsten.haitzler@arm.com>
>
> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
>
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
> ---
> drivers/gpu/drm/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> index 58a242871b28..6e3f1d600541 100644
> --- a/drivers/gpu/drm/arm/Kconfig
> +++ b/drivers/gpu/drm/arm/Kconfig
> @@ -6,6 +6,7 @@ config DRM_HDLCD
> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
> depends on COMMON_CLK
> select DRM_KMS_HELPER
> + select DRM_GEM_CMA_HELPER
> help
> Choose this option if you have an ARM High Definition Colour LCD
> controller.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
@ 2022-01-24 15:13 ` carsten.haitzler
0 siblings, 0 replies; 17+ messages in thread
From: carsten.haitzler @ 2022-01-24 15:13 UTC (permalink / raw)
To: dri-devel
Cc: liviu.dudau, brian.starkey, airlied, daniel, steven.price, linux-kernel
From: Carsten Haitzler <carsten.haitzler@arm.com>
Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
---
drivers/gpu/drm/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 58a242871b28..6e3f1d600541 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -6,6 +6,7 @@ config DRM_HDLCD
depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
depends on COMMON_CLK
select DRM_KMS_HELPER
+ select DRM_GEM_CMA_HELPER
help
Choose this option if you have an ARM High Definition Colour LCD
controller.
--
2.30.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER
@ 2022-01-24 15:13 ` carsten.haitzler
0 siblings, 0 replies; 17+ messages in thread
From: carsten.haitzler @ 2022-01-24 15:13 UTC (permalink / raw)
To: dri-devel; +Cc: airlied, liviu.dudau, linux-kernel, steven.price
From: Carsten Haitzler <carsten.haitzler@arm.com>
Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
---
drivers/gpu/drm/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 58a242871b28..6e3f1d600541 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -6,6 +6,7 @@ config DRM_HDLCD
depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
depends on COMMON_CLK
select DRM_KMS_HELPER
+ select DRM_GEM_CMA_HELPER
help
Choose this option if you have an ARM High Definition Colour LCD
controller.
--
2.30.1
^ permalink raw reply related [flat|nested] 17+ messages in thread
end of thread, other threads:[~2022-02-28 19:51 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-24 16:24 [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER carsten.haitzler
2022-01-24 16:24 ` carsten.haitzler
2022-01-25 12:37 ` Liviu Dudau
2022-01-25 12:37 ` Liviu Dudau
2022-02-23 10:18 ` Andre Przywara
2022-02-23 10:18 ` Andre Przywara
2022-02-23 10:18 ` Andre Przywara
2022-02-28 19:36 ` Rob Herring
2022-02-28 19:36 ` Rob Herring
2022-02-28 19:36 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2022-01-24 15:13 carsten.haitzler
2022-01-24 15:13 ` carsten.haitzler
2022-01-24 15:17 ` Carsten Haitzler
2022-01-24 16:13 ` Steven Price
2022-01-24 16:13 ` Steven Price
2022-01-24 16:25 ` Carsten Haitzler
2022-01-24 16:25 ` Carsten Haitzler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.