All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/5] drm/i915: Skip dsc readout if the transcoder is disabled
@ 2022-01-24 19:26 Ville Syrjala
  2022-01-24 19:26 ` [Intel-gfx] [PATCH 2/5] drm/i915: Simplify intel_dsc_source_support() Ville Syrjala
                   ` (9 more replies)
  0 siblings, 10 replies; 17+ messages in thread
From: Ville Syrjala @ 2022-01-24 19:26 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Tryingf to do readout when we don't even have a cpu transcoder
is not a great idea. Don't do it.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 80bc52425e47..e32a7a1e7ba0 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -4380,13 +4380,13 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc,
 		active = true;
 	}
 
+	if (!active)
+		goto out;
+
 	intel_dsc_get_config(pipe_config);
 	if (DISPLAY_VER(dev_priv) >= 13 && !pipe_config->dsc.compression_enable)
 		intel_uncompressed_joiner_get_config(pipe_config);
 
-	if (!active)
-		goto out;
-
 	if (!transcoder_is_dsi(pipe_config->cpu_transcoder) ||
 	    DISPLAY_VER(dev_priv) >= 11)
 		intel_get_transcoder_timings(crtc, pipe_config);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2022-01-26 10:00 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-24 19:26 [Intel-gfx] [PATCH 1/5] drm/i915: Skip dsc readout if the transcoder is disabled Ville Syrjala
2022-01-24 19:26 ` [Intel-gfx] [PATCH 2/5] drm/i915: Simplify intel_dsc_source_support() Ville Syrjala
2022-01-24 19:26 ` [Intel-gfx] [PATCH 3/5] drm/i915: Use per-device debugs for bigjoiner stuff Ville Syrjala
2022-01-24 19:26 ` [Intel-gfx] [PATCH 4/5] drm/i915: Extract hsw_configure_cpu_transcoder() Ville Syrjala
2022-01-25  5:38   ` Jani Nikula
2022-01-24 19:26 ` [Intel-gfx] [PATCH 5/5] drm/i915: Move dsc/joiner enable into hsw_crtc_enable() Ville Syrjala
2022-01-25  5:40   ` Jani Nikula
2022-01-25  5:59     ` Ville Syrjälä
2022-01-25  6:39   ` [Intel-gfx] [PATCH v2 " Ville Syrjala
2022-01-25  6:50     ` Jani Nikula
2022-01-25  7:07       ` Ville Syrjälä
2022-01-24 23:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Skip dsc readout if the transcoder is disabled Patchwork
2022-01-25  5:36 ` [Intel-gfx] [PATCH 1/5] " Jani Nikula
2022-01-25  5:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] " Patchwork
2022-01-25  8:20 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Skip dsc readout if the transcoder is disabled (rev2) Patchwork
2022-01-26  7:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Skip dsc readout if the transcoder is disabled (rev3) Patchwork
2022-01-26 10:00 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.