All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH v2] include/mk/env_pre.mk: remove dup makefile sourcing
@ 2022-01-25  2:50 Murphy Zhou
  2022-01-25 10:56 ` Petr Vorel
  0 siblings, 1 reply; 2+ messages in thread
From: Murphy Zhou @ 2022-01-25  2:50 UTC (permalink / raw)
  To: ltp

This will cause file not found errors.

Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
---
v2: fix sign-off mail address

 include/mk/env_pre.mk | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/mk/env_pre.mk b/include/mk/env_pre.mk
index f36215167..f913eb5fd 100644
--- a/include/mk/env_pre.mk
+++ b/include/mk/env_pre.mk
@@ -88,9 +88,6 @@ endif
 # autotools, *clean, and help don't require config.mk, features.mk, etc...
 ifeq ($(filter autotools %clean .gitignore gitignore.% help,$(MAKECMDGOALS)),)
 
-include $(abs_top_builddir)/include/mk/config.mk
-include $(abs_top_builddir)/include/mk/features.mk
-
 # START out-of-build-tree check.
 ifneq ($(abs_builddir),$(abs_srcdir))
 BUILD_TREE_STATE		:= $(BUILD_TREE_BUILDDIR_INSTALL)
-- 
2.31.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [LTP] [PATCH v2] include/mk/env_pre.mk: remove dup makefile sourcing
  2022-01-25  2:50 [LTP] [PATCH v2] include/mk/env_pre.mk: remove dup makefile sourcing Murphy Zhou
@ 2022-01-25 10:56 ` Petr Vorel
  0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2022-01-25 10:56 UTC (permalink / raw)
  To: Murphy Zhou; +Cc: ltp

Hi Murphy,

> This will cause file not found errors.
...

> +++ b/include/mk/env_pre.mk
> @@ -88,9 +88,6 @@ endif
>  # autotools, *clean, and help don't require config.mk, features.mk, etc...
>  ifeq ($(filter autotools %clean .gitignore gitignore.% help,$(MAKECMDGOALS)),)

> -include $(abs_top_builddir)/include/mk/config.mk
> -include $(abs_top_builddir)/include/mk/features.mk
> -
This is most certainly wrong, these includes are needed.

I guess you run make without running:
make autotools && ./configure

https://github.com/linux-test-project/ltp#quick-guide-to-running-the-tests

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-25 10:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25  2:50 [LTP] [PATCH v2] include/mk/env_pre.mk: remove dup makefile sourcing Murphy Zhou
2022-01-25 10:56 ` Petr Vorel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.