[virtio-dev] [PATCH] virtio-gpio: offered -> negotiated

[virtio-dev] [PATCH] virtio-gpio: offered -> negotiated

[Michael S. Tsirkin]

virtqueues are only discovered after FEATURES_OK.
As such it makes no sense to talk about virtqueues being affected by
features which are offered but not negotiated, and doing so will confuse
the reader.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

Viresh, others your thoughts on this? Looks like an obvious typo
to me, and something that I think we can fix under the editorial
changes rule.

 virtio-gpio.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virtio-gpio.tex b/virtio-gpio.tex
index 55c553f..8e5c7f0 100644
--- a/virtio-gpio.tex
+++ b/virtio-gpio.tex
@@ -15,7 +15,7 @@ \subsection{Virtqueues}\label{sec:Device Types / GPIO Device / Virtqueues}
 \end{description}
 
 The \field{eventq} virtqueue is available only if the \field{VIRTIO_GPIO_F_IRQ}
-feature is offered by the device.
+feature has been negotiated.
 
 \subsection{Feature bits}\label{sec:Device Types / GPIO Device / Feature bits}
 
-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] Re: [PATCH] virtio-gpio: offered -> negotiated

[Viresh Kumar]

On 25-01-22, 07:24, Michael S. Tsirkin wrote:
> virtqueues are only discovered after FEATURES_OK.
> As such it makes no sense to talk about virtqueues being affected by
> features which are offered but not negotiated, and doing so will confuse
> the reader.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> Viresh, others your thoughts on this? Looks like an obvious typo
> to me, and something that I think we can fix under the editorial
> changes rule.
> 
>  virtio-gpio.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virtio-gpio.tex b/virtio-gpio.tex
> index 55c553f..8e5c7f0 100644
> --- a/virtio-gpio.tex
> +++ b/virtio-gpio.tex
> @@ -15,7 +15,7 @@ \subsection{Virtqueues}\label{sec:Device Types / GPIO Device / Virtqueues}
>  \end{description}
>  
>  The \field{eventq} virtqueue is available only if the \field{VIRTIO_GPIO_F_IRQ}
> -feature is offered by the device.
> +feature has been negotiated.
>  
>  \subsection{Feature bits}\label{sec:Device Types / GPIO Device / Feature bits}

Sorry for the delay, was out of office.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio] Re: [virtio-dev] [PATCH] virtio-gpio: offered -> negotiated

[Cornelia Huck]

On Tue, Jan 25 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> virtqueues are only discovered after FEATURES_OK.
> As such it makes no sense to talk about virtqueues being affected by
> features which are offered but not negotiated, and doing so will confuse
> the reader.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Viresh, others your thoughts on this? Looks like an obvious typo
> to me, and something that I think we can fix under the editorial
> changes rule.
>
>  virtio-gpio.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Pushed as editorial update.


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php