From: kernel test robot <lkp@intel.com>
To: Hannes Reinecke <hare@suse.de>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: [PATCH] nvme-fabrics: fix returnvar.cocci warnings
Date: Wed, 26 Jan 2022 00:12:11 +0800 [thread overview]
Message-ID: <20220125161210.GA42603@d3bbc358300d> (raw)
In-Reply-To: <202201260046.otELTDdH-lkp@intel.com>
From: kernel test robot <lkp@intel.com>
drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics")
CC: Hannes Reinecke <hare@suse.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a08b41ab9e2e468647f78eb17c28e29b93006394
commit: f18ee3d988157ebcadc9b7e5fd34811938f50223 nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics
:::::: branch date: 10 hours ago
:::::: commit date: 5 weeks ago
fabrics.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -1092,7 +1092,6 @@ static void __nvmf_concat_opt_tokens(str
static int nvmf_dev_show(struct seq_file *seq_file, void *private)
{
struct nvme_ctrl *ctrl;
- int ret = 0;
mutex_lock(&nvmf_dev_mutex);
ctrl = seq_file->private;
@@ -1106,7 +1105,7 @@ static int nvmf_dev_show(struct seq_file
out_unlock:
mutex_unlock(&nvmf_dev_mutex);
- return ret;
+ return 0;
}
static int nvmf_dev_open(struct inode *inode, struct file *file)
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [PATCH] nvme-fabrics: fix returnvar.cocci warnings
Date: Wed, 26 Jan 2022 00:12:11 +0800 [thread overview]
Message-ID: <20220125161210.GA42603@d3bbc358300d> (raw)
In-Reply-To: <202201260046.otELTDdH-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]
From: kernel test robot <lkp@intel.com>
drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics")
CC: Hannes Reinecke <hare@suse.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a08b41ab9e2e468647f78eb17c28e29b93006394
commit: f18ee3d988157ebcadc9b7e5fd34811938f50223 nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics
:::::: branch date: 10 hours ago
:::::: commit date: 5 weeks ago
fabrics.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -1092,7 +1092,6 @@ static void __nvmf_concat_opt_tokens(str
static int nvmf_dev_show(struct seq_file *seq_file, void *private)
{
struct nvme_ctrl *ctrl;
- int ret = 0;
mutex_lock(&nvmf_dev_mutex);
ctrl = seq_file->private;
@@ -1106,7 +1105,7 @@ static int nvmf_dev_show(struct seq_file
out_unlock:
mutex_unlock(&nvmf_dev_mutex);
- return ret;
+ return 0;
}
static int nvmf_dev_open(struct inode *inode, struct file *file)
next prev parent reply other threads:[~2022-01-25 16:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 19:16 drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 kernel test robot
2022-01-25 19:16 ` kernel test robot
2022-01-25 16:12 ` kernel test robot [this message]
2022-01-25 16:12 ` [PATCH] nvme-fabrics: fix returnvar.cocci warnings kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-04-23 1:04 drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 kernel test robot
2022-04-23 1:00 ` [PATCH] nvme-fabrics: fix returnvar.cocci warnings kernel test robot
2022-01-22 3:26 drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 kernel test robot
2022-01-22 3:17 ` [PATCH] nvme-fabrics: fix returnvar.cocci warnings kernel test robot
2022-01-22 3:17 ` kernel test robot
2022-01-22 4:27 ` Chaitanya Kulkarni
2022-01-22 4:27 ` Chaitanya Kulkarni
2022-01-23 9:16 ` Sagi Grimberg
2022-01-23 9:16 ` Sagi Grimberg
2022-01-18 11:13 drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 kernel test robot
2022-01-18 9:25 ` [PATCH] nvme-fabrics: fix returnvar.cocci warnings kernel test robot
2022-01-18 9:25 ` kernel test robot
2022-01-19 7:40 ` Chaitanya Kulkarni
2022-01-19 7:40 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125161210.GA42603@d3bbc358300d \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbuild-all@lists.01.org \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.