* [PATCH v19 0/3] Add matrix keypad driver support for Mediatek SoCs @ 2022-01-26 15:35 ` Mattijs Korpershoek 0 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel Dear all, This is a follow-up on an abandoned series, see [1] Since Dmitry seemed generally happy with the driver, I applied his rename recommendations. I also did a couple of binding fixes which were needed to pass "make dt_binding_check". Thus, I have made the following: * All Reviewed-By: tags were kept * Applied Marco's reviewed by on the bindings (since he approved v10) * Fengping is still the maintainer since he is the original author of this driver * The binding license is not changed even if checkpatch recommended it: > WARNING: DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause) Please tell me if you would rather have me do things differently. [1] https://lore.kernel.org/all/20200909072159.14888-1-fengping.yu@mediatek.com/ v18 -> v19: - bindings: fix maintainer -> maintainers keyword - bindings: add matrix-keymap.yaml ref and remove included properties - bindings: fix compatible strings (reported by make dt_binding_check) - bindings: reorder properties to match the required ones - bindings: remove un-necessary descriptions - bindings: fix multiline description for mediatek,debounce-us - bindings: fix example to pass make dt_binding_check - bindings: fixed licence to GPL-2.0 only (checkpatch) - bindings: rename to mediatek,mt6779-keypad.yaml to match driver - rename driver to mt6779-keypad.c - prefix function names with mt6779_keypad_ - prefix globals with mt6779_keypad_ - rename CONFIG_KEYBOARD_MTK_KPD to CONFIG_KEYBOARD_MT6779 - rename module name to mt6779-keypad - update copyright year to 2022 fengping.yu (3): dt-bindings: input: Add bindings for Mediatek matrix keypad Input: mt6779-keypad - Add MediaTek keypad driver arm64: defconfig: Add CONFIG_KEYBOARD_MT6779=m .../input/mediatek,mt6779-keypad.yaml | 80 +++++++ arch/arm64/configs/defconfig | 1 + drivers/input/keyboard/Kconfig | 12 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/mt6779-keypad.c | 218 ++++++++++++++++++ 5 files changed, 312 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml create mode 100644 drivers/input/keyboard/mt6779-keypad.c base-commit: 87a0b2fafc09766d8c55461a18345a1cfb10a7fe -- 2.32.0 ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v19 0/3] Add matrix keypad driver support for Mediatek SoCs @ 2022-01-26 15:35 ` Mattijs Korpershoek 0 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel Dear all, This is a follow-up on an abandoned series, see [1] Since Dmitry seemed generally happy with the driver, I applied his rename recommendations. I also did a couple of binding fixes which were needed to pass "make dt_binding_check". Thus, I have made the following: * All Reviewed-By: tags were kept * Applied Marco's reviewed by on the bindings (since he approved v10) * Fengping is still the maintainer since he is the original author of this driver * The binding license is not changed even if checkpatch recommended it: > WARNING: DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause) Please tell me if you would rather have me do things differently. [1] https://lore.kernel.org/all/20200909072159.14888-1-fengping.yu@mediatek.com/ v18 -> v19: - bindings: fix maintainer -> maintainers keyword - bindings: add matrix-keymap.yaml ref and remove included properties - bindings: fix compatible strings (reported by make dt_binding_check) - bindings: reorder properties to match the required ones - bindings: remove un-necessary descriptions - bindings: fix multiline description for mediatek,debounce-us - bindings: fix example to pass make dt_binding_check - bindings: fixed licence to GPL-2.0 only (checkpatch) - bindings: rename to mediatek,mt6779-keypad.yaml to match driver - rename driver to mt6779-keypad.c - prefix function names with mt6779_keypad_ - prefix globals with mt6779_keypad_ - rename CONFIG_KEYBOARD_MTK_KPD to CONFIG_KEYBOARD_MT6779 - rename module name to mt6779-keypad - update copyright year to 2022 fengping.yu (3): dt-bindings: input: Add bindings for Mediatek matrix keypad Input: mt6779-keypad - Add MediaTek keypad driver arm64: defconfig: Add CONFIG_KEYBOARD_MT6779=m .../input/mediatek,mt6779-keypad.yaml | 80 +++++++ arch/arm64/configs/defconfig | 1 + drivers/input/keyboard/Kconfig | 12 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/mt6779-keypad.c | 218 ++++++++++++++++++ 5 files changed, 312 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml create mode 100644 drivers/input/keyboard/mt6779-keypad.c base-commit: 87a0b2fafc09766d8c55461a18345a1cfb10a7fe -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v19 0/3] Add matrix keypad driver support for Mediatek SoCs @ 2022-01-26 15:35 ` Mattijs Korpershoek 0 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel Dear all, This is a follow-up on an abandoned series, see [1] Since Dmitry seemed generally happy with the driver, I applied his rename recommendations. I also did a couple of binding fixes which were needed to pass "make dt_binding_check". Thus, I have made the following: * All Reviewed-By: tags were kept * Applied Marco's reviewed by on the bindings (since he approved v10) * Fengping is still the maintainer since he is the original author of this driver * The binding license is not changed even if checkpatch recommended it: > WARNING: DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause) Please tell me if you would rather have me do things differently. [1] https://lore.kernel.org/all/20200909072159.14888-1-fengping.yu@mediatek.com/ v18 -> v19: - bindings: fix maintainer -> maintainers keyword - bindings: add matrix-keymap.yaml ref and remove included properties - bindings: fix compatible strings (reported by make dt_binding_check) - bindings: reorder properties to match the required ones - bindings: remove un-necessary descriptions - bindings: fix multiline description for mediatek,debounce-us - bindings: fix example to pass make dt_binding_check - bindings: fixed licence to GPL-2.0 only (checkpatch) - bindings: rename to mediatek,mt6779-keypad.yaml to match driver - rename driver to mt6779-keypad.c - prefix function names with mt6779_keypad_ - prefix globals with mt6779_keypad_ - rename CONFIG_KEYBOARD_MTK_KPD to CONFIG_KEYBOARD_MT6779 - rename module name to mt6779-keypad - update copyright year to 2022 fengping.yu (3): dt-bindings: input: Add bindings for Mediatek matrix keypad Input: mt6779-keypad - Add MediaTek keypad driver arm64: defconfig: Add CONFIG_KEYBOARD_MT6779=m .../input/mediatek,mt6779-keypad.yaml | 80 +++++++ arch/arm64/configs/defconfig | 1 + drivers/input/keyboard/Kconfig | 12 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/mt6779-keypad.c | 218 ++++++++++++++++++ 5 files changed, 312 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml create mode 100644 drivers/input/keyboard/mt6779-keypad.c base-commit: 87a0b2fafc09766d8c55461a18345a1cfb10a7fe -- 2.32.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v19 1/3] dt-bindings: input: Add bindings for Mediatek matrix keypad 2022-01-26 15:35 ` Mattijs Korpershoek (?) @ 2022-01-26 15:35 ` Mattijs Korpershoek -1 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel From: "fengping.yu" <fengping.yu@mediatek.com> This patch add devicetree bindings for Mediatek matrix keypad driver. Signed-off-by: fengping.yu <fengping.yu@mediatek.com> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> --- .../input/mediatek,mt6779-keypad.yaml | 80 +++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml new file mode 100644 index 000000000000..2c76029224a0 --- /dev/null +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml @@ -0,0 +1,80 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/mediatek,mt6779-keypad.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek's Keypad Controller device tree bindings + +maintainers: + - Fengping Yu <fengping.yu@mediatek.com> + +allOf: + - $ref: "/schemas/input/matrix-keymap.yaml#" + +description: | + Mediatek's Keypad controller is used to interface a SoC with a matrix-type + keypad device. The keypad controller supports multiple row and column lines. + A key can be placed at each intersection of a unique row and a unique column. + The keypad controller can sense a key-press and key-release and report the + event using a interrupt to the cpu. + +properties: + compatible: + oneOf: + - const: mediatek,mt6779-keypad + - items: + - enum: + - mediatek,mt6873-keypad + - const: mediatek,mt6779-keypad + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + description: Names of the clocks listed in clocks property in the same order + items: + - const: kpd + + wakeup-source: + description: use any event on keypad as wakeup event + type: boolean + + mediatek,debounce-us: + description: | + Debounce interval in microseconds, if not specified, the default + value is 16000 + maximum: 256000 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/input/input.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + kp@10010000 { + compatible = "mediatek,mt6779-keypad"; + reg = <0 0x10010000 0 0x1000>; + interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>; + clocks = <&clk26m>; + clock-names = "kpd"; + }; + }; -- 2.32.0 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v19 1/3] dt-bindings: input: Add bindings for Mediatek matrix keypad @ 2022-01-26 15:35 ` Mattijs Korpershoek 0 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel From: "fengping.yu" <fengping.yu@mediatek.com> This patch add devicetree bindings for Mediatek matrix keypad driver. Signed-off-by: fengping.yu <fengping.yu@mediatek.com> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> --- .../input/mediatek,mt6779-keypad.yaml | 80 +++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml new file mode 100644 index 000000000000..2c76029224a0 --- /dev/null +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml @@ -0,0 +1,80 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/mediatek,mt6779-keypad.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek's Keypad Controller device tree bindings + +maintainers: + - Fengping Yu <fengping.yu@mediatek.com> + +allOf: + - $ref: "/schemas/input/matrix-keymap.yaml#" + +description: | + Mediatek's Keypad controller is used to interface a SoC with a matrix-type + keypad device. The keypad controller supports multiple row and column lines. + A key can be placed at each intersection of a unique row and a unique column. + The keypad controller can sense a key-press and key-release and report the + event using a interrupt to the cpu. + +properties: + compatible: + oneOf: + - const: mediatek,mt6779-keypad + - items: + - enum: + - mediatek,mt6873-keypad + - const: mediatek,mt6779-keypad + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + description: Names of the clocks listed in clocks property in the same order + items: + - const: kpd + + wakeup-source: + description: use any event on keypad as wakeup event + type: boolean + + mediatek,debounce-us: + description: | + Debounce interval in microseconds, if not specified, the default + value is 16000 + maximum: 256000 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/input/input.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + kp@10010000 { + compatible = "mediatek,mt6779-keypad"; + reg = <0 0x10010000 0 0x1000>; + interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>; + clocks = <&clk26m>; + clock-names = "kpd"; + }; + }; -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v19 1/3] dt-bindings: input: Add bindings for Mediatek matrix keypad @ 2022-01-26 15:35 ` Mattijs Korpershoek 0 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel From: "fengping.yu" <fengping.yu@mediatek.com> This patch add devicetree bindings for Mediatek matrix keypad driver. Signed-off-by: fengping.yu <fengping.yu@mediatek.com> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> --- .../input/mediatek,mt6779-keypad.yaml | 80 +++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml new file mode 100644 index 000000000000..2c76029224a0 --- /dev/null +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml @@ -0,0 +1,80 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/mediatek,mt6779-keypad.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek's Keypad Controller device tree bindings + +maintainers: + - Fengping Yu <fengping.yu@mediatek.com> + +allOf: + - $ref: "/schemas/input/matrix-keymap.yaml#" + +description: | + Mediatek's Keypad controller is used to interface a SoC with a matrix-type + keypad device. The keypad controller supports multiple row and column lines. + A key can be placed at each intersection of a unique row and a unique column. + The keypad controller can sense a key-press and key-release and report the + event using a interrupt to the cpu. + +properties: + compatible: + oneOf: + - const: mediatek,mt6779-keypad + - items: + - enum: + - mediatek,mt6873-keypad + - const: mediatek,mt6779-keypad + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + description: Names of the clocks listed in clocks property in the same order + items: + - const: kpd + + wakeup-source: + description: use any event on keypad as wakeup event + type: boolean + + mediatek,debounce-us: + description: | + Debounce interval in microseconds, if not specified, the default + value is 16000 + maximum: 256000 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/input/input.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + kp@10010000 { + compatible = "mediatek,mt6779-keypad"; + reg = <0 0x10010000 0 0x1000>; + interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>; + clocks = <&clk26m>; + clock-names = "kpd"; + }; + }; -- 2.32.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v19 1/3] dt-bindings: input: Add bindings for Mediatek matrix keypad 2022-01-26 15:35 ` Mattijs Korpershoek (?) @ 2022-01-26 22:10 ` Rob Herring -1 siblings, 0 replies; 18+ messages in thread From: Rob Herring @ 2022-01-26 22:10 UTC (permalink / raw) To: Mattijs Korpershoek Cc: linux-arm-kernel, Yingjoe Chen, Fengping Yu, Matthias Brugger, devicetree, Dmitry Torokhov, linux-kernel, Fabien Parent, Kevin Hilman, Marco Felsch, linux-mediatek, linux-input, Rob Herring, Andy Shevchenko On Wed, 26 Jan 2022 16:35:17 +0100, Mattijs Korpershoek wrote: > From: "fengping.yu" <fengping.yu@mediatek.com> > > This patch add devicetree bindings for Mediatek matrix keypad driver. > > Signed-off-by: fengping.yu <fengping.yu@mediatek.com> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > .../input/mediatek,mt6779-keypad.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml:28:13: [warning] wrong indentation: expected 14 but found 12 (indentation) ./Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml:43:8: [warning] wrong indentation: expected 6 but found 7 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1584526 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v19 1/3] dt-bindings: input: Add bindings for Mediatek matrix keypad @ 2022-01-26 22:10 ` Rob Herring 0 siblings, 0 replies; 18+ messages in thread From: Rob Herring @ 2022-01-26 22:10 UTC (permalink / raw) To: Mattijs Korpershoek Cc: linux-arm-kernel, Yingjoe Chen, Fengping Yu, Matthias Brugger, devicetree, Dmitry Torokhov, linux-kernel, Fabien Parent, Kevin Hilman, Marco Felsch, linux-mediatek, linux-input, Rob Herring, Andy Shevchenko On Wed, 26 Jan 2022 16:35:17 +0100, Mattijs Korpershoek wrote: > From: "fengping.yu" <fengping.yu@mediatek.com> > > This patch add devicetree bindings for Mediatek matrix keypad driver. > > Signed-off-by: fengping.yu <fengping.yu@mediatek.com> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > .../input/mediatek,mt6779-keypad.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml:28:13: [warning] wrong indentation: expected 14 but found 12 (indentation) ./Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml:43:8: [warning] wrong indentation: expected 6 but found 7 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1584526 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v19 1/3] dt-bindings: input: Add bindings for Mediatek matrix keypad @ 2022-01-26 22:10 ` Rob Herring 0 siblings, 0 replies; 18+ messages in thread From: Rob Herring @ 2022-01-26 22:10 UTC (permalink / raw) To: Mattijs Korpershoek Cc: linux-arm-kernel, Yingjoe Chen, Fengping Yu, Matthias Brugger, devicetree, Dmitry Torokhov, linux-kernel, Fabien Parent, Kevin Hilman, Marco Felsch, linux-mediatek, linux-input, Rob Herring, Andy Shevchenko On Wed, 26 Jan 2022 16:35:17 +0100, Mattijs Korpershoek wrote: > From: "fengping.yu" <fengping.yu@mediatek.com> > > This patch add devicetree bindings for Mediatek matrix keypad driver. > > Signed-off-by: fengping.yu <fengping.yu@mediatek.com> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > .../input/mediatek,mt6779-keypad.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml:28:13: [warning] wrong indentation: expected 14 but found 12 (indentation) ./Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml:43:8: [warning] wrong indentation: expected 6 but found 7 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1584526 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v19 1/3] dt-bindings: input: Add bindings for Mediatek matrix keypad 2022-01-26 15:35 ` Mattijs Korpershoek (?) @ 2022-01-26 22:44 ` Rob Herring -1 siblings, 0 replies; 18+ messages in thread From: Rob Herring @ 2022-01-26 22:44 UTC (permalink / raw) To: Mattijs Korpershoek Cc: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Matthias Brugger, Fengping Yu, Yingjoe Chen, Fabien Parent, Kevin Hilman, Linux Input, devicetree, linux-arm-kernel, moderated list:ARM/Mediatek SoC support, linux-kernel On Wed, Jan 26, 2022 at 9:35 AM Mattijs Korpershoek <mkorpershoek@baylibre.com> wrote: > > From: "fengping.yu" <fengping.yu@mediatek.com> > > This patch add devicetree bindings for Mediatek matrix keypad driver. > > Signed-off-by: fengping.yu <fengping.yu@mediatek.com> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > .../input/mediatek,mt6779-keypad.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > > diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > new file mode 100644 > index 000000000000..2c76029224a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: GPL-2.0 dual license new bindings > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/mediatek,mt6779-keypad.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek's Keypad Controller device tree bindings > + > +maintainers: > + - Fengping Yu <fengping.yu@mediatek.com> > + > +allOf: > + - $ref: "/schemas/input/matrix-keymap.yaml#" > + > +description: | > + Mediatek's Keypad controller is used to interface a SoC with a matrix-type > + keypad device. The keypad controller supports multiple row and column lines. > + A key can be placed at each intersection of a unique row and a unique column. > + The keypad controller can sense a key-press and key-release and report the > + event using a interrupt to the cpu. > + > +properties: > + compatible: > + oneOf: > + - const: mediatek,mt6779-keypad > + - items: > + - enum: > + - mediatek,mt6873-keypad > + - const: mediatek,mt6779-keypad > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: Names of the clocks listed in clocks property in the same order Drop generic descriptions. > + items: > + - const: kpd > + > + wakeup-source: > + description: use any event on keypad as wakeup event > + type: boolean > + > + mediatek,debounce-us: We already a somewhat common property: debounce-delay-ms > + description: | > + Debounce interval in microseconds, if not specified, the default > + value is 16000 > + maximum: 256000 default: 16000 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/input/input.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + kp@10010000 { Use a standard node name: keyboard@... or keys@... > + compatible = "mediatek,mt6779-keypad"; > + reg = <0 0x10010000 0 0x1000>; > + interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>; > + clocks = <&clk26m>; > + clock-names = "kpd"; > + }; > + }; > -- > 2.32.0 > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v19 1/3] dt-bindings: input: Add bindings for Mediatek matrix keypad @ 2022-01-26 22:44 ` Rob Herring 0 siblings, 0 replies; 18+ messages in thread From: Rob Herring @ 2022-01-26 22:44 UTC (permalink / raw) To: Mattijs Korpershoek Cc: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Matthias Brugger, Fengping Yu, Yingjoe Chen, Fabien Parent, Kevin Hilman, Linux Input, devicetree, linux-arm-kernel, moderated list:ARM/Mediatek SoC support, linux-kernel On Wed, Jan 26, 2022 at 9:35 AM Mattijs Korpershoek <mkorpershoek@baylibre.com> wrote: > > From: "fengping.yu" <fengping.yu@mediatek.com> > > This patch add devicetree bindings for Mediatek matrix keypad driver. > > Signed-off-by: fengping.yu <fengping.yu@mediatek.com> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > .../input/mediatek,mt6779-keypad.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > > diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > new file mode 100644 > index 000000000000..2c76029224a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: GPL-2.0 dual license new bindings > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/mediatek,mt6779-keypad.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek's Keypad Controller device tree bindings > + > +maintainers: > + - Fengping Yu <fengping.yu@mediatek.com> > + > +allOf: > + - $ref: "/schemas/input/matrix-keymap.yaml#" > + > +description: | > + Mediatek's Keypad controller is used to interface a SoC with a matrix-type > + keypad device. The keypad controller supports multiple row and column lines. > + A key can be placed at each intersection of a unique row and a unique column. > + The keypad controller can sense a key-press and key-release and report the > + event using a interrupt to the cpu. > + > +properties: > + compatible: > + oneOf: > + - const: mediatek,mt6779-keypad > + - items: > + - enum: > + - mediatek,mt6873-keypad > + - const: mediatek,mt6779-keypad > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: Names of the clocks listed in clocks property in the same order Drop generic descriptions. > + items: > + - const: kpd > + > + wakeup-source: > + description: use any event on keypad as wakeup event > + type: boolean > + > + mediatek,debounce-us: We already a somewhat common property: debounce-delay-ms > + description: | > + Debounce interval in microseconds, if not specified, the default > + value is 16000 > + maximum: 256000 default: 16000 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/input/input.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + kp@10010000 { Use a standard node name: keyboard@... or keys@... > + compatible = "mediatek,mt6779-keypad"; > + reg = <0 0x10010000 0 0x1000>; > + interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>; > + clocks = <&clk26m>; > + clock-names = "kpd"; > + }; > + }; > -- > 2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v19 1/3] dt-bindings: input: Add bindings for Mediatek matrix keypad @ 2022-01-26 22:44 ` Rob Herring 0 siblings, 0 replies; 18+ messages in thread From: Rob Herring @ 2022-01-26 22:44 UTC (permalink / raw) To: Mattijs Korpershoek Cc: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Matthias Brugger, Fengping Yu, Yingjoe Chen, Fabien Parent, Kevin Hilman, Linux Input, devicetree, linux-arm-kernel, moderated list:ARM/Mediatek SoC support, linux-kernel On Wed, Jan 26, 2022 at 9:35 AM Mattijs Korpershoek <mkorpershoek@baylibre.com> wrote: > > From: "fengping.yu" <fengping.yu@mediatek.com> > > This patch add devicetree bindings for Mediatek matrix keypad driver. > > Signed-off-by: fengping.yu <fengping.yu@mediatek.com> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > .../input/mediatek,mt6779-keypad.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > > diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > new file mode 100644 > index 000000000000..2c76029224a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: GPL-2.0 dual license new bindings > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/mediatek,mt6779-keypad.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek's Keypad Controller device tree bindings > + > +maintainers: > + - Fengping Yu <fengping.yu@mediatek.com> > + > +allOf: > + - $ref: "/schemas/input/matrix-keymap.yaml#" > + > +description: | > + Mediatek's Keypad controller is used to interface a SoC with a matrix-type > + keypad device. The keypad controller supports multiple row and column lines. > + A key can be placed at each intersection of a unique row and a unique column. > + The keypad controller can sense a key-press and key-release and report the > + event using a interrupt to the cpu. > + > +properties: > + compatible: > + oneOf: > + - const: mediatek,mt6779-keypad > + - items: > + - enum: > + - mediatek,mt6873-keypad > + - const: mediatek,mt6779-keypad > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: Names of the clocks listed in clocks property in the same order Drop generic descriptions. > + items: > + - const: kpd > + > + wakeup-source: > + description: use any event on keypad as wakeup event > + type: boolean > + > + mediatek,debounce-us: We already a somewhat common property: debounce-delay-ms > + description: | > + Debounce interval in microseconds, if not specified, the default > + value is 16000 > + maximum: 256000 default: 16000 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/input/input.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + kp@10010000 { Use a standard node name: keyboard@... or keys@... > + compatible = "mediatek,mt6779-keypad"; > + reg = <0 0x10010000 0 0x1000>; > + interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>; > + clocks = <&clk26m>; > + clock-names = "kpd"; > + }; > + }; > -- > 2.32.0 > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v19 2/3] Input: mt6779-keypad - Add MediaTek keypad driver 2022-01-26 15:35 ` Mattijs Korpershoek (?) @ 2022-01-26 15:35 ` Mattijs Korpershoek -1 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel From: "fengping.yu" <fengping.yu@mediatek.com> This patch adds matrix keypad support for Mediatek SoCs. Signed-off-by: fengping.yu <fengping.yu@mediatek.com> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> --- drivers/input/keyboard/Kconfig | 12 ++ drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/mt6779-keypad.c | 218 +++++++++++++++++++++++++ 3 files changed, 231 insertions(+) create mode 100644 drivers/input/keyboard/mt6779-keypad.c diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 0c607da9ee10..03a9530f620e 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -779,6 +779,18 @@ config KEYBOARD_BCM To compile this driver as a module, choose M here: the module will be called bcm-keypad. +config KEYBOARD_MT6779 + tristate "MediaTek Keypad Support" + depends on ARCH_MEDIATEK || COMPILE_TEST + select REGMAP_MMIO + select INPUT_MATRIXKMAP + help + Say Y here if you want to use the keypad on MediaTek SoCs. + If unsure, say N. + + To compile this driver as a module, choose M here: the + module will be called mt6779-keypad. + config KEYBOARD_MTK_PMIC tristate "MediaTek PMIC keys support" depends on MFD_MT6397 diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile index e3c8648f834e..721936e90290 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -44,6 +44,7 @@ obj-$(CONFIG_KEYBOARD_MATRIX) += matrix_keypad.o obj-$(CONFIG_KEYBOARD_MAX7359) += max7359_keypad.o obj-$(CONFIG_KEYBOARD_MCS) += mcs_touchkey.o obj-$(CONFIG_KEYBOARD_MPR121) += mpr121_touchkey.o +obj-$(CONFIG_KEYBOARD_MT6779) += mt6779-keypad.o obj-$(CONFIG_KEYBOARD_MTK_PMIC) += mtk-pmic-keys.o obj-$(CONFIG_KEYBOARD_NEWTON) += newtonkbd.o obj-$(CONFIG_KEYBOARD_NOMADIK) += nomadik-ske-keypad.o diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c new file mode 100644 index 000000000000..1564ed529e09 --- /dev/null +++ b/drivers/input/keyboard/mt6779-keypad.c @@ -0,0 +1,218 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2022 MediaTek Inc. + * Author Fengping Yu <fengping.yu@mediatek.com> + */ +#include <linux/bitops.h> +#include <linux/clk.h> +#include <linux/input/matrix_keypad.h> +#include <linux/interrupt.h> +#include <linux/module.h> +#include <linux/property.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> + +#define MTK_KPD_NAME "mt6779-keypad" +#define MTK_KPD_MEM 0x0004 +#define MTK_KPD_DEBOUNCE 0x0018 +#define MTK_KPD_DEBOUNCE_MASK GENMASK(13, 0) +#define MTK_KPD_DEBOUNCE_MAX_US 256000 +#define MTK_KPD_NUM_MEMS 5 +#define MTK_KPD_NUM_BITS 136 /* 4*32+8 MEM5 only use 8 BITS */ + +struct mt6779_keypad { + struct regmap *regmap; + struct input_dev *input_dev; + struct clk *clk; + void __iomem *base; + u32 n_rows; + u32 n_cols; + DECLARE_BITMAP(keymap_state, MTK_KPD_NUM_BITS); +}; + +static const struct regmap_config mt6779_keypad_regmap_cfg = { + .reg_bits = 32, + .val_bits = 32, + .reg_stride = sizeof(u32), + .max_register = 36, +}; + +static irqreturn_t mt6779_keypad_irq_handler(int irq, void *dev_id) +{ + struct mt6779_keypad *keypad = dev_id; + unsigned short *keycode = keypad->input_dev->keycode; + DECLARE_BITMAP(new_state, MTK_KPD_NUM_BITS); + DECLARE_BITMAP(change, MTK_KPD_NUM_BITS); + int bit_nr; + int pressed; + unsigned short code; + int row, col; + int row_shift = get_count_order(keypad->n_cols); + + regmap_bulk_read(keypad->regmap, MTK_KPD_MEM, + new_state, MTK_KPD_NUM_MEMS); + + bitmap_xor(change, new_state, keypad->keymap_state, MTK_KPD_NUM_BITS); + + for_each_set_bit(bit_nr, change, MTK_KPD_NUM_BITS) { + /* For 32bits register, only bits [15:0] use to indicate key status */ + if (bit_nr % 32 >= 16) + continue; + + /* 1: not pressed, 0: pressed */ + pressed = !test_bit(bit_nr, new_state); + dev_dbg(&keypad->input_dev->dev, "%s", + pressed ? "pressed" : "released"); + + row = bit_nr / 32; + col = bit_nr % 32; + + code = keycode[MATRIX_SCAN_CODE(row, col, row_shift)]; + + input_report_key(keypad->input_dev, code, pressed); + input_sync(keypad->input_dev); + + dev_dbg(&keypad->input_dev->dev, + "report Linux keycode = %d\n", code); + } + + bitmap_copy(keypad->keymap_state, new_state, MTK_KPD_NUM_BITS); + + return IRQ_HANDLED; +} + +static void mt6779_keypad_clk_disable(void *data) +{ + clk_disable_unprepare(data); +} + +static int mt6779_keypad_pdrv_probe(struct platform_device *pdev) +{ + struct mt6779_keypad *keypad; + unsigned int irq; + u32 debounce; + bool wakeup; + int error; + + keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL); + if (!keypad) + return -ENOMEM; + + keypad->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(keypad->base)) + return PTR_ERR(keypad->base); + + keypad->regmap = devm_regmap_init_mmio(&pdev->dev, + keypad->base, + &mt6779_keypad_regmap_cfg); + if (IS_ERR(keypad->regmap)) { + dev_err(&pdev->dev, + "regmap init failed:%pe\n", keypad->regmap); + return PTR_ERR(keypad->regmap); + } + + bitmap_fill(keypad->keymap_state, MTK_KPD_NUM_BITS); + + keypad->input_dev = devm_input_allocate_device(&pdev->dev); + if (!keypad->input_dev) { + dev_err(&pdev->dev, "Failed to allocate input dev\n"); + return -ENOMEM; + } + + keypad->input_dev->name = MTK_KPD_NAME; + keypad->input_dev->id.bustype = BUS_HOST; + + error = matrix_keypad_parse_properties(&pdev->dev, &keypad->n_rows, + &keypad->n_cols); + if (error) { + dev_err(&pdev->dev, "Failed to parse keypad params\n"); + return error; + } + + if (device_property_read_u32(&pdev->dev, "mediatek,debounce-us", + &debounce)) + debounce = 16000; + + if (debounce > MTK_KPD_DEBOUNCE_MAX_US) { + dev_err(&pdev->dev, "Debounce time exceeds the maximum allowed time %dus\n", + MTK_KPD_DEBOUNCE_MAX_US); + return -EINVAL; + } + + wakeup = device_property_read_bool(&pdev->dev, "wakeup-source"); + + dev_dbg(&pdev->dev, "n_row=%d n_col=%d debounce=%d\n", + keypad->n_rows, keypad->n_cols, debounce); + + error = matrix_keypad_build_keymap(NULL, NULL, + keypad->n_rows, + keypad->n_cols, + NULL, + keypad->input_dev); + if (error) { + dev_err(&pdev->dev, "Failed to build keymap\n"); + return error; + } + + regmap_write(keypad->regmap, MTK_KPD_DEBOUNCE, + debounce * 32 / 1000 & MTK_KPD_DEBOUNCE_MASK); + + keypad->clk = devm_clk_get(&pdev->dev, "kpd"); + if (IS_ERR(keypad->clk)) + return PTR_ERR(keypad->clk); + + error = clk_prepare_enable(keypad->clk); + if (error) { + dev_err(&pdev->dev, "cannot prepare/enable keypad clock\n"); + return error; + } + + error = devm_add_action_or_reset(&pdev->dev, mt6779_keypad_clk_disable, keypad->clk); + if (error) + return error; + + irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + + error = devm_request_threaded_irq(&pdev->dev, irq, + NULL, mt6779_keypad_irq_handler, + IRQF_ONESHOT, + MTK_KPD_NAME, keypad); + if (error) { + dev_err(&pdev->dev, "Failed to request IRQ#%d:%d\n", + irq, error); + return error; + } + + error = input_register_device(keypad->input_dev); + if (error) { + dev_err(&pdev->dev, "Failed to register device\n"); + return error; + } + + error = device_init_wakeup(&pdev->dev, wakeup); + if (error) + dev_warn(&pdev->dev, "device_init_wakeup fail\n"); + + return 0; +} + +static const struct of_device_id mt6779_keypad_of_match[] = { + { .compatible = "mediatek,mt6779-keypad" }, + { .compatible = "mediatek,mt6873-keypad" }, + { /* sentinel */ } +}; + +static struct platform_driver mt6779_keypad_pdrv = { + .probe = mt6779_keypad_pdrv_probe, + .driver = { + .name = MTK_KPD_NAME, + .of_match_table = mt6779_keypad_of_match, + }, +}; +module_platform_driver(mt6779_keypad_pdrv); + +MODULE_AUTHOR("Mediatek Corporation"); +MODULE_DESCRIPTION("MTK Keypad (KPD) Driver"); +MODULE_LICENSE("GPL"); -- 2.32.0 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v19 2/3] Input: mt6779-keypad - Add MediaTek keypad driver @ 2022-01-26 15:35 ` Mattijs Korpershoek 0 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel From: "fengping.yu" <fengping.yu@mediatek.com> This patch adds matrix keypad support for Mediatek SoCs. Signed-off-by: fengping.yu <fengping.yu@mediatek.com> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> --- drivers/input/keyboard/Kconfig | 12 ++ drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/mt6779-keypad.c | 218 +++++++++++++++++++++++++ 3 files changed, 231 insertions(+) create mode 100644 drivers/input/keyboard/mt6779-keypad.c diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 0c607da9ee10..03a9530f620e 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -779,6 +779,18 @@ config KEYBOARD_BCM To compile this driver as a module, choose M here: the module will be called bcm-keypad. +config KEYBOARD_MT6779 + tristate "MediaTek Keypad Support" + depends on ARCH_MEDIATEK || COMPILE_TEST + select REGMAP_MMIO + select INPUT_MATRIXKMAP + help + Say Y here if you want to use the keypad on MediaTek SoCs. + If unsure, say N. + + To compile this driver as a module, choose M here: the + module will be called mt6779-keypad. + config KEYBOARD_MTK_PMIC tristate "MediaTek PMIC keys support" depends on MFD_MT6397 diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile index e3c8648f834e..721936e90290 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -44,6 +44,7 @@ obj-$(CONFIG_KEYBOARD_MATRIX) += matrix_keypad.o obj-$(CONFIG_KEYBOARD_MAX7359) += max7359_keypad.o obj-$(CONFIG_KEYBOARD_MCS) += mcs_touchkey.o obj-$(CONFIG_KEYBOARD_MPR121) += mpr121_touchkey.o +obj-$(CONFIG_KEYBOARD_MT6779) += mt6779-keypad.o obj-$(CONFIG_KEYBOARD_MTK_PMIC) += mtk-pmic-keys.o obj-$(CONFIG_KEYBOARD_NEWTON) += newtonkbd.o obj-$(CONFIG_KEYBOARD_NOMADIK) += nomadik-ske-keypad.o diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c new file mode 100644 index 000000000000..1564ed529e09 --- /dev/null +++ b/drivers/input/keyboard/mt6779-keypad.c @@ -0,0 +1,218 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2022 MediaTek Inc. + * Author Fengping Yu <fengping.yu@mediatek.com> + */ +#include <linux/bitops.h> +#include <linux/clk.h> +#include <linux/input/matrix_keypad.h> +#include <linux/interrupt.h> +#include <linux/module.h> +#include <linux/property.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> + +#define MTK_KPD_NAME "mt6779-keypad" +#define MTK_KPD_MEM 0x0004 +#define MTK_KPD_DEBOUNCE 0x0018 +#define MTK_KPD_DEBOUNCE_MASK GENMASK(13, 0) +#define MTK_KPD_DEBOUNCE_MAX_US 256000 +#define MTK_KPD_NUM_MEMS 5 +#define MTK_KPD_NUM_BITS 136 /* 4*32+8 MEM5 only use 8 BITS */ + +struct mt6779_keypad { + struct regmap *regmap; + struct input_dev *input_dev; + struct clk *clk; + void __iomem *base; + u32 n_rows; + u32 n_cols; + DECLARE_BITMAP(keymap_state, MTK_KPD_NUM_BITS); +}; + +static const struct regmap_config mt6779_keypad_regmap_cfg = { + .reg_bits = 32, + .val_bits = 32, + .reg_stride = sizeof(u32), + .max_register = 36, +}; + +static irqreturn_t mt6779_keypad_irq_handler(int irq, void *dev_id) +{ + struct mt6779_keypad *keypad = dev_id; + unsigned short *keycode = keypad->input_dev->keycode; + DECLARE_BITMAP(new_state, MTK_KPD_NUM_BITS); + DECLARE_BITMAP(change, MTK_KPD_NUM_BITS); + int bit_nr; + int pressed; + unsigned short code; + int row, col; + int row_shift = get_count_order(keypad->n_cols); + + regmap_bulk_read(keypad->regmap, MTK_KPD_MEM, + new_state, MTK_KPD_NUM_MEMS); + + bitmap_xor(change, new_state, keypad->keymap_state, MTK_KPD_NUM_BITS); + + for_each_set_bit(bit_nr, change, MTK_KPD_NUM_BITS) { + /* For 32bits register, only bits [15:0] use to indicate key status */ + if (bit_nr % 32 >= 16) + continue; + + /* 1: not pressed, 0: pressed */ + pressed = !test_bit(bit_nr, new_state); + dev_dbg(&keypad->input_dev->dev, "%s", + pressed ? "pressed" : "released"); + + row = bit_nr / 32; + col = bit_nr % 32; + + code = keycode[MATRIX_SCAN_CODE(row, col, row_shift)]; + + input_report_key(keypad->input_dev, code, pressed); + input_sync(keypad->input_dev); + + dev_dbg(&keypad->input_dev->dev, + "report Linux keycode = %d\n", code); + } + + bitmap_copy(keypad->keymap_state, new_state, MTK_KPD_NUM_BITS); + + return IRQ_HANDLED; +} + +static void mt6779_keypad_clk_disable(void *data) +{ + clk_disable_unprepare(data); +} + +static int mt6779_keypad_pdrv_probe(struct platform_device *pdev) +{ + struct mt6779_keypad *keypad; + unsigned int irq; + u32 debounce; + bool wakeup; + int error; + + keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL); + if (!keypad) + return -ENOMEM; + + keypad->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(keypad->base)) + return PTR_ERR(keypad->base); + + keypad->regmap = devm_regmap_init_mmio(&pdev->dev, + keypad->base, + &mt6779_keypad_regmap_cfg); + if (IS_ERR(keypad->regmap)) { + dev_err(&pdev->dev, + "regmap init failed:%pe\n", keypad->regmap); + return PTR_ERR(keypad->regmap); + } + + bitmap_fill(keypad->keymap_state, MTK_KPD_NUM_BITS); + + keypad->input_dev = devm_input_allocate_device(&pdev->dev); + if (!keypad->input_dev) { + dev_err(&pdev->dev, "Failed to allocate input dev\n"); + return -ENOMEM; + } + + keypad->input_dev->name = MTK_KPD_NAME; + keypad->input_dev->id.bustype = BUS_HOST; + + error = matrix_keypad_parse_properties(&pdev->dev, &keypad->n_rows, + &keypad->n_cols); + if (error) { + dev_err(&pdev->dev, "Failed to parse keypad params\n"); + return error; + } + + if (device_property_read_u32(&pdev->dev, "mediatek,debounce-us", + &debounce)) + debounce = 16000; + + if (debounce > MTK_KPD_DEBOUNCE_MAX_US) { + dev_err(&pdev->dev, "Debounce time exceeds the maximum allowed time %dus\n", + MTK_KPD_DEBOUNCE_MAX_US); + return -EINVAL; + } + + wakeup = device_property_read_bool(&pdev->dev, "wakeup-source"); + + dev_dbg(&pdev->dev, "n_row=%d n_col=%d debounce=%d\n", + keypad->n_rows, keypad->n_cols, debounce); + + error = matrix_keypad_build_keymap(NULL, NULL, + keypad->n_rows, + keypad->n_cols, + NULL, + keypad->input_dev); + if (error) { + dev_err(&pdev->dev, "Failed to build keymap\n"); + return error; + } + + regmap_write(keypad->regmap, MTK_KPD_DEBOUNCE, + debounce * 32 / 1000 & MTK_KPD_DEBOUNCE_MASK); + + keypad->clk = devm_clk_get(&pdev->dev, "kpd"); + if (IS_ERR(keypad->clk)) + return PTR_ERR(keypad->clk); + + error = clk_prepare_enable(keypad->clk); + if (error) { + dev_err(&pdev->dev, "cannot prepare/enable keypad clock\n"); + return error; + } + + error = devm_add_action_or_reset(&pdev->dev, mt6779_keypad_clk_disable, keypad->clk); + if (error) + return error; + + irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + + error = devm_request_threaded_irq(&pdev->dev, irq, + NULL, mt6779_keypad_irq_handler, + IRQF_ONESHOT, + MTK_KPD_NAME, keypad); + if (error) { + dev_err(&pdev->dev, "Failed to request IRQ#%d:%d\n", + irq, error); + return error; + } + + error = input_register_device(keypad->input_dev); + if (error) { + dev_err(&pdev->dev, "Failed to register device\n"); + return error; + } + + error = device_init_wakeup(&pdev->dev, wakeup); + if (error) + dev_warn(&pdev->dev, "device_init_wakeup fail\n"); + + return 0; +} + +static const struct of_device_id mt6779_keypad_of_match[] = { + { .compatible = "mediatek,mt6779-keypad" }, + { .compatible = "mediatek,mt6873-keypad" }, + { /* sentinel */ } +}; + +static struct platform_driver mt6779_keypad_pdrv = { + .probe = mt6779_keypad_pdrv_probe, + .driver = { + .name = MTK_KPD_NAME, + .of_match_table = mt6779_keypad_of_match, + }, +}; +module_platform_driver(mt6779_keypad_pdrv); + +MODULE_AUTHOR("Mediatek Corporation"); +MODULE_DESCRIPTION("MTK Keypad (KPD) Driver"); +MODULE_LICENSE("GPL"); -- 2.32.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v19 2/3] Input: mt6779-keypad - Add MediaTek keypad driver @ 2022-01-26 15:35 ` Mattijs Korpershoek 0 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel From: "fengping.yu" <fengping.yu@mediatek.com> This patch adds matrix keypad support for Mediatek SoCs. Signed-off-by: fengping.yu <fengping.yu@mediatek.com> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> --- drivers/input/keyboard/Kconfig | 12 ++ drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/mt6779-keypad.c | 218 +++++++++++++++++++++++++ 3 files changed, 231 insertions(+) create mode 100644 drivers/input/keyboard/mt6779-keypad.c diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 0c607da9ee10..03a9530f620e 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -779,6 +779,18 @@ config KEYBOARD_BCM To compile this driver as a module, choose M here: the module will be called bcm-keypad. +config KEYBOARD_MT6779 + tristate "MediaTek Keypad Support" + depends on ARCH_MEDIATEK || COMPILE_TEST + select REGMAP_MMIO + select INPUT_MATRIXKMAP + help + Say Y here if you want to use the keypad on MediaTek SoCs. + If unsure, say N. + + To compile this driver as a module, choose M here: the + module will be called mt6779-keypad. + config KEYBOARD_MTK_PMIC tristate "MediaTek PMIC keys support" depends on MFD_MT6397 diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makefile index e3c8648f834e..721936e90290 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -44,6 +44,7 @@ obj-$(CONFIG_KEYBOARD_MATRIX) += matrix_keypad.o obj-$(CONFIG_KEYBOARD_MAX7359) += max7359_keypad.o obj-$(CONFIG_KEYBOARD_MCS) += mcs_touchkey.o obj-$(CONFIG_KEYBOARD_MPR121) += mpr121_touchkey.o +obj-$(CONFIG_KEYBOARD_MT6779) += mt6779-keypad.o obj-$(CONFIG_KEYBOARD_MTK_PMIC) += mtk-pmic-keys.o obj-$(CONFIG_KEYBOARD_NEWTON) += newtonkbd.o obj-$(CONFIG_KEYBOARD_NOMADIK) += nomadik-ske-keypad.o diff --git a/drivers/input/keyboard/mt6779-keypad.c b/drivers/input/keyboard/mt6779-keypad.c new file mode 100644 index 000000000000..1564ed529e09 --- /dev/null +++ b/drivers/input/keyboard/mt6779-keypad.c @@ -0,0 +1,218 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2022 MediaTek Inc. + * Author Fengping Yu <fengping.yu@mediatek.com> + */ +#include <linux/bitops.h> +#include <linux/clk.h> +#include <linux/input/matrix_keypad.h> +#include <linux/interrupt.h> +#include <linux/module.h> +#include <linux/property.h> +#include <linux/platform_device.h> +#include <linux/regmap.h> + +#define MTK_KPD_NAME "mt6779-keypad" +#define MTK_KPD_MEM 0x0004 +#define MTK_KPD_DEBOUNCE 0x0018 +#define MTK_KPD_DEBOUNCE_MASK GENMASK(13, 0) +#define MTK_KPD_DEBOUNCE_MAX_US 256000 +#define MTK_KPD_NUM_MEMS 5 +#define MTK_KPD_NUM_BITS 136 /* 4*32+8 MEM5 only use 8 BITS */ + +struct mt6779_keypad { + struct regmap *regmap; + struct input_dev *input_dev; + struct clk *clk; + void __iomem *base; + u32 n_rows; + u32 n_cols; + DECLARE_BITMAP(keymap_state, MTK_KPD_NUM_BITS); +}; + +static const struct regmap_config mt6779_keypad_regmap_cfg = { + .reg_bits = 32, + .val_bits = 32, + .reg_stride = sizeof(u32), + .max_register = 36, +}; + +static irqreturn_t mt6779_keypad_irq_handler(int irq, void *dev_id) +{ + struct mt6779_keypad *keypad = dev_id; + unsigned short *keycode = keypad->input_dev->keycode; + DECLARE_BITMAP(new_state, MTK_KPD_NUM_BITS); + DECLARE_BITMAP(change, MTK_KPD_NUM_BITS); + int bit_nr; + int pressed; + unsigned short code; + int row, col; + int row_shift = get_count_order(keypad->n_cols); + + regmap_bulk_read(keypad->regmap, MTK_KPD_MEM, + new_state, MTK_KPD_NUM_MEMS); + + bitmap_xor(change, new_state, keypad->keymap_state, MTK_KPD_NUM_BITS); + + for_each_set_bit(bit_nr, change, MTK_KPD_NUM_BITS) { + /* For 32bits register, only bits [15:0] use to indicate key status */ + if (bit_nr % 32 >= 16) + continue; + + /* 1: not pressed, 0: pressed */ + pressed = !test_bit(bit_nr, new_state); + dev_dbg(&keypad->input_dev->dev, "%s", + pressed ? "pressed" : "released"); + + row = bit_nr / 32; + col = bit_nr % 32; + + code = keycode[MATRIX_SCAN_CODE(row, col, row_shift)]; + + input_report_key(keypad->input_dev, code, pressed); + input_sync(keypad->input_dev); + + dev_dbg(&keypad->input_dev->dev, + "report Linux keycode = %d\n", code); + } + + bitmap_copy(keypad->keymap_state, new_state, MTK_KPD_NUM_BITS); + + return IRQ_HANDLED; +} + +static void mt6779_keypad_clk_disable(void *data) +{ + clk_disable_unprepare(data); +} + +static int mt6779_keypad_pdrv_probe(struct platform_device *pdev) +{ + struct mt6779_keypad *keypad; + unsigned int irq; + u32 debounce; + bool wakeup; + int error; + + keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL); + if (!keypad) + return -ENOMEM; + + keypad->base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(keypad->base)) + return PTR_ERR(keypad->base); + + keypad->regmap = devm_regmap_init_mmio(&pdev->dev, + keypad->base, + &mt6779_keypad_regmap_cfg); + if (IS_ERR(keypad->regmap)) { + dev_err(&pdev->dev, + "regmap init failed:%pe\n", keypad->regmap); + return PTR_ERR(keypad->regmap); + } + + bitmap_fill(keypad->keymap_state, MTK_KPD_NUM_BITS); + + keypad->input_dev = devm_input_allocate_device(&pdev->dev); + if (!keypad->input_dev) { + dev_err(&pdev->dev, "Failed to allocate input dev\n"); + return -ENOMEM; + } + + keypad->input_dev->name = MTK_KPD_NAME; + keypad->input_dev->id.bustype = BUS_HOST; + + error = matrix_keypad_parse_properties(&pdev->dev, &keypad->n_rows, + &keypad->n_cols); + if (error) { + dev_err(&pdev->dev, "Failed to parse keypad params\n"); + return error; + } + + if (device_property_read_u32(&pdev->dev, "mediatek,debounce-us", + &debounce)) + debounce = 16000; + + if (debounce > MTK_KPD_DEBOUNCE_MAX_US) { + dev_err(&pdev->dev, "Debounce time exceeds the maximum allowed time %dus\n", + MTK_KPD_DEBOUNCE_MAX_US); + return -EINVAL; + } + + wakeup = device_property_read_bool(&pdev->dev, "wakeup-source"); + + dev_dbg(&pdev->dev, "n_row=%d n_col=%d debounce=%d\n", + keypad->n_rows, keypad->n_cols, debounce); + + error = matrix_keypad_build_keymap(NULL, NULL, + keypad->n_rows, + keypad->n_cols, + NULL, + keypad->input_dev); + if (error) { + dev_err(&pdev->dev, "Failed to build keymap\n"); + return error; + } + + regmap_write(keypad->regmap, MTK_KPD_DEBOUNCE, + debounce * 32 / 1000 & MTK_KPD_DEBOUNCE_MASK); + + keypad->clk = devm_clk_get(&pdev->dev, "kpd"); + if (IS_ERR(keypad->clk)) + return PTR_ERR(keypad->clk); + + error = clk_prepare_enable(keypad->clk); + if (error) { + dev_err(&pdev->dev, "cannot prepare/enable keypad clock\n"); + return error; + } + + error = devm_add_action_or_reset(&pdev->dev, mt6779_keypad_clk_disable, keypad->clk); + if (error) + return error; + + irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + + error = devm_request_threaded_irq(&pdev->dev, irq, + NULL, mt6779_keypad_irq_handler, + IRQF_ONESHOT, + MTK_KPD_NAME, keypad); + if (error) { + dev_err(&pdev->dev, "Failed to request IRQ#%d:%d\n", + irq, error); + return error; + } + + error = input_register_device(keypad->input_dev); + if (error) { + dev_err(&pdev->dev, "Failed to register device\n"); + return error; + } + + error = device_init_wakeup(&pdev->dev, wakeup); + if (error) + dev_warn(&pdev->dev, "device_init_wakeup fail\n"); + + return 0; +} + +static const struct of_device_id mt6779_keypad_of_match[] = { + { .compatible = "mediatek,mt6779-keypad" }, + { .compatible = "mediatek,mt6873-keypad" }, + { /* sentinel */ } +}; + +static struct platform_driver mt6779_keypad_pdrv = { + .probe = mt6779_keypad_pdrv_probe, + .driver = { + .name = MTK_KPD_NAME, + .of_match_table = mt6779_keypad_of_match, + }, +}; +module_platform_driver(mt6779_keypad_pdrv); + +MODULE_AUTHOR("Mediatek Corporation"); +MODULE_DESCRIPTION("MTK Keypad (KPD) Driver"); +MODULE_LICENSE("GPL"); -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v19 3/3] arm64: defconfig: Add CONFIG_KEYBOARD_MT6779=m 2022-01-26 15:35 ` Mattijs Korpershoek (?) @ 2022-01-26 15:35 ` Mattijs Korpershoek -1 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel From: "fengping.yu" <fengping.yu@mediatek.com> Add Mediatek matrix keypad support in defconfig. Signed-off-by: fengping.yu <fengping.yu@mediatek.com> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index f2e2b9bdd702..099a9e68711c 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -390,6 +390,7 @@ CONFIG_KEYBOARD_GPIO=y CONFIG_KEYBOARD_SNVS_PWRKEY=m CONFIG_KEYBOARD_IMX_SC_KEY=m CONFIG_KEYBOARD_CROS_EC=y +CONFIG_KEYBOARD_MT6779=m CONFIG_INPUT_TOUCHSCREEN=y CONFIG_TOUCHSCREEN_ATMEL_MXT=m CONFIG_TOUCHSCREEN_GOODIX=m -- 2.32.0 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v19 3/3] arm64: defconfig: Add CONFIG_KEYBOARD_MT6779=m @ 2022-01-26 15:35 ` Mattijs Korpershoek 0 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel From: "fengping.yu" <fengping.yu@mediatek.com> Add Mediatek matrix keypad support in defconfig. Signed-off-by: fengping.yu <fengping.yu@mediatek.com> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index f2e2b9bdd702..099a9e68711c 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -390,6 +390,7 @@ CONFIG_KEYBOARD_GPIO=y CONFIG_KEYBOARD_SNVS_PWRKEY=m CONFIG_KEYBOARD_IMX_SC_KEY=m CONFIG_KEYBOARD_CROS_EC=y +CONFIG_KEYBOARD_MT6779=m CONFIG_INPUT_TOUCHSCREEN=y CONFIG_TOUCHSCREEN_ATMEL_MXT=m CONFIG_TOUCHSCREEN_GOODIX=m -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v19 3/3] arm64: defconfig: Add CONFIG_KEYBOARD_MT6779=m @ 2022-01-26 15:35 ` Mattijs Korpershoek 0 siblings, 0 replies; 18+ messages in thread From: Mattijs Korpershoek @ 2022-01-26 15:35 UTC (permalink / raw) To: Dmitry Torokhov, Andy Shevchenko, Marco Felsch, Rob Herring, Matthias Brugger, Fengping Yu, Yingjoe Chen Cc: Mattijs Korpershoek, Fabien Parent, Kevin Hilman, linux-input, devicetree, linux-arm-kernel, linux-mediatek, linux-kernel From: "fengping.yu" <fengping.yu@mediatek.com> Add Mediatek matrix keypad support in defconfig. Signed-off-by: fengping.yu <fengping.yu@mediatek.com> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index f2e2b9bdd702..099a9e68711c 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -390,6 +390,7 @@ CONFIG_KEYBOARD_GPIO=y CONFIG_KEYBOARD_SNVS_PWRKEY=m CONFIG_KEYBOARD_IMX_SC_KEY=m CONFIG_KEYBOARD_CROS_EC=y +CONFIG_KEYBOARD_MT6779=m CONFIG_INPUT_TOUCHSCREEN=y CONFIG_TOUCHSCREEN_ATMEL_MXT=m CONFIG_TOUCHSCREEN_GOODIX=m -- 2.32.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 18+ messages in thread
end of thread, other threads:[~2022-01-26 22:45 UTC | newest] Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-01-26 15:35 [PATCH v19 0/3] Add matrix keypad driver support for Mediatek SoCs Mattijs Korpershoek 2022-01-26 15:35 ` Mattijs Korpershoek 2022-01-26 15:35 ` Mattijs Korpershoek 2022-01-26 15:35 ` [PATCH v19 1/3] dt-bindings: input: Add bindings for Mediatek matrix keypad Mattijs Korpershoek 2022-01-26 15:35 ` Mattijs Korpershoek 2022-01-26 15:35 ` Mattijs Korpershoek 2022-01-26 22:10 ` Rob Herring 2022-01-26 22:10 ` Rob Herring 2022-01-26 22:10 ` Rob Herring 2022-01-26 22:44 ` Rob Herring 2022-01-26 22:44 ` Rob Herring 2022-01-26 22:44 ` Rob Herring 2022-01-26 15:35 ` [PATCH v19 2/3] Input: mt6779-keypad - Add MediaTek keypad driver Mattijs Korpershoek 2022-01-26 15:35 ` Mattijs Korpershoek 2022-01-26 15:35 ` Mattijs Korpershoek 2022-01-26 15:35 ` [PATCH v19 3/3] arm64: defconfig: Add CONFIG_KEYBOARD_MT6779=m Mattijs Korpershoek 2022-01-26 15:35 ` Mattijs Korpershoek 2022-01-26 15:35 ` Mattijs Korpershoek
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.