All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 1/4] panic: Add panic_in_progress helper
Date: Thu, 27 Jan 2022 08:40:13 +0800	[thread overview]
Message-ID: <202201270843.6F0l6Ntb-lkp@intel.com> (raw)
In-Reply-To: <20220126230236.750229-2-stephen.s.brennan@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 5391 bytes --]

Hi Stephen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.17-rc1 next-20220125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Stephen-Brennan/printk-reduce-deadlocks-during-panic/20220127-070450
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 0280e3c58f92b2fe0e8fbbdf8d386449168de4a8
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220127/202201270843.6F0l6Ntb-lkp(a)intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1a13d274a7781724644b4267dce99e45c9232a29
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Stephen-Brennan/printk-reduce-deadlocks-during-panic/20220127-070450
        git checkout 1a13d274a7781724644b4267dce99e45c9232a29
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv prepare

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/riscv/include/asm/atomic.h:19,
                    from include/linux/atomic.h:7,
                    from include/linux/panic.h:7,
                    from include/asm-generic/bug.h:21,
                    from arch/riscv/include/asm/bug.h:83,
                    from include/linux/bug.h:5,
                    from include/linux/page-flags.h:10,
                    from kernel/bounds.c:10:
   arch/riscv/include/asm/atomic.h: In function 'arch_atomic_xchg_relaxed':
>> arch/riscv/include/asm/cmpxchg.h:35:17: error: implicit declaration of function 'BUILD_BUG' [-Werror=implicit-function-declaration]
      35 |                 BUILD_BUG();                                            \
         |                 ^~~~~~~~~
   arch/riscv/include/asm/atomic.h:249:16: note: in expansion of macro '__xchg_relaxed'
     249 |         return __xchg_relaxed(&(v->counter), n, size);                  \
         |                ^~~~~~~~~~~~~~
   arch/riscv/include/asm/atomic.h:295:9: note: in expansion of macro 'ATOMIC_OP'
     295 |         ATOMIC_OP(int,   , 4)                                           \
         |         ^~~~~~~~~
   arch/riscv/include/asm/atomic.h:299:1: note: in expansion of macro 'ATOMIC_OPS'
     299 | ATOMIC_OPS()
         | ^~~~~~~~~~
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:121: kernel/bounds.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1191: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:219: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +/BUILD_BUG +35 arch/riscv/include/asm/cmpxchg.h

fab957c11efe2f Palmer Dabbelt 2017-07-10  13  
5ce6c1f3535fa8 Andrea Parri   2018-03-09  14  #define __xchg_relaxed(ptr, new, size)					\
fab957c11efe2f Palmer Dabbelt 2017-07-10  15  ({									\
fab957c11efe2f Palmer Dabbelt 2017-07-10  16  	__typeof__(ptr) __ptr = (ptr);					\
fab957c11efe2f Palmer Dabbelt 2017-07-10  17  	__typeof__(new) __new = (new);					\
fab957c11efe2f Palmer Dabbelt 2017-07-10  18  	__typeof__(*(ptr)) __ret;					\
fab957c11efe2f Palmer Dabbelt 2017-07-10  19  	switch (size) {							\
fab957c11efe2f Palmer Dabbelt 2017-07-10  20  	case 4:								\
fab957c11efe2f Palmer Dabbelt 2017-07-10  21  		__asm__ __volatile__ (					\
5ce6c1f3535fa8 Andrea Parri   2018-03-09  22  			"	amoswap.w %0, %2, %1\n"			\
fab957c11efe2f Palmer Dabbelt 2017-07-10  23  			: "=r" (__ret), "+A" (*__ptr)			\
fab957c11efe2f Palmer Dabbelt 2017-07-10  24  			: "r" (__new)					\
fab957c11efe2f Palmer Dabbelt 2017-07-10  25  			: "memory");					\
fab957c11efe2f Palmer Dabbelt 2017-07-10  26  		break;							\
fab957c11efe2f Palmer Dabbelt 2017-07-10  27  	case 8:								\
fab957c11efe2f Palmer Dabbelt 2017-07-10  28  		__asm__ __volatile__ (					\
5ce6c1f3535fa8 Andrea Parri   2018-03-09  29  			"	amoswap.d %0, %2, %1\n"			\
fab957c11efe2f Palmer Dabbelt 2017-07-10  30  			: "=r" (__ret), "+A" (*__ptr)			\
fab957c11efe2f Palmer Dabbelt 2017-07-10  31  			: "r" (__new)					\
fab957c11efe2f Palmer Dabbelt 2017-07-10  32  			: "memory");					\
fab957c11efe2f Palmer Dabbelt 2017-07-10  33  		break;							\
fab957c11efe2f Palmer Dabbelt 2017-07-10  34  	default:							\
fab957c11efe2f Palmer Dabbelt 2017-07-10 @35  		BUILD_BUG();						\
fab957c11efe2f Palmer Dabbelt 2017-07-10  36  	}								\
fab957c11efe2f Palmer Dabbelt 2017-07-10  37  	__ret;								\
fab957c11efe2f Palmer Dabbelt 2017-07-10  38  })
fab957c11efe2f Palmer Dabbelt 2017-07-10  39  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

  parent reply	other threads:[~2022-01-27  0:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 23:02 [PATCH v2 0/4] printk: reduce deadlocks during panic Stephen Brennan
2022-01-26 23:02 ` [PATCH v2 1/4] panic: Add panic_in_progress helper Stephen Brennan
2022-01-27  0:29   ` kernel test robot
2022-01-27  0:40   ` kernel test robot [this message]
2022-01-27 14:34   ` Petr Mladek
2022-01-27 16:02     ` Stephen Brennan
2022-01-28  8:24       ` Petr Mladek
2022-01-26 23:02 ` [PATCH v2 2/4] printk: disable optimistic spin during panic Stephen Brennan
2022-01-26 23:02 ` [PATCH v2 3/4] printk: Avoid livelock with heavy printk " Stephen Brennan
2022-01-27 14:50   ` Petr Mladek
2022-01-27 16:19     ` Stephen Brennan
2022-01-26 23:02 ` [PATCH v2 4/4] printk: Drop console_sem " Stephen Brennan
2022-01-27  9:22   ` John Ogness
2022-01-27 15:03     ` Petr Mladek
2022-01-28  5:55       ` Sergey Senozhatsky
2022-01-27 15:12   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202201270843.6F0l6Ntb-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.