From: Petr Mladek <pmladek@suse.com>
To: Stephen Brennan <stephen.s.brennan@oracle.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Arnd Bergmann <arnd@arndb.de>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
Sebastian Reichel <sre@kernel.org>,
John Ogness <john.ogness@linutronix.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] printk: Drop console_sem during panic
Date: Thu, 27 Jan 2022 16:12:58 +0100 [thread overview]
Message-ID: <YfK2ekZdiM/lJOEW@alley> (raw)
In-Reply-To: <20220126230236.750229-5-stephen.s.brennan@oracle.com>
On Wed 2022-01-26 15:02:36, Stephen Brennan wrote:
> If another CPU is in panic, we are about to be halted. Try to gracefully
> abandon the console_sem, leaving it free for the panic CPU to grab.
>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 18107db118d4..572363ff716f 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -2742,6 +2761,10 @@ void console_unlock(void)
> if (handover)
> return;
>
> + /* Allow panic_cpu to take over the consoles safely */
> + if (abandon_console_lock_in_panic())
> + break;
Hmm, it makes some sense to have it before cond_resched(). But I would
like to have it at the beginning of the cycle so that console_unlock()
might leave quickly without processing any single message.
We could have it in both (three) locations. But it might be over
cautious.
Anyway, the beginning is more important. Sleeping with console_sem is
less risky from the panic and races point of view.
Best Regards,
Petr
prev parent reply other threads:[~2022-01-27 15:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 23:02 [PATCH v2 0/4] printk: reduce deadlocks during panic Stephen Brennan
2022-01-26 23:02 ` [PATCH v2 1/4] panic: Add panic_in_progress helper Stephen Brennan
2022-01-27 0:29 ` kernel test robot
2022-01-27 0:40 ` kernel test robot
2022-01-27 14:34 ` Petr Mladek
2022-01-27 16:02 ` Stephen Brennan
2022-01-28 8:24 ` Petr Mladek
2022-01-26 23:02 ` [PATCH v2 2/4] printk: disable optimistic spin during panic Stephen Brennan
2022-01-26 23:02 ` [PATCH v2 3/4] printk: Avoid livelock with heavy printk " Stephen Brennan
2022-01-27 14:50 ` Petr Mladek
2022-01-27 16:19 ` Stephen Brennan
2022-01-26 23:02 ` [PATCH v2 4/4] printk: Drop console_sem " Stephen Brennan
2022-01-27 9:22 ` John Ogness
2022-01-27 15:03 ` Petr Mladek
2022-01-28 5:55 ` Sergey Senozhatsky
2022-01-27 15:12 ` Petr Mladek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfK2ekZdiM/lJOEW@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=sre@kernel.org \
--cc=stephen.s.brennan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.