All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/1] remove libiberty from target install
@ 2022-01-27 13:53 Jonathan Borne via buildroot
  2022-01-27 13:53 ` [Buildroot] [PATCH 1/1] package/binutils: " Jonathan Borne via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Borne via buildroot @ 2022-01-27 13:53 UTC (permalink / raw)
  To: buildroot; +Cc: ysionneau, jmaselbas, Jonathan Borne

Hi,
Following my earlier request for comment and your answers,
I'm providing this patch...

I hope this is Ok. This is pretty much my first patch submission...

Thanks again for your nice answers.

Best regards.
Jonathan.

Jonathan Borne (1):
  package/binutils: remove libiberty from target install

 package/binutils/binutils.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.17.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/binutils: remove libiberty from target install
  2022-01-27 13:53 [Buildroot] [PATCH 0/1] remove libiberty from target install Jonathan Borne via buildroot
@ 2022-01-27 13:53 ` Jonathan Borne via buildroot
  2022-01-27 21:18   ` Yann E. MORIN
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Borne via buildroot @ 2022-01-27 13:53 UTC (permalink / raw)
  To: buildroot; +Cc: ysionneau, jmaselbas, Jonathan Borne

In BINUTILS_INSTALL_TARGET_CMDS, libiberty is installed
to STAGING_DIR

This is not necessary since libiberty is already
unconditionally installed to staging in
BINUTILS_INSTALL_STAGING_CMDS. Furthermore the presence
of STAGING_DIR path in TARGET_CMDS is confusing.

Moreover libiberty is static only. Static libraries
are only used at build time, not at run time so
we do not want to install libiberty on target.

This commit removes the unnecessary libiberty
install in TARGET_CMDS and add a comment to clarify
why we do not see libiberty installed on target.

Signed-off-by: Jonathan Borne <jborne@kalray.eu>
---
 package/binutils/binutils.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
index 13f61be035..32ca70d325 100644
--- a/package/binutils/binutils.mk
+++ b/package/binutils/binutils.mk
@@ -95,6 +95,8 @@ BINUTILS_MAKE_ENV = $(TARGET_CONFIGURE_ARGS)
 
 # We just want libbfd, libiberty and libopcodes,
 # not the full-blown binutils in staging
+# Static-only libraries such as libiberty are used at buildtime in staging
+# but are not installed to target.
 define BINUTILS_INSTALL_STAGING_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(STAGING_DIR) install
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(STAGING_DIR) install
@@ -106,7 +108,6 @@ ifneq ($(BR2_PACKAGE_BINUTILS_TARGET),y)
 define BINUTILS_INSTALL_TARGET_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(TARGET_DIR) install
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(TARGET_DIR) install
-	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install
 endef
 endif
 
-- 
2.17.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/binutils: remove libiberty from target install
  2022-01-27 13:53 ` [Buildroot] [PATCH 1/1] package/binutils: " Jonathan Borne via buildroot
@ 2022-01-27 21:18   ` Yann E. MORIN
  2022-01-28  9:15     ` Jonathan Borne via buildroot
  0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2022-01-27 21:18 UTC (permalink / raw)
  To: Jonathan Borne; +Cc: ysionneau, jmaselbas, buildroot

Jonathan, All,

Thanks for this new iteration. :-)

On 2022-01-27 14:53 +0100, Jonathan Borne via buildroot spake thusly:
> In BINUTILS_INSTALL_TARGET_CMDS, libiberty is installed
> to STAGING_DIR
> 
> This is not necessary since libiberty is already
> unconditionally installed to staging in
> BINUTILS_INSTALL_STAGING_CMDS. Furthermore the presence
> of STAGING_DIR path in TARGET_CMDS is confusing.
> 
> Moreover libiberty is static only. Static libraries
> are only used at build time, not at run time so
> we do not want to install libiberty on target.
> 
> This commit removes the unnecessary libiberty
> install in TARGET_CMDS and add a comment to clarify
> why we do not see libiberty installed on target.

I've slightly reworded the commit log, and rewrapped it closer to the
usual 72-char width.

> Signed-off-by: Jonathan Borne <jborne@kalray.eu>
> ---
>  package/binutils/binutils.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
> index 13f61be035..32ca70d325 100644
> --- a/package/binutils/binutils.mk
> +++ b/package/binutils/binutils.mk
> @@ -95,6 +95,8 @@ BINUTILS_MAKE_ENV = $(TARGET_CONFIGURE_ARGS)
>  
>  # We just want libbfd, libiberty and libopcodes,
>  # not the full-blown binutils in staging
> +# Static-only libraries such as libiberty are used at buildtime in staging
> +# but are not installed to target.

I believe the comment in fact makes more sense closer to the
_ISNTALL_TARGET_CMDS, so I moved it there, and reworded it
appropriately.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  define BINUTILS_INSTALL_STAGING_CMDS
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(STAGING_DIR) install
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(STAGING_DIR) install
> @@ -106,7 +108,6 @@ ifneq ($(BR2_PACKAGE_BINUTILS_TARGET),y)
>  define BINUTILS_INSTALL_TARGET_CMDS
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(TARGET_DIR) install
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(TARGET_DIR) install
> -	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install
>  endef
>  endif
>  
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/binutils: remove libiberty from target install
  2022-01-27 21:18   ` Yann E. MORIN
@ 2022-01-28  9:15     ` Jonathan Borne via buildroot
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Borne via buildroot @ 2022-01-28  9:15 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: ysionneau, jmaselbas, Baruch Siach via buildroot



----- On Jan 27, 2022, at 10:18 PM, Yann E. MORIN yann.morin.1998@free.fr wrote:

> Jonathan, All,
> 
> Thanks for this new iteration. :-)
> 
> On 2022-01-27 14:53 +0100, Jonathan Borne via buildroot spake thusly:
>> In BINUTILS_INSTALL_TARGET_CMDS, libiberty is installed
>> to STAGING_DIR
>> 
>> This is not necessary since libiberty is already
>> unconditionally installed to staging in
>> BINUTILS_INSTALL_STAGING_CMDS. Furthermore the presence
>> of STAGING_DIR path in TARGET_CMDS is confusing.
>> 
>> Moreover libiberty is static only. Static libraries
>> are only used at build time, not at run time so
>> we do not want to install libiberty on target.
>> 
>> This commit removes the unnecessary libiberty
>> install in TARGET_CMDS and add a comment to clarify
>> why we do not see libiberty installed on target.
> 
> I've slightly reworded the commit log, and rewrapped it closer to the
> usual 72-char width.
> 

That's perfect. I will think about the wrapping next time.

>> Signed-off-by: Jonathan Borne <jborne@kalray.eu>
>> ---
>>  package/binutils/binutils.mk | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
>> index 13f61be035..32ca70d325 100644
>> --- a/package/binutils/binutils.mk
>> +++ b/package/binutils/binutils.mk
>> @@ -95,6 +95,8 @@ BINUTILS_MAKE_ENV = $(TARGET_CONFIGURE_ARGS)
>>  
>>  # We just want libbfd, libiberty and libopcodes,
>>  # not the full-blown binutils in staging
>> +# Static-only libraries such as libiberty are used at buildtime in staging
>> +# but are not installed to target.
> 
> I believe the comment in fact makes more sense closer to the
> _ISNTALL_TARGET_CMDS, so I moved it there, and reworded it
> appropriately.
> 

I hesitated a bit about the right place to put this comment but
that's definitively cleaner this way.

> Applied to master, thanks.
> 
> Regards,
> Yann E. MORIN.
> 

Nice! Thank you very much!

Best regards,
Jonathan

>>  define BINUTILS_INSTALL_STAGING_CMDS
>>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(STAGING_DIR) install
>>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(STAGING_DIR) install
>> @@ -106,7 +108,6 @@ ifneq ($(BR2_PACKAGE_BINUTILS_TARGET),y)
>>  define BINUTILS_INSTALL_TARGET_CMDS
>>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(TARGET_DIR) install
>>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(TARGET_DIR) install
>> -	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install
>>  endef
>>  endif
>>  
>> --
>> 2.17.1
>> 
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> --
> .-----------------.--------------------.------------------.--------------------.
>|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
>| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
>| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
>| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> 
> 
> To declare a filtering error, please use the following link :
> https://www.security-mail.net/reporter.php?mid=16157.61f30c1f.e3bf2.0&r=jborne%40kalray.eu&s=yann.morin.1998%40free.fr&o=Re%3A+%5BBuildroot%5D+%5BPATCH+1%2F1%5D+package%2Fbinutils%3A+remove+libiberty+from+target+install&verdict=C&c=175bda5746a47a6dc86efbf686983009e1fe0acd




_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-28  9:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-27 13:53 [Buildroot] [PATCH 0/1] remove libiberty from target install Jonathan Borne via buildroot
2022-01-27 13:53 ` [Buildroot] [PATCH 1/1] package/binutils: " Jonathan Borne via buildroot
2022-01-27 21:18   ` Yann E. MORIN
2022-01-28  9:15     ` Jonathan Borne via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.