[davidhildenbrand:single_zone 4/4] drivers/base/memory.c:648:13: sparse: sparse: symbol 'early_node_zone_for_memory_block' was not declared. Should it be static?

[davidhildenbrand:single_zone 4/4] drivers/base/memory.c:648:13: sparse: sparse: symbol 'early_node_zone_for_memory_block' was not declared. Should it be static?

[kernel test robot]

tree:   git://github.com/davidhildenbrand/linux single_zone
head:   176a3d535903312944f7489127f520c5494bc810
commit: 176a3d535903312944f7489127f520c5494bc810 [4/4] tmp
config: x86_64-randconfig-s021-20220124 (https://download.01.org/0day-ci/archive/20220128/202201280621.HyzMsDkU-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/davidhildenbrand/linux/commit/176a3d535903312944f7489127f520c5494bc810
        git remote add davidhildenbrand git://github.com/davidhildenbrand/linux
        git fetch --no-tags davidhildenbrand single_zone
        git checkout 176a3d535903312944f7489127f520c5494bc810
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/base/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/base/memory.c:648:13: sparse: sparse: symbol 'early_node_zone_for_memory_block' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[davidhildenbrand:single_zone 4/4] drivers/base/memory.c:648:13: sparse: sparse: symbol 'early_node_zone_for_memory_block' was not declared. Should it be static?

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]

tree:   git://github.com/davidhildenbrand/linux single_zone
head:   176a3d535903312944f7489127f520c5494bc810
commit: 176a3d535903312944f7489127f520c5494bc810 [4/4] tmp
config: x86_64-randconfig-s021-20220124 (https://download.01.org/0day-ci/archive/20220128/202201280621.HyzMsDkU-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/davidhildenbrand/linux/commit/176a3d535903312944f7489127f520c5494bc810
        git remote add davidhildenbrand git://github.com/davidhildenbrand/linux
        git fetch --no-tags davidhildenbrand single_zone
        git checkout 176a3d535903312944f7489127f520c5494bc810
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/base/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/base/memory.c:648:13: sparse: sparse: symbol 'early_node_zone_for_memory_block' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[RFC PATCH davidhildenbrand] early_node_zone_for_memory_block() can be static

[kernel test robot]

drivers/base/memory.c:648:13: warning: symbol 'early_node_zone_for_memory_block' was not declared. Should it be static?

Fixes: 176a3d535903 ("tmp")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 memory.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index fa20ca42862f4..0b396e4c30667 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -645,7 +645,7 @@ int register_memory(struct memory_block *memory)
 	return ret;
 }
 
-struct zone *early_node_zone_for_memory_block(int nid, struct memory_block *mem)
+static struct zone *early_node_zone_for_memory_block(int nid, struct memory_block *mem)
 {
 	const unsigned long start_pfn = section_nr_to_pfn(mem->start_section_nr);
 	const unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;

[RFC PATCH davidhildenbrand] early_node_zone_for_memory_block() can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

drivers/base/memory.c:648:13: warning: symbol 'early_node_zone_for_memory_block' was not declared. Should it be static?

Fixes: 176a3d535903 ("tmp")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 memory.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index fa20ca42862f4..0b396e4c30667 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -645,7 +645,7 @@ int register_memory(struct memory_block *memory)
 	return ret;
 }
 
-struct zone *early_node_zone_for_memory_block(int nid, struct memory_block *mem)
+static struct zone *early_node_zone_for_memory_block(int nid, struct memory_block *mem)
 {
 	const unsigned long start_pfn = section_nr_to_pfn(mem->start_section_nr);
 	const unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;