[PATCH] media: mtk-vcodec: fix platform_get_irq.cocci warnings

[PATCH] media: mtk-vcodec: fix platform_get_irq.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1814 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Yunfei Dong <yunfei.dong@mediatek.com>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: Steve Cho <stevecho@chromium.org>
CC: Hans Verkuil <hverkuil@xs4all.nl>
CC: Tiffany Lin <tiffany.lin@mediatek.com>
CC: "Andrew-CT Chen" <andrew-ct.chen@mediatek.com>
CC: Matthias Brugger <matthias.bgg@gmail.com>
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-mediatek(a)lists.infradead.org

From: kernel test robot <lkp@intel.com>

drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c:105:2-9: line 105 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: c05bada35f01 ("media: mtk-vcodec: Add to support multi hardware decode")
CC: Yunfei Dong <yunfei.dong@mediatek.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   git://linuxtv.org/hverkuil/media_tree.git for-v5.18i
head:   232e2106ba4413aa88143fba77fd717b22169b10
commit: c05bada35f015fb735a9c3830226ccbe2b05008f [82/111] media: mtk-vcodec: Add to support multi hardware decode
:::::: branch date: 23 hours ago
:::::: commit date: 5 days ago

Please take the patch only if it's a positive warning. Thanks!

 mtk_vcodec_dec_drv.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
@@ -102,7 +102,6 @@ static int mtk_vcodec_init_dec_resources
 
 	dev->dec_irq = platform_get_irq(pdev, 0);
 	if (dev->dec_irq < 0) {
-		dev_err(&pdev->dev, "failed to get irq number");
 		return dev->dec_irq;
 	}
 

[PATCH] media: mtk-vcodec: fix platform_get_irq.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Yunfei Dong <yunfei.dong@mediatek.com>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: Steve Cho <stevecho@chromium.org>
CC: Hans Verkuil <hverkuil@xs4all.nl>
CC: Tiffany Lin <tiffany.lin@mediatek.com>
CC: "Andrew-CT Chen" <andrew-ct.chen@mediatek.com>
CC: Matthias Brugger <matthias.bgg@gmail.com>
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-mediatek(a)lists.infradead.org

From: kernel test robot <lkp@intel.com>

drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c:102:2-9: line 102 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: c05bada35f01 ("media: mtk-vcodec: Add to support multi hardware decode")
CC: Yunfei Dong <yunfei.dong@mediatek.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   git://linuxtv.org/hverkuil/media_tree.git for-v5.18i
head:   232e2106ba4413aa88143fba77fd717b22169b10
commit: c05bada35f015fb735a9c3830226ccbe2b05008f [82/111] media: mtk-vcodec: Add to support multi hardware decode
:::::: branch date: 23 hours ago
:::::: commit date: 5 days ago

Please take the patch only if it's a positive warning. Thanks!

 mtk_vcodec_dec_hw.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c
@@ -99,7 +99,6 @@ static int mtk_vdec_hw_init_irq(struct m
 
 	dev->dec_irq = platform_get_irq(pdev, 0);
 	if (dev->dec_irq < 0) {
-		dev_err(&pdev->dev, "Failed to get irq resource");
 		return dev->dec_irq;
 	}
 

[hverkuil-media-tree:for-v5.18i 82/111] drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c:105:2-9: line 105 is redundant because platform_get_irq() already prints an error

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Yunfei Dong <yunfei.dong@mediatek.com>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: Steve Cho <stevecho@chromium.org>
CC: Hans Verkuil <hverkuil@xs4all.nl>

tree:   git://linuxtv.org/hverkuil/media_tree.git for-v5.18i
head:   232e2106ba4413aa88143fba77fd717b22169b10
commit: c05bada35f015fb735a9c3830226ccbe2b05008f [82/111] media: mtk-vcodec: Add to support multi hardware decode
:::::: branch date: 24 hours ago
:::::: commit date: 5 days ago
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220128/202201281603.YgWZ0q17-lkp(a)intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c:105:2-9: line 105 is redundant because platform_get_irq() already prints an error
--
>> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c:102:2-9: line 102 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org