All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Ghiti <alexandre.ghiti@canonical.com>
To: Rick Chen <rick@andestech.com>, Leo <ycliang@andestech.com>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	u-boot@lists.denx.de
Cc: Alexandre Ghiti <alexandre.ghiti@canonical.com>
Subject: [PATCH] riscv: Fix build against binutils 2.38
Date: Fri, 28 Jan 2022 14:47:13 +0100	[thread overview]
Message-ID: <20220128134713.2322800-1-alexandre.ghiti@canonical.com> (raw)

The following description is copied from the equivalent patch for the
Linux Kernel proposed by Aurelien Jarno:

From version 2.38, binutils default to ISA spec version 20191213. This
means that the csr read/write (csrr*/csrw*) instructions and fence.i
instruction has separated from the `I` extension, become two standalone
extensions: Zicsr and Zifencei. As the kernel uses those instruction,
this causes the following build failure:

arch/riscv/cpu/mtrap.S: Assembler messages:
arch/riscv/cpu/mtrap.S:65: Error: unrecognized opcode `csrr a0,scause'
arch/riscv/cpu/mtrap.S:66: Error: unrecognized opcode `csrr a1,sepc'
arch/riscv/cpu/mtrap.S:67: Error: unrecognized opcode `csrr a2,stval'
arch/riscv/cpu/mtrap.S:70: Error: unrecognized opcode `csrw sepc,a0'

Signed-off-by: Alexandre Ghiti <alexandre.ghiti@canonical.com>
---
 arch/riscv/Makefile | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
index 0b80eb8d86..53d1194ffb 100644
--- a/arch/riscv/Makefile
+++ b/arch/riscv/Makefile
@@ -24,7 +24,16 @@ ifeq ($(CONFIG_CMODEL_MEDANY),y)
 	CMODEL = medany
 endif
 
-ARCH_FLAGS = -march=$(ARCH_BASE)$(ARCH_A)$(ARCH_C) -mabi=$(ABI) \
+RISCV_MARCH = $(ARCH_BASE)$(ARCH_A)$(ARCH_C)
+
+# Newer binutils versions default to ISA spec version 20191213 which moves some
+# instructions from the I extension to the Zicsr and Zifencei extensions.
+toolchain-need-zicsr-zifencei := $(call cc-option-yn, -mabi=$(ABI) -march=$(RISCV_MARCH)_zicsr_zifencei)
+ifeq ($(toolchain-need-zicsr-zifencei),y)
+	RISCV_MARCH := $(RISCV_MARCH)_zicsr_zifencei
+endif
+
+ARCH_FLAGS = -march=$(RISCV_MARCH) -mabi=$(ABI) \
 	     -mcmodel=$(CMODEL)
 
 PLATFORM_CPPFLAGS	+= $(ARCH_FLAGS)
-- 
2.32.0


             reply	other threads:[~2022-01-28 13:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 13:47 Alexandre Ghiti [this message]
2022-01-28 14:15 ` [PATCH] riscv: Fix build against binutils 2.38 Bin Meng
2022-01-28 18:03 ` Heinrich Schuchardt
2022-01-28 18:19   ` Aurelien Jarno
2022-01-28 18:28     ` Aurelien Jarno
2022-01-28 18:22   ` Heinrich Schuchardt
2022-02-17  9:24 ` Leo Liang
2022-02-17 10:28   ` Alexandre Ghiti
2022-02-19  8:51     ` Leo Liang
2022-02-21 16:42       ` Alexandre Ghiti
2022-03-01  3:21         ` Leo Liang
2022-03-03 11:06           ` Leo Liang
2022-03-09  6:31             ` Leo Liang
2022-03-10  8:03               ` Alexandre Ghiti
2022-04-07  9:12                 ` Leo Liang
2022-04-12  9:14                   ` Alexandre Ghiti
2022-04-13  1:49                     ` Leo Liang
2022-10-01 23:24               ` Heinrich Schuchardt
2022-10-01 23:57                 ` Tom Rini
2022-10-02  1:52                   ` Heinrich Schuchardt
2022-10-02 17:16                     ` Tom Rini
2022-10-02 17:25                       ` Tom Rini
2022-06-23 13:40 ` Heiko Stübner
2022-08-30 20:28   ` Christian Stewart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220128134713.2322800-1-alexandre.ghiti@canonical.com \
    --to=alexandre.ghiti@canonical.com \
    --cc=aurelien@aurel32.net \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=rick@andestech.com \
    --cc=u-boot@lists.denx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.