All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Stewart <christian@paral.in>
To: Heiko <heiko@sntech.de>
Cc: Rick Chen <rick@andestech.com>,  Leo <ycliang@andestech.com>,
	 Aurelien Jarno <aurelien@aurel32.net>,
	 Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	 u-boot@lists.denx.de,
	 Alexandre Ghiti <alexandre.ghiti@canonical.com>,
	 Coelacanthus <coelacanthus@outlook.com>
Subject: Re: [PATCH] riscv: Fix build against binutils 2.38
Date: Tue, 30 Aug 2022 13:28:56 -0700	[thread overview]
Message-ID: <87sfldfpbr.fsf@paral.in> (raw)
In-Reply-To: <2249202.ElGaqSPkdT@diego> (heiko@sntech.de's message of "Thu, 23 Jun 2022 15:40:18 +0200")


Hi all,

Am Freitag, 28. Januar 2022, 14:47:13 CEST schrieb Alexandre Ghiti:
> The following description is copied from the equivalent patch for the
> Linux Kernel proposed by Aurelien Jarno:
> 
> From version 2.38, binutils default to ISA spec version 20191213. This
> means that the csr read/write (csrr*/csrw*) instructions and fence.i
> instruction has separated from the `I` extension, become two standalone
> extensions: Zicsr and Zifencei. As the kernel uses those instruction,
> this causes the following build failure:
> 
> arch/riscv/cpu/mtrap.S: Assembler messages:
> arch/riscv/cpu/mtrap.S:65: Error: unrecognized opcode `csrr a0,scause'
> arch/riscv/cpu/mtrap.S:66: Error: unrecognized opcode `csrr a1,sepc'
> arch/riscv/cpu/mtrap.S:67: Error: unrecognized opcode `csrr a2,stval'
> arch/riscv/cpu/mtrap.S:70: Error: unrecognized opcode `csrw sepc,a0'
> 
> Signed-off-by: Alexandre Ghiti <alexandre.ghiti@canonical.com>

Heiko wrote:
> Is there progress in getting this patch applied to u-boot in some way?
> Also it looks like there was another patch with similar content submitted
> recently [0].
>
> In any case:
>
> On a D1-Nezha it fixes the build (and boot)
> Tested-by: Heiko Stuebner <heiko@sntech.de>

Fixes the boot with u-boot in Buildroot:

[0] https://lore.kernel.org/all/PH7PR14MB5594FD11D1BE74284F554BEBCED49@PH7PR14MB5594.namprd14.prod.outlook.com/
[1] https://github.com/skiffos/u-boot/commit/3bb93519563146419aa06e8d21394089163302b6

This is for a few Risc-v boards based on D1.

Tested-by: Christian Stewart <christian@paral.in>

Thanks & best,
Christian Stewart

      reply	other threads:[~2022-08-30 21:07 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 13:47 [PATCH] riscv: Fix build against binutils 2.38 Alexandre Ghiti
2022-01-28 14:15 ` Bin Meng
2022-01-28 18:03 ` Heinrich Schuchardt
2022-01-28 18:19   ` Aurelien Jarno
2022-01-28 18:28     ` Aurelien Jarno
2022-01-28 18:22   ` Heinrich Schuchardt
2022-02-17  9:24 ` Leo Liang
2022-02-17 10:28   ` Alexandre Ghiti
2022-02-19  8:51     ` Leo Liang
2022-02-21 16:42       ` Alexandre Ghiti
2022-03-01  3:21         ` Leo Liang
2022-03-03 11:06           ` Leo Liang
2022-03-09  6:31             ` Leo Liang
2022-03-10  8:03               ` Alexandre Ghiti
2022-04-07  9:12                 ` Leo Liang
2022-04-12  9:14                   ` Alexandre Ghiti
2022-04-13  1:49                     ` Leo Liang
2022-10-01 23:24               ` Heinrich Schuchardt
2022-10-01 23:57                 ` Tom Rini
2022-10-02  1:52                   ` Heinrich Schuchardt
2022-10-02 17:16                     ` Tom Rini
2022-10-02 17:25                       ` Tom Rini
2022-06-23 13:40 ` Heiko Stübner
2022-08-30 20:28   ` Christian Stewart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfldfpbr.fsf@paral.in \
    --to=christian@paral.in \
    --cc=alexandre.ghiti@canonical.com \
    --cc=aurelien@aurel32.net \
    --cc=coelacanthus@outlook.com \
    --cc=heiko@sntech.de \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=rick@andestech.com \
    --cc=u-boot@lists.denx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.