[PATCH] ALSA: hda/realtek: Add quirk for ASUS GU603

[PATCH] ALSA: hda/realtek: Add quirk for ASUS GU603

[Albert Geanta]

The ASUS GU603 (Zephyrus M16 - SSID 1043:16b2) requires a quirk similar to
other ASUS devices for correctly routing the 4 integrated speakers. This
fixes it by adding a corresponding quirk entry, which connects the bass
speakers to the proper DAC.

Signed-off-by: Albert Geantă <albertgeanta@gmail.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 668274e52674..61b314c7dbc9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8969,6 +8969,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS),
 	SND_PCI_QUIRK(0x1043, 0x1e8e, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA401),
 	SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401),
+	SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
 	SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE", ALC256_FIXUP_ASUS_AIO_GPIO2),
 	SND_PCI_QUIRK(0x1043, 0x831a, "ASUS P901", ALC269_FIXUP_STEREO_DMIC),
 	SND_PCI_QUIRK(0x1043, 0x834a, "ASUS S101", ALC269_FIXUP_STEREO_DMIC),
-- 
2.35.1

Re: [PATCH] ALSA: hda/realtek: Add quirk for ASUS GU603

[Greg KH]

On Mon, Jan 31, 2022 at 03:05:23AM +0200, Albert Geanta wrote:
> The ASUS GU603 (Zephyrus M16 - SSID 1043:16b2) requires a quirk similar to
> other ASUS devices for correctly routing the 4 integrated speakers. This
> fixes it by adding a corresponding quirk entry, which connects the bass
> speakers to the proper DAC.
> 
> Signed-off-by: Albert Geantă <albertgeanta@gmail.com>
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 668274e52674..61b314c7dbc9 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -8969,6 +8969,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS),
>  	SND_PCI_QUIRK(0x1043, 0x1e8e, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA401),
>  	SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401),
> +	SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
>  	SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE", ALC256_FIXUP_ASUS_AIO_GPIO2),
>  	SND_PCI_QUIRK(0x1043, 0x831a, "ASUS P901", ALC269_FIXUP_STEREO_DMIC),
>  	SND_PCI_QUIRK(0x1043, 0x834a, "ASUS S101", ALC269_FIXUP_STEREO_DMIC),
> -- 
> 2.35.1
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Re: [PATCH] ALSA: hda/realtek: Add quirk for ASUS GU603

[Takashi Iwai]

On Mon, 31 Jan 2022 02:05:23 +0100,
Albert Geanta wrote:
> 
> The ASUS GU603 (Zephyrus M16 - SSID 1043:16b2) requires a quirk similar to
> other ASUS devices for correctly routing the 4 integrated speakers. This
> fixes it by adding a corresponding quirk entry, which connects the bass
> speakers to the proper DAC.
> 
> Signed-off-by: Albert Geantă <albertgeanta@gmail.com>

Thanks, I applied the patch now with the manual addition of
Cc-to-stable tag.

At the next time, however, please don't forget to put Cc-to-stable in
the patch itself, as Greg already complained.

Also, try to align both From and Signed-off-by name/address strings.
In this patch, only Signed-off was with an accent, too.

Last but not least, please put the maintainers to Cc at the next
submission.


thanks,

Takashi