From: Jonathan Woithe <jwoithe@just42.net>
To: Chuck Lever III <chuck.lever@oracle.com>
Cc: Bruce Fields <bfields@fieldses.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] lockd: fix server crash on reboot of client holding lock
Date: Tue, 1 Feb 2022 08:50:20 +1030 [thread overview]
Message-ID: <20220131222020.GB12905@marvin.atrad.com.au> (raw)
In-Reply-To: <6349BB98-FB18-4ABC-A893-1CCB1E5CA3E5@oracle.com>
On Wed, Jan 19, 2022 at 04:18:10PM +0000, Chuck Lever III wrote:
> > On Jan 18, 2022, at 5:00 PM, Bruce Fields <bfields@fieldses.org> wrote:
> >
> > From: "J. Bruce Fields" <bfields@redhat.com>
> >
> > I thought I was iterating over the array when actually the iteration is
> > over the values contained in the array?
> >
> > Ugh, keep it simple.
> >
> > Symptoms were a null deference in vfs_lock_file() when an NFSv3 client
> > that previously held a lock came back up and sent a notify.
> >
> > Reported-by: Jonathan Woithe <jwoithe@just42.net>
> > Fixes: 7f024fcd5c97 ("Keep read and write fds with each nlm_file")
> > Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> > ---
> > :
> Hi Bruce, thanks for the fixes. They've passed my basic smoke tests.
> I've applied both patches for the very next nfsd PR. See:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git for-next
OOI, is it expected that these fixes will appear in a 5.15.x stable branch
patch at some point? I've looked at the 5.15.17 and 5.15.18 changelogs and
they don't appear to be mentioned yet.
Regards
jonathan
next prev parent reply other threads:[~2022-01-31 22:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 10:39 [Bug report] Recurring oops, 5.15.x, possibly during or soon after client mount Jonathan Woithe
2022-01-14 15:18 ` Chuck Lever III
2022-01-15 8:14 ` Jonathan Woithe
2022-01-15 19:46 ` Chuck Lever III
2022-01-15 21:23 ` Jonathan Woithe
2022-01-16 22:06 ` Jonathan Woithe
2022-01-16 22:30 ` Chuck Lever III
2022-01-17 7:44 ` Jonathan Woithe
2022-01-17 22:08 ` Jonathan Woithe
2022-01-17 22:11 ` Bruce Fields
2022-01-18 22:00 ` [PATCH 1/2] lockd: fix server crash on reboot of client holding lock Bruce Fields
2022-01-18 22:00 ` [PATCH 2/2] lockd: fix failure to cleanup client locks Bruce Fields
2022-01-18 22:20 ` [PATCH 1/2] lockd: fix server crash on reboot of client holding lock Jonathan Woithe
2022-01-18 22:27 ` Bruce Fields
2022-03-23 23:33 ` Jonathan Woithe
2022-03-24 18:28 ` Bruce Fields
2022-01-19 16:18 ` Chuck Lever III
2022-01-31 22:20 ` Jonathan Woithe [this message]
2022-02-01 2:10 ` Chuck Lever III
2022-01-17 15:50 ` [Bug report] Recurring oops, 5.15.x, possibly during or soon after client mount Bruce Fields
2022-01-17 18:22 ` Chuck Lever III
2022-01-17 15:47 ` Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131222020.GB12905@marvin.atrad.com.au \
--to=jwoithe@just42.net \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.