Re: [PATCH 1/2] lockd: fix server crash on reboot of client holding lock

[Bruce Fields <bfields@fieldses.org>]

On Thu, Mar 24, 2022 at 10:03:23AM +1030, Jonathan Woithe wrote:
> On Tue, Jan 18, 2022 at 05:27:03PM -0500, Bruce Fields wrote:
> > On Wed, Jan 19, 2022 at 08:50:50AM +1030, Jonathan Woithe wrote:
> > > On Tue, Jan 18, 2022 at 05:00:16PM -0500, Bruce Fields wrote:
> > > > From: "J. Bruce Fields" <bfields@redhat.com>
> > > > 
> > > > I thought I was iterating over the array when actually the iteration is
> > > > over the values contained in the array?
> > > > :
> > > 
> > > Would you like me to apply this against a 5.15.x kernel and test locally? 
> > > Or should I just wait for a 5.15.x stable series update which includes it?
> > 
> > I'm pretty confident I'm reproducing the same problem you saw, so it'd
> > be fine to just wait for an update.
> > 
> > (But if you do test these patches, let us know, one more confirmation
> > never hurts.)
> 
> The shift back to a 5.15.x kernel ended up being delayed for a while for
> various reasons.  The server concerned was eventually upgraded to 5.15.27 on
> 9 March 2022.  In that time, client machines have been turned on and off and
> inevitably the conditions which caused the crash have been exercised many
> times (libreoffice, firefox and thunderbird are used daily on almost all of
> the clients).  The server has not experienced the crash since the upgrade. 
> On the basis of this I think it's fair to consider our problem solved.

Thanks for the confirmation.--b.