* sound/soc/amd/vangogh/acp5x-mach.c:190 acp5x_cs35l41_hw_params() error: uninitialized symbol 'ret'.
@ 2022-01-31 23:31 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2022-01-31 23:31 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4132 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
CC: Mark Brown <broonie@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 26291c54e111ff6ba87a164d85d4a4e134b7315c
commit: 96792fdd77cd19fcf2368e7c19bb8b78557ae425 ASoC: amd: enable vangogh platform machine driver build
date: 4 months ago
:::::: branch date: 31 hours ago
:::::: commit date: 4 months ago
config: x86_64-randconfig-m001-20220131 (https://download.01.org/0day-ci/archive/20220201/202202010421.VYOO1bXN-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/amd/vangogh/acp5x-mach.c:190 acp5x_cs35l41_hw_params() error: uninitialized symbol 'ret'.
vim +/ret +190 sound/soc/amd/vangogh/acp5x-mach.c
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 157
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 158 static int acp5x_cs35l41_hw_params(struct snd_pcm_substream *substream,
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 159 struct snd_pcm_hw_params *params)
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 160 {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 161 struct snd_soc_pcm_runtime *rtd = substream->private_data;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 162 struct snd_soc_card *card = rtd->card;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 163 struct snd_soc_dai *codec_dai;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 164 int ret, i;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 165 unsigned int num_codecs = rtd->num_codecs;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 166 unsigned int bclk_val;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 167
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 168 for (i = 0; i < num_codecs; i++) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 169 codec_dai = asoc_rtd_to_codec(rtd, i);
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 170 if ((strcmp(codec_dai->name, "spi-VLV1776:00") == 0) ||
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 171 (strcmp(codec_dai->name, "spi-VLV1776:01") == 0)) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 172 switch (params_rate(params)) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 173 case 48000:
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 174 bclk_val = 1536000;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 175 break;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 176 default:
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 177 dev_err(card->dev, "Invalid Samplerate:0x%x\n",
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 178 params_rate(params));
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 179 return -EINVAL;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 180 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 181 ret = snd_soc_component_set_sysclk(codec_dai->component,
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 182 0, 0, bclk_val, SND_SOC_CLOCK_IN);
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 183 if (ret < 0) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 184 dev_err(card->dev, "failed to set sysclk for CS35l41 dai\n");
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 185 return ret;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 186 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 187 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 188 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 189
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 @190 return ret;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 191 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 192
:::::: The code at line 190 was first introduced by commit
:::::: 34a0094b9ff7b7544591a6841f9b61747033f292 ASoC: amd: add vangogh machine driver
:::::: TO: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* sound/soc/amd/vangogh/acp5x-mach.c:190 acp5x_cs35l41_hw_params() error: uninitialized symbol 'ret'.
@ 2022-01-31 3:54 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2022-01-31 3:54 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4191 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
CC: Mark Brown <broonie@kernel.org>
Hi Vijendar,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 26291c54e111ff6ba87a164d85d4a4e134b7315c
commit: 96792fdd77cd19fcf2368e7c19bb8b78557ae425 ASoC: amd: enable vangogh platform machine driver build
date: 4 months ago
:::::: branch date: 14 hours ago
:::::: commit date: 4 months ago
config: x86_64-randconfig-m001-20220131 (https://download.01.org/0day-ci/archive/20220131/202201311159.FJsrC79q-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/amd/vangogh/acp5x-mach.c:190 acp5x_cs35l41_hw_params() error: uninitialized symbol 'ret'.
vim +/ret +190 sound/soc/amd/vangogh/acp5x-mach.c
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 157
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 158 static int acp5x_cs35l41_hw_params(struct snd_pcm_substream *substream,
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 159 struct snd_pcm_hw_params *params)
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 160 {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 161 struct snd_soc_pcm_runtime *rtd = substream->private_data;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 162 struct snd_soc_card *card = rtd->card;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 163 struct snd_soc_dai *codec_dai;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 164 int ret, i;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 165 unsigned int num_codecs = rtd->num_codecs;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 166 unsigned int bclk_val;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 167
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 168 for (i = 0; i < num_codecs; i++) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 169 codec_dai = asoc_rtd_to_codec(rtd, i);
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 170 if ((strcmp(codec_dai->name, "spi-VLV1776:00") == 0) ||
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 171 (strcmp(codec_dai->name, "spi-VLV1776:01") == 0)) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 172 switch (params_rate(params)) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 173 case 48000:
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 174 bclk_val = 1536000;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 175 break;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 176 default:
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 177 dev_err(card->dev, "Invalid Samplerate:0x%x\n",
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 178 params_rate(params));
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 179 return -EINVAL;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 180 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 181 ret = snd_soc_component_set_sysclk(codec_dai->component,
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 182 0, 0, bclk_val, SND_SOC_CLOCK_IN);
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 183 if (ret < 0) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 184 dev_err(card->dev, "failed to set sysclk for CS35l41 dai\n");
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 185 return ret;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 186 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 187 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 188 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 189
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 @190 return ret;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 191 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 192
:::::: The code at line 190 was first introduced by commit
:::::: 34a0094b9ff7b7544591a6841f9b61747033f292 ASoC: amd: add vangogh machine driver
:::::: TO: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* sound/soc/amd/vangogh/acp5x-mach.c:190 acp5x_cs35l41_hw_params() error: uninitialized symbol 'ret'.
@ 2021-12-16 4:43 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2021-12-16 4:43 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4188 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
CC: Mark Brown <broonie@kernel.org>
Hi Vijendar,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2b14864acbaaf03d9c01982e243a84632524c3ac
commit: 96792fdd77cd19fcf2368e7c19bb8b78557ae425 ASoC: amd: enable vangogh platform machine driver build
date: 9 weeks ago
:::::: branch date: 9 hours ago
:::::: commit date: 9 weeks ago
config: x86_64-randconfig-m001-20211215 (https://download.01.org/0day-ci/archive/20211216/202112161210.taedkEiN-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/amd/vangogh/acp5x-mach.c:190 acp5x_cs35l41_hw_params() error: uninitialized symbol 'ret'.
vim +/ret +190 sound/soc/amd/vangogh/acp5x-mach.c
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 157
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 158 static int acp5x_cs35l41_hw_params(struct snd_pcm_substream *substream,
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 159 struct snd_pcm_hw_params *params)
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 160 {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 161 struct snd_soc_pcm_runtime *rtd = substream->private_data;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 162 struct snd_soc_card *card = rtd->card;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 163 struct snd_soc_dai *codec_dai;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 164 int ret, i;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 165 unsigned int num_codecs = rtd->num_codecs;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 166 unsigned int bclk_val;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 167
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 168 for (i = 0; i < num_codecs; i++) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 169 codec_dai = asoc_rtd_to_codec(rtd, i);
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 170 if ((strcmp(codec_dai->name, "spi-VLV1776:00") == 0) ||
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 171 (strcmp(codec_dai->name, "spi-VLV1776:01") == 0)) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 172 switch (params_rate(params)) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 173 case 48000:
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 174 bclk_val = 1536000;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 175 break;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 176 default:
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 177 dev_err(card->dev, "Invalid Samplerate:0x%x\n",
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 178 params_rate(params));
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 179 return -EINVAL;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 180 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 181 ret = snd_soc_component_set_sysclk(codec_dai->component,
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 182 0, 0, bclk_val, SND_SOC_CLOCK_IN);
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 183 if (ret < 0) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 184 dev_err(card->dev, "failed to set sysclk for CS35l41 dai\n");
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 185 return ret;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 186 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 187 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 188 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 189
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 @190 return ret;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 191 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 192
:::::: The code at line 190 was first introduced by commit
:::::: 34a0094b9ff7b7544591a6841f9b61747033f292 ASoC: amd: add vangogh machine driver
:::::: TO: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* sound/soc/amd/vangogh/acp5x-mach.c:190 acp5x_cs35l41_hw_params() error: uninitialized symbol 'ret'.
@ 2021-12-07 6:07 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2021-12-07 6:07 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4129 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
CC: Mark Brown <broonie@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: cd8c917a56f20f48748dd43d9ae3caff51d5b987
commit: 96792fdd77cd19fcf2368e7c19bb8b78557ae425 ASoC: amd: enable vangogh platform machine driver build
date: 8 weeks ago
:::::: branch date: 5 hours ago
:::::: commit date: 8 weeks ago
config: x86_64-randconfig-m001-20211201 (https://download.01.org/0day-ci/archive/20211207/202112071329.eX6ekOgK-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/amd/vangogh/acp5x-mach.c:190 acp5x_cs35l41_hw_params() error: uninitialized symbol 'ret'.
vim +/ret +190 sound/soc/amd/vangogh/acp5x-mach.c
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 157
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 158 static int acp5x_cs35l41_hw_params(struct snd_pcm_substream *substream,
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 159 struct snd_pcm_hw_params *params)
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 160 {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 161 struct snd_soc_pcm_runtime *rtd = substream->private_data;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 162 struct snd_soc_card *card = rtd->card;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 163 struct snd_soc_dai *codec_dai;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 164 int ret, i;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 165 unsigned int num_codecs = rtd->num_codecs;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 166 unsigned int bclk_val;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 167
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 168 for (i = 0; i < num_codecs; i++) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 169 codec_dai = asoc_rtd_to_codec(rtd, i);
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 170 if ((strcmp(codec_dai->name, "spi-VLV1776:00") == 0) ||
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 171 (strcmp(codec_dai->name, "spi-VLV1776:01") == 0)) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 172 switch (params_rate(params)) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 173 case 48000:
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 174 bclk_val = 1536000;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 175 break;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 176 default:
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 177 dev_err(card->dev, "Invalid Samplerate:0x%x\n",
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 178 params_rate(params));
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 179 return -EINVAL;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 180 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 181 ret = snd_soc_component_set_sysclk(codec_dai->component,
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 182 0, 0, bclk_val, SND_SOC_CLOCK_IN);
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 183 if (ret < 0) {
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 184 dev_err(card->dev, "failed to set sysclk for CS35l41 dai\n");
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 185 return ret;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 186 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 187 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 188 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 189
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 @190 return ret;
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 191 }
34a0094b9ff7b7 Vijendar Mukunda 2021-10-14 192
:::::: The code at line 190 was first introduced by commit
:::::: 34a0094b9ff7b7544591a6841f9b61747033f292 ASoC: amd: add vangogh machine driver
:::::: TO: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* sound/soc/amd/vangogh/acp5x-mach.c:190 acp5x_cs35l41_hw_params() error: uninitialized symbol 'ret'.
@ 2021-12-02 2:47 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2021-12-02 2:47 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4166 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
CC: Mark Brown <broonie@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 58e1100fdc5990b0cc0d4beaf2562a92e621ac7d
commit: 96792fdd77cd19fcf2368e7c19bb8b78557ae425 ASoC: amd: enable vangogh platform machine driver build
date: 7 weeks ago
:::::: branch date: 29 hours ago
:::::: commit date: 7 weeks ago
config: x86_64-randconfig-m001-20211201 (https://download.01.org/0day-ci/archive/20211202/202112021050.OPtN50Tj-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
sound/soc/amd/vangogh/acp5x-mach.c:190 acp5x_cs35l41_hw_params() error: uninitialized symbol 'ret'.
vim +/ret +190 sound/soc/amd/vangogh/acp5x-mach.c
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 157
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 158 static int acp5x_cs35l41_hw_params(struct snd_pcm_substream *substream,
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 159 struct snd_pcm_hw_params *params)
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 160 {
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 161 struct snd_soc_pcm_runtime *rtd = substream->private_data;
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 162 struct snd_soc_card *card = rtd->card;
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 163 struct snd_soc_dai *codec_dai;
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 164 int ret, i;
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 165 unsigned int num_codecs = rtd->num_codecs;
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 166 unsigned int bclk_val;
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 167
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 168 for (i = 0; i < num_codecs; i++) {
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 169 codec_dai = asoc_rtd_to_codec(rtd, i);
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 170 if ((strcmp(codec_dai->name, "spi-VLV1776:00") == 0) ||
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 171 (strcmp(codec_dai->name, "spi-VLV1776:01") == 0)) {
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 172 switch (params_rate(params)) {
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 173 case 48000:
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 174 bclk_val = 1536000;
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 175 break;
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 176 default:
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 177 dev_err(card->dev, "Invalid Samplerate:0x%x\n",
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 178 params_rate(params));
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 179 return -EINVAL;
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 180 }
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 181 ret = snd_soc_component_set_sysclk(codec_dai->component,
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 182 0, 0, bclk_val, SND_SOC_CLOCK_IN);
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 183 if (ret < 0) {
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 184 dev_err(card->dev, "failed to set sysclk for CS35l41 dai\n");
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 185 return ret;
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 186 }
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 187 }
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 188 }
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 189
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 @190 return ret;
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 191 }
34a0094b9ff7b75 Vijendar Mukunda 2021-10-14 192
:::::: The code at line 190 was first introduced by commit
:::::: 34a0094b9ff7b7544591a6841f9b61747033f292 ASoC: amd: add vangogh machine driver
:::::: TO: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-31 23:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-31 23:31 sound/soc/amd/vangogh/acp5x-mach.c:190 acp5x_cs35l41_hw_params() error: uninitialized symbol 'ret' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-01-31 3:54 kernel test robot
2021-12-16 4:43 kernel test robot
2021-12-07 6:07 kernel test robot
2021-12-02 2:47 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.