* [PATCH 1/3] cve-check: create directory before copy
@ 2022-02-01 16:16 Stefan Herbrechtsmeier
2022-02-01 16:16 ` [PATCH 2/3] systemd: Add link-udev-shared PACKAGECONFIG Stefan Herbrechtsmeier
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-01 16:16 UTC (permalink / raw)
To: openembedded-core; +Cc: Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
---
meta/classes/cve-check.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
index 70d1988a70..a4d735c323 100644
--- a/meta/classes/cve-check.bbclass
+++ b/meta/classes/cve-check.bbclass
@@ -143,6 +143,7 @@ python cve_check_write_rootfs_manifest () {
manifest_name = d.getVar("CVE_CHECK_MANIFEST")
cve_tmp_file = d.getVar("CVE_CHECK_TMP_FILE")
+ bb.utils.mkdirhier(os.path.dirname(manifest_name))
shutil.copyfile(cve_tmp_file, manifest_name)
if manifest_name and os.path.exists(manifest_name):
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] systemd: Add link-udev-shared PACKAGECONFIG
2022-02-01 16:16 [PATCH 1/3] cve-check: create directory before copy Stefan Herbrechtsmeier
@ 2022-02-01 16:16 ` Stefan Herbrechtsmeier
2022-02-01 16:16 ` [PATCH 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd Stefan Herbrechtsmeier
2022-02-01 17:00 ` [OE-core] [PATCH 1/3] cve-check: create directory before copy Alexander Kanavin
2 siblings, 0 replies; 6+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-01 16:16 UTC (permalink / raw)
To: openembedded-core; +Cc: Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
Add a PACKAGECONFIG to link systemd-udev and its helpers to
libsystemd-shared.so. If enabled the udev package depends on the systemd
package.
Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
---
meta/recipes-core/systemd/systemd_249.7.bb | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/meta/recipes-core/systemd/systemd_249.7.bb b/meta/recipes-core/systemd/systemd_249.7.bb
index 53e7f6738d..739f3aae86 100644
--- a/meta/recipes-core/systemd/systemd_249.7.bb
+++ b/meta/recipes-core/systemd/systemd_249.7.bb
@@ -156,6 +156,9 @@ PACKAGECONFIG[kmod] = "-Dkmod=true,-Dkmod=false,kmod"
PACKAGECONFIG[ldconfig] = "-Dldconfig=true,-Dldconfig=false,,ldconfig"
PACKAGECONFIG[libidn] = "-Dlibidn=true,-Dlibidn=false,libidn,,libidn"
PACKAGECONFIG[libidn2] = "-Dlibidn2=true,-Dlibidn2=false,libidn2,,libidn2"
+# Link udev shared with systemd helper library.
+# If enabled the udev package depends on the systemd package (which has the needed shared library).
+PACKAGECONFIG[link-udev-shared] = "-Dlink-udev-shared=true,-Dlink-udev-shared=false"
PACKAGECONFIG[localed] = "-Dlocaled=true,-Dlocaled=false"
PACKAGECONFIG[logind] = "-Dlogind=true,-Dlogind=false"
PACKAGECONFIG[lz4] = "-Dlz4=true,-Dlz4=false,lz4"
@@ -215,11 +218,6 @@ rootprefix ?= "${root_prefix}"
rootlibdir ?= "${base_libdir}"
rootlibexecdir = "${rootprefix}/lib"
-# This links udev statically with systemd helper library.
-# Otherwise udev package would depend on systemd package (which has the needed shared library),
-# and always pull it into images.
-EXTRA_OEMESON += "-Dlink-udev-shared=false"
-
EXTRA_OEMESON += "-Dnobody-user=nobody \
-Dnobody-group=nobody \
-Drootlibdir=${rootlibdir} \
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-01 16:16 [PATCH 1/3] cve-check: create directory before copy Stefan Herbrechtsmeier
2022-02-01 16:16 ` [PATCH 2/3] systemd: Add link-udev-shared PACKAGECONFIG Stefan Herbrechtsmeier
@ 2022-02-01 16:16 ` Stefan Herbrechtsmeier
2022-02-01 17:00 ` [OE-core] [PATCH 1/3] cve-check: create directory before copy Alexander Kanavin
2 siblings, 0 replies; 6+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-01 16:16 UTC (permalink / raw)
To: openembedded-core; +Cc: Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
Link udev shared with systemd helper to minimize the udev package size
if DISTRO_FEATURES contains systemd.
It is only usefull to link udev static with systemd helper if udev
should be installed without systemd.
Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
---
meta/recipes-core/systemd/systemd_249.7.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-core/systemd/systemd_249.7.bb b/meta/recipes-core/systemd/systemd_249.7.bb
index 739f3aae86..431781e6c7 100644
--- a/meta/recipes-core/systemd/systemd_249.7.bb
+++ b/meta/recipes-core/systemd/systemd_249.7.bb
@@ -66,6 +66,7 @@ PACKAGECONFIG ??= " \
${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig pam selinux smack usrmerge polkit seccomp', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \
+ ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'link-udev-shared', '', d)} \
backlight \
binfmt \
gshadow \
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH 1/3] cve-check: create directory before copy
2022-02-01 16:16 [PATCH 1/3] cve-check: create directory before copy Stefan Herbrechtsmeier
2022-02-01 16:16 ` [PATCH 2/3] systemd: Add link-udev-shared PACKAGECONFIG Stefan Herbrechtsmeier
2022-02-01 16:16 ` [PATCH 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd Stefan Herbrechtsmeier
@ 2022-02-01 17:00 ` Alexander Kanavin
2022-02-01 18:58 ` Stefan Herbrechtsmeier
2 siblings, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2022-02-01 17:00 UTC (permalink / raw)
To: Stefan Herbrechtsmeier; +Cc: OE-core, Stefan Herbrechtsmeier
[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]
Can you please describe the issue this is fixing in the commit message? Why
is this not seen by others?
Alex
On Tue, 1 Feb 2022 at 17:17, Stefan Herbrechtsmeier <
stefan.herbrechtsmeier-oss@weidmueller.com> wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>
> Signed-off-by: Stefan Herbrechtsmeier <
> stefan.herbrechtsmeier@weidmueller.com>
> ---
>
> meta/classes/cve-check.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/cve-check.bbclass
> b/meta/classes/cve-check.bbclass
> index 70d1988a70..a4d735c323 100644
> --- a/meta/classes/cve-check.bbclass
> +++ b/meta/classes/cve-check.bbclass
> @@ -143,6 +143,7 @@ python cve_check_write_rootfs_manifest () {
> manifest_name = d.getVar("CVE_CHECK_MANIFEST")
> cve_tmp_file = d.getVar("CVE_CHECK_TMP_FILE")
>
> + bb.utils.mkdirhier(os.path.dirname(manifest_name))
> shutil.copyfile(cve_tmp_file, manifest_name)
>
> if manifest_name and os.path.exists(manifest_name):
> --
> 2.30.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#161159):
> https://lists.openembedded.org/g/openembedded-core/message/161159
> Mute This Topic: https://lists.openembedded.org/mt/88836328/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
[-- Attachment #2: Type: text/html, Size: 2585 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH 1/3] cve-check: create directory before copy
2022-02-01 17:00 ` [OE-core] [PATCH 1/3] cve-check: create directory before copy Alexander Kanavin
@ 2022-02-01 18:58 ` Stefan Herbrechtsmeier
2022-02-01 20:18 ` Alexander Kanavin
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-01 18:58 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: OE-core, Stefan Herbrechtsmeier
Am 01.02.2022 um 18:00 schrieb Alexander Kanavin:
> Can you please describe the issue this is fixing in the commit message?
> Why is this not seen by others?
Isn't it best practice to create a directory before copy something into
the directory? The patch shows that the arbitrary directory of the
CVE_CHECK_MANIFEST variable isn't created.
> On Tue, 1 Feb 2022 at 17:17, Stefan Herbrechtsmeier
> <stefan.herbrechtsmeier-oss@weidmueller.com
> <mailto:stefan.herbrechtsmeier-oss@weidmueller.com>> wrote:
>
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com
> <mailto:stefan.herbrechtsmeier@weidmueller.com>>
>
> Signed-off-by: Stefan Herbrechtsmeier
> <stefan.herbrechtsmeier@weidmueller.com
> <mailto:stefan.herbrechtsmeier@weidmueller.com>>
> ---
>
> meta/classes/cve-check.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/cve-check.bbclass
> b/meta/classes/cve-check.bbclass
> index 70d1988a70..a4d735c323 100644
> --- a/meta/classes/cve-check.bbclass
> +++ b/meta/classes/cve-check.bbclass
> @@ -143,6 +143,7 @@ python cve_check_write_rootfs_manifest () {
> manifest_name = d.getVar("CVE_CHECK_MANIFEST")
> cve_tmp_file = d.getVar("CVE_CHECK_TMP_FILE")
>
> + bb.utils.mkdirhier(os.path.dirname(manifest_name))
> shutil.copyfile(cve_tmp_file, manifest_name)
>
> if manifest_name and os.path.exists(manifest_name):
> --
> 2.30.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#161159):
> https://lists.openembedded.org/g/openembedded-core/message/161159
> <https://lists.openembedded.org/g/openembedded-core/message/161159>
> Mute This Topic: https://lists.openembedded.org/mt/88836328/1686489
> <https://lists.openembedded.org/mt/88836328/1686489>
> Group Owner: openembedded-core+owner@lists.openembedded.org
> <mailto:openembedded-core%2Bowner@lists.openembedded.org>
> Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub
> <https://lists.openembedded.org/g/openembedded-core/unsub>
> [alex.kanavin@gmail.com <mailto:alex.kanavin@gmail.com>]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH 1/3] cve-check: create directory before copy
2022-02-01 18:58 ` Stefan Herbrechtsmeier
@ 2022-02-01 20:18 ` Alexander Kanavin
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Kanavin @ 2022-02-01 20:18 UTC (permalink / raw)
To: Stefan Herbrechtsmeier; +Cc: OE-core, Stefan Herbrechtsmeier
[-- Attachment #1: Type: text/plain, Size: 2640 bytes --]
On Tue, 1 Feb 2022 at 19:58, Stefan Herbrechtsmeier <
stefan.herbrechtsmeier-oss@weidmueller.com> wrote:
> Am 01.02.2022 um 18:00 schrieb Alexander Kanavin:
> > Can you please describe the issue this is fixing in the commit message?
> > Why is this not seen by others?
>
> Isn't it best practice to create a directory before copy something into
> the directory? The patch shows that the arbitrary directory of the
> CVE_CHECK_MANIFEST variable isn't created.
>
That's right, but then the commit title should mention CVE_CHECK_MESSAGE;
"create directory before copy" is too generic.
Alex
>
> > On Tue, 1 Feb 2022 at 17:17, Stefan Herbrechtsmeier
> > <stefan.herbrechtsmeier-oss@weidmueller.com
> > <mailto:stefan.herbrechtsmeier-oss@weidmueller.com>> wrote:
> >
> > From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com
> > <mailto:stefan.herbrechtsmeier@weidmueller.com>>
> >
> > Signed-off-by: Stefan Herbrechtsmeier
> > <stefan.herbrechtsmeier@weidmueller.com
> > <mailto:stefan.herbrechtsmeier@weidmueller.com>>
> > ---
> >
> > meta/classes/cve-check.bbclass | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/classes/cve-check.bbclass
> > b/meta/classes/cve-check.bbclass
> > index 70d1988a70..a4d735c323 100644
> > --- a/meta/classes/cve-check.bbclass
> > +++ b/meta/classes/cve-check.bbclass
> > @@ -143,6 +143,7 @@ python cve_check_write_rootfs_manifest () {
> > manifest_name = d.getVar("CVE_CHECK_MANIFEST")
> > cve_tmp_file = d.getVar("CVE_CHECK_TMP_FILE")
> >
> > + bb.utils.mkdirhier(os.path.dirname(manifest_name))
> > shutil.copyfile(cve_tmp_file, manifest_name)
> >
> > if manifest_name and os.path.exists(manifest_name):
> > --
> > 2.30.2
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#161159):
> > https://lists.openembedded.org/g/openembedded-core/message/161159
> > <https://lists.openembedded.org/g/openembedded-core/message/161159>
> > Mute This Topic: https://lists.openembedded.org/mt/88836328/1686489
> > <https://lists.openembedded.org/mt/88836328/1686489>
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > <mailto:openembedded-core%2Bowner@lists.openembedded.org>
> > Unsubscribe:
> > https://lists.openembedded.org/g/openembedded-core/unsub
> > <https://lists.openembedded.org/g/openembedded-core/unsub>
> > [alex.kanavin@gmail.com <mailto:alex.kanavin@gmail.com>]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
[-- Attachment #2: Type: text/html, Size: 5088 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-01 20:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-01 16:16 [PATCH 1/3] cve-check: create directory before copy Stefan Herbrechtsmeier
2022-02-01 16:16 ` [PATCH 2/3] systemd: Add link-udev-shared PACKAGECONFIG Stefan Herbrechtsmeier
2022-02-01 16:16 ` [PATCH 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd Stefan Herbrechtsmeier
2022-02-01 17:00 ` [OE-core] [PATCH 1/3] cve-check: create directory before copy Alexander Kanavin
2022-02-01 18:58 ` Stefan Herbrechtsmeier
2022-02-01 20:18 ` Alexander Kanavin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.