* [PATCH v2] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
@ 2022-02-01 17:46 ` Nícolas F. R. A. Prado
0 siblings, 0 replies; 10+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-02-01 17:46 UTC (permalink / raw)
To: Robert Foss, Matthias Brugger, Rob Herring, Xin Ji
Cc: kernel, Nícolas F. R. A. Prado, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek
mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625:
add MIPI DPI input feature"), a bus-type property started being required
in the endpoint node by the driver to indicate whether it is DSI or DPI.
Add the missing bus-type property and set it to 5
(V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
configured to DSI and the display pipeline can probe correctly.
While at it, also set the data-lanes property that was also introduced
in that same commit, so that we don't rely on the default value.
Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com
Changes in v2:
- (thanks Rob) Use proper format when refering to commit in commit
message as pointed out by checkpatch
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
index 8f7bf33f607d..e8f133dc96b9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
@@ -171,6 +171,8 @@ port@0 {
anx7625_in: endpoint {
remote-endpoint = <&dsi_out>;
+ bus-type = <5>;
+ data-lanes = <0 1 2 3>;
};
};
--
2.35.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
@ 2022-02-01 17:46 ` Nícolas F. R. A. Prado
0 siblings, 0 replies; 10+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-02-01 17:46 UTC (permalink / raw)
To: Robert Foss, Matthias Brugger, Rob Herring, Xin Ji
Cc: kernel, Nícolas F. R. A. Prado, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek
mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625:
add MIPI DPI input feature"), a bus-type property started being required
in the endpoint node by the driver to indicate whether it is DSI or DPI.
Add the missing bus-type property and set it to 5
(V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
configured to DSI and the display pipeline can probe correctly.
While at it, also set the data-lanes property that was also introduced
in that same commit, so that we don't rely on the default value.
Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com
Changes in v2:
- (thanks Rob) Use proper format when refering to commit in commit
message as pointed out by checkpatch
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
index 8f7bf33f607d..e8f133dc96b9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
@@ -171,6 +171,8 @@ port@0 {
anx7625_in: endpoint {
remote-endpoint = <&dsi_out>;
+ bus-type = <5>;
+ data-lanes = <0 1 2 3>;
};
};
--
2.35.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
@ 2022-02-01 17:46 ` Nícolas F. R. A. Prado
0 siblings, 0 replies; 10+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-02-01 17:46 UTC (permalink / raw)
To: Robert Foss, Matthias Brugger, Rob Herring, Xin Ji
Cc: kernel, Nícolas F. R. A. Prado, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek
mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625:
add MIPI DPI input feature"), a bus-type property started being required
in the endpoint node by the driver to indicate whether it is DSI or DPI.
Add the missing bus-type property and set it to 5
(V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
configured to DSI and the display pipeline can probe correctly.
While at it, also set the data-lanes property that was also introduced
in that same commit, so that we don't rely on the default value.
Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com
Changes in v2:
- (thanks Rob) Use proper format when refering to commit in commit
message as pointed out by checkpatch
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
index 8f7bf33f607d..e8f133dc96b9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
@@ -171,6 +171,8 @@ port@0 {
anx7625_in: endpoint {
remote-endpoint = <&dsi_out>;
+ bus-type = <5>;
+ data-lanes = <0 1 2 3>;
};
};
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
2022-02-01 17:46 ` Nícolas F. R. A. Prado
(?)
@ 2022-02-01 17:51 ` Nícolas F. R. A. Prado
-1 siblings, 0 replies; 10+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-02-01 17:51 UTC (permalink / raw)
To: Robert Foss, Matthias Brugger, Rob Herring, Xin Ji
Cc: kernel, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
Sorry, I forgot to add the reviewed-by from v1. Added below.
On Tue, Feb 01, 2022 at 12:46:43PM -0500, Nícolas F. R. A. Prado wrote:
> mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
> its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625:
> add MIPI DPI input feature"), a bus-type property started being required
> in the endpoint node by the driver to indicate whether it is DSI or DPI.
>
> Add the missing bus-type property and set it to 5
> (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
> configured to DSI and the display pipeline can probe correctly.
>
> While at it, also set the data-lanes property that was also introduced
> in that same commit, so that we don't rely on the default value.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> ---
> v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com
>
> Changes in v2:
> - (thanks Rob) Use proper format when refering to commit in commit
> message as pointed out by checkpatch
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> index 8f7bf33f607d..e8f133dc96b9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> @@ -171,6 +171,8 @@ port@0 {
>
> anx7625_in: endpoint {
> remote-endpoint = <&dsi_out>;
> + bus-type = <5>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
> --
> 2.35.1
>
>
> --
> To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
@ 2022-02-01 17:51 ` Nícolas F. R. A. Prado
0 siblings, 0 replies; 10+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-02-01 17:51 UTC (permalink / raw)
To: Robert Foss, Matthias Brugger, Rob Herring, Xin Ji
Cc: kernel, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
Sorry, I forgot to add the reviewed-by from v1. Added below.
On Tue, Feb 01, 2022 at 12:46:43PM -0500, Nícolas F. R. A. Prado wrote:
> mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
> its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625:
> add MIPI DPI input feature"), a bus-type property started being required
> in the endpoint node by the driver to indicate whether it is DSI or DPI.
>
> Add the missing bus-type property and set it to 5
> (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
> configured to DSI and the display pipeline can probe correctly.
>
> While at it, also set the data-lanes property that was also introduced
> in that same commit, so that we don't rely on the default value.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> ---
> v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com
>
> Changes in v2:
> - (thanks Rob) Use proper format when refering to commit in commit
> message as pointed out by checkpatch
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> index 8f7bf33f607d..e8f133dc96b9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> @@ -171,6 +171,8 @@ port@0 {
>
> anx7625_in: endpoint {
> remote-endpoint = <&dsi_out>;
> + bus-type = <5>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
> --
> 2.35.1
>
>
> --
> To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
@ 2022-02-01 17:51 ` Nícolas F. R. A. Prado
0 siblings, 0 replies; 10+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-02-01 17:51 UTC (permalink / raw)
To: Robert Foss, Matthias Brugger, Rob Herring, Xin Ji
Cc: kernel, devicetree, linux-arm-kernel, linux-kernel, linux-mediatek
Sorry, I forgot to add the reviewed-by from v1. Added below.
On Tue, Feb 01, 2022 at 12:46:43PM -0500, Nícolas F. R. A. Prado wrote:
> mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
> its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625:
> add MIPI DPI input feature"), a bus-type property started being required
> in the endpoint node by the driver to indicate whether it is DSI or DPI.
>
> Add the missing bus-type property and set it to 5
> (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
> configured to DSI and the display pipeline can probe correctly.
>
> While at it, also set the data-lanes property that was also introduced
> in that same commit, so that we don't rely on the default value.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> ---
> v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com
>
> Changes in v2:
> - (thanks Rob) Use proper format when refering to commit in commit
> message as pointed out by checkpatch
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> index 8f7bf33f607d..e8f133dc96b9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> @@ -171,6 +171,8 @@ port@0 {
>
> anx7625_in: endpoint {
> remote-endpoint = <&dsi_out>;
> + bus-type = <5>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
> --
> 2.35.1
>
>
> --
> To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
2022-02-01 17:46 ` Nícolas F. R. A. Prado
(?)
(?)
@ 2022-02-24 3:51 ` Chen-Yu Tsai
-1 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2022-02-24 3:51 UTC (permalink / raw)
To: Nícolas F. R. A. Prado
Cc: Robert Foss, Matthias Brugger, Rob Herring, Xin Ji, kernel,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
dri-devel, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec
Hi,
(CC-ed DRM bridge maintainers and the dri-devel ML)
On Wed, Feb 2, 2022 at 1:47 AM Nícolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
>
> mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
> its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625:
> add MIPI DPI input feature"), a bus-type property started being required
> in the endpoint node by the driver to indicate whether it is DSI or DPI.
>
> Add the missing bus-type property and set it to 5
> (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
> configured to DSI and the display pipeline can probe correctly.
Don't people find it odd that this is setting the bus-type to "parallel"
(5) for the device to use DSI? Instead of "MIPI CSI-2 D-PHY" (4) or even
"MIPI CSI-2 C-PHY" (1) which is specified in the binding? It's completely
backwards.
Would it be possible to fix the binding and driver at this point?
Thanks
ChenYu
> While at it, also set the data-lanes property that was also introduced
> in that same commit, so that we don't rely on the default value.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
> v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com
>
> Changes in v2:
> - (thanks Rob) Use proper format when refering to commit in commit
> message as pointed out by checkpatch
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> index 8f7bf33f607d..e8f133dc96b9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> @@ -171,6 +171,8 @@ port@0 {
>
> anx7625_in: endpoint {
> remote-endpoint = <&dsi_out>;
> + bus-type = <5>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
> --
> 2.35.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
@ 2022-02-24 3:51 ` Chen-Yu Tsai
0 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2022-02-24 3:51 UTC (permalink / raw)
To: Nícolas F. R. A. Prado
Cc: devicetree, Jernej Skrabec, Neil Armstrong, Jonas Karlman,
linux-kernel, Robert Foss, Rob Herring, linux-mediatek,
dri-devel, Andrzej Hajda, Matthias Brugger, kernel, Xin Ji,
linux-arm-kernel, Laurent Pinchart
Hi,
(CC-ed DRM bridge maintainers and the dri-devel ML)
On Wed, Feb 2, 2022 at 1:47 AM Nícolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
>
> mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
> its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625:
> add MIPI DPI input feature"), a bus-type property started being required
> in the endpoint node by the driver to indicate whether it is DSI or DPI.
>
> Add the missing bus-type property and set it to 5
> (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
> configured to DSI and the display pipeline can probe correctly.
Don't people find it odd that this is setting the bus-type to "parallel"
(5) for the device to use DSI? Instead of "MIPI CSI-2 D-PHY" (4) or even
"MIPI CSI-2 C-PHY" (1) which is specified in the binding? It's completely
backwards.
Would it be possible to fix the binding and driver at this point?
Thanks
ChenYu
> While at it, also set the data-lanes property that was also introduced
> in that same commit, so that we don't rely on the default value.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
> v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com
>
> Changes in v2:
> - (thanks Rob) Use proper format when refering to commit in commit
> message as pointed out by checkpatch
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> index 8f7bf33f607d..e8f133dc96b9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> @@ -171,6 +171,8 @@ port@0 {
>
> anx7625_in: endpoint {
> remote-endpoint = <&dsi_out>;
> + bus-type = <5>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
> --
> 2.35.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
@ 2022-02-24 3:51 ` Chen-Yu Tsai
0 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2022-02-24 3:51 UTC (permalink / raw)
To: Nícolas F. R. A. Prado
Cc: Robert Foss, Matthias Brugger, Rob Herring, Xin Ji, kernel,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
dri-devel, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec
Hi,
(CC-ed DRM bridge maintainers and the dri-devel ML)
On Wed, Feb 2, 2022 at 1:47 AM Nícolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
>
> mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
> its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625:
> add MIPI DPI input feature"), a bus-type property started being required
> in the endpoint node by the driver to indicate whether it is DSI or DPI.
>
> Add the missing bus-type property and set it to 5
> (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
> configured to DSI and the display pipeline can probe correctly.
Don't people find it odd that this is setting the bus-type to "parallel"
(5) for the device to use DSI? Instead of "MIPI CSI-2 D-PHY" (4) or even
"MIPI CSI-2 C-PHY" (1) which is specified in the binding? It's completely
backwards.
Would it be possible to fix the binding and driver at this point?
Thanks
ChenYu
> While at it, also set the data-lanes property that was also introduced
> in that same commit, so that we don't rely on the default value.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
> v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com
>
> Changes in v2:
> - (thanks Rob) Use proper format when refering to commit in commit
> message as pointed out by checkpatch
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> index 8f7bf33f607d..e8f133dc96b9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> @@ -171,6 +171,8 @@ port@0 {
>
> anx7625_in: endpoint {
> remote-endpoint = <&dsi_out>;
> + bus-type = <5>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
> --
> 2.35.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint
@ 2022-02-24 3:51 ` Chen-Yu Tsai
0 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2022-02-24 3:51 UTC (permalink / raw)
To: Nícolas F. R. A. Prado
Cc: Robert Foss, Matthias Brugger, Rob Herring, Xin Ji, kernel,
devicetree, linux-arm-kernel, linux-kernel, linux-mediatek,
dri-devel, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec
Hi,
(CC-ed DRM bridge maintainers and the dri-devel ML)
On Wed, Feb 2, 2022 at 1:47 AM Nícolas F. R. A. Prado
<nfraprado@collabora.com> wrote:
>
> mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
> its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625:
> add MIPI DPI input feature"), a bus-type property started being required
> in the endpoint node by the driver to indicate whether it is DSI or DPI.
>
> Add the missing bus-type property and set it to 5
> (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
> configured to DSI and the display pipeline can probe correctly.
Don't people find it odd that this is setting the bus-type to "parallel"
(5) for the device to use DSI? Instead of "MIPI CSI-2 D-PHY" (4) or even
"MIPI CSI-2 C-PHY" (1) which is specified in the binding? It's completely
backwards.
Would it be possible to fix the binding and driver at this point?
Thanks
ChenYu
> While at it, also set the data-lanes property that was also introduced
> in that same commit, so that we don't rely on the default value.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
> v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com
>
> Changes in v2:
> - (thanks Rob) Use proper format when refering to commit in commit
> message as pointed out by checkpatch
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> index 8f7bf33f607d..e8f133dc96b9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> @@ -171,6 +171,8 @@ port@0 {
>
> anx7625_in: endpoint {
> remote-endpoint = <&dsi_out>;
> + bus-type = <5>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
> --
> 2.35.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-02-24 3:53 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-01 17:46 [PATCH v2] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint Nícolas F. R. A. Prado
2022-02-01 17:46 ` Nícolas F. R. A. Prado
2022-02-01 17:46 ` Nícolas F. R. A. Prado
2022-02-01 17:51 ` Nícolas F. R. A. Prado
2022-02-01 17:51 ` Nícolas F. R. A. Prado
2022-02-01 17:51 ` Nícolas F. R. A. Prado
2022-02-24 3:51 ` Chen-Yu Tsai
2022-02-24 3:51 ` Chen-Yu Tsai
2022-02-24 3:51 ` Chen-Yu Tsai
2022-02-24 3:51 ` Chen-Yu Tsai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.