* [PATCH v2 1/3] cve-check: create directory of CVE_CHECK_MANIFEST before copy
@ 2022-02-02 7:35 Stefan Herbrechtsmeier
2022-02-02 7:35 ` [PATCH v2 2/3] systemd: Add link-udev-shared PACKAGECONFIG Stefan Herbrechtsmeier
` (2 more replies)
0 siblings, 3 replies; 22+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-02 7:35 UTC (permalink / raw)
To: openembedded-core; +Cc: Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
Create directory of the CVE_CHECK_MANIFEST variable before copy to it,
so that the variable can use an arbitrary directory name.
Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
---
Changes in v2:
- Reword commit
meta/classes/cve-check.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/classes/cve-check.bbclass b/meta/classes/cve-check.bbclass
index 70d1988a70..a4d735c323 100644
--- a/meta/classes/cve-check.bbclass
+++ b/meta/classes/cve-check.bbclass
@@ -143,6 +143,7 @@ python cve_check_write_rootfs_manifest () {
manifest_name = d.getVar("CVE_CHECK_MANIFEST")
cve_tmp_file = d.getVar("CVE_CHECK_TMP_FILE")
+ bb.utils.mkdirhier(os.path.dirname(manifest_name))
shutil.copyfile(cve_tmp_file, manifest_name)
if manifest_name and os.path.exists(manifest_name):
--
2.30.2
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 2/3] systemd: Add link-udev-shared PACKAGECONFIG
2022-02-02 7:35 [PATCH v2 1/3] cve-check: create directory of CVE_CHECK_MANIFEST before copy Stefan Herbrechtsmeier
@ 2022-02-02 7:35 ` Stefan Herbrechtsmeier
2022-02-02 7:35 ` [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd Stefan Herbrechtsmeier
2022-02-02 8:54 ` [OE-core] [PATCH v2 1/3] cve-check: create directory of CVE_CHECK_MANIFEST before copy Alexander Kanavin
2 siblings, 0 replies; 22+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-02 7:35 UTC (permalink / raw)
To: openembedded-core; +Cc: Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
Add a PACKAGECONFIG to link systemd-udev and its helpers to
libsystemd-shared.so. If enabled the udev package depends on the systemd
package.
Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
---
(no changes since v1)
meta/recipes-core/systemd/systemd_249.7.bb | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/meta/recipes-core/systemd/systemd_249.7.bb b/meta/recipes-core/systemd/systemd_249.7.bb
index 53e7f6738d..739f3aae86 100644
--- a/meta/recipes-core/systemd/systemd_249.7.bb
+++ b/meta/recipes-core/systemd/systemd_249.7.bb
@@ -156,6 +156,9 @@ PACKAGECONFIG[kmod] = "-Dkmod=true,-Dkmod=false,kmod"
PACKAGECONFIG[ldconfig] = "-Dldconfig=true,-Dldconfig=false,,ldconfig"
PACKAGECONFIG[libidn] = "-Dlibidn=true,-Dlibidn=false,libidn,,libidn"
PACKAGECONFIG[libidn2] = "-Dlibidn2=true,-Dlibidn2=false,libidn2,,libidn2"
+# Link udev shared with systemd helper library.
+# If enabled the udev package depends on the systemd package (which has the needed shared library).
+PACKAGECONFIG[link-udev-shared] = "-Dlink-udev-shared=true,-Dlink-udev-shared=false"
PACKAGECONFIG[localed] = "-Dlocaled=true,-Dlocaled=false"
PACKAGECONFIG[logind] = "-Dlogind=true,-Dlogind=false"
PACKAGECONFIG[lz4] = "-Dlz4=true,-Dlz4=false,lz4"
@@ -215,11 +218,6 @@ rootprefix ?= "${root_prefix}"
rootlibdir ?= "${base_libdir}"
rootlibexecdir = "${rootprefix}/lib"
-# This links udev statically with systemd helper library.
-# Otherwise udev package would depend on systemd package (which has the needed shared library),
-# and always pull it into images.
-EXTRA_OEMESON += "-Dlink-udev-shared=false"
-
EXTRA_OEMESON += "-Dnobody-user=nobody \
-Dnobody-group=nobody \
-Drootlibdir=${rootlibdir} \
--
2.30.2
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-02 7:35 [PATCH v2 1/3] cve-check: create directory of CVE_CHECK_MANIFEST before copy Stefan Herbrechtsmeier
2022-02-02 7:35 ` [PATCH v2 2/3] systemd: Add link-udev-shared PACKAGECONFIG Stefan Herbrechtsmeier
@ 2022-02-02 7:35 ` Stefan Herbrechtsmeier
2022-02-06 8:10 ` [OE-core] " Richard Purdie
` (2 more replies)
2022-02-02 8:54 ` [OE-core] [PATCH v2 1/3] cve-check: create directory of CVE_CHECK_MANIFEST before copy Alexander Kanavin
2 siblings, 3 replies; 22+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-02 7:35 UTC (permalink / raw)
To: openembedded-core; +Cc: Stefan Herbrechtsmeier
From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
Link udev shared with systemd helper to minimize the udev package size
if DISTRO_FEATURES contains systemd.
It is only usefull to link udev static with systemd helper if udev
should be installed without systemd.
Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
---
(no changes since v1)
meta/recipes-core/systemd/systemd_249.7.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-core/systemd/systemd_249.7.bb b/meta/recipes-core/systemd/systemd_249.7.bb
index 739f3aae86..431781e6c7 100644
--- a/meta/recipes-core/systemd/systemd_249.7.bb
+++ b/meta/recipes-core/systemd/systemd_249.7.bb
@@ -66,6 +66,7 @@ PACKAGECONFIG ??= " \
${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig pam selinux smack usrmerge polkit seccomp', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \
+ ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'link-udev-shared', '', d)} \
backlight \
binfmt \
gshadow \
--
2.30.2
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 1/3] cve-check: create directory of CVE_CHECK_MANIFEST before copy
2022-02-02 7:35 [PATCH v2 1/3] cve-check: create directory of CVE_CHECK_MANIFEST before copy Stefan Herbrechtsmeier
2022-02-02 7:35 ` [PATCH v2 2/3] systemd: Add link-udev-shared PACKAGECONFIG Stefan Herbrechtsmeier
2022-02-02 7:35 ` [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd Stefan Herbrechtsmeier
@ 2022-02-02 8:54 ` Alexander Kanavin
2 siblings, 0 replies; 22+ messages in thread
From: Alexander Kanavin @ 2022-02-02 8:54 UTC (permalink / raw)
To: Stefan Herbrechtsmeier; +Cc: OE-core, Stefan Herbrechtsmeier
[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]
Thanks :)
Alex
On Wed, 2 Feb 2022 at 08:35, Stefan Herbrechtsmeier <
stefan.herbrechtsmeier-oss@weidmueller.com> wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>
> Create directory of the CVE_CHECK_MANIFEST variable before copy to it,
> so that the variable can use an arbitrary directory name.
>
> Signed-off-by: Stefan Herbrechtsmeier <
> stefan.herbrechtsmeier@weidmueller.com>
>
> ---
>
> Changes in v2:
> - Reword commit
>
> meta/classes/cve-check.bbclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/cve-check.bbclass
> b/meta/classes/cve-check.bbclass
> index 70d1988a70..a4d735c323 100644
> --- a/meta/classes/cve-check.bbclass
> +++ b/meta/classes/cve-check.bbclass
> @@ -143,6 +143,7 @@ python cve_check_write_rootfs_manifest () {
> manifest_name = d.getVar("CVE_CHECK_MANIFEST")
> cve_tmp_file = d.getVar("CVE_CHECK_TMP_FILE")
>
> + bb.utils.mkdirhier(os.path.dirname(manifest_name))
> shutil.copyfile(cve_tmp_file, manifest_name)
>
> if manifest_name and os.path.exists(manifest_name):
> --
> 2.30.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#161180):
> https://lists.openembedded.org/g/openembedded-core/message/161180
> Mute This Topic: https://lists.openembedded.org/mt/88853820/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
[-- Attachment #2: Type: text/html, Size: 2689 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-02 7:35 ` [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd Stefan Herbrechtsmeier
@ 2022-02-06 8:10 ` Richard Purdie
2022-02-06 16:39 ` Stefan Herbrechtsmeier
2022-02-06 17:23 ` Mark Hatle
[not found] ` <16D124152B709F2D.20549@lists.openembedded.org>
2022-02-22 9:20 ` Yu, Mingli
2 siblings, 2 replies; 22+ messages in thread
From: Richard Purdie @ 2022-02-06 8:10 UTC (permalink / raw)
To: Stefan Herbrechtsmeier, openembedded-core; +Cc: Stefan Herbrechtsmeier
On Wed, 2022-02-02 at 08:35 +0100, Stefan Herbrechtsmeier wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>
> Link udev shared with systemd helper to minimize the udev package size
> if DISTRO_FEATURES contains systemd.
>
> It is only usefull to link udev static with systemd helper if udev
> should be installed without systemd.
>
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>
> ---
>
> (no changes since v1)
>
> meta/recipes-core/systemd/systemd_249.7.bb | 1 +
> 1 file changed, 1 insertion(+)
This seems to break some of our tests:
https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/4708
https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3121
https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/3085
https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/3089
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3127
Presumably it causes extra dependencies to be pulled in causing the file overlap
where there was previously none.
Cheers,
Richard
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
[not found] ` <16D124152B709F2D.20549@lists.openembedded.org>
@ 2022-02-06 9:53 ` Richard Purdie
2022-02-06 16:43 ` Stefan Herbrechtsmeier
[not found] ` <16D1401AF7E66E0D.14843@lists.openembedded.org>
0 siblings, 2 replies; 22+ messages in thread
From: Richard Purdie @ 2022-02-06 9:53 UTC (permalink / raw)
To: Stefan Herbrechtsmeier, openembedded-core; +Cc: Stefan Herbrechtsmeier
On Sun, 2022-02-06 at 08:10 +0000, Richard Purdie via lists.openembedded.org
wrote:
> On Wed, 2022-02-02 at 08:35 +0100, Stefan Herbrechtsmeier wrote:
> > From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> >
> > Link udev shared with systemd helper to minimize the udev package size
> > if DISTRO_FEATURES contains systemd.
> >
> > It is only usefull to link udev static with systemd helper if udev
> > should be installed without systemd.
> >
> > Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> >
> > ---
> >
> > (no changes since v1)
> >
> > meta/recipes-core/systemd/systemd_249.7.bb | 1 +
> > 1 file changed, 1 insertion(+)
>
>
> This seems to break some of our tests:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/4708
> https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3121
> https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/3085
> https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/3089
> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3127
>
> Presumably it causes extra dependencies to be pulled in causing the file overlap
> where there was previously none.
Thinking a bit more, I think this needs to be:
diff --git a/meta/recipes-core/systemd/systemd_250.3.bb b/meta/recipes-core/systemd/systemd_250.3.bb
index 2b6bfcc2c25..7851c4c16a7 100644
--- a/meta/recipes-core/systemd/systemd_250.3.bb
+++ b/meta/recipes-core/systemd/systemd_250.3.bb
@@ -69,7 +69,7 @@ PACKAGECONFIG ??= " \
${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig pam selinux smack usrmerge polkit seccomp', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \
- ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'link-udev-shared', '', d)} \
+ ${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', '', 'link-udev-shared', d)} \
backlight \
binfmt \
gshadow \
which I'll test...
Cheers,
Richard
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-06 8:10 ` [OE-core] " Richard Purdie
@ 2022-02-06 16:39 ` Stefan Herbrechtsmeier
2022-02-06 17:26 ` Mark Hatle
2022-02-06 17:23 ` Mark Hatle
1 sibling, 1 reply; 22+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-06 16:39 UTC (permalink / raw)
To: Richard Purdie, Stefan Herbrechtsmeier, openembedded-core
Cc: Stefan Herbrechtsmeier
Am 06.02.22 um 09:10 schrieb Richard Purdie:
> On Wed, 2022-02-02 at 08:35 +0100, Stefan Herbrechtsmeier wrote:
>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>
>> Link udev shared with systemd helper to minimize the udev package size
>> if DISTRO_FEATURES contains systemd.
>>
>> It is only usefull to link udev static with systemd helper if udev
>> should be installed without systemd.
>>
>> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>
>> ---
>>
>> (no changes since v1)
>>
>> meta/recipes-core/systemd/systemd_249.7.bb | 1 +
>> 1 file changed, 1 insertion(+)
>
>
> This seems to break some of our tests:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/4708
> https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3121
> https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/3085
> https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/3089
> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3127
>
> Presumably it causes extra dependencies to be pulled in causing the file overlap
> where there was previously none.
Sorry, I was told sysvinit with systemd isn't a valid use case anymore.
Would it be okay to enable it only if sysvinit isn't in distro?
Otherwise reject the change because it is impossible to know if a
dependency between udev and systemd is okay or not.
Regads
Stefan
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-06 9:53 ` Richard Purdie
@ 2022-02-06 16:43 ` Stefan Herbrechtsmeier
[not found] ` <16D1401AF7E66E0D.14843@lists.openembedded.org>
1 sibling, 0 replies; 22+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-06 16:43 UTC (permalink / raw)
To: openembedded-core
Am 06.02.22 um 10:53 schrieb Richard Purdie:
> On Sun, 2022-02-06 at 08:10 +0000, Richard Purdie via lists.openembedded.org
> wrote:
>> On Wed, 2022-02-02 at 08:35 +0100, Stefan Herbrechtsmeier wrote:
>>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>>
>>> Link udev shared with systemd helper to minimize the udev package size
>>> if DISTRO_FEATURES contains systemd.
>>>
>>> It is only usefull to link udev static with systemd helper if udev
>>> should be installed without systemd.
>>>
>>> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>>
>>> ---
>>>
>>> (no changes since v1)
>>>
>>> meta/recipes-core/systemd/systemd_249.7.bb | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>>
>> This seems to break some of our tests:
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/4708
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3121
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/3085
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/3089
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3127
>>
>> Presumably it causes extra dependencies to be pulled in causing the file overlap
>> where there was previously none.
>
> Thinking a bit more, I think this needs to be:
>
> diff --git a/meta/recipes-core/systemd/systemd_250.3.bb b/meta/recipes-core/systemd/systemd_250.3.bb
> index 2b6bfcc2c25..7851c4c16a7 100644
> --- a/meta/recipes-core/systemd/systemd_250.3.bb
> +++ b/meta/recipes-core/systemd/systemd_250.3.bb
> @@ -69,7 +69,7 @@ PACKAGECONFIG ??= " \
> ${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig pam selinux smack usrmerge polkit seccomp', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \
> - ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'link-udev-shared', '', d)} \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', '', 'link-udev-shared', d)} \
> backlight \
> binfmt \
> gshadow \
>
>
> which I'll test...
Maybe the systemd naming for the option is sub optimal. The
link-udev-shared option create a dependency between udev and systemd
package. It links udev against the libsystemd-shared library. Without it
udev is linked statically against this library. The option should only
be enabled if udev is always used together with systemd.
Regards
Stefan
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
[not found] ` <16D1401AF7E66E0D.14843@lists.openembedded.org>
@ 2022-02-06 16:54 ` Stefan Herbrechtsmeier
0 siblings, 0 replies; 22+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-06 16:54 UTC (permalink / raw)
To: openembedded-core
Am 06.02.22 um 17:43 schrieb Stefan Herbrechtsmeier:
> Am 06.02.22 um 10:53 schrieb Richard Purdie:
>> On Sun, 2022-02-06 at 08:10 +0000, Richard Purdie via
>> lists.openembedded.org
>> wrote:
>>> On Wed, 2022-02-02 at 08:35 +0100, Stefan Herbrechtsmeier wrote:
>>>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>>>
>>>> Link udev shared with systemd helper to minimize the udev package size
>>>> if DISTRO_FEATURES contains systemd.
>>>>
>>>> It is only usefull to link udev static with systemd helper if udev
>>>> should be installed without systemd.
>>>>
>>>> Signed-off-by: Stefan Herbrechtsmeier
>>>> <stefan.herbrechtsmeier@weidmueller.com>
>>>>
>>>> ---
>>>>
>>>> (no changes since v1)
>>>>
>>>> meta/recipes-core/systemd/systemd_249.7.bb | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>
>>>
>>> This seems to break some of our tests:
>>>
>>> https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/4708
>>> https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3121
>>> https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/3085
>>> https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/3089
>>> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3127
>>>
>>> Presumably it causes extra dependencies to be pulled in causing the
>>> file overlap
>>> where there was previously none.
>>
>> Thinking a bit more, I think this needs to be:
>>
>> diff --git a/meta/recipes-core/systemd/systemd_250.3.bb
>> b/meta/recipes-core/systemd/systemd_250.3.bb
>> index 2b6bfcc2c25..7851c4c16a7 100644
>> --- a/meta/recipes-core/systemd/systemd_250.3.bb
>> +++ b/meta/recipes-core/systemd/systemd_250.3.bb
>> @@ -69,7 +69,7 @@ PACKAGECONFIG ??= " \
>> ${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig
>> pam selinux smack usrmerge polkit seccomp', d)} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '', d)} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '',
>> d)} \
>> - ${@bb.utils.contains('DISTRO_FEATURES', 'systemd',
>> 'link-udev-shared', '', d)} \
>> + ${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', '',
>> 'link-udev-shared', d)} \
>> backlight \
>> binfmt \
>> gshadow \
>>
>>
>> which I'll test...
>
> Maybe the systemd naming for the option is sub optimal. The
> link-udev-shared option create a dependency between udev and systemd
> package. It links udev against the libsystemd-shared library. Without it
> udev is linked statically against this library. The option should only
> be enabled if udev is always used together with systemd.
Sorry, I should read the patch careful.
I we can assume that udev from systemd is only used with sysvinit or
systemd, this is okay.
Regards
Stefan
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-06 8:10 ` [OE-core] " Richard Purdie
2022-02-06 16:39 ` Stefan Herbrechtsmeier
@ 2022-02-06 17:23 ` Mark Hatle
1 sibling, 0 replies; 22+ messages in thread
From: Mark Hatle @ 2022-02-06 17:23 UTC (permalink / raw)
To: Richard Purdie, Stefan Herbrechtsmeier, openembedded-core
Cc: Stefan Herbrechtsmeier
I just noticed this. It might make sense to link udev static when BOTH systemd
and sysvinit are enabled. (A single package set, multiple images with different
init managers.)
Not sure though how that works in Honister, just something I noticed with this
commit. (And yes, I do use a distro with BOTH sysvinit and systemd enabled for
a single package set.)
--Mark
On 2/6/22 2:10 AM, Richard Purdie wrote:
> On Wed, 2022-02-02 at 08:35 +0100, Stefan Herbrechtsmeier wrote:
>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>
>> Link udev shared with systemd helper to minimize the udev package size
>> if DISTRO_FEATURES contains systemd.
>>
>> It is only usefull to link udev static with systemd helper if udev
>> should be installed without systemd.
>>
>> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>
>> ---
>>
>> (no changes since v1)
>>
>> meta/recipes-core/systemd/systemd_249.7.bb | 1 +
>> 1 file changed, 1 insertion(+)
>
>
> This seems to break some of our tests:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/4708
> https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3121
> https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/3085
> https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/3089
> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3127
>
> Presumably it causes extra dependencies to be pulled in causing the file overlap
> where there was previously none.
>
> Cheers,
>
> Richard
>
>
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#161392): https://lists.openembedded.org/g/openembedded-core/message/161392
> Mute This Topic: https://lists.openembedded.org/mt/88853822/3616948
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mark.hatle@kernel.crashing.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-06 16:39 ` Stefan Herbrechtsmeier
@ 2022-02-06 17:26 ` Mark Hatle
2022-02-06 17:31 ` Alexander Kanavin
0 siblings, 1 reply; 22+ messages in thread
From: Mark Hatle @ 2022-02-06 17:26 UTC (permalink / raw)
To: Stefan Herbrechtsmeier, Richard Purdie, Stefan Herbrechtsmeier,
openembedded-core
Cc: Stefan Herbrechtsmeier
On 2/6/22 10:39 AM, Stefan Herbrechtsmeier wrote:
> Am 06.02.22 um 09:10 schrieb Richard Purdie:
>> On Wed, 2022-02-02 at 08:35 +0100, Stefan Herbrechtsmeier wrote:
>>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>>
>>> Link udev shared with systemd helper to minimize the udev package size
>>> if DISTRO_FEATURES contains systemd.
>>>
>>> It is only usefull to link udev static with systemd helper if udev
>>> should be installed without systemd.
>>>
>>> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>>
>>> ---
>>>
>>> (no changes since v1)
>>>
>>> meta/recipes-core/systemd/systemd_249.7.bb | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>>
>> This seems to break some of our tests:
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/4708
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/3121
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/3085
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/3089
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/3127
>>
>> Presumably it causes extra dependencies to be pulled in causing the file overlap
>> where there was previously none.
>
> Sorry, I was told sysvinit with systemd isn't a valid use case anymore.
It definitely works in Honister (I'm actively using it.)
We produce a single package set, then allow for multiple image recipes to select
which init manager to use. This simplifies the eSDK, sstate-cache and binary
package feed -- while still giving the end user the ability to switch.
(And there is a HUGE difference in image size between sysvinit and systemd.)
--Mark
> Would it be okay to enable it only if sysvinit isn't in distro?
>
> Otherwise reject the change because it is impossible to know if a
> dependency between udev and systemd is okay or not.
>
> Regads
> Stefan
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#161402): https://lists.openembedded.org/g/openembedded-core/message/161402
> Mute This Topic: https://lists.openembedded.org/mt/88853822/3616948
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mark.hatle@kernel.crashing.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-06 17:26 ` Mark Hatle
@ 2022-02-06 17:31 ` Alexander Kanavin
2022-02-06 17:35 ` Richard Purdie
0 siblings, 1 reply; 22+ messages in thread
From: Alexander Kanavin @ 2022-02-06 17:31 UTC (permalink / raw)
To: Mark Hatle
Cc: Stefan Herbrechtsmeier, Richard Purdie, Stefan Herbrechtsmeier,
OE-core, Stefan Herbrechtsmeier
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
On Sun, 6 Feb 2022 at 18:27, Mark Hatle <mark.hatle@kernel.crashing.org>
wrote:
> It definitely works in Honister (I'm actively using it.)
>
> We produce a single package set, then allow for multiple image recipes to
> select
> which init manager to use. This simplifies the eSDK, sstate-cache and
> binary
> package feed -- while still giving the end user the ability to switch.
>
Selection of init manager is a distro setting, it can be used by component
recipes to make decisions, and overriding it from images is neither tested
nor supported.
Alex
[-- Attachment #2: Type: text/html, Size: 912 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-06 17:31 ` Alexander Kanavin
@ 2022-02-06 17:35 ` Richard Purdie
2022-02-06 17:43 ` Alexander Kanavin
2022-02-06 19:05 ` Mark Hatle
0 siblings, 2 replies; 22+ messages in thread
From: Richard Purdie @ 2022-02-06 17:35 UTC (permalink / raw)
To: Alexander Kanavin, Mark Hatle
Cc: Stefan Herbrechtsmeier, Stefan Herbrechtsmeier, OE-core,
Stefan Herbrechtsmeier
On Sun, 2022-02-06 at 18:31 +0100, Alexander Kanavin wrote:
> On Sun, 6 Feb 2022 at 18:27, Mark Hatle <mark.hatle@kernel.crashing.org>
> wrote:
> > It definitely works in Honister (I'm actively using it.)
> >
> > We produce a single package set, then allow for multiple image recipes to
> > select
> > which init manager to use. This simplifies the eSDK, sstate-cache and
> > binary
> > package feed -- while still giving the end user the ability to switch.
> >
>
>
> Selection of init manager is a distro setting, it can be used by component
> recipes to make decisions, and overriding it from images is neither tested nor
> supported.
There is a hybrid where you can enable sysvinit and systemd at the same time and
use them in different situations. We do test that and it is that test which
showed issues on the autobuilder with this patch.
It isn't as easy as pick and chose either in a given image but handy for
initramfs and some other uses.
Cheers,
Richard
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-06 17:35 ` Richard Purdie
@ 2022-02-06 17:43 ` Alexander Kanavin
2022-02-06 19:05 ` Mark Hatle
1 sibling, 0 replies; 22+ messages in thread
From: Alexander Kanavin @ 2022-02-06 17:43 UTC (permalink / raw)
To: Richard Purdie
Cc: Mark Hatle, Stefan Herbrechtsmeier, Stefan Herbrechtsmeier,
OE-core, Stefan Herbrechtsmeier
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
On Sun, 6 Feb 2022 at 18:35, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:
> > Selection of init manager is a distro setting, it can be used by
> component
> > recipes to make decisions, and overriding it from images is neither
> tested nor
> > supported.
>
> There is a hybrid where you can enable sysvinit and systemd at the same
> time and
> use them in different situations. We do test that and it is that test which
> showed issues on the autobuilder with this patch.
>
> It isn't as easy as pick and chose either in a given image but handy for
> initramfs and some other uses.
>
I believe what we test is this:
https://git.yoctoproject.org/yocto-autobuilder-helper/tree/config.json#n1034
It only enables both systemd and sysvinit distro features, but does not
redefine init managers on the image level - it remains systemd everywhere
as explicitly set in the test (with ability to load legacy sysvinit scripts
added to it).
Hybrid initramfs case should be helped by the recent multiconfig patch:
kernel.bbclass: Allow initramfs to be built from a separate multiconfig
Alex
[-- Attachment #2: Type: text/html, Size: 1884 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-06 17:35 ` Richard Purdie
2022-02-06 17:43 ` Alexander Kanavin
@ 2022-02-06 19:05 ` Mark Hatle
2022-02-07 12:12 ` Stefan Herbrechtsmeier
1 sibling, 1 reply; 22+ messages in thread
From: Mark Hatle @ 2022-02-06 19:05 UTC (permalink / raw)
To: Richard Purdie, Alexander Kanavin
Cc: Stefan Herbrechtsmeier, Stefan Herbrechtsmeier, OE-core,
Stefan Herbrechtsmeier
On 2/6/22 11:35 AM, Richard Purdie wrote:
> On Sun, 2022-02-06 at 18:31 +0100, Alexander Kanavin wrote:
>> On Sun, 6 Feb 2022 at 18:27, Mark Hatle <mark.hatle@kernel.crashing.org>
>> wrote:
>>> It definitely works in Honister (I'm actively using it.)
>>>
>>> We produce a single package set, then allow for multiple image recipes to
>>> select
>>> which init manager to use. This simplifies the eSDK, sstate-cache and
>>> binary
>>> package feed -- while still giving the end user the ability to switch.
>>>
>>
>>
>> Selection of init manager is a distro setting, it can be used by component
>> recipes to make decisions, and overriding it from images is neither tested nor
>> supported.
>
> There is a hybrid where you can enable sysvinit and systemd at the same time and
> use them in different situations. We do test that and it is that test which
> showed issues on the autobuilder with this patch.
>
> It isn't as easy as pick and chose either in a given image but handy for
> initramfs and some other uses.
I've got the following in my distro:
# Create packages that support both systemd and sysvinit
# but only on arm/arm64 systems, microblaze is sysvinit only
DISTRO_FEATURES_BACKFILL_CONSIDERED:remove:arm = "sysvinit systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED:remove:aarch64 = "sysvinit systemd"
DISTRO_FEATURES_BACKFILL:append:arm = " systemd"
DISTRO_FEATURES_BACKFILL:append:aarch64 = " systemd”
INIT_MANAGER_DEFAULT = "systemd"
INIT_MANAGER_DEFAULT:microblaze = "sysvinit"
INIT_MANAGER_DEFAULT:zynq = "sysvinit"
INIT_MANAGER ?= "${INIT_MANAGER_DEFAULT}"
Then a few configurations change the INIT_MANAGER, and (almost) all of the
sstate is re-usable and things don't need to be re-built.
The issue I have, microblaze if the filesystem is over about 80mb it doesn't fit
into memory. On Arm, some devices are memory limited the same way microblaze
is, while some have full access to flash storage and thus can use systemd. And
on aarch64 - most defined (but not all) have flash storage.
This is all about sstate-cache re-use (time to build the image) and ability to
have a SINGLE binary distribution that supports the image size requirements of
the user.
--Mark
> Cheers,
>
> Richard
>
>
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#161408): https://lists.openembedded.org/g/openembedded-core/message/161408
> Mute This Topic: https://lists.openembedded.org/mt/88853822/3616948
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mark.hatle@kernel.crashing.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-06 19:05 ` Mark Hatle
@ 2022-02-07 12:12 ` Stefan Herbrechtsmeier
0 siblings, 0 replies; 22+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-07 12:12 UTC (permalink / raw)
To: Mark Hatle, Richard Purdie, Alexander Kanavin
Cc: Stefan Herbrechtsmeier, OE-core, Stefan Herbrechtsmeier
Am 06.02.2022 um 20:05 schrieb Mark Hatle:
> On 2/6/22 11:35 AM, Richard Purdie wrote:
>> On Sun, 2022-02-06 at 18:31 +0100, Alexander Kanavin wrote:
>>> On Sun, 6 Feb 2022 at 18:27, Mark Hatle <mark.hatle@kernel.crashing.org>
>>> wrote:
>>>> It definitely works in Honister (I'm actively using it.)
>>>>
>>>> We produce a single package set, then allow for multiple image
>>>> recipes to
>>>> select
>>>> which init manager to use. This simplifies the eSDK, sstate-cache and
>>>> binary
>>>> package feed -- while still giving the end user the ability to switch.
>>>>
>>>
>>>
>>> Selection of init manager is a distro setting, it can be used by
>>> component
>>> recipes to make decisions, and overriding it from images is neither
>>> tested nor
>>> supported.
>>
>> There is a hybrid where you can enable sysvinit and systemd at the
>> same time and
>> use them in different situations. We do test that and it is that test
>> which
>> showed issues on the autobuilder with this patch.
>>
>> It isn't as easy as pick and chose either in a given image but handy for
>> initramfs and some other uses.
>
> I've got the following in my distro:
>
> # Create packages that support both systemd and sysvinit
> # but only on arm/arm64 systems, microblaze is sysvinit only
> DISTRO_FEATURES_BACKFILL_CONSIDERED:remove:arm = "sysvinit systemd"
> DISTRO_FEATURES_BACKFILL_CONSIDERED:remove:aarch64 = "sysvinit systemd"
> DISTRO_FEATURES_BACKFILL:append:arm = " systemd"
> DISTRO_FEATURES_BACKFILL:append:aarch64 = " systemd”
>
> INIT_MANAGER_DEFAULT = "systemd"
> INIT_MANAGER_DEFAULT:microblaze = "sysvinit"
> INIT_MANAGER_DEFAULT:zynq = "sysvinit"
>
> INIT_MANAGER ?= "${INIT_MANAGER_DEFAULT}"
>
> Then a few configurations change the INIT_MANAGER, and (almost) all of
> the sstate is re-usable and things don't need to be re-built.
>
> The issue I have, microblaze if the filesystem is over about 80mb it
> doesn't fit into memory. On Arm, some devices are memory limited the
> same way microblaze is, while some have full access to flash storage and
> thus can use systemd. And on aarch64 - most defined (but not all) have
> flash storage.
>
> This is all about sstate-cache re-use (time to build the image) and
> ability to have a SINGLE binary distribution that supports the image
> size requirements of the user.
After the change from Richard the optimization will only take place if
DISTRO_FEATURES doesn't contain sysvinit and you will get the
independent systemd and udev packages for all your platforms.
Regards
Stefan
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-02 7:35 ` [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd Stefan Herbrechtsmeier
2022-02-06 8:10 ` [OE-core] " Richard Purdie
[not found] ` <16D124152B709F2D.20549@lists.openembedded.org>
@ 2022-02-22 9:20 ` Yu, Mingli
2022-02-22 13:26 ` Stefan Herbrechtsmeier
2 siblings, 1 reply; 22+ messages in thread
From: Yu, Mingli @ 2022-02-22 9:20 UTC (permalink / raw)
To: Stefan Herbrechtsmeier, openembedded-core; +Cc: Stefan Herbrechtsmeier
[-- Attachment #1: Type: text/plain, Size: 2382 bytes --]
Hi,
On 2/2/22 3:35 PM, Stefan Herbrechtsmeier wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>
> Link udev shared with systemd helper to minimize the udev package size
> if DISTRO_FEATURES contains systemd.
>
> It is only usefull to link udev static with systemd helper if udev
> should be installed without systemd.
>
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>
> ---
>
> (no changes since v1)
>
> meta/recipes-core/systemd/systemd_249.7.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/systemd/systemd_249.7.bb b/meta/recipes-core/systemd/systemd_249.7.bb
> index 739f3aae86..431781e6c7 100644
> --- a/meta/recipes-core/systemd/systemd_249.7.bb
> +++ b/meta/recipes-core/systemd/systemd_249.7.bb
> @@ -66,6 +66,7 @@ PACKAGECONFIG ??= " \
> ${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig pam selinux smack usrmerge polkit seccomp', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)} \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'link-udev-shared', '', d)} \
After this change, the iso image failed to boot with below error:
Cannot find rootfs.img file in /run/media/*, dropping to a shell
And more detailed about the error as the attached.
Steps to reproduce:
1, update conf/local.conf to use systemd as the default init manager
DISTRO_FEATURES:append = " systemd"
DISTRO_FEATURES_BACKFILL_CONSIDERED += "sysvinit"
VIRTUAL-RUNTIME_init_manager = "systemd"
VIRTUAL-RUNTIME_initscripts = "systemd-compat-units"
KERNEL_FEATURES:append = " cfg/systemd.scc"
2, bitbake core-image-minimal
3, runqemu qemux86-64 core-image-minimal iso
Thanks,
> backlight \
> binfmt \
> gshadow \
> --
> 2.30.2
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#161182): https://lists.openembedded.org/g/openembedded-core/message/161182
> Mute This Topic: https://lists.openembedded.org/mt/88853822/3618448
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [mingli.yu@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
[-- Attachment #2: iso_boot_error.png --]
[-- Type: image/png, Size: 164347 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-22 9:20 ` Yu, Mingli
@ 2022-02-22 13:26 ` Stefan Herbrechtsmeier
2022-02-23 1:49 ` Yu, Mingli
0 siblings, 1 reply; 22+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-22 13:26 UTC (permalink / raw)
To: Yu, Mingli, openembedded-core; +Cc: Stefan Herbrechtsmeier
Hi,
Am 22.02.2022 um 10:20 schrieb Yu, Mingli:
> Hi,
>
> On 2/2/22 3:35 PM, Stefan Herbrechtsmeier wrote:
>> [Please note: This e-mail is from an EXTERNAL e-mail address]
>>
>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>
>> Link udev shared with systemd helper to minimize the udev package size
>> if DISTRO_FEATURES contains systemd.
>>
>> It is only usefull to link udev static with systemd helper if udev
>> should be installed without systemd.
>>
>> Signed-off-by: Stefan Herbrechtsmeier
>> <stefan.herbrechtsmeier@weidmueller.com>
>>
>> ---
>>
>> (no changes since v1)
>>
>> meta/recipes-core/systemd/systemd_249.7.bb | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-core/systemd/systemd_249.7.bb
>> b/meta/recipes-core/systemd/systemd_249.7.bb
>> index 739f3aae86..431781e6c7 100644
>> --- a/meta/recipes-core/systemd/systemd_249.7.bb
>> +++ b/meta/recipes-core/systemd/systemd_249.7.bb
>> @@ -66,6 +66,7 @@ PACKAGECONFIG ??= " \
>> ${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig
>> pam selinux smack usrmerge polkit seccomp', d)} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '', d)} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '',
>> d)} \
>> + ${@bb.utils.contains('DISTRO_FEATURES', 'systemd',
>> 'link-udev-shared', '', d)} \
>
> After this change, the iso image failed to boot with below error:
> Cannot find rootfs.img file in /run/media/*, dropping to a shell
>
> And more detailed about the error as the attached.
>
> Steps to reproduce:
> 1, update conf/local.conf to use systemd as the default init manager
> DISTRO_FEATURES:append = " systemd"
> DISTRO_FEATURES_BACKFILL_CONSIDERED += "sysvinit"
> VIRTUAL-RUNTIME_init_manager = "systemd"
> VIRTUAL-RUNTIME_initscripts = "systemd-compat-units"
> KERNEL_FEATURES:append = " cfg/systemd.scc"
You have to set the INIT_MANAGER variable instead or set the
VIRTUAL-RUNTIME_dev_manager variable to systemd.
> 2, bitbake core-image-minimal
>
> 3, runqemu qemux86-64 core-image-minimal iso
A revert of the commit solve your problem?
Regards
Stefan
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-22 13:26 ` Stefan Herbrechtsmeier
@ 2022-02-23 1:49 ` Yu, Mingli
2022-02-23 8:13 ` Stefan Herbrechtsmeier
0 siblings, 1 reply; 22+ messages in thread
From: Yu, Mingli @ 2022-02-23 1:49 UTC (permalink / raw)
To: Stefan Herbrechtsmeier, openembedded-core; +Cc: Stefan Herbrechtsmeier
On 2/22/22 9:26 PM, Stefan Herbrechtsmeier wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> Hi,
>
> Am 22.02.2022 um 10:20 schrieb Yu, Mingli:
>> Hi,
>>
>> On 2/2/22 3:35 PM, Stefan Herbrechtsmeier wrote:
>>> [Please note: This e-mail is from an EXTERNAL e-mail address]
>>>
>>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>>
>>> Link udev shared with systemd helper to minimize the udev package size
>>> if DISTRO_FEATURES contains systemd.
>>>
>>> It is only usefull to link udev static with systemd helper if udev
>>> should be installed without systemd.
>>>
>>> Signed-off-by: Stefan Herbrechtsmeier
>>> <stefan.herbrechtsmeier@weidmueller.com>
>>>
>>> ---
>>>
>>> (no changes since v1)
>>>
>>> meta/recipes-core/systemd/systemd_249.7.bb | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta/recipes-core/systemd/systemd_249.7.bb
>>> b/meta/recipes-core/systemd/systemd_249.7.bb
>>> index 739f3aae86..431781e6c7 100644
>>> --- a/meta/recipes-core/systemd/systemd_249.7.bb
>>> +++ b/meta/recipes-core/systemd/systemd_249.7.bb
>>> @@ -66,6 +66,7 @@ PACKAGECONFIG ??= " \
>>> ${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig
>>> pam selinux smack usrmerge polkit seccomp', d)} \
>>> ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '',
>>> d)} \
>>> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '',
>>> d)} \
>>> + ${@bb.utils.contains('DISTRO_FEATURES', 'systemd',
>>> 'link-udev-shared', '', d)} \
>>
>> After this change, the iso image failed to boot with below error:
>> Cannot find rootfs.img file in /run/media/*, dropping to a shell
>>
>> And more detailed about the error as the attached.
>>
>> Steps to reproduce:
>> 1, update conf/local.conf to use systemd as the default init manager
>> DISTRO_FEATURES:append = " systemd"
>> DISTRO_FEATURES_BACKFILL_CONSIDERED += "sysvinit"
>> VIRTUAL-RUNTIME_init_manager = "systemd"
>> VIRTUAL-RUNTIME_initscripts = "systemd-compat-units"
>> KERNEL_FEATURES:append = " cfg/systemd.scc"
> You have to set the INIT_MANAGER variable instead or set the
> VIRTUAL-RUNTIME_dev_manager variable to systemd.
>
>> 2, bitbake core-image-minimal
>>
>> 3, runqemu qemux86-64 core-image-minimal iso
>
> A revert of the commit solve your problem?
Yes, the issue is gone after revert the commit.
Thanks,
>
> Regards
> Stefan
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-23 1:49 ` Yu, Mingli
@ 2022-02-23 8:13 ` Stefan Herbrechtsmeier
2022-02-23 12:39 ` Richard Purdie
0 siblings, 1 reply; 22+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-23 8:13 UTC (permalink / raw)
To: Yu, Mingli, openembedded-core; +Cc: Stefan Herbrechtsmeier
Hi,
Am 23.02.2022 um 02:49 schrieb Yu, Mingli:
>
>
> On 2/22/22 9:26 PM, Stefan Herbrechtsmeier wrote:
>> [Please note: This e-mail is from an EXTERNAL e-mail address]
>>
>> Hi,
>>
>> Am 22.02.2022 um 10:20 schrieb Yu, Mingli:
>>> Hi,
>>>
>>> On 2/2/22 3:35 PM, Stefan Herbrechtsmeier wrote:
>>>> [Please note: This e-mail is from an EXTERNAL e-mail address]
>>>>
>>>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>>>>
>>>> Link udev shared with systemd helper to minimize the udev package size
>>>> if DISTRO_FEATURES contains systemd.
>>>>
>>>> It is only usefull to link udev static with systemd helper if udev
>>>> should be installed without systemd.
>>>>
>>>> Signed-off-by: Stefan Herbrechtsmeier
>>>> <stefan.herbrechtsmeier@weidmueller.com>
>>>>
>>>> ---
>>>>
>>>> (no changes since v1)
>>>>
>>>> meta/recipes-core/systemd/systemd_249.7.bb | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/meta/recipes-core/systemd/systemd_249.7.bb
>>>> b/meta/recipes-core/systemd/systemd_249.7.bb
>>>> index 739f3aae86..431781e6c7 100644
>>>> --- a/meta/recipes-core/systemd/systemd_249.7.bb
>>>> +++ b/meta/recipes-core/systemd/systemd_249.7.bb
>>>> @@ -66,6 +66,7 @@ PACKAGECONFIG ??= " \
>>>> ${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig
>>>> pam selinux smack usrmerge polkit seccomp', d)} \
>>>> ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '',
>>>> d)} \
>>>> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '',
>>>> d)} \
>>>> + ${@bb.utils.contains('DISTRO_FEATURES', 'systemd',
>>>> 'link-udev-shared', '', d)} \
>>>
>>> After this change, the iso image failed to boot with below error:
>>> Cannot find rootfs.img file in /run/media/*, dropping to a shell
>>>
>>> And more detailed about the error as the attached.
>>>
>>> Steps to reproduce:
>>> 1, update conf/local.conf to use systemd as the default init manager
>>> DISTRO_FEATURES:append = " systemd"
>>> DISTRO_FEATURES_BACKFILL_CONSIDERED += "sysvinit"
>>> VIRTUAL-RUNTIME_init_manager = "systemd"
>>> VIRTUAL-RUNTIME_initscripts = "systemd-compat-units"
>>> KERNEL_FEATURES:append = " cfg/systemd.scc"
>> You have to set the INIT_MANAGER variable instead or set the
>> VIRTUAL-RUNTIME_dev_manager variable to systemd.
>>
>>> 2, bitbake core-image-minimal
>>>
>>> 3, runqemu qemux86-64 core-image-minimal iso
>>
>> A revert of the commit solve your problem?
>
> Yes, the issue is gone after revert the commit.
It looks like a loot of packages have a direct runtime dependency to
udev and after this patch udev have a runtime dependency to systemd. We
could revert this patch or move libsystemd-shared.so to its own package
to remove the dependency to systemd itself.
Regards
Stefan
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-23 8:13 ` Stefan Herbrechtsmeier
@ 2022-02-23 12:39 ` Richard Purdie
2022-02-23 13:17 ` Stefan Herbrechtsmeier
0 siblings, 1 reply; 22+ messages in thread
From: Richard Purdie @ 2022-02-23 12:39 UTC (permalink / raw)
To: Stefan Herbrechtsmeier, Yu, Mingli, openembedded-core
Cc: Stefan Herbrechtsmeier
On Wed, 2022-02-23 at 09:13 +0100, Stefan Herbrechtsmeier wrote:
> Hi,
>
> Am 23.02.2022 um 02:49 schrieb Yu, Mingli:
> >
> >
> > On 2/22/22 9:26 PM, Stefan Herbrechtsmeier wrote:
> > > [Please note: This e-mail is from an EXTERNAL e-mail address]
> > >
> > > Hi,
> > >
> > > Am 22.02.2022 um 10:20 schrieb Yu, Mingli:
> > > > Hi,
> > > >
> > > > On 2/2/22 3:35 PM, Stefan Herbrechtsmeier wrote:
> > > > > [Please note: This e-mail is from an EXTERNAL e-mail address]
> > > > >
> > > > > From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> > > > >
> > > > > Link udev shared with systemd helper to minimize the udev package size
> > > > > if DISTRO_FEATURES contains systemd.
> > > > >
> > > > > It is only usefull to link udev static with systemd helper if udev
> > > > > should be installed without systemd.
> > > > >
> > > > > Signed-off-by: Stefan Herbrechtsmeier
> > > > > <stefan.herbrechtsmeier@weidmueller.com>
> > > > >
> > > > > ---
> > > > >
> > > > > (no changes since v1)
> > > > >
> > > > > meta/recipes-core/systemd/systemd_249.7.bb | 1 +
> > > > > 1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/meta/recipes-core/systemd/systemd_249.7.bb
> > > > > b/meta/recipes-core/systemd/systemd_249.7.bb
> > > > > index 739f3aae86..431781e6c7 100644
> > > > > --- a/meta/recipes-core/systemd/systemd_249.7.bb
> > > > > +++ b/meta/recipes-core/systemd/systemd_249.7.bb
> > > > > @@ -66,6 +66,7 @@ PACKAGECONFIG ??= " \
> > > > > ${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig
> > > > > pam selinux smack usrmerge polkit seccomp', d)} \
> > > > > ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '',
> > > > > d)} \
> > > > > ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '',
> > > > > d)} \
> > > > > + ${@bb.utils.contains('DISTRO_FEATURES', 'systemd',
> > > > > 'link-udev-shared', '', d)} \
> > > >
> > > > After this change, the iso image failed to boot with below error:
> > > > Cannot find rootfs.img file in /run/media/*, dropping to a shell
> > > >
> > > > And more detailed about the error as the attached.
> > > >
> > > > Steps to reproduce:
> > > > 1, update conf/local.conf to use systemd as the default init manager
> > > > DISTRO_FEATURES:append = " systemd"
> > > > DISTRO_FEATURES_BACKFILL_CONSIDERED += "sysvinit"
> > > > VIRTUAL-RUNTIME_init_manager = "systemd"
> > > > VIRTUAL-RUNTIME_initscripts = "systemd-compat-units"
> > > > KERNEL_FEATURES:append = " cfg/systemd.scc"
> > > You have to set the INIT_MANAGER variable instead or set the
> > > VIRTUAL-RUNTIME_dev_manager variable to systemd.
> > >
> > > > 2, bitbake core-image-minimal
> > > >
> > > > 3, runqemu qemux86-64 core-image-minimal iso
> > >
> > > A revert of the commit solve your problem?
> >
> > Yes, the issue is gone after revert the commit.
>
> It looks like a loot of packages have a direct runtime dependency to
> udev and after this patch udev have a runtime dependency to systemd. We
> could revert this patch or move libsystemd-shared.so to its own package
> to remove the dependency to systemd itself.
A separate package for it would seem like a good option and could smplify the
original issues we saw enabling this too?
Cheers,
Richard
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [OE-core] [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd
2022-02-23 12:39 ` Richard Purdie
@ 2022-02-23 13:17 ` Stefan Herbrechtsmeier
0 siblings, 0 replies; 22+ messages in thread
From: Stefan Herbrechtsmeier @ 2022-02-23 13:17 UTC (permalink / raw)
To: Richard Purdie, Yu, Mingli, openembedded-core; +Cc: Stefan Herbrechtsmeier
Am 23.02.2022 um 13:39 schrieb Richard Purdie:
> On Wed, 2022-02-23 at 09:13 +0100, Stefan Herbrechtsmeier wrote:
>> Am 23.02.2022 um 02:49 schrieb Yu, Mingli:
>>> On 2/22/22 9:26 PM, Stefan Herbrechtsmeier wrote:
>>>> [Please note: This e-mail is from an EXTERNAL e-mail address]
>>>> Am 22.02.2022 um 10:20 schrieb Yu, Mingli:
>>>>> On 2/2/22 3:35 PM, Stefan Herbrechtsmeier wrote:
>>>>>> Link udev shared with systemd helper to minimize the udev package size
>>>>>> if DISTRO_FEATURES contains systemd.
>>>>>>
>>>>>> It is only usefull to link udev static with systemd helper if udev
>>>>>> should be installed without systemd.
>>>>>>
>>>>>> Signed-off-by: Stefan Herbrechtsmeier
>>>>>> <stefan.herbrechtsmeier@weidmueller.com>
>>>>>>
>>>>>> ---
>>>>>>
>>>>>> (no changes since v1)
>>>>>>
>>>>>> meta/recipes-core/systemd/systemd_249.7.bb | 1 +
>>>>>> 1 file changed, 1 insertion(+)
>>>>>>
>>>>>> diff --git a/meta/recipes-core/systemd/systemd_249.7.bb
>>>>>> b/meta/recipes-core/systemd/systemd_249.7.bb
>>>>>> index 739f3aae86..431781e6c7 100644
>>>>>> --- a/meta/recipes-core/systemd/systemd_249.7.bb
>>>>>> +++ b/meta/recipes-core/systemd/systemd_249.7.bb
>>>>>> @@ -66,6 +66,7 @@ PACKAGECONFIG ??= " \
>>>>>> ${@bb.utils.filter('DISTRO_FEATURES', 'acl audit efi ldconfig
>>>>>> pam selinux smack usrmerge polkit seccomp', d)} \
>>>>>> ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', 'rfkill', '',
>>>>>> d)} \
>>>>>> ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '',
>>>>>> d)} \
>>>>>> + ${@bb.utils.contains('DISTRO_FEATURES', 'systemd',
>>>>>> 'link-udev-shared', '', d)} \
>>>>>
>>>>> After this change, the iso image failed to boot with below error:
>>>>> Cannot find rootfs.img file in /run/media/*, dropping to a shell
>>>>>
>>>>> And more detailed about the error as the attached.
>>>>>
>>>>> Steps to reproduce:
>>>>> 1, update conf/local.conf to use systemd as the default init manager
>>>>> DISTRO_FEATURES:append = " systemd"
>>>>> DISTRO_FEATURES_BACKFILL_CONSIDERED += "sysvinit"
>>>>> VIRTUAL-RUNTIME_init_manager = "systemd"
>>>>> VIRTUAL-RUNTIME_initscripts = "systemd-compat-units"
>>>>> KERNEL_FEATURES:append = " cfg/systemd.scc"
>>>> You have to set the INIT_MANAGER variable instead or set the
>>>> VIRTUAL-RUNTIME_dev_manager variable to systemd.
>>>>
>>>>> 2, bitbake core-image-minimal
>>>>>
>>>>> 3, runqemu qemux86-64 core-image-minimal iso
>>>>
>>>> A revert of the commit solve your problem?
>>>
>>> Yes, the issue is gone after revert the commit.
>>
>> It looks like a loot of packages have a direct runtime dependency to
>> udev and after this patch udev have a runtime dependency to systemd. We
>> could revert this patch or move libsystemd-shared.so to its own package
>> to remove the dependency to systemd itself.
>
> A separate package for it would seem like a good option and could smplify the
> original issues we saw enabling this too?
I think so but it will increase the size of the udev package because of
the size and dependencies of libsystemd-shared if you use udev without
systemd.
If we create a extra package udev, systemctl, networkd, timesyncd and
boot could be used without systemd package.
Regards
Stefan
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2022-02-23 13:17 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-02 7:35 [PATCH v2 1/3] cve-check: create directory of CVE_CHECK_MANIFEST before copy Stefan Herbrechtsmeier
2022-02-02 7:35 ` [PATCH v2 2/3] systemd: Add link-udev-shared PACKAGECONFIG Stefan Herbrechtsmeier
2022-02-02 7:35 ` [PATCH v2 3/3] systemd: Minimize udev package size if DISTRO_FEATURES contains systemd Stefan Herbrechtsmeier
2022-02-06 8:10 ` [OE-core] " Richard Purdie
2022-02-06 16:39 ` Stefan Herbrechtsmeier
2022-02-06 17:26 ` Mark Hatle
2022-02-06 17:31 ` Alexander Kanavin
2022-02-06 17:35 ` Richard Purdie
2022-02-06 17:43 ` Alexander Kanavin
2022-02-06 19:05 ` Mark Hatle
2022-02-07 12:12 ` Stefan Herbrechtsmeier
2022-02-06 17:23 ` Mark Hatle
[not found] ` <16D124152B709F2D.20549@lists.openembedded.org>
2022-02-06 9:53 ` Richard Purdie
2022-02-06 16:43 ` Stefan Herbrechtsmeier
[not found] ` <16D1401AF7E66E0D.14843@lists.openembedded.org>
2022-02-06 16:54 ` Stefan Herbrechtsmeier
2022-02-22 9:20 ` Yu, Mingli
2022-02-22 13:26 ` Stefan Herbrechtsmeier
2022-02-23 1:49 ` Yu, Mingli
2022-02-23 8:13 ` Stefan Herbrechtsmeier
2022-02-23 12:39 ` Richard Purdie
2022-02-23 13:17 ` Stefan Herbrechtsmeier
2022-02-02 8:54 ` [OE-core] [PATCH v2 1/3] cve-check: create directory of CVE_CHECK_MANIFEST before copy Alexander Kanavin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.