All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/util-linux: improve host build failure fix
Date: Thu, 3 Feb 2022 21:23:27 +0100	[thread overview]
Message-ID: <20220203212328.264bc948@gmx.net> (raw)
In-Reply-To: <20220202220538.2858380-1-giulio.benetti@benettiengineering.com>

Hello Giulio,

On Wed,  2 Feb 2022 23:05:38 +0100, Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> As suggested by Peter Seiderer package util-linux doesn't need raw support
> when built for host, so let's remove:
> HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE
> in favor of:
> HOST_UTIL_LINUX_CONF_OPTS += --disable-raw
> This is a better approach than my commit:
> https://git.buildroot.net/buildroot/commit/?id=d895bd973b35fde10d3dd7db530d9e4782926497
>
> Suggested-by: Peter Seiderer <ps.report@gmx.net>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Tested with registry.gitlab.com/buildroot.org/buildroot/base:20220105.2314:

- reverted 'package/util-linux: fix host build failure' (d895bd973b35fde10d3dd7db530d9e4782926497)
  --> build fails with: No rule to make target 'disk-utils/raw.8'

- build with 'package/util-linux: fix host build failure' (d895bd973b35fde10d3dd7db530d9e4782926497)
  --> build o.k.

- build with this additional patch
  --> build o.k.

Tested-by: Peter Seiderer <ps.report@gmx.net>


> ---
>  package/util-linux/util-linux.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
> index 5a4ff64d01..f3297257cf 100644
> --- a/package/util-linux/util-linux.mk
> +++ b/package/util-linux/util-linux.mk
> @@ -41,7 +41,6 @@ define UTIL_LINUX_FIX_DISK_UTILS_COMPILE
>  	touch $(@D)/disk-utils/raw.8
>  endef
>  UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE
> -HOST_UTIL_LINUX_POST_PATCH_HOOKS += UTIL_LINUX_FIX_DISK_UTILS_COMPILE
>
>  HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf
>

The line above reads:

	# We also don't want the host-python dependency

> @@ -49,7 +48,8 @@ HOST_UTIL_LINUX_DEPENDENCIES = host-pkgconf
>  HOST_UTIL_LINUX_CONF_OPTS = \
>  	--without-systemd \
>  	--with-systemdsystemunitdir=no \
> -	--without-python
> +	--without-python \
> +	--disable-raw

So I would move the 'disable-raw' down to line 196ff (or below to an
extra 'HOST_UTIL_LINUX_CONF_OPTS +=' section with comment why...

With this change you can add my:

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter

>
>  ifneq ($(BR2_PACKAGE_UTIL_LINUX_BINARIES)$(BR2_PACKAGE_UTIL_LINUX_CRAMFS)$(BR2_PACKAGE_UTIL_LINUX_FSCK)$(BR2_PACKAGE_UTIL_LINUX_LOSETUP),)
>  UTIL_LINUX_SELINUX_MODULES = fstools

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-02-03 20:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 23:22 [Buildroot] [URGENT 0/1] This patch is needed for host-util-linux Giulio Benetti
2022-02-01 23:22 ` [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure Giulio Benetti
2022-02-01 23:25   ` Giulio Benetti
2022-02-02  7:41   ` Arnout Vandecappelle
2022-02-02 20:42     ` Peter Seiderer
2022-02-02 21:09       ` Giulio Benetti
2022-02-02 21:40         ` Peter Seiderer
2022-02-02 21:54           ` Giulio Benetti
2022-02-02 22:05             ` [Buildroot] [PATCH] package/util-linux: improve host build failure fix Giulio Benetti
2022-02-03 20:23               ` Peter Seiderer [this message]
2022-02-03 22:29                 ` Giulio Benetti
2022-02-03 22:31                 ` [Buildroot] [PATCH v2] " Giulio Benetti
2022-02-12 22:02                   ` Arnout Vandecappelle
2022-02-02 22:10           ` [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220203212328.264bc948@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.