Re: [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure

From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Peter Seiderer <ps.report@gmx.net>
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [URGENT 1/1] package/util-linux: fix host build failure
Date: Wed, 2 Feb 2022 22:54:18 +0100	[thread overview]
Message-ID: <412baee3-b818-521a-99bf-ee868d3e1be2@benettiengineering.com> (raw)
In-Reply-To: <20220202224046.1ccef19a@gmx.net>

On 02/02/22 22:40, Peter Seiderer wrote:
> Hello Giulio,
> 
> On Wed, 2 Feb 2022 22:09:22 +0100, Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> Hi Peter,
>>
>> On 02/02/22 21:42, Peter Seiderer wrote:
>>> Hello Arnout, Giulio,
>>>
>>> On Wed, 2 Feb 2022 08:41:34 +0100, Arnout Vandecappelle <arnout@mind.be> wrote:
>>>
>>>> On 02/02/2022 00:22, Giulio Benetti wrote:
>>>>> The UTIL_LINUX_FIX_DISK_UTILS_COMPILE workaround is needed for host
>>>>> building too. So let's add it to HOST_UTIL_LINUX_POST_PATCH_HOOKS.
>>>>> host-util-linux is used a lot, so this patch fixes a lot of future
>>>>> builds.
>>>>
>>>>     Darn, I tested that, both with and without BR2_PACKAGE_HOST_UTIL_LINUX set. I
>>>> don't understand what went wrong in my test...
>>>
>>> The raw support depends on the available toolchain headers, see e.g.
>>> package/util-linux/Config.in:
>>>
>>> 	config BR2_PACKAGE_UTIL_LINUX_RAW
>>> 	        bool "raw"
>>> 	        depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_14
>>> 	        help
>>> 	          Build a linux raw character device
>>>
>>> Or according to [1] '--disable-raw' for the host build should do
>>> the trick too...
>>
>> I was in hurry to produce the patch last night, so I went for the
>> fastest way. Can you give a try with --disable-raw and eventually submit
> 
> Thanks for taking care!
> 
>> the patch? That would save some time while building. Also because
>> host-util-linux is used a lot
> 
> Sorry, could not reproduce the host-build failure on my system, seems the
> toolchain is too up-to-date (openSUSE Tumbleweed - gcc-11.2.1) ;-)
> 
> But can provide an RFC patch for testing...

I give a go on my pc and if it works I add
Suggested-by: Peter Seiderer <ps.report@gmx.net>

Are you on IRC? If yes my nick is benettig you can ping me there :-)

Best regards
-- 
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot