All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI
@ 2022-02-03 22:59 Giulio Benetti
  2022-02-03 22:59 ` [Buildroot] [PATCH 1/5] board/friendlyarm/nanopc-t4:use partition-type-uuid for genimage-15 Giulio Benetti
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Giulio Benetti @ 2022-02-03 22:59 UTC (permalink / raw)
  To: buildroot; +Cc: Giulio Benetti, Jagan Teki, Yann E . MORIN, Suniel Mahesh

Giulio Benetti (5):
  board/friendlyarm/nanopc-t4:use partition-type-uuid for genimage-15
  board/friendlyarm/nanopi-m4:use partition-type-uuid for genimage-15
  board/pine64/rockpro64:use partition-type-uuid for genimage-15
  board/radxa/rockpi-4:use partition-type-uuid for genimage-15
  board/radxa/rockpi-n10:use partition-type-uuid for genimage-15

 board/friendlyarm/nanopc-t4/genimage.cfg | 4 ++--
 board/friendlyarm/nanopi-m4/genimage.cfg | 4 ++--
 board/pine64/rockpro64/genimage.cfg      | 4 ++--
 board/radxa/rockpi-4/genimage.cfg        | 4 ++--
 board/radxa/rockpi-n10/genimage.cfg      | 4 ++--
 5 files changed, 10 insertions(+), 10 deletions(-)

-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 1/5] board/friendlyarm/nanopc-t4:use partition-type-uuid for genimage-15
  2022-02-03 22:59 [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI Giulio Benetti
@ 2022-02-03 22:59 ` Giulio Benetti
  2022-02-03 22:59 ` [Buildroot] [PATCH 2/5] board/friendlyarm/nanopi-m4:use " Giulio Benetti
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Giulio Benetti @ 2022-02-03 22:59 UTC (permalink / raw)
  To: buildroot; +Cc: Giulio Benetti, Jagan Teki, Yann E . MORIN, Suniel Mahesh

Genimage 15 restricted the partition-type option to mbr and hybrid
partition-table-type and now prints a warning when it is used [1]:

ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type

[1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876

So let's use for EFI System partition:
'partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b'
and for Root partition (64-bit ARM/AArch64):
'partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae'

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717055

FTR, the magic UUID are from:
    https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/friendlyarm/nanopc-t4/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/friendlyarm/nanopc-t4/genimage.cfg b/board/friendlyarm/nanopc-t4/genimage.cfg
index d63c293ab4..98dc2f3892 100644
--- a/board/friendlyarm/nanopc-t4/genimage.cfg
+++ b/board/friendlyarm/nanopc-t4/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type = 0xC
+		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type = 0x83
+		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/5] board/friendlyarm/nanopi-m4:use partition-type-uuid for genimage-15
  2022-02-03 22:59 [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI Giulio Benetti
  2022-02-03 22:59 ` [Buildroot] [PATCH 1/5] board/friendlyarm/nanopc-t4:use partition-type-uuid for genimage-15 Giulio Benetti
@ 2022-02-03 22:59 ` Giulio Benetti
  2022-02-03 22:59 ` [Buildroot] [PATCH 3/5] board/pine64/rockpro64:use " Giulio Benetti
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Giulio Benetti @ 2022-02-03 22:59 UTC (permalink / raw)
  To: buildroot; +Cc: Giulio Benetti, Jagan Teki, Yann E . MORIN, Suniel Mahesh

Genimage 15 restricted the partition-type option to mbr and hybrid
partition-table-type and now prints a warning when it is used [1]:

ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type

[1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876

So let's use for EFI System partition:
'partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b'
and for Root partition (64-bit ARM/AArch64):
'partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae'

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717059

FTR, the magic UUID are from:
    https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/friendlyarm/nanopi-m4/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/friendlyarm/nanopi-m4/genimage.cfg b/board/friendlyarm/nanopi-m4/genimage.cfg
index 35d056ae6e..8d0e6ad13b 100644
--- a/board/friendlyarm/nanopi-m4/genimage.cfg
+++ b/board/friendlyarm/nanopi-m4/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type = 0xC
+		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type = 0x83
+		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 3/5] board/pine64/rockpro64:use partition-type-uuid for genimage-15
  2022-02-03 22:59 [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI Giulio Benetti
  2022-02-03 22:59 ` [Buildroot] [PATCH 1/5] board/friendlyarm/nanopc-t4:use partition-type-uuid for genimage-15 Giulio Benetti
  2022-02-03 22:59 ` [Buildroot] [PATCH 2/5] board/friendlyarm/nanopi-m4:use " Giulio Benetti
@ 2022-02-03 22:59 ` Giulio Benetti
  2022-02-03 22:59 ` [Buildroot] [PATCH 4/5] board/radxa/rockpi-4:use " Giulio Benetti
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Giulio Benetti @ 2022-02-03 22:59 UTC (permalink / raw)
  To: buildroot; +Cc: Giulio Benetti, Jagan Teki, Yann E . MORIN, Suniel Mahesh

Genimage 15 restricted the partition-type option to mbr and hybrid
partition-table-type and now prints a warning when it is used [1]:

ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type

[1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876

So let's use for EFI System partition:
'partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b'
and for Root partition (64-bit ARM/AArch64):
'partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae'

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717243

FTR, the magic UUID are from:
    https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/pine64/rockpro64/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/pine64/rockpro64/genimage.cfg b/board/pine64/rockpro64/genimage.cfg
index 14dd0e1d18..d3926f2df6 100644
--- a/board/pine64/rockpro64/genimage.cfg
+++ b/board/pine64/rockpro64/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type = 0xC
+		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type = 0x83
+		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 4/5] board/radxa/rockpi-4:use partition-type-uuid for genimage-15
  2022-02-03 22:59 [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI Giulio Benetti
                   ` (2 preceding siblings ...)
  2022-02-03 22:59 ` [Buildroot] [PATCH 3/5] board/pine64/rockpro64:use " Giulio Benetti
@ 2022-02-03 22:59 ` Giulio Benetti
  2022-02-03 22:59 ` [Buildroot] [PATCH 5/5] board/radxa/rockpi-n10:use " Giulio Benetti
  2022-02-06  9:32 ` [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI Thomas Petazzoni via buildroot
  5 siblings, 0 replies; 7+ messages in thread
From: Giulio Benetti @ 2022-02-03 22:59 UTC (permalink / raw)
  To: buildroot; +Cc: Giulio Benetti, Jagan Teki, Yann E . MORIN, Suniel Mahesh

Genimage 15 restricted the partition-type option to mbr and hybrid
partition-table-type and now prints a warning when it is used [1]:

ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type

[1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876

So let's use for EFI System partition:
'partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b'
and for Root partition (64-bit ARM/AArch64):
'partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae'

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717240

FTR, the magic UUID are from:
    https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/radxa/rockpi-4/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/radxa/rockpi-4/genimage.cfg b/board/radxa/rockpi-4/genimage.cfg
index a5100af420..68cc4d61a8 100644
--- a/board/radxa/rockpi-4/genimage.cfg
+++ b/board/radxa/rockpi-4/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type = 0xC
+		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type = 0x83
+		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 5/5] board/radxa/rockpi-n10:use partition-type-uuid for genimage-15
  2022-02-03 22:59 [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI Giulio Benetti
                   ` (3 preceding siblings ...)
  2022-02-03 22:59 ` [Buildroot] [PATCH 4/5] board/radxa/rockpi-4:use " Giulio Benetti
@ 2022-02-03 22:59 ` Giulio Benetti
  2022-02-06  9:32 ` [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI Thomas Petazzoni via buildroot
  5 siblings, 0 replies; 7+ messages in thread
From: Giulio Benetti @ 2022-02-03 22:59 UTC (permalink / raw)
  To: buildroot; +Cc: Giulio Benetti, Jagan Teki, Yann E . MORIN, Suniel Mahesh

Genimage 15 restricted the partition-type option to mbr and hybrid
partition-table-type and now prints a warning when it is used [1]:

ERROR: hdimage(disk.img): part boot: 'partition-type' is only valid for mbr and hybrid partition-table-type

[1] https://github.com/pengutronix/genimage/commit/1d72d8091f83790a0a35a1ea7dc25d46adba8876

So let's use for EFI System partition:
'partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b'
and for Root partition (64-bit ARM/AArch64):
'partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae'

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1929717241

FTR, the magic UUID are from:
    https://en.wikipedia.org/wiki/GUID_Partition_Table#Partition_type_GUIDs

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 board/radxa/rockpi-n10/genimage.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/radxa/rockpi-n10/genimage.cfg b/board/radxa/rockpi-n10/genimage.cfg
index 652e75db11..7f4b639bbc 100644
--- a/board/radxa/rockpi-n10/genimage.cfg
+++ b/board/radxa/rockpi-n10/genimage.cfg
@@ -26,14 +26,14 @@ image sdcard.img {
 	}
 
 	partition boot {
-		partition-type = 0xC
+		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
 		bootable = "true"
 		image = "boot.vfat"
 		offset = 16M
 	}
 
 	partition rootfs {
-		partition-type = 0x83
+		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
 		image = "rootfs.ext4"
 	}
 }
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI
  2022-02-03 22:59 [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI Giulio Benetti
                   ` (4 preceding siblings ...)
  2022-02-03 22:59 ` [Buildroot] [PATCH 5/5] board/radxa/rockpi-n10:use " Giulio Benetti
@ 2022-02-06  9:32 ` Thomas Petazzoni via buildroot
  5 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-02-06  9:32 UTC (permalink / raw)
  To: Giulio Benetti; +Cc: Suniel Mahesh, Jagan Teki, Yann E . MORIN, buildroot

On Thu,  3 Feb 2022 23:59:52 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Giulio Benetti (5):
>   board/friendlyarm/nanopc-t4:use partition-type-uuid for genimage-15
>   board/friendlyarm/nanopi-m4:use partition-type-uuid for genimage-15
>   board/pine64/rockpro64:use partition-type-uuid for genimage-15
>   board/radxa/rockpi-4:use partition-type-uuid for genimage-15
>   board/radxa/rockpi-n10:use partition-type-uuid for genimage-15

Series applied, thanks

-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-02-06  9:33 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-03 22:59 [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI Giulio Benetti
2022-02-03 22:59 ` [Buildroot] [PATCH 1/5] board/friendlyarm/nanopc-t4:use partition-type-uuid for genimage-15 Giulio Benetti
2022-02-03 22:59 ` [Buildroot] [PATCH 2/5] board/friendlyarm/nanopi-m4:use " Giulio Benetti
2022-02-03 22:59 ` [Buildroot] [PATCH 3/5] board/pine64/rockpro64:use " Giulio Benetti
2022-02-03 22:59 ` [Buildroot] [PATCH 4/5] board/radxa/rockpi-4:use " Giulio Benetti
2022-02-03 22:59 ` [Buildroot] [PATCH 5/5] board/radxa/rockpi-n10:use " Giulio Benetti
2022-02-06  9:32 ` [Buildroot] [PATCH 0/5] Fix genimage build failure on Gitlab-CI Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.