* [PATCH 1/1] cmd: wrong printf() code in do_test_stackprot_fail()
@ 2022-02-04 9:50 Heinrich Schuchardt
2022-02-11 17:07 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2022-02-04 9:50 UTC (permalink / raw)
To: Joel Peshkin; +Cc: Tom Rini, u-boot, Heinrich Schuchardt
strlen() returns size_t. So we should use %zu to print it.
This avoids incorrect output on 32bit systems.
Fixes: 2fc62f299174 ("stackprot: Make our test a bit more complex")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
cmd/stackprot_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cmd/stackprot_test.c b/cmd/stackprot_test.c
index 1e26193e88..f3470288fa 100644
--- a/cmd/stackprot_test.c
+++ b/cmd/stackprot_test.c
@@ -17,7 +17,8 @@ static int do_test_stackprot_fail(struct cmd_tbl *cmdtp, int flag, int argc,
memset(a, 0xa5, 512);
- printf("We have smashed our stack as this should not exceed 128: sizeof(a) = %ld\n", strlen(a));
+ printf("We have smashed our stack as this should not exceed 128: sizeof(a) = %zd\n",
+ strlen(a));
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] cmd: wrong printf() code in do_test_stackprot_fail()
2022-02-04 9:50 [PATCH 1/1] cmd: wrong printf() code in do_test_stackprot_fail() Heinrich Schuchardt
@ 2022-02-11 17:07 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2022-02-11 17:07 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: Joel Peshkin, u-boot
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
On Fri, Feb 04, 2022 at 10:50:04AM +0100, Heinrich Schuchardt wrote:
> strlen() returns size_t. So we should use %zu to print it.
> This avoids incorrect output on 32bit systems.
>
> Fixes: 2fc62f299174 ("stackprot: Make our test a bit more complex")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-11 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-04 9:50 [PATCH 1/1] cmd: wrong printf() code in do_test_stackprot_fail() Heinrich Schuchardt
2022-02-11 17:07 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.