* [PATCH] spi: spi-zynqmp-gqspi: fix platform_get_irq.cocci warnings
2022-02-04 16:06 [xilinx-xlnx:xlnx_rebase_v5.15 848/872] drivers/spi/spi-zynqmp-gqspi.c:1331:2-9: line 1331 is redundant because platform_get_irq() already prints an error kernel test robot
@ 2022-02-04 16:05 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-02-04 16:05 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1752 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
CC: Mark Brown <broonie@kernel.org>
CC: linux-spi(a)vger.kernel.org
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/spi/spi-zynqmp-gqspi.c:1331:2-9: line 1331 is redundant because platform_get_irq() already prints an error
Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Fixes: ad3ea50420b2 ("spi: spi-zynqmp-gqspi: Add dual parallel and stacked mode support in driver")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head: 1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: ad3ea50420b2f1742f84afbb0de7dd0b355298c2 [848/872] spi: spi-zynqmp-gqspi: Add dual parallel and stacked mode support in driver
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
Please take the patch only if it's a positive warning. Thanks!
spi-zynqmp-gqspi.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -1328,7 +1328,6 @@ static int zynqmp_qspi_probe(struct plat
xqspi->irq = platform_get_irq(pdev, 0);
if (xqspi->irq <= 0) {
ret = -ENXIO;
- dev_err(dev, "irq resource not found\n");
goto clk_dis_all;
}
ret = devm_request_irq(&pdev->dev, xqspi->irq, zynqmp_qspi_irq,
^ permalink raw reply [flat|nested] 2+ messages in thread
* [xilinx-xlnx:xlnx_rebase_v5.15 848/872] drivers/spi/spi-zynqmp-gqspi.c:1331:2-9: line 1331 is redundant because platform_get_irq() already prints an error
@ 2022-02-04 16:06 kernel test robot
2022-02-04 16:05 ` [PATCH] spi: spi-zynqmp-gqspi: fix platform_get_irq.cocci warnings kernel test robot
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2022-02-04 16:06 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head: 1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: ad3ea50420b2f1742f84afbb0de7dd0b355298c2 [848/872] spi: spi-zynqmp-gqspi: Add dual parallel and stacked mode support in driver
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: x86_64-randconfig-c002-20220131 (https://download.01.org/0day-ci/archive/20220205/202202050012.ev9HmPhu-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/spi/spi-zynqmp-gqspi.c:1331:2-9: line 1331 is redundant because platform_get_irq() already prints an error
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-04 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-04 16:06 [xilinx-xlnx:xlnx_rebase_v5.15 848/872] drivers/spi/spi-zynqmp-gqspi.c:1331:2-9: line 1331 is redundant because platform_get_irq() already prints an error kernel test robot
2022-02-04 16:05 ` [PATCH] spi: spi-zynqmp-gqspi: fix platform_get_irq.cocci warnings kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.