* [rmk-arm:clearfog 9/10] drivers/pci/pcie/portdrv_core.c:329 pcie_port_device_register() warn: inconsistent indenting
@ 2022-02-05 4:51 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-02-05 4:51 UTC (permalink / raw)
To: Russell King; +Cc: kbuild-all, linux-kernel, Russell King (Oracle)
tree: git://git.armlinux.org.uk/~rmk/linux-arm clearfog
head: 76e9a0db445a3fdaa7685fe133a55673c94e9b5e
commit: 9d274182feb7642db60ac4b713ac6572b5dbd04b [9/10] mvebu/clearfog pcie updates
config: i386-randconfig-m021-20220131 (https://download.01.org/0day-ci/archive/20220205/202202051233.wNW2l14n-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/pci/pcie/portdrv_core.c:329 pcie_port_device_register() warn: inconsistent indenting
Old smatch warnings:
drivers/pci/pcie/portdrv_core.c:355 pcie_port_device_register() warn: inconsistent indenting
vim +329 drivers/pci/pcie/portdrv_core.c
307
308 /**
309 * pcie_port_device_register - register PCI Express port
310 * @dev: PCI Express port to register
311 *
312 * Allocate the port extension structure and register services associated with
313 * the port.
314 */
315 int pcie_port_device_register(struct pci_dev *dev)
316 {
317 int status, capabilities, irq_services, i, nr_service;
318 int irqs[PCIE_PORT_DEVICE_MAXSERVICES] = {
319 [0 ... PCIE_PORT_DEVICE_MAXSERVICES-1] = -1
320 };
321
322 /* Enable PCI Express port device */
323 status = pci_enable_device(dev);
324 if (status)
325 return status;
326
327 /* Get and check PCI Express port services */
328 capabilities = get_port_device_capability(dev);
> 329 dev_info(&dev->dev, "PCIe capabilities: 0x%x\n", capabilities);
330 if (!capabilities)
331 return 0;
332
333 pci_set_master(dev);
334
335 irq_services = 0;
336 if (IS_ENABLED(CONFIG_PCIE_PME))
337 irq_services |= PCIE_PORT_SERVICE_PME;
338 if (IS_ENABLED(CONFIG_PCIEAER))
339 irq_services |= PCIE_PORT_SERVICE_AER;
340 if (IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE))
341 irq_services |= PCIE_PORT_SERVICE_HP;
342 if (IS_ENABLED(CONFIG_PCIE_DPC))
343 irq_services |= PCIE_PORT_SERVICE_DPC;
344 irq_services &= capabilities;
345
346 if (irq_services) {
347 /*
348 * Initialize service IRQs. Don't use service devices that
349 * require interrupts if there is no way to generate them.
350 * However, some drivers may have a polling mode (e.g.
351 * pciehp_poll_mode) that can be used in the absence of IRQs.
352 * Allow them to determine if that is to be used.
353 */
354 status = pcie_init_service_irqs(dev, irqs, irq_services);
355 dev_info(&dev->dev, "init_service_irqs: %d\n", status);
356 if (status) {
357 irq_services &= PCIE_PORT_SERVICE_HP;
358 if (!irq_services)
359 goto error_disable;
360 }
361 }
362
363 /* Allocate child services if any */
364 status = -ENODEV;
365 nr_service = 0;
366 for (i = 0; i < PCIE_PORT_DEVICE_MAXSERVICES; i++) {
367 int service = 1 << i;
368 if (!(capabilities & service))
369 continue;
370 if (!pcie_device_init(dev, service, irqs[i]))
371 nr_service++;
372 }
373 if (!nr_service)
374 goto error_cleanup_irqs;
375
376 return 0;
377
378 error_cleanup_irqs:
379 pci_free_irq_vectors(dev);
380 error_disable:
381 pci_disable_device(dev);
382 return status;
383 }
384
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* [rmk-arm:clearfog 9/10] drivers/pci/pcie/portdrv_core.c:329 pcie_port_device_register() warn: inconsistent indenting
@ 2022-02-05 4:51 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-02-05 4:51 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3570 bytes --]
tree: git://git.armlinux.org.uk/~rmk/linux-arm clearfog
head: 76e9a0db445a3fdaa7685fe133a55673c94e9b5e
commit: 9d274182feb7642db60ac4b713ac6572b5dbd04b [9/10] mvebu/clearfog pcie updates
config: i386-randconfig-m021-20220131 (https://download.01.org/0day-ci/archive/20220205/202202051233.wNW2l14n-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/pci/pcie/portdrv_core.c:329 pcie_port_device_register() warn: inconsistent indenting
Old smatch warnings:
drivers/pci/pcie/portdrv_core.c:355 pcie_port_device_register() warn: inconsistent indenting
vim +329 drivers/pci/pcie/portdrv_core.c
307
308 /**
309 * pcie_port_device_register - register PCI Express port
310 * @dev: PCI Express port to register
311 *
312 * Allocate the port extension structure and register services associated with
313 * the port.
314 */
315 int pcie_port_device_register(struct pci_dev *dev)
316 {
317 int status, capabilities, irq_services, i, nr_service;
318 int irqs[PCIE_PORT_DEVICE_MAXSERVICES] = {
319 [0 ... PCIE_PORT_DEVICE_MAXSERVICES-1] = -1
320 };
321
322 /* Enable PCI Express port device */
323 status = pci_enable_device(dev);
324 if (status)
325 return status;
326
327 /* Get and check PCI Express port services */
328 capabilities = get_port_device_capability(dev);
> 329 dev_info(&dev->dev, "PCIe capabilities: 0x%x\n", capabilities);
330 if (!capabilities)
331 return 0;
332
333 pci_set_master(dev);
334
335 irq_services = 0;
336 if (IS_ENABLED(CONFIG_PCIE_PME))
337 irq_services |= PCIE_PORT_SERVICE_PME;
338 if (IS_ENABLED(CONFIG_PCIEAER))
339 irq_services |= PCIE_PORT_SERVICE_AER;
340 if (IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE))
341 irq_services |= PCIE_PORT_SERVICE_HP;
342 if (IS_ENABLED(CONFIG_PCIE_DPC))
343 irq_services |= PCIE_PORT_SERVICE_DPC;
344 irq_services &= capabilities;
345
346 if (irq_services) {
347 /*
348 * Initialize service IRQs. Don't use service devices that
349 * require interrupts if there is no way to generate them.
350 * However, some drivers may have a polling mode (e.g.
351 * pciehp_poll_mode) that can be used in the absence of IRQs.
352 * Allow them to determine if that is to be used.
353 */
354 status = pcie_init_service_irqs(dev, irqs, irq_services);
355 dev_info(&dev->dev, "init_service_irqs: %d\n", status);
356 if (status) {
357 irq_services &= PCIE_PORT_SERVICE_HP;
358 if (!irq_services)
359 goto error_disable;
360 }
361 }
362
363 /* Allocate child services if any */
364 status = -ENODEV;
365 nr_service = 0;
366 for (i = 0; i < PCIE_PORT_DEVICE_MAXSERVICES; i++) {
367 int service = 1 << i;
368 if (!(capabilities & service))
369 continue;
370 if (!pcie_device_init(dev, service, irqs[i]))
371 nr_service++;
372 }
373 if (!nr_service)
374 goto error_cleanup_irqs;
375
376 return 0;
377
378 error_cleanup_irqs:
379 pci_free_irq_vectors(dev);
380 error_disable:
381 pci_disable_device(dev);
382 return status;
383 }
384
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-05 4:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-05 4:51 [rmk-arm:clearfog 9/10] drivers/pci/pcie/portdrv_core.c:329 pcie_port_device_register() warn: inconsistent indenting kernel test robot
2022-02-05 4:51 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.