All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] MHI fixes for v5.17
@ 2022-02-05 13:57 Manivannan Sadhasivam
  2022-02-05 13:57 ` [PATCH 1/2] bus: mhi: pci_generic: Add mru_default for Foxconn SDX55 Manivannan Sadhasivam
  2022-02-05 13:57 ` [PATCH 2/2] bus: mhi: pci_generic: Add mru_default for Cinterion MV31-W Manivannan Sadhasivam
  0 siblings, 2 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2022-02-05 13:57 UTC (permalink / raw)
  To: gregkh; +Cc: mhi, hemantk, bbhatt, Manivannan Sadhasivam

Hi Greg,

Here is the small set of fixes for the v5.17 cycle. Both of the patches adds the
default MRU (Maximum Receive Unit) value for 2 modems, Foxconn SDX55 and
Cinterion MV31-W. Without these MRU values, the MHI host stack would use the
default MRU value of 3500 for these modems and that causes the hang during high
network traffic.

It has been identified that the MRU value of 32786 works well with the firmware
running on these modems and hence the patch adds the same to pci_generic driver.

Please consider merging!

Thanks,
Mani

Slark Xiao (2):
  bus: mhi: pci_generic: Add mru_default for Foxconn SDX55
  bus: mhi: pci_generic: Add mru_default for Cinterion MV31-W

 drivers/bus/mhi/pci_generic.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] bus: mhi: pci_generic: Add mru_default for Foxconn SDX55
  2022-02-05 13:57 [PATCH 0/2] MHI fixes for v5.17 Manivannan Sadhasivam
@ 2022-02-05 13:57 ` Manivannan Sadhasivam
  2022-02-05 13:57 ` [PATCH 2/2] bus: mhi: pci_generic: Add mru_default for Cinterion MV31-W Manivannan Sadhasivam
  1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2022-02-05 13:57 UTC (permalink / raw)
  To: gregkh
  Cc: mhi, hemantk, bbhatt, Slark Xiao, stable, Manivannan Sadhasivam,
	Manivannan Sadhasivam

From: Slark Xiao <slark_xiao@163.com>

For default mechanism, product would use default MRU 3500 if
they didn't define it. But for Foxconn SDX55, there is a known
issue which MRU 3500 would lead to data connection lost.
So we align it with Qualcomm default MRU settings.

Cc: stable@vger.kernel.org # v5.12+
Fixes: aac426562f56 ("bus: mhi: pci_generic: Introduce Foxconn T99W175 support")
Signed-off-by: Slark Xiao <slark_xiao@163.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://lore.kernel.org/r/20220119101213.5008-1-slark_xiao@163.com
[mani: Added pci_generic prefix to subject and CCed stable]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/bus/mhi/pci_generic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 3a258a677df8..74e8fc342cfd 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -366,6 +366,7 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx55_info = {
 	.config = &modem_foxconn_sdx55_config,
 	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
 	.dma_data_width = 32,
+	.mru_default = 32768,
 	.sideband_wake = false,
 };
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] bus: mhi: pci_generic: Add mru_default for Cinterion MV31-W
  2022-02-05 13:57 [PATCH 0/2] MHI fixes for v5.17 Manivannan Sadhasivam
  2022-02-05 13:57 ` [PATCH 1/2] bus: mhi: pci_generic: Add mru_default for Foxconn SDX55 Manivannan Sadhasivam
@ 2022-02-05 13:57 ` Manivannan Sadhasivam
  1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2022-02-05 13:57 UTC (permalink / raw)
  To: gregkh
  Cc: mhi, hemantk, bbhatt, Slark Xiao, stable, Manivannan Sadhasivam,
	Manivannan Sadhasivam

From: Slark Xiao <slark_xiao@163.com>

For default mechanism, product would use default MRU 3500 if
they didn't define it. But for Cinterion MV31-W, there is a known
issue which MRU 3500 would lead to data connection lost.
So we align it with Qualcomm default MRU settings.

Cc: stable@vger.kernel.org # v5.14 +
Fixes: 87693e092bd0 ("bus: mhi: pci_generic: Add Cinterion MV31-W PCIe to MHI")
Signed-off-by: Slark Xiao <slark_xiao@163.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://lore.kernel.org/r/20220119102519.5342-1-slark_xiao@163.com
[mani: Modified the commit message to reflect Cinterion MV31-W and CCed stable]
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/bus/mhi/pci_generic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 74e8fc342cfd..b79895810c52 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -402,6 +402,7 @@ static const struct mhi_pci_dev_info mhi_mv31_info = {
 	.config = &modem_mv31_config,
 	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
 	.dma_data_width = 32,
+	.mru_default = 32768,
 };
 
 static const struct mhi_channel_config mhi_sierra_em919x_channels[] = {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-05 13:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-05 13:57 [PATCH 0/2] MHI fixes for v5.17 Manivannan Sadhasivam
2022-02-05 13:57 ` [PATCH 1/2] bus: mhi: pci_generic: Add mru_default for Foxconn SDX55 Manivannan Sadhasivam
2022-02-05 13:57 ` [PATCH 2/2] bus: mhi: pci_generic: Add mru_default for Cinterion MV31-W Manivannan Sadhasivam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.