[PATCH] drm: xlnx: fix for_each_child.cocci warnings

[PATCH] drm: xlnx: fix for_each_child.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Jianqiang Chen <jianqiang.chen@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: dri-devel(a)lists.freedesktop.org
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/xlnx/zynqmp_dp.c:1965:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before break around line 1970.


Semantic patch information:
 False positives can be due to function calls within the for_each
 loop that may encapsulate an of_node_put.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Jianqiang Chen <jianqiang.chen@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: 2d2fa5c476daa40a5aac243bd776cab2568c7111 [797/872] drm: xlnx: Update DP subsystem with downstream version
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago

Please take the patch only if it's a positive warning. Thanks!

 zynqmp_dp.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
@@ -1967,6 +1967,7 @@ int zynqmp_dp_probe(struct platform_devi
 			continue;
 
 		dpsub->external_crtc_attached = true;
+		of_node_put(port);
 		break;
 	}
 

[xilinx-xlnx:xlnx_rebase_v5.15 797/872] drivers/gpu/drm/xlnx/zynqmp_disp.c:132:19-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Jianqiang Chen <jianqiang.chen@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: 2d2fa5c476daa40a5aac243bd776cab2568c7111 [797/872] drm: xlnx: Update DP subsystem with downstream version
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: arm64-randconfig-c023-20220131 (https://download.01.org/0day-ci/archive/20220205/202202052203.TDerbJwb-lkp(a)intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/xlnx/zynqmp_disp.c:132:19-22: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
--
>> drivers/gpu/drm/xlnx/zynqmp_dp.c:1965:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before break around line 1970.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org