[PATCH 1/3] mmc-utils: manpage: Document -c option for partitioning commands

[PATCH 1/3] mmc-utils: manpage: Document -c option for partitioning commands

[Marius Strobl]

The 'continue' option was added in commit 752072dafe9c ("Add -c option
for partitioning commands).

Signed-off-by: Marius Strobl <marius@FreeBSD.org>
---
 man/mmc.1 | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/man/mmc.1 b/man/mmc.1
index bdb6f09..bccabf3 100644
--- a/man/mmc.1
+++ b/man/mmc.1
@@ -30,21 +30,24 @@ This sets the eMMC to be write-protected until next boot.
 Set the eMMC data sector size to 4KB by disabling emulation on
 <device>.
 .TP
-.BR "gp create <-y|-n> <length KiB> <partition> <enh_attr> <ext_attr> <device>"
+.BR "gp create <-y|-n|-c> <length KiB> <partition> <enh_attr> <ext_attr> <device>"
 create general purpose partition for the <device>.
-Dry-run only unless -y is passed.
+Dry-run only unless -y or -c is passed.
+Use -c if more partitioning settings are still to come.
 To set enhanced attribute to general partition being created set <enh_attr> to 1 else set it to 0.
 To set extended attribute to general partition set <ext_attr> to 1,2 else set it to 0.
 NOTE!  This is a one-time programmable (unreversible) change.
 .TP
-.BR "enh_area set <-y|-n> <start KiB> <length KiB> <device>"
+.BR "enh_area set <-y|-n|-c> <start KiB> <length KiB> <device>"
 Enable the enhanced user area for the <device>.
-Dry-run only unless -y is passed.
+Dry-run only unless -y or -c is passed.
+Use -c if more partitioning settings are still to come.
 NOTE!  This is a one-time programmable (unreversible) change.
 .TP
-.BR "write_reliability set <-y|-n> <partition> <device>"
+.BR "write_reliability set <-y|-n|-c> <partition> <device>"
 Enable write reliability per partition for the <device>.
-Dry-run only unless -y is passed.
+Dry-run only unless -y or -c is passed.
+Use -c if more partitioning settings are still to come.
 NOTE!  This is a one-time programmable (unreversible) change.
 .TP
 .BR "status get <device>"
-- 
2.31.1

[PATCH 2/3] mmc-utils: Remove unused MMC_BLOCK_MAJOR

[Marius Strobl]

It was added in commit 294bf86972d6 ("mmc-utils: Remove dependency on
linux/major.h.") but never actually used, apparently.

Signed-off-by: Marius Strobl <marius@FreeBSD.org>
---
 mmc.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mmc.h b/mmc.h
index e9766d7..2ff6e66 100644
--- a/mmc.h
+++ b/mmc.h
@@ -19,9 +19,6 @@
 
 #include <linux/mmc/ioctl.h>
 
-/* From kernel linux/major.h */
-#define MMC_BLOCK_MAJOR			179
-
 /* From kernel linux/mmc/mmc.h */
 #define MMC_SWITCH		6	/* ac	[31:0] See below	R1b */
 #define MMC_SEND_EXT_CSD	8	/* adtc				R1  */
-- 
2.31.1

[PATCH 3/3] mmc-utils: Display STROBE_SUPPORT when printing EXT_CSD

[Marius Strobl]

Support for Enhanced Strobe mode introduced in eMMC 5.1 JESD84-B51
can be determined via EXT_CSD[184]. Along with the identification of
HS400 data rates added in commit 3969aa4804ed ("mmc_cmds: add HS400
data rates"), this allows to differentiate support for HS400/HS400ES.

Signed-off-by: Marius Strobl <marius@FreeBSD.org>
---
 mmc_cmds.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mmc_cmds.c b/mmc_cmds.c
index f024079..508ddad 100644
--- a/mmc_cmds.c
+++ b/mmc_cmds.c
@@ -1628,6 +1628,9 @@ int do_read_extcsd(int nargs, char **argv)
 	printf("Power class [POWER_CLASS: 0x%02x]\n", ext_csd[187]);
 	printf("High-speed interface timing [HS_TIMING: 0x%02x]\n",
 		ext_csd[185]);
+	if (ext_csd_rev >= 8)
+		printf("Enhanced Strobe mode [STROBE_SUPPORT: 0x%02x]\n",
+			ext_csd[184]);
 	/* bus_width: ext_csd[183] not readable */
 	printf("Erased memory content [ERASED_MEM_CONT: 0x%02x]\n",
 		ext_csd[181]);
-- 
2.31.1

RE: [PATCH 1/3] mmc-utils: manpage: Document -c option for partitioning commands

[Avri Altman]

 
> The 'continue' option was added in commit 752072dafe9c ("Add -c option
> for partitioning commands).
> 
> Signed-off-by: Marius Strobl <marius@FreeBSD.org>
Looks good to me.

A small editorial comment - if you are bundling your patches -
a cover letter is usually attached with few words describing the series.

Thanks,
Avri

> ---
>  man/mmc.1 | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/man/mmc.1 b/man/mmc.1
> index bdb6f09..bccabf3 100644
> --- a/man/mmc.1
> +++ b/man/mmc.1
> @@ -30,21 +30,24 @@ This sets the eMMC to be write-protected until next
> boot.
>  Set the eMMC data sector size to 4KB by disabling emulation on
>  <device>.
>  .TP
> -.BR "gp create <-y|-n> <length KiB> <partition> <enh_attr> <ext_attr>
> <device>"
> +.BR "gp create <-y|-n|-c> <length KiB> <partition> <enh_attr> <ext_attr>
> <device>"
>  create general purpose partition for the <device>.
> -Dry-run only unless -y is passed.
> +Dry-run only unless -y or -c is passed.
> +Use -c if more partitioning settings are still to come.
>  To set enhanced attribute to general partition being created set <enh_attr> to 1
> else set it to 0.
>  To set extended attribute to general partition set <ext_attr> to 1,2 else set it to
> 0.
>  NOTE!  This is a one-time programmable (unreversible) change.
>  .TP
> -.BR "enh_area set <-y|-n> <start KiB> <length KiB> <device>"
> +.BR "enh_area set <-y|-n|-c> <start KiB> <length KiB> <device>"
>  Enable the enhanced user area for the <device>.
> -Dry-run only unless -y is passed.
> +Dry-run only unless -y or -c is passed.
> +Use -c if more partitioning settings are still to come.
>  NOTE!  This is a one-time programmable (unreversible) change.
>  .TP
> -.BR "write_reliability set <-y|-n> <partition> <device>"
> +.BR "write_reliability set <-y|-n|-c> <partition> <device>"
>  Enable write reliability per partition for the <device>.
> -Dry-run only unless -y is passed.
> +Dry-run only unless -y or -c is passed.
> +Use -c if more partitioning settings are still to come.
>  NOTE!  This is a one-time programmable (unreversible) change.
>  .TP
>  .BR "status get <device>"
> --
> 2.31.1

RE: [PATCH 2/3] mmc-utils: Remove unused MMC_BLOCK_MAJOR

[Avri Altman]

 
> It was added in commit 294bf86972d6 ("mmc-utils: Remove dependency on
> linux/major.h.") but never actually used, apparently.
> 
> Signed-off-by: Marius Strobl <marius@FreeBSD.org>
Looks good to me.

Thanks,
Avri

> ---
>  mmc.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mmc.h b/mmc.h
> index e9766d7..2ff6e66 100644
> --- a/mmc.h
> +++ b/mmc.h
> @@ -19,9 +19,6 @@
> 
>  #include <linux/mmc/ioctl.h>
> 
> -/* From kernel linux/major.h */
> -#define MMC_BLOCK_MAJOR                        179
> -
>  /* From kernel linux/mmc/mmc.h */
>  #define MMC_SWITCH             6       /* ac   [31:0] See below        R1b */
>  #define MMC_SEND_EXT_CSD       8       /* adtc                         R1  */
> --
> 2.31.1

RE: [PATCH 3/3] mmc-utils: Display STROBE_SUPPORT when printing EXT_CSD

[Avri Altman]

> Support for Enhanced Strobe mode introduced in eMMC 5.1 JESD84-B51 can be
> determined via EXT_CSD[184]. Along with the identification of
> HS400 data rates added in commit 3969aa4804ed ("mmc_cmds: add HS400 data
> rates"), this allows to differentiate support for HS400/HS400ES.
> 
> Signed-off-by: Marius Strobl <marius@FreeBSD.org>
Looks good to me.

Thanks,
Avri

> ---
>  mmc_cmds.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mmc_cmds.c b/mmc_cmds.c
> index f024079..508ddad 100644
> --- a/mmc_cmds.c
> +++ b/mmc_cmds.c
> @@ -1628,6 +1628,9 @@ int do_read_extcsd(int nargs, char **argv)
>         printf("Power class [POWER_CLASS: 0x%02x]\n", ext_csd[187]);
>         printf("High-speed interface timing [HS_TIMING: 0x%02x]\n",
>                 ext_csd[185]);
> +       if (ext_csd_rev >= 8)
> +               printf("Enhanced Strobe mode [STROBE_SUPPORT: 0x%02x]\n",
> +                       ext_csd[184]);
>         /* bus_width: ext_csd[183] not readable */
>         printf("Erased memory content [ERASED_MEM_CONT: 0x%02x]\n",
>                 ext_csd[181]);
> --
> 2.31.1

Re: [PATCH 1/3] mmc-utils: manpage: Document -c option for partitioning commands

[Ulf Hansson]

On Sat, 5 Feb 2022 at 21:57, Marius Strobl <marius@freebsd.org> wrote:
>
> The 'continue' option was added in commit 752072dafe9c ("Add -c option
> for partitioning commands).
>
> Signed-off-by: Marius Strobl <marius@FreeBSD.org>

The three patches applied to
git.kernel.org/pub/scm//utils/mmc/mmc-utils.git master, thanks!

Kind regards
Uffe

> ---
>  man/mmc.1 | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/man/mmc.1 b/man/mmc.1
> index bdb6f09..bccabf3 100644
> --- a/man/mmc.1
> +++ b/man/mmc.1
> @@ -30,21 +30,24 @@ This sets the eMMC to be write-protected until next boot.
>  Set the eMMC data sector size to 4KB by disabling emulation on
>  <device>.
>  .TP
> -.BR "gp create <-y|-n> <length KiB> <partition> <enh_attr> <ext_attr> <device>"
> +.BR "gp create <-y|-n|-c> <length KiB> <partition> <enh_attr> <ext_attr> <device>"
>  create general purpose partition for the <device>.
> -Dry-run only unless -y is passed.
> +Dry-run only unless -y or -c is passed.
> +Use -c if more partitioning settings are still to come.
>  To set enhanced attribute to general partition being created set <enh_attr> to 1 else set it to 0.
>  To set extended attribute to general partition set <ext_attr> to 1,2 else set it to 0.
>  NOTE!  This is a one-time programmable (unreversible) change.
>  .TP
> -.BR "enh_area set <-y|-n> <start KiB> <length KiB> <device>"
> +.BR "enh_area set <-y|-n|-c> <start KiB> <length KiB> <device>"
>  Enable the enhanced user area for the <device>.
> -Dry-run only unless -y is passed.
> +Dry-run only unless -y or -c is passed.
> +Use -c if more partitioning settings are still to come.
>  NOTE!  This is a one-time programmable (unreversible) change.
>  .TP
> -.BR "write_reliability set <-y|-n> <partition> <device>"
> +.BR "write_reliability set <-y|-n|-c> <partition> <device>"
>  Enable write reliability per partition for the <device>.
> -Dry-run only unless -y is passed.
> +Dry-run only unless -y or -c is passed.
> +Use -c if more partitioning settings are still to come.
>  NOTE!  This is a one-time programmable (unreversible) change.
>  .TP
>  .BR "status get <device>"
> --
> 2.31.1
>