* drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
@ 2022-02-07 8:15 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2022-02-06 12:31 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4345 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Dikshita Agarwal <dikshita@codeaurora.org>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: Stanimir Varbanov <stanimir.varbanov@linaro.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 90c9e950c0def5c354b4a6154a2ddda3e5f214ac
commit: 16545aa3dee5a01f3f42aa566a051096c87f4b6f media: venus: Set buffer to FW based on FW min count requirement.
date: 4 months ago
:::::: branch date: 18 hours ago
:::::: commit date: 4 months ago
config: microblaze-randconfig-m031-20220206 (https://download.01.org/0day-ci/archive/20220206/202202062034.T1pUQtL9-lkp(a)intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
vim +/req +627 drivers/media/platform/qcom/venus/helpers.c
7371093f983d35d Stanimir Varbanov 2020-08-26 614
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 615 int venus_helper_get_bufreq(struct venus_inst *inst, u32 type,
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 616 struct hfi_buffer_requirements *req)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 617 {
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 618 u32 ptype = HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 619 union hfi_get_property hprop;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 620 unsigned int i;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 621 int ret;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 622
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 @623 if (req)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 624 memset(req, 0, sizeof(*req));
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 625
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 626 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 @627 req->count_min = inst->fw_min_cnt;
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 628
7371093f983d35d Stanimir Varbanov 2020-08-26 629 ret = platform_get_bufreq(inst, type, req);
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 630 if (!ret) {
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 631 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 632 inst->fw_min_cnt = req->count_min;
7371093f983d35d Stanimir Varbanov 2020-08-26 633 return 0;
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 634 }
7371093f983d35d Stanimir Varbanov 2020-08-26 635
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 636 ret = hfi_session_get_property(inst, ptype, &hprop);
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 637 if (ret)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 638 return ret;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 639
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 640 ret = -EINVAL;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 641
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 642 for (i = 0; i < HFI_BUFFER_TYPE_MAX; i++) {
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 643 if (hprop.bufreq[i].type != type)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 644 continue;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 645
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 646 if (req)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 647 memcpy(req, &hprop.bufreq[i], sizeof(*req));
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 648 ret = 0;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 649 break;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 650 }
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 651
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 652 return ret;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 653 }
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 654 EXPORT_SYMBOL_GPL(venus_helper_get_bufreq);
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 655
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
@ 2022-02-07 8:15 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2022-02-07 8:15 UTC (permalink / raw)
To: kbuild, Dikshita Agarwal
Cc: lkp, kbuild-all, linux-kernel, Mauro Carvalho Chehab,
linux-media, Stanimir Varbanov
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 90c9e950c0def5c354b4a6154a2ddda3e5f214ac
commit: 16545aa3dee5a01f3f42aa566a051096c87f4b6f media: venus: Set buffer to FW based on FW min count requirement.
config: microblaze-randconfig-m031-20220206 (https://download.01.org/0day-ci/archive/20220206/202202062034.T1pUQtL9-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
vim +/req +627 drivers/media/platform/qcom/venus/helpers.c
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 615 int venus_helper_get_bufreq(struct venus_inst *inst, u32 type,
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 616 struct hfi_buffer_requirements *req)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 617 {
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 618 u32 ptype = HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 619 union hfi_get_property hprop;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 620 unsigned int i;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 621 int ret;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 622
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 @623 if (req)
Check for NULL
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 624 memset(req, 0, sizeof(*req));
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 625
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 626 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 @627 req->count_min = inst->fw_min_cnt;
Unchecked dereference
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 628
7371093f983d35d Stanimir Varbanov 2020-08-26 629 ret = platform_get_bufreq(inst, type, req);
I looked at this in linux-next from Friday and I don't think
platform_get_bufreq() can succeed with a NULL "req"...
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 630 if (!ret) {
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 631 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 632 inst->fw_min_cnt = req->count_min;
Unchecked
7371093f983d35d Stanimir Varbanov 2020-08-26 633 return 0;
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 634 }
7371093f983d35d Stanimir Varbanov 2020-08-26 635
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 636 ret = hfi_session_get_property(inst, ptype, &hprop);
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 637 if (ret)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 638 return ret;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 639
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 640 ret = -EINVAL;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 641
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 642 for (i = 0; i < HFI_BUFFER_TYPE_MAX; i++) {
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 643 if (hprop.bufreq[i].type != type)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 644 continue;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 645
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 646 if (req)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 647 memcpy(req, &hprop.bufreq[i], sizeof(*req));
Another NULL check
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 648 ret = 0;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 649 break;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 650 }
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 651
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 652 return ret;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 653 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
@ 2022-02-07 8:15 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2022-02-07 8:15 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4009 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 90c9e950c0def5c354b4a6154a2ddda3e5f214ac
commit: 16545aa3dee5a01f3f42aa566a051096c87f4b6f media: venus: Set buffer to FW based on FW min count requirement.
config: microblaze-randconfig-m031-20220206 (https://download.01.org/0day-ci/archive/20220206/202202062034.T1pUQtL9-lkp(a)intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
vim +/req +627 drivers/media/platform/qcom/venus/helpers.c
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 615 int venus_helper_get_bufreq(struct venus_inst *inst, u32 type,
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 616 struct hfi_buffer_requirements *req)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 617 {
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 618 u32 ptype = HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 619 union hfi_get_property hprop;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 620 unsigned int i;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 621 int ret;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 622
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 @623 if (req)
Check for NULL
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 624 memset(req, 0, sizeof(*req));
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 625
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 626 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 @627 req->count_min = inst->fw_min_cnt;
Unchecked dereference
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 628
7371093f983d35d Stanimir Varbanov 2020-08-26 629 ret = platform_get_bufreq(inst, type, req);
I looked at this in linux-next from Friday and I don't think
platform_get_bufreq() can succeed with a NULL "req"...
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 630 if (!ret) {
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 631 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 632 inst->fw_min_cnt = req->count_min;
Unchecked
7371093f983d35d Stanimir Varbanov 2020-08-26 633 return 0;
16545aa3dee5a01 Dikshita Agarwal 2021-08-10 634 }
7371093f983d35d Stanimir Varbanov 2020-08-26 635
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 636 ret = hfi_session_get_property(inst, ptype, &hprop);
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 637 if (ret)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 638 return ret;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 639
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 640 ret = -EINVAL;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 641
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 642 for (i = 0; i < HFI_BUFFER_TYPE_MAX; i++) {
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 643 if (hprop.bufreq[i].type != type)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 644 continue;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 645
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 646 if (req)
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 647 memcpy(req, &hprop.bufreq[i], sizeof(*req));
Another NULL check
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 648 ret = 0;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 649 break;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 650 }
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 651
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 652 return ret;
af2c3834c8ca7cc Stanimir Varbanov 2017-06-15 653 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
@ 2022-03-15 9:09 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2022-03-15 9:09 UTC (permalink / raw)
To: kbuild, Dikshita Agarwal
Cc: lkp, kbuild-all, linux-kernel, Mauro Carvalho Chehab,
linux-media, Stanimir Varbanov
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 09688c0166e76ce2fb85e86b9d99be8b0084cdf9
commit: 16545aa3dee5a01f3f42aa566a051096c87f4b6f media: venus: Set buffer to FW based on FW min count requirement.
config: microblaze-randconfig-m031-20220314 (https://download.01.org/0day-ci/archive/20220315/202203151010.lrgnt9Tm-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
vim +/req +627 drivers/media/platform/qcom/venus/helpers.c
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 615 int venus_helper_get_bufreq(struct venus_inst *inst, u32 type,
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 616 struct hfi_buffer_requirements *req)
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 617 {
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 618 u32 ptype = HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 619 union hfi_get_property hprop;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 620 unsigned int i;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 621 int ret;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 622
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 @623 if (req)
Hopefully we can delete this check?
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 624 memset(req, 0, sizeof(*req));
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 625
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 626 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 @627 req->count_min = inst->fw_min_cnt;
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 628
7371093f983d35 Stanimir Varbanov 2020-08-26 629 ret = platform_get_bufreq(inst, type, req);
Because "req" will be dereferenced inside platform_get_bufreq()
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 630 if (!ret) {
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 631 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 632 inst->fw_min_cnt = req->count_min;
7371093f983d35 Stanimir Varbanov 2020-08-26 633 return 0;
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 634 }
7371093f983d35 Stanimir Varbanov 2020-08-26 635
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 636 ret = hfi_session_get_property(inst, ptype, &hprop);
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 637 if (ret)
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 638 return ret;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 639
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 640 ret = -EINVAL;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 641
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 642 for (i = 0; i < HFI_BUFFER_TYPE_MAX; i++) {
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 643 if (hprop.bufreq[i].type != type)
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 644 continue;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 645
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 646 if (req)
Delete this as well?
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 647 memcpy(req, &hprop.bufreq[i], sizeof(*req));
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 648 ret = 0;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 649 break;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 650 }
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 651
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 652 return ret;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 653 }
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
@ 2022-03-15 9:09 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2022-03-15 9:09 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3879 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 09688c0166e76ce2fb85e86b9d99be8b0084cdf9
commit: 16545aa3dee5a01f3f42aa566a051096c87f4b6f media: venus: Set buffer to FW based on FW min count requirement.
config: microblaze-randconfig-m031-20220314 (https://download.01.org/0day-ci/archive/20220315/202203151010.lrgnt9Tm-lkp(a)intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
vim +/req +627 drivers/media/platform/qcom/venus/helpers.c
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 615 int venus_helper_get_bufreq(struct venus_inst *inst, u32 type,
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 616 struct hfi_buffer_requirements *req)
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 617 {
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 618 u32 ptype = HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 619 union hfi_get_property hprop;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 620 unsigned int i;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 621 int ret;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 622
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 @623 if (req)
Hopefully we can delete this check?
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 624 memset(req, 0, sizeof(*req));
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 625
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 626 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 @627 req->count_min = inst->fw_min_cnt;
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 628
7371093f983d35 Stanimir Varbanov 2020-08-26 629 ret = platform_get_bufreq(inst, type, req);
Because "req" will be dereferenced inside platform_get_bufreq()
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 630 if (!ret) {
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 631 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 632 inst->fw_min_cnt = req->count_min;
7371093f983d35 Stanimir Varbanov 2020-08-26 633 return 0;
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 634 }
7371093f983d35 Stanimir Varbanov 2020-08-26 635
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 636 ret = hfi_session_get_property(inst, ptype, &hprop);
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 637 if (ret)
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 638 return ret;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 639
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 640 ret = -EINVAL;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 641
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 642 for (i = 0; i < HFI_BUFFER_TYPE_MAX; i++) {
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 643 if (hprop.bufreq[i].type != type)
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 644 continue;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 645
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 646 if (req)
Delete this as well?
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 647 memcpy(req, &hprop.bufreq[i], sizeof(*req));
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 648 ret = 0;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 649 break;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 650 }
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 651
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 652 return ret;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 653 }
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
@ 2022-03-15 9:09 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2022-03-15 2:26 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 4306 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Dikshita Agarwal <dikshita@codeaurora.org>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org
CC: Stanimir Varbanov <stanimir.varbanov@linaro.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 09688c0166e76ce2fb85e86b9d99be8b0084cdf9
commit: 16545aa3dee5a01f3f42aa566a051096c87f4b6f media: venus: Set buffer to FW based on FW min count requirement.
date: 5 months ago
:::::: branch date: 30 hours ago
:::::: commit date: 5 months ago
config: microblaze-randconfig-m031-20220314 (https://download.01.org/0day-ci/archive/20220315/202203151010.lrgnt9Tm-lkp(a)intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623)
vim +/req +627 drivers/media/platform/qcom/venus/helpers.c
7371093f983d35 Stanimir Varbanov 2020-08-26 614
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 615 int venus_helper_get_bufreq(struct venus_inst *inst, u32 type,
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 616 struct hfi_buffer_requirements *req)
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 617 {
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 618 u32 ptype = HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 619 union hfi_get_property hprop;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 620 unsigned int i;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 621 int ret;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 622
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 @623 if (req)
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 624 memset(req, 0, sizeof(*req));
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 625
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 626 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 @627 req->count_min = inst->fw_min_cnt;
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 628
7371093f983d35 Stanimir Varbanov 2020-08-26 629 ret = platform_get_bufreq(inst, type, req);
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 630 if (!ret) {
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 631 if (type == HFI_BUFFER_OUTPUT || type == HFI_BUFFER_OUTPUT2)
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 632 inst->fw_min_cnt = req->count_min;
7371093f983d35 Stanimir Varbanov 2020-08-26 633 return 0;
16545aa3dee5a0 Dikshita Agarwal 2021-08-10 634 }
7371093f983d35 Stanimir Varbanov 2020-08-26 635
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 636 ret = hfi_session_get_property(inst, ptype, &hprop);
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 637 if (ret)
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 638 return ret;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 639
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 640 ret = -EINVAL;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 641
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 642 for (i = 0; i < HFI_BUFFER_TYPE_MAX; i++) {
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 643 if (hprop.bufreq[i].type != type)
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 644 continue;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 645
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 646 if (req)
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 647 memcpy(req, &hprop.bufreq[i], sizeof(*req));
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 648 ret = 0;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 649 break;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 650 }
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 651
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 652 return ret;
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 653 }
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 654 EXPORT_SYMBOL_GPL(venus_helper_get_bufreq);
af2c3834c8ca7c Stanimir Varbanov 2017-06-15 655
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-15 9:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-06 12:31 drivers/media/platform/qcom/venus/helpers.c:627 venus_helper_get_bufreq() error: we previously assumed 'req' could be null (see line 623) kernel test robot
2022-02-07 8:15 ` Dan Carpenter
2022-02-07 8:15 ` Dan Carpenter
2022-03-15 9:09 Dan Carpenter
2022-03-15 2:26 ` kernel test robot
2022-03-15 9:09 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.