All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] docs: block: biodoc.rst: Drop the obsolete and incorrect content
@ 2022-02-07  7:49 Barry Song
  2022-02-09  8:32 ` Christoph Hellwig
  2022-02-11 22:07 ` Jens Axboe
  0 siblings, 2 replies; 4+ messages in thread
From: Barry Song @ 2022-02-07  7:49 UTC (permalink / raw)
  To: axboe, corbet, linux-doc, linux-block; +Cc: linuxarm, linux-kernel, Barry Song

Since commit 7eaceaccab5f ("block: remove per-queue plugging"), kernel
has removed blk_run_address_space(), blk_unplug() and sync_buffer(),
and moved to on-stack plugging. The document has been obsolete for
years.
Given that there is no obvious counterparts in the new mechinism to
replace old APIs, this patch drops the content directly.

Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
---
 Documentation/block/biodoc.rst | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/Documentation/block/biodoc.rst b/Documentation/block/biodoc.rst
index 2098477851a4..9df0c9cf6090 100644
--- a/Documentation/block/biodoc.rst
+++ b/Documentation/block/biodoc.rst
@@ -970,11 +970,7 @@ till it fills up with a few more requests, before starting to service
 the requests. This provides an opportunity to merge/sort the requests before
 passing them down to the device. There are various conditions when the queue is
 unplugged (to open up the flow again), either through a scheduled task or
-could be on demand. For example wait_on_buffer sets the unplugging going
-through sync_buffer() running blk_run_address_space(mapping). Or the caller
-can do it explicity through blk_unplug(bdev). So in the read case,
-the queue gets explicitly unplugged as part of waiting for completion on that
-buffer.
+could be on demand.
 
 Aside:
   This is kind of controversial territory, as it's not clear if plugging is
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: block: biodoc.rst: Drop the obsolete and incorrect content
  2022-02-07  7:49 [PATCH] docs: block: biodoc.rst: Drop the obsolete and incorrect content Barry Song
@ 2022-02-09  8:32 ` Christoph Hellwig
  2022-02-11 22:06   ` Jens Axboe
  2022-02-11 22:07 ` Jens Axboe
  1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2022-02-09  8:32 UTC (permalink / raw)
  To: Barry Song
  Cc: axboe, corbet, linux-doc, linux-block, linuxarm, linux-kernel,
	Barry Song

I suspect it is timeto just drop that entire file.  It is so stale
that it is actively harmful.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: block: biodoc.rst: Drop the obsolete and incorrect content
  2022-02-09  8:32 ` Christoph Hellwig
@ 2022-02-11 22:06   ` Jens Axboe
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2022-02-11 22:06 UTC (permalink / raw)
  To: Christoph Hellwig, Barry Song
  Cc: corbet, linux-doc, linux-block, linuxarm, linux-kernel, Barry Song

On 2/9/22 1:32 AM, Christoph Hellwig wrote:
> I suspect it is timeto just drop that entire file.  It is so stale
> that it is actively harmful.

I'll apply this one since it's obviously correct, but yes, we
probably should just kill this file.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] docs: block: biodoc.rst: Drop the obsolete and incorrect content
  2022-02-07  7:49 [PATCH] docs: block: biodoc.rst: Drop the obsolete and incorrect content Barry Song
  2022-02-09  8:32 ` Christoph Hellwig
@ 2022-02-11 22:07 ` Jens Axboe
  1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2022-02-11 22:07 UTC (permalink / raw)
  To: corbet, linux-block, Barry Song, linux-doc
  Cc: linux-kernel, Barry Song, linuxarm

On Mon, 7 Feb 2022 15:49:31 +0800, Barry Song wrote:
> Since commit 7eaceaccab5f ("block: remove per-queue plugging"), kernel
> has removed blk_run_address_space(), blk_unplug() and sync_buffer(),
> and moved to on-stack plugging. The document has been obsolete for
> years.
> Given that there is no obvious counterparts in the new mechinism to
> replace old APIs, this patch drops the content directly.
> 
> [...]

Applied, thanks!

[1/1] docs: block: biodoc.rst: Drop the obsolete and incorrect content
      commit: 2e2f0199a20780463945e1cbffb3a191fa84bd9d

Best regards,
-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-02-11 22:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-07  7:49 [PATCH] docs: block: biodoc.rst: Drop the obsolete and incorrect content Barry Song
2022-02-09  8:32 ` Christoph Hellwig
2022-02-11 22:06   ` Jens Axboe
2022-02-11 22:07 ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.