* [PATCH] net: ethernet: litex: Add the dependency on HAS_IOMEM
@ 2022-02-07 8:49 Cai Huoqing
2022-02-07 9:25 ` Joel Stanley
0 siblings, 1 reply; 3+ messages in thread
From: Cai Huoqing @ 2022-02-07 8:49 UTC (permalink / raw)
To: cai.huoqing
Cc: David S. Miller, Jakub Kicinski, Karol Gugala, Mateusz Holenko,
Gabriel Somlo, Joel Stanley, Cai Huoqing, netdev, linux-kernel
The helper function devm_platform_ioremap_resource_xxx()
needs HAS_IOMEM enabled, so add the dependency on HAS_IOMEM.
Fixes: 464a57281f29 ("net/mlxbf_gige: Make use of devm_platform_ioremap_resourcexxx()")
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/net/ethernet/litex/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig
index f99adbf26ab4..04345b929d8e 100644
--- a/drivers/net/ethernet/litex/Kconfig
+++ b/drivers/net/ethernet/litex/Kconfig
@@ -17,7 +17,7 @@ if NET_VENDOR_LITEX
config LITEX_LITEETH
tristate "LiteX Ethernet support"
- depends on OF
+ depends on OF && HAS_IOMEM
help
If you wish to compile a kernel for hardware with a LiteX LiteEth
device then you should answer Y to this.
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: litex: Add the dependency on HAS_IOMEM
2022-02-07 8:49 [PATCH] net: ethernet: litex: Add the dependency on HAS_IOMEM Cai Huoqing
@ 2022-02-07 9:25 ` Joel Stanley
2022-02-08 1:28 ` Cai Huoqing
0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2022-02-07 9:25 UTC (permalink / raw)
To: Cai Huoqing
Cc: David S. Miller, Jakub Kicinski, Karol Gugala, Mateusz Holenko,
Gabriel Somlo, Cai Huoqing, Networking,
Linux Kernel Mailing List
On Mon, 7 Feb 2022 at 08:49, Cai Huoqing <cai.huoqing@linux.dev> wrote:
>
> The helper function devm_platform_ioremap_resource_xxx()
> needs HAS_IOMEM enabled, so add the dependency on HAS_IOMEM.
>
> Fixes: 464a57281f29 ("net/mlxbf_gige: Make use of devm_platform_ioremap_resourcexxx()")
That looks wrong...
$ git show --oneline --stat 464a57281f29
464a57281f29 net/mlxbf_gige: Make use of devm_platform_ioremap_resourcexxx()
drivers/net/ethernet/litex/litex_liteeth.c | 7 ++-----
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 21
+++------------------
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c | 7 +------
drivers/net/ethernet/ni/nixge.c
That's a strange commit message for the litex driver. Similarly for
the ni driver. Did something go wrong there?
A better fixes line would be ee7da21ac4c3be1f618b6358e0a38739a5d1773e,
as the original driver addition also has the iomem dependency.
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> ---
> drivers/net/ethernet/litex/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig
> index f99adbf26ab4..04345b929d8e 100644
> --- a/drivers/net/ethernet/litex/Kconfig
> +++ b/drivers/net/ethernet/litex/Kconfig
> @@ -17,7 +17,7 @@ if NET_VENDOR_LITEX
>
> config LITEX_LITEETH
> tristate "LiteX Ethernet support"
> - depends on OF
> + depends on OF && HAS_IOMEM
> help
> If you wish to compile a kernel for hardware with a LiteX LiteEth
> device then you should answer Y to this.
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ethernet: litex: Add the dependency on HAS_IOMEM
2022-02-07 9:25 ` Joel Stanley
@ 2022-02-08 1:28 ` Cai Huoqing
0 siblings, 0 replies; 3+ messages in thread
From: Cai Huoqing @ 2022-02-08 1:28 UTC (permalink / raw)
To: Joel Stanley
Cc: David S. Miller, Jakub Kicinski, Karol Gugala, Mateusz Holenko,
Gabriel Somlo, Cai Huoqing, Networking,
Linux Kernel Mailing List
On 07 2月 22 09:25:42, Joel Stanley wrote:
> On Mon, 7 Feb 2022 at 08:49, Cai Huoqing <cai.huoqing@linux.dev> wrote:
> >
> > The helper function devm_platform_ioremap_resource_xxx()
> > needs HAS_IOMEM enabled, so add the dependency on HAS_IOMEM.
> >
> > Fixes: 464a57281f29 ("net/mlxbf_gige: Make use of devm_platform_ioremap_resourcexxx()")
>
> That looks wrong...
>
> $ git show --oneline --stat 464a57281f29
> 464a57281f29 net/mlxbf_gige: Make use of devm_platform_ioremap_resourcexxx()
> drivers/net/ethernet/litex/litex_liteeth.c | 7 ++-----
> drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 21
> +++------------------
> drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c | 7 +------
> drivers/net/ethernet/ni/nixge.c
>
> That's a strange commit message for the litex driver. Similarly for
> the ni driver. Did something go wrong there?
no, ni driver has the dependency on HAS_IOMEM in
drivers/net/ethernet/ni/Kconfig.
>
> A better fixes line would be ee7da21ac4c3be1f618b6358e0a38739a5d1773e,
ok.
Thanks
Cai
> as the original driver addition also has the iomem dependency.
>
> > Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> > ---
> > drivers/net/ethernet/litex/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig
> > index f99adbf26ab4..04345b929d8e 100644
> > --- a/drivers/net/ethernet/litex/Kconfig
> > +++ b/drivers/net/ethernet/litex/Kconfig
> > @@ -17,7 +17,7 @@ if NET_VENDOR_LITEX
> >
> > config LITEX_LITEETH
> > tristate "LiteX Ethernet support"
> > - depends on OF
> > + depends on OF && HAS_IOMEM
> > help
> > If you wish to compile a kernel for hardware with a LiteX LiteEth
> > device then you should answer Y to this.
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-08 1:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-07 8:49 [PATCH] net: ethernet: litex: Add the dependency on HAS_IOMEM Cai Huoqing
2022-02-07 9:25 ` Joel Stanley
2022-02-08 1:28 ` Cai Huoqing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.