From: Jason Gunthorpe <jgg@nvidia.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>,
Christoph Hellwig <hch@infradead.org>,
Ben Skeggs <bskeggs@redhat.com>,
Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>,
Jacob jun Pan <jacob.jun.pan@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 06/10] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain
Date: Wed, 9 Feb 2022 09:31:39 -0400 [thread overview]
Message-ID: <20220209133139.GX4160@nvidia.com> (raw)
In-Reply-To: <20220208012559.1121729-7-baolu.lu@linux.intel.com>
On Tue, Feb 08, 2022 at 09:25:55AM +0800, Lu Baolu wrote:
> The supported page sizes of an iommu_domain are saved in the pgsize_bitmap
> field. Retrieve the value from the right place.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Link: https://lore.kernel.org/r/20211218074546.1772553-1-baolu.lu@linux.intel.com
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
IMHO it is weird that the ops have a pgsize_bitmap at all.
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe via iommu <iommu@lists.linux-foundation.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>, David Airlie <airlied@linux.ie>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org,
Jonathan Hunter <jonathanh@nvidia.com>,
Christoph Hellwig <hch@infradead.org>,
Alex Williamson <alex.williamson@redhat.com>,
Thierry Reding <thierry.reding@gmail.com>,
Ben Skeggs <bskeggs@redhat.com>, Daniel Vetter <daniel@ffwll.ch>,
Will Deacon <will@kernel.org>, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org,
Jacob jun Pan <jacob.jun.pan@intel.com>
Subject: Re: [PATCH v2 06/10] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain
Date: Wed, 9 Feb 2022 09:31:39 -0400 [thread overview]
Message-ID: <20220209133139.GX4160@nvidia.com> (raw)
In-Reply-To: <20220208012559.1121729-7-baolu.lu@linux.intel.com>
On Tue, Feb 08, 2022 at 09:25:55AM +0800, Lu Baolu wrote:
> The supported page sizes of an iommu_domain are saved in the pgsize_bitmap
> field. Retrieve the value from the right place.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Link: https://lore.kernel.org/r/20211218074546.1772553-1-baolu.lu@linux.intel.com
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
IMHO it is weird that the ops have a pgsize_bitmap at all.
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2022-02-09 13:32 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 1:25 [PATCH v2 00/10] iommu cleanup and refactoring Lu Baolu
2022-02-08 1:25 ` Lu Baolu
2022-02-08 1:25 ` [PATCH v2 01/10] iommu/vt-d: Remove guest pasid related callbacks Lu Baolu
2022-02-08 1:25 ` Lu Baolu
2022-02-09 13:29 ` Jason Gunthorpe
2022-02-09 13:29 ` Jason Gunthorpe via iommu
2022-02-08 1:25 ` [PATCH v2 02/10] iommu: Remove guest pasid related interfaces and definitions Lu Baolu
2022-02-08 1:25 ` Lu Baolu
2022-02-09 13:29 ` Jason Gunthorpe
2022-02-09 13:29 ` Jason Gunthorpe via iommu
2022-02-10 0:44 ` Lu Baolu
2022-02-10 0:44 ` Lu Baolu
2022-02-08 1:25 ` [PATCH v2 03/10] iommu/vt-d: Remove aux-domain related callbacks Lu Baolu
2022-02-08 1:25 ` Lu Baolu
2022-02-09 13:30 ` Jason Gunthorpe
2022-02-09 13:30 ` Jason Gunthorpe via iommu
2022-02-08 1:25 ` [PATCH v2 04/10] iommu: Remove aux-domain related interfaces and iommu_ops Lu Baolu
2022-02-08 1:25 ` Lu Baolu
2022-02-09 13:30 ` Jason Gunthorpe
2022-02-09 13:30 ` Jason Gunthorpe via iommu
2022-02-08 1:25 ` [PATCH v2 05/10] iommu: Remove apply_resv_region Lu Baolu
2022-02-08 1:25 ` Lu Baolu
2022-02-09 6:36 ` Christoph Hellwig
2022-02-09 6:36 ` Christoph Hellwig
2022-02-09 13:31 ` Jason Gunthorpe
2022-02-09 13:31 ` Jason Gunthorpe via iommu
2022-02-08 1:25 ` [PATCH v2 06/10] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain Lu Baolu
2022-02-08 1:25 ` Lu Baolu
2022-02-09 13:31 ` Jason Gunthorpe [this message]
2022-02-09 13:31 ` Jason Gunthorpe via iommu
2022-02-10 0:48 ` Lu Baolu
2022-02-10 0:48 ` Lu Baolu
2022-02-08 1:25 ` [PATCH v2 07/10] iommu: Use right way to retrieve iommu_ops Lu Baolu
2022-02-08 1:25 ` Lu Baolu
2022-02-09 6:40 ` Christoph Hellwig
2022-02-09 6:40 ` Christoph Hellwig
2022-02-09 13:33 ` Jason Gunthorpe
2022-02-09 13:33 ` Jason Gunthorpe via iommu
2022-02-08 1:25 ` [PATCH v2 08/10] iommu: Remove unused argument in is_attach_deferred Lu Baolu
2022-02-08 1:25 ` Lu Baolu
2022-02-09 6:41 ` Christoph Hellwig
2022-02-09 6:41 ` Christoph Hellwig
2022-02-09 13:34 ` Jason Gunthorpe
2022-02-09 13:34 ` Jason Gunthorpe via iommu
2022-02-09 13:52 ` Robin Murphy
2022-02-09 13:52 ` Robin Murphy
2022-02-10 0:51 ` Lu Baolu
2022-02-10 0:51 ` Lu Baolu
2022-02-14 0:50 ` Lu Baolu
2022-02-14 0:50 ` Lu Baolu
2022-02-08 1:25 ` [PATCH v2 09/10] iommu: Use dev_iommu_ops() helper Lu Baolu
2022-02-08 1:25 ` Lu Baolu
2022-02-09 6:44 ` Christoph Hellwig
2022-02-09 6:44 ` Christoph Hellwig
2022-02-09 13:41 ` Jason Gunthorpe
2022-02-09 13:41 ` Jason Gunthorpe via iommu
2022-02-10 1:10 ` Lu Baolu
2022-02-10 1:10 ` Lu Baolu
2022-02-08 1:25 ` [PATCH v2 10/10] iommu: Split struct iommu_ops Lu Baolu
2022-02-08 1:25 ` Lu Baolu
2022-02-09 6:46 ` Christoph Hellwig
2022-02-09 6:46 ` Christoph Hellwig
2022-02-09 13:43 ` Jason Gunthorpe
2022-02-09 13:43 ` Jason Gunthorpe via iommu
2022-02-14 2:00 ` [PATCH v2 00/10] iommu cleanup and refactoring Lu Baolu
2022-02-14 2:00 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209133139.GX4160@nvidia.com \
--to=jgg@nvidia.com \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=eric.auger@redhat.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jonathanh@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.