From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Stephen Boyd <swboyd@chromium.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: [PATCH 16/25] drm/msm/dpu: drop EAGAIN check from dpu_format_populate_layout Date: Wed, 9 Feb 2022 20:25:11 +0300 [thread overview] Message-ID: <20220209172520.3719906-17-dmitry.baryshkov@linaro.org> (raw) In-Reply-To: <20220209172520.3719906-1-dmitry.baryshkov@linaro.org> Since layout is not cached anymore, drop comparison against previous layout and corresponding EAGAIN handling. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ---- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 5 +---- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c index 440ae93d7bd1..5c7d739143f0 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c @@ -927,10 +927,6 @@ int dpu_format_populate_layout( else ret = _dpu_format_populate_addrs_linear(aspace, fb, layout); - /* check if anything changed */ - if (!ret && !memcmp(plane_addr, layout->plane_addr, sizeof(plane_addr))) - ret = -EAGAIN; - return ret; } diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index a521c0681af6..b2395f02f6d3 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -1061,10 +1061,7 @@ static void dpu_plane_sspp_atomic_update(struct drm_plane *plane) memset(&pipe_cfg, 0, sizeof(struct dpu_hw_pipe_cfg)); ret = dpu_format_populate_layout(aspace, fb, &layout); - if (ret == -EAGAIN) { - DPU_DEBUG_PLANE(pdpu, "not updating same src addrs\n"); - update_src_addr = false; - } else if (ret) { + if (ret) { DPU_ERROR_PLANE(pdpu, "failed to get format layout, %d\n", ret); update_src_addr = false; } -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd <swboyd@chromium.org>, freedreno@lists.freedesktop.org Subject: [PATCH 16/25] drm/msm/dpu: drop EAGAIN check from dpu_format_populate_layout Date: Wed, 9 Feb 2022 20:25:11 +0300 [thread overview] Message-ID: <20220209172520.3719906-17-dmitry.baryshkov@linaro.org> (raw) In-Reply-To: <20220209172520.3719906-1-dmitry.baryshkov@linaro.org> Since layout is not cached anymore, drop comparison against previous layout and corresponding EAGAIN handling. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ---- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 5 +---- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c index 440ae93d7bd1..5c7d739143f0 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c @@ -927,10 +927,6 @@ int dpu_format_populate_layout( else ret = _dpu_format_populate_addrs_linear(aspace, fb, layout); - /* check if anything changed */ - if (!ret && !memcmp(plane_addr, layout->plane_addr, sizeof(plane_addr))) - ret = -EAGAIN; - return ret; } diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index a521c0681af6..b2395f02f6d3 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -1061,10 +1061,7 @@ static void dpu_plane_sspp_atomic_update(struct drm_plane *plane) memset(&pipe_cfg, 0, sizeof(struct dpu_hw_pipe_cfg)); ret = dpu_format_populate_layout(aspace, fb, &layout); - if (ret == -EAGAIN) { - DPU_DEBUG_PLANE(pdpu, "not updating same src addrs\n"); - update_src_addr = false; - } else if (ret) { + if (ret) { DPU_ERROR_PLANE(pdpu, "failed to get format layout, %d\n", ret); update_src_addr = false; } -- 2.34.1
next prev parent reply other threads:[~2022-02-09 17:25 UTC|newest] Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-09 17:24 [PATCH 00/25] drm/msm/dpu: wide planes support Dmitry Baryshkov 2022-02-09 17:24 ` Dmitry Baryshkov 2022-02-09 17:24 ` [PATCH 01/25] drm/msm/dpu: rip out master " Dmitry Baryshkov 2022-02-09 17:24 ` Dmitry Baryshkov 2022-04-27 1:28 ` Abhinav Kumar 2022-04-27 1:28 ` Abhinav Kumar 2022-02-09 17:24 ` [PATCH 02/25] drm/msm/dpu: do not limit the zpos property Dmitry Baryshkov 2022-02-09 17:24 ` Dmitry Baryshkov 2022-04-27 1:32 ` Abhinav Kumar 2022-04-27 1:32 ` Abhinav Kumar 2022-02-09 17:24 ` [PATCH 03/25] drm/msm/dpu: add support for SSPP allocation to RM Dmitry Baryshkov 2022-02-09 17:24 ` Dmitry Baryshkov 2022-04-27 2:06 ` Abhinav Kumar 2022-04-27 2:06 ` Abhinav Kumar 2022-02-09 17:24 ` [PATCH 04/25] drm/msm/dpu: move SSPP debugfs creation to dpu_kms.c Dmitry Baryshkov 2022-02-09 17:24 ` Dmitry Baryshkov 2022-05-03 21:34 ` Abhinav Kumar 2022-05-03 21:34 ` Abhinav Kumar 2022-05-03 22:11 ` Dmitry Baryshkov 2022-05-03 22:11 ` Dmitry Baryshkov 2022-05-03 22:34 ` Abhinav Kumar 2022-05-03 22:34 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 05/25] drm/msm/dpu: move pipe_hw to dpu_plane_state Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-03 22:32 ` Abhinav Kumar 2022-05-03 22:32 ` Abhinav Kumar 2022-05-14 6:37 ` Dmitry Baryshkov 2022-05-14 6:37 ` Dmitry Baryshkov 2022-05-26 20:21 ` Abhinav Kumar 2022-05-26 20:21 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 06/25] drm/msm/dpu: inline dpu_plane_get_ctl_flush Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-03 22:55 ` Abhinav Kumar 2022-05-03 22:55 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 07/25] drm/msm/dpu: drop dpu_plane_pipe function Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-03 23:04 ` Abhinav Kumar 2022-05-03 23:04 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 08/25] drm/msm/dpu: get rid of cached flush_mask Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-03 23:40 ` Abhinav Kumar 2022-05-03 23:40 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 09/25] drm/msm/dpu: dpu_crtc_blend_setup: split mixer and ctl logic Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-06 18:56 ` Abhinav Kumar 2022-05-06 18:56 ` Abhinav Kumar 2022-05-06 20:14 ` Dmitry Baryshkov 2022-05-06 20:14 ` Dmitry Baryshkov 2022-02-09 17:25 ` [PATCH 10/25] drm/msm/dpu: introduce struct dpu_sw_pipe Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-06 21:30 ` Abhinav Kumar 2022-05-06 21:30 ` Abhinav Kumar 2022-05-06 21:39 ` Dmitry Baryshkov 2022-05-06 21:39 ` Dmitry Baryshkov 2022-05-06 21:48 ` [Freedreno] " Abhinav Kumar 2022-05-06 21:48 ` Abhinav Kumar 2022-05-06 22:29 ` Dmitry Baryshkov 2022-05-06 22:29 ` Dmitry Baryshkov 2022-05-06 22:46 ` Abhinav Kumar 2022-05-06 22:46 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 11/25] drm/msm/dpu: use dpu_sw_pipe for dpu_hw_sspp callbacks Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-06 22:24 ` Abhinav Kumar 2022-05-06 22:24 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 12/25] drm/msm/dpu: inline _dpu_plane_set_scanout Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-06 23:33 ` Abhinav Kumar 2022-05-06 23:33 ` Abhinav Kumar 2022-05-06 23:34 ` Dmitry Baryshkov 2022-05-06 23:34 ` Dmitry Baryshkov 2022-02-09 17:25 ` [PATCH 13/25] drm/msm/dpu: pass dpu_format to _dpu_hw_sspp_setup_scaler3() Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-09 22:30 ` Abhinav Kumar 2022-05-09 22:30 ` Abhinav Kumar 2022-05-14 6:46 ` Dmitry Baryshkov 2022-05-14 6:46 ` Dmitry Baryshkov 2022-02-09 17:25 ` [PATCH 14/25] drm/msm/dpu: move stride programming to dpu_hw_sspp_setup_sourceaddress Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-13 18:50 ` Abhinav Kumar 2022-05-13 18:50 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 15/25] drm/msm/dpu: remove dpu_hw_fmt_layout from struct dpu_hw_pipe_cfg Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-13 18:58 ` Abhinav Kumar 2022-05-13 18:58 ` Abhinav Kumar 2022-05-14 6:53 ` Dmitry Baryshkov 2022-05-14 6:53 ` Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov [this message] 2022-02-09 17:25 ` [PATCH 16/25] drm/msm/dpu: drop EAGAIN check from dpu_format_populate_layout Dmitry Baryshkov 2022-05-13 19:03 ` Abhinav Kumar 2022-05-13 19:03 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 17/25] drm/msm/dpu: drop src_split and multirect check from dpu_crtc_atomic_check Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-26 22:59 ` Abhinav Kumar 2022-05-26 22:59 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 18/25] drm/msm/dpu: move the rest of plane checks to dpu_plane_atomic_check() Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-27 0:14 ` Abhinav Kumar 2022-05-27 0:14 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 19/25] drm/msm/dpu: don't use unsupported blend stages Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-05-14 1:57 ` Abhinav Kumar 2022-05-14 1:57 ` Abhinav Kumar 2022-02-09 17:25 ` [PATCH 20/25] drm/msm/dpu: add dpu_hw_pipe_cfg to dpu_plane_state Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-02-09 17:25 ` [PATCH 21/25] drm/msm/dpu: simplify dpu_plane_validate_src() Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-02-09 17:25 ` [PATCH 22/25] drm/msm/dpu: rewrite plane's QoS-related functions to take dpu_sw_pipe and dpu_format Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-02-09 17:25 ` [PATCH 23/25] drm/msm/dpu: rework dpu_plane_atomic_check() and dpu_plane_sspp_atomic_update() Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-02-09 17:25 ` [PATCH 24/25] drm/msm/dpu: populate SmartDMA features in hw catalog Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-02-09 17:25 ` [PATCH 25/25] drm/msm/dpu: add support for wide planes Dmitry Baryshkov 2022-02-09 17:25 ` Dmitry Baryshkov 2022-03-17 1:10 ` [PATCH 00/25] drm/msm/dpu: wide planes support Abhinav Kumar 2022-03-17 1:10 ` Abhinav Kumar 2022-03-17 7:59 ` Dmitry Baryshkov 2022-03-17 7:59 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220209172520.3719906-17-dmitry.baryshkov@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.