* [PATCH] drm/amdkfd: CRIU fix a NULL vs IS_ERR() check
@ 2022-02-09 18:09 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-02-09 18:09 UTC (permalink / raw)
To: Felix Kuehling, David Yat Sin
Cc: Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
Daniel Vetter, Rajneesh Bhardwaj, amd-gfx, dri-devel,
kernel-janitors
The kfd_process_device_data_by_id() does not return error pointers,
it returns NULL.
Fixes: bef153b70c6e ("drm/amdkfd: CRIU implement gpu_id remapping")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index 64e3b4e3a712..75aca99f6ece 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -2526,7 +2526,7 @@ static int criu_restore_bos(struct kfd_process *p,
break;
peer_pdd = kfd_process_device_data_by_id(p, bo_priv->mapped_gpuids[j]);
- if (IS_ERR(peer_pdd)) {
+ if (!peer_pdd) {
ret = -EINVAL;
goto exit;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] drm/amdkfd: CRIU fix a NULL vs IS_ERR() check
@ 2022-02-09 18:09 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-02-09 18:09 UTC (permalink / raw)
To: Felix Kuehling, David Yat Sin
Cc: David Airlie, Pan, Xinhui, kernel-janitors, Rajneesh Bhardwaj,
amd-gfx, dri-devel, Alex Deucher, Christian König
The kfd_process_device_data_by_id() does not return error pointers,
it returns NULL.
Fixes: bef153b70c6e ("drm/amdkfd: CRIU implement gpu_id remapping")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index 64e3b4e3a712..75aca99f6ece 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -2526,7 +2526,7 @@ static int criu_restore_bos(struct kfd_process *p,
break;
peer_pdd = kfd_process_device_data_by_id(p, bo_priv->mapped_gpuids[j]);
- if (IS_ERR(peer_pdd)) {
+ if (!peer_pdd) {
ret = -EINVAL;
goto exit;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] drm/amdkfd: CRIU fix a NULL vs IS_ERR() check
@ 2022-02-09 18:09 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-02-09 18:09 UTC (permalink / raw)
To: Felix Kuehling, David Yat Sin
Cc: David Airlie, Pan, Xinhui, kernel-janitors, Rajneesh Bhardwaj,
amd-gfx, dri-devel, Daniel Vetter, Alex Deucher,
Christian König
The kfd_process_device_data_by_id() does not return error pointers,
it returns NULL.
Fixes: bef153b70c6e ("drm/amdkfd: CRIU implement gpu_id remapping")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index 64e3b4e3a712..75aca99f6ece 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -2526,7 +2526,7 @@ static int criu_restore_bos(struct kfd_process *p,
break;
peer_pdd = kfd_process_device_data_by_id(p, bo_priv->mapped_gpuids[j]);
- if (IS_ERR(peer_pdd)) {
+ if (!peer_pdd) {
ret = -EINVAL;
goto exit;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-09 18:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-09 18:09 [PATCH] drm/amdkfd: CRIU fix a NULL vs IS_ERR() check Dan Carpenter
2022-02-09 18:09 ` Dan Carpenter
2022-02-09 18:09 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.