All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: rt5640: Remove the sysclk and sysclk_src checking
@ 2022-02-10  7:19 Oder Chiou
  2022-02-10 16:53 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Oder Chiou @ 2022-02-10  7:19 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: Oder Chiou, jack.yu, alsa-devel, spujar, albertchen, derek.fang,
	shumingf, flove

Remove the sysclk and sysclk_src checking in the function set_sysclk() to
prevent the PLL power off. It is not getting re-programmed during
subsequent runs after the first run (in BIAS_OFF stage).

Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
---
 sound/soc/codecs/rt5640.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c
index e7a82565b905..30c2e7cb7ed2 100644
--- a/sound/soc/codecs/rt5640.c
+++ b/sound/soc/codecs/rt5640.c
@@ -1839,9 +1839,6 @@ static int rt5640_set_dai_sysclk(struct snd_soc_dai *dai,
 	unsigned int reg_val = 0;
 	unsigned int pll_bit = 0;
 
-	if (freq == rt5640->sysclk && clk_id == rt5640->sysclk_src)
-		return 0;
-
 	switch (clk_id) {
 	case RT5640_SCLK_S_MCLK:
 		reg_val |= RT5640_SCLK_SRC_MCLK;
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: rt5640: Remove the sysclk and sysclk_src checking
  2022-02-10  7:19 [PATCH] ASoC: rt5640: Remove the sysclk and sysclk_src checking Oder Chiou
@ 2022-02-10 16:53 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2022-02-10 16:53 UTC (permalink / raw)
  To: lgirdwood, Oder Chiou
  Cc: jack.yu, alsa-devel, spujar, albertchen, derek.fang, shumingf, flove

On Thu, 10 Feb 2022 15:19:00 +0800, Oder Chiou wrote:
> Remove the sysclk and sysclk_src checking in the function set_sysclk() to
> prevent the PLL power off. It is not getting re-programmed during
> subsequent runs after the first run (in BIAS_OFF stage).
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt5640: Remove the sysclk and sysclk_src checking
      commit: d9c5996ab37fca71b4d97440798d54dd87540c8b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-10 16:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10  7:19 [PATCH] ASoC: rt5640: Remove the sysclk and sysclk_src checking Oder Chiou
2022-02-10 16:53 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.