* [PATCH v2] drm/bridge: anx7625: Fix overflow issue on reading EDID
@ 2022-02-10 10:38 ` Pin-Yen Lin
0 siblings, 0 replies; 4+ messages in thread
From: Pin-Yen Lin @ 2022-02-10 10:38 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter
Cc: Pin-Yen Lin, Hsin-Yi Wang, Maxime Ripard, Pi-Hsun Shih,
Sam Ravnborg, Tzung-Bi Shih, Xin Ji, dri-devel, linux-kernel
The length of EDID block can be longer than 256 bytes, so we should use
`int` instead of `u8` for the `edid_pos` variable.
Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP")
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
Changes in v2:
- add "Fixes" tag
- collect review tag
drivers/gpu/drm/bridge/analogix/anx7625.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 2346dbcc505f..e596cacce9e3 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -846,7 +846,8 @@ static int segments_edid_read(struct anx7625_data *ctx,
static int sp_tx_edid_read(struct anx7625_data *ctx,
u8 *pedid_blocks_buf)
{
- u8 offset, edid_pos;
+ u8 offset;
+ int edid_pos;
int count, blocks_num;
u8 pblock_buf[MAX_DPCD_BUFFER_SIZE];
u8 i, j;
--
2.35.0.263.gb82422642f-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] drm/bridge: anx7625: Fix overflow issue on reading EDID
@ 2022-02-10 10:38 ` Pin-Yen Lin
0 siblings, 0 replies; 4+ messages in thread
From: Pin-Yen Lin @ 2022-02-10 10:38 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter
Cc: Tzung-Bi Shih, linux-kernel, dri-devel, Pin-Yen Lin,
Maxime Ripard, Pi-Hsun Shih, Hsin-Yi Wang, Sam Ravnborg, Xin Ji
The length of EDID block can be longer than 256 bytes, so we should use
`int` instead of `u8` for the `edid_pos` variable.
Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP")
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
Changes in v2:
- add "Fixes" tag
- collect review tag
drivers/gpu/drm/bridge/analogix/anx7625.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 2346dbcc505f..e596cacce9e3 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -846,7 +846,8 @@ static int segments_edid_read(struct anx7625_data *ctx,
static int sp_tx_edid_read(struct anx7625_data *ctx,
u8 *pedid_blocks_buf)
{
- u8 offset, edid_pos;
+ u8 offset;
+ int edid_pos;
int count, blocks_num;
u8 pblock_buf[MAX_DPCD_BUFFER_SIZE];
u8 i, j;
--
2.35.0.263.gb82422642f-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Fix overflow issue on reading EDID
2022-02-10 10:38 ` Pin-Yen Lin
@ 2022-02-14 15:23 ` Robert Foss
-1 siblings, 0 replies; 4+ messages in thread
From: Robert Foss @ 2022-02-14 15:23 UTC (permalink / raw)
To: Pin-Yen Lin
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Hsin-Yi Wang,
Maxime Ripard, Pi-Hsun Shih, Sam Ravnborg, Tzung-Bi Shih, Xin Ji,
dri-devel, linux-kernel
On Thu, 10 Feb 2022 at 11:38, Pin-Yen Lin <treapking@chromium.org> wrote:
>
> The length of EDID block can be longer than 256 bytes, so we should use
> `int` instead of `u8` for the `edid_pos` variable.
>
> Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP")
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
>
> Changes in v2:
> - add "Fixes" tag
> - collect review tag
>
> drivers/gpu/drm/bridge/analogix/anx7625.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 2346dbcc505f..e596cacce9e3 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -846,7 +846,8 @@ static int segments_edid_read(struct anx7625_data *ctx,
> static int sp_tx_edid_read(struct anx7625_data *ctx,
> u8 *pedid_blocks_buf)
> {
> - u8 offset, edid_pos;
> + u8 offset;
> + int edid_pos;
> int count, blocks_num;
> u8 pblock_buf[MAX_DPCD_BUFFER_SIZE];
> u8 i, j;
> --
> 2.35.0.263.gb82422642f-goog
>
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Fix overflow issue on reading EDID
@ 2022-02-14 15:23 ` Robert Foss
0 siblings, 0 replies; 4+ messages in thread
From: Robert Foss @ 2022-02-14 15:23 UTC (permalink / raw)
To: Pin-Yen Lin
Cc: Jonas Karlman, David Airlie, dri-devel, Neil Armstrong,
linux-kernel, Jernej Skrabec, Tzung-Bi Shih, Pi-Hsun Shih,
Laurent Pinchart, Andrzej Hajda, Hsin-Yi Wang, Sam Ravnborg,
Xin Ji, Maxime Ripard
On Thu, 10 Feb 2022 at 11:38, Pin-Yen Lin <treapking@chromium.org> wrote:
>
> The length of EDID block can be longer than 256 bytes, so we should use
> `int` instead of `u8` for the `edid_pos` variable.
>
> Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP")
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
>
> Changes in v2:
> - add "Fixes" tag
> - collect review tag
>
> drivers/gpu/drm/bridge/analogix/anx7625.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 2346dbcc505f..e596cacce9e3 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -846,7 +846,8 @@ static int segments_edid_read(struct anx7625_data *ctx,
> static int sp_tx_edid_read(struct anx7625_data *ctx,
> u8 *pedid_blocks_buf)
> {
> - u8 offset, edid_pos;
> + u8 offset;
> + int edid_pos;
> int count, blocks_num;
> u8 pblock_buf[MAX_DPCD_BUFFER_SIZE];
> u8 i, j;
> --
> 2.35.0.263.gb82422642f-goog
>
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-14 15:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 10:38 [PATCH v2] drm/bridge: anx7625: Fix overflow issue on reading EDID Pin-Yen Lin
2022-02-10 10:38 ` Pin-Yen Lin
2022-02-14 15:23 ` Robert Foss
2022-02-14 15:23 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.